Commit Graph
1197 Commits
Author SHA1 Message Date
kandera 18aaeaa6be Core/Spells: Tricks of the Trade (fix entier spell. aggro now removed after buff dissapears, correct buffs are placed on both the rogue and the target, both 15% buff and the second threat modifier buff are working as intended) 2011-12-05 13:56:08 -05:00
Shauren 0cc62432e8 Merge pull request #4196 from kandera/fix_Ravage
Core/Spells: Fix Ravage positioning requirement
2011-12-05 10:36:00 -08:00
kandera d6f2359e20 Core/Spells: Fix Ravage (was able to attack from any side. now only from back) 2011-12-05 10:20:06 -05:00
Machiavelli 95b422f674 Merge pull request #4095 from Svannon/fix-helboar
Core/Spells: Make Spell 29200 (Purify Helboar Meat) use caster as casting target
2011-12-05 06:52:25 -08:00
megamage 5b034ee631 Revert 81fea2d7b5. 2011-11-28 14:34:30 -05:00
megamage 1f70fd2851 Delete DynamicObject if AddToMap fails. 2011-11-28 14:19:29 -05:00
megamage 81fea2d7b5 Fix some memory leak from CreateTamedPetFrom. 2011-11-28 14:10:56 -05:00
Svannon 9876ef723e [Spell] Make Spell 29200 (Purify Helboar Meat) use caster as casting target 2011-11-26 15:33:05 -07:00
Shocker 80f8791907 Core/Misc: Small cleanup in SpellMgr 2011-11-26 21:42:40 +02:00
Chaplain 4d65c1e729 Core/Mechanics: Armor penetration improvement. Revamp calculation of SPELL_AURA_MOD_TARGET_ARMOR_PCT 2011-11-26 21:05:27 +02:00
Shauren 358b33239a Core: Fixed remaining C6246: Local declaration of 'x' hides declaration of the same name in outer scope. from previous commit 2011-11-23 19:17:33 +01:00
megamage b3fef1e280 Fix build. 2011-11-23 12:42:11 -05:00
Shauren 638693e78f Core: Fixed more warnings (C6246: Local declaration of 'x' hides declaration of the same name in outer scope.) 2011-11-23 17:55:16 +01:00
Machiavelli c67af87eda Core/Spells: Fix SPELL_EFFECT_SEND_EVENT handler being executed more than once when targets != (0, 0). Closes #3934 2011-11-16 19:09:51 +01:00
kaelima 79903f31ce Core/Spells: Add own diminishing category for Dragon's Breath.
Will no longer share diminishing with Polymorph
Closes #3081
2011-11-13 00:51:33 +01:00
tobmaps 70aafbda94 Core/Spells: Partially fix RP-GG 2011-11-12 02:36:18 +07:00
megamage 360c9dd635 Add detailed crash info when aura owner is not in the same map as target in Aura::UpdateTargetMap. 2011-11-11 11:29:59 -05:00
Bootz d1334624da Core: Codestyle clean-up
"pl"->"player"

 Note: codestyle methods needs maintained, Player* player.
still to do properly clean-up chat.cpp.
2011-11-07 11:18:00 -06:00
Bootz f75ec5ba2b Core: Codestyle clean-up
"plr"->player

Note: codestyle methods needs maintained, Player* player.
2011-11-07 11:06:39 -06:00
tobmaps 8fd7720318 Core/Misc: Rename Spell::CalcCastTime to Spell::GetCastTime as it does not calculate anything 2011-11-05 05:33:52 +07:00
tobmaps 935527eebe Core/Spells: Use dbc flag to check if channeled spell can be interrupted
Closes #2292
2011-11-05 05:21:37 +07:00
tobmaps 37abe2528c Core/Spells: Remove not needed check added in 9229b878f2 2011-11-03 17:08:30 +07:00
tobmaps 68601bb286 Core/Spells: Use correct dbc flag to check if spell can be interrupted 2011-11-03 16:53:29 +07:00
tobmaps 9229b878f2 Core/Spells: Fix Runic Healing/Mana Injector bonus for engineers 2011-11-02 19:23:59 +07:00
tobmaps c0c6000a44 Core/Misc: Fix spelling typo 2011-11-02 19:13:51 +07:00
megamage dfeb4a746b Fix a crash caused by spell with CAST_FLAG_RUNE_LIST casted by a creature mover. Thanks to Vasago. 2011-10-31 09:56:04 -04:00
kaelima e16e18da23 Core/Spells: Added safe-checks for places where caster/victim can be null.
And some random cleanup
2011-10-31 01:54:44 +01:00
draco 96c63fdf90 Change magic numbers for EffectRadiusIndex into enum with actual effect radius 2011-10-27 21:30:23 +02:00
ille 5514523a7c use effectMask to calculate mechanicMask in ModSpellDuration 2011-10-20 18:28:37 +02:00
Liberate ddec56b3e0 Core/Spells: Fix shadowfiend.
Fixes #3285
2011-10-19 23:30:25 +02:00
Liberate a658d0b592 Core/Spells: Define and implement SPELL_ATTR4_PROC_ONLY_ON_DUMMY.
Fixes #2685
Fixes #2573
2011-10-19 22:08:54 +02:00
Liberate 1431a5d15c Core/Spells: Revert d7e0190726 and solve it differently.
All totems have TARGET_UNIT_CASTER as implicit target except from Wrath of Air and Flametongue.
To make Glyph of Totem of Wrath work again modified these 2 totems to be the same as the other totems.
This still makes the 2 totems not stackable.
Fixes #3293
2011-10-19 18:35:21 +02:00
kaelima be0b2fcf97 Core/Grid:
- Simplified CellArea calculation (Original author: SilverIce)

- Removed unused code in Cell class (Original author: SilverIce)

- Improve some Visit functions.
2011-10-19 17:40:44 +01:00
Liberate b268b51d0e Core/Spells: Add Block Value cap to Shield Slam and Shield of Righteousness.
Fixes #599
Fixes #2119
2011-10-19 13:00:22 +02:00
Liberate 8f8949fcf0 Core/Spells: Spells with the self-cast range should not have a range check. This range used for many triggered spells.
Fixes #3358
2011-10-19 00:24:43 +02:00
Liberate 8cc13ff838 And I forgot to turn on tabs to spaces. Also fixed... 2011-10-18 23:38:55 +02:00
Liberate 89bae3b51c Core/Spells: Add a new stack rule for spellgroups: SPELL_GROUP_STACK_RULE_EXCLUSIVE_SAME_EFFECT
This stack rule makes the effects of the spells in the spellgroup non-stackable, but the spells/auras itself are stackable.
a spell should be in only 1 group with this stack rule.
Fixes #2243
2011-10-18 23:27:39 +02:00
megamage c29ff41001 Rename some classes in grid system.
Note: The naming of classes is still confusing. "cell" usually refers to class "Grid", and "grid" usually refers to class "NGrid". But it requires a lot of changes to clean this up.
2011-10-18 10:53:34 -04:00
Spp ee69fc940e Core/Items: Split SetSoulboundTradeable in two functions (Set and Clear)
Note: this is mostly for clarify action being done: ClearSoulboundTradeable better than SetSoulboundTradeable(..., ..., false)
2011-10-18 10:44:45 +02:00
Fredi Machado 97142102e0 Core/Misc: Added 'f' after float values 2011-10-17 07:38:27 -03:00
megamage fd9bab9d89 Add a missing break in AuraEffect::CalculateSpellMod. Thanks to vlad852 for pointing out. 2011-10-12 14:48:22 -04:00
megamage 0184720df6 Merge pull request #3444 from Havenard/fix0008
Fix Elemental Oath
2011-10-12 08:44:47 -07:00
Havenard 0e274bdcb7 Fix Divine Storm
Fix healing part of Divine Storm, will now work as intented healing up to 3 party or raid members for a total of 25% (or 40% with Glyph) of the damage caused.

Closes #285
2011-10-11 22:32:36 -03:00
Chaplain 3e9611578c Core/Spells: SPELL_AURA_MOD_INCREASE_ENERGY_PERCENT improvement
*Now it'll correctly increase\decrease % of power
*Added helper function for modify power with percent ammount
2011-10-12 01:11:52 +03:00
megamage 3ba22d0d06 Rename Map::Add to Map::AddToMap, Map::Remove to Map::RemoveFromMap for better management. 2011-10-10 17:39:34 -04:00
megamage d156e066cf Rename "SetPosition" to "UpdatePosition".
Replace CreatureRelocation in scripts with new Creature::SetPosition.
2011-10-10 17:08:01 -04:00
Havenard 61f468d5a1 Fix Elemental Oath
Remove hacky implementation of Elemental Oath
Properly fix it by correcting DBC data
Fix Clearcasting from Elemental Oath damage bonus being displayed twice in Spell ToolTips by damage Addons like DrDamage (displaying 10.25% instead of 5%, 21% instead of 10%)
2011-10-10 18:01:02 -03:00
megamage 00f5366029 Fix the bug that CC AOE spells do not remove stealth aura if the target is behind the caster. 2011-10-10 12:56:14 -04:00
3kids 35126d3c5e Core/Spells: Restore work of Unrelenting Assault after 341d22ff91 2011-10-08 15:50:50 +07:00
Bootz 5b4c7783c2 REPO: Code-style clean-ups
* Fixed pMap->map
* Fixed pInstance->instance
* Fixed pInsta->instance
* Fixed pQuest->quest
* Fixed pWho->who
* Fixed pTarget->target
* Fixed pGo->go

~DEVNOTES: Handlers/QuestHandler.cpp still needs to be cleaned...
2011-10-07 19:45:43 -05:00