Commit Graph
36213 Commits
Author SHA1 Message Date
Trond B. Krokli b6dc6fd742 Core/Spells: make Four Horsemen debuffs negative (#23253)
By Riztazz
Closes #23248

(cherry picked from commit 1e97dfec538b9113134a67b7d25a1c1d2bc7b662)
2021-12-04 00:31:32 +01:00
Killyana 4ce9a7a2cc DB/Quest: Troll Patrol: Can You Dig It?
(cherry picked from commit 704354d027c19db1e5c37cecf7e407098a094e05)
2021-12-04 00:31:32 +01:00
Killyana 8e12cda58b DB/Creature: Father Levariol, Mage-Captain Adams & Mage-Lieutenant Malister
(cherry picked from commit 40fa01cc8efff021584ed2d6325d0e106852d0a8)
2021-12-04 00:31:32 +01:00
Killyana 4d84eb8643 DB/Quest: Towers of Certain Doom
From https://github.com/cmangos/wotlk-db/commit/784e41131cb420219921fae2a5d89c8faa6389ea
By Grz3s

(cherry picked from commit d470ebaf0428353442e02b05c51373f470132b9d)
2021-12-04 00:31:32 +01:00
Killyana bdb728a165 Spell/Script: Throw Torch must hit only one target
(cherry picked from commit ce562415ed49d202de172fc2edab84250c494238)
2021-12-04 00:31:32 +01:00
Wyrserth 238726b824 Core/Achievement: fix mistake related to ACHIEVEMENT_CRITERIA_TYPE_OWN_ITEM. (#23252)
(cherry picked from commit b76bcc836cb194e35a534c94054b2bf4b94776be)
2021-12-04 00:31:32 +01:00
Killyana a2ee0f1aef DB/Quest: Burn Skorn, Burn!
From https://github.com/cmangos/wotlk-db/commit/98bf88325ceebe5a3244b17416a09b8527a1c6e0  by Grz3s

(cherry picked from commit 8e0cf3bc2a3e963cce7ffa2953090da65ca0ae83)
2021-12-04 00:31:32 +01:00
Wyrserth 3264ef1f75 Core/Achievement: correctly credit progress for skill-related achievements when learning a new skill. (#23249)
(cherry picked from commit 0a25069db4fd359619fed219e86f7842104677d0)
2021-12-04 00:31:32 +01:00
jackpoz ccc8d679d8 Core/Misc: Log Map name in asserts
(cherry picked from commit 991b2a11bd8aba4351a60a5f0e13153cd3f2c71c)
2021-12-04 00:31:32 +01:00
jackpoz 6be185e6a2 Core/Misc: Log Spell/Aura name in Spell/Auras asserts
(cherry picked from commit 4130384f2e88ba266f75c553c89a351d43e52203)
2021-12-04 00:31:28 +01:00
ZenoX92 8385356abe DB/Texts: Twilight Idolater
Closes #23245

(cherry picked from commit 84c5be936d5527bf3a8035410c927231d921278e)
2021-12-03 23:26:14 +01:00
ZenoX92 f693411ac1 DB/SAI: Seradane
Closes #23241

(cherry picked from commit 3c23ac03f00f5b4d0395c93e01af612f7b79aa01)
2021-12-03 22:26:55 +01:00
Killyana f273d4944c DB/Creature: Tormented Citizen & Tormented Soul
From https://github.com/cmangos/wotlk-db/commit/49cc891e4aac3112c7b46ad59105fa951e59e31a by Grz3s

(cherry picked from commit 00e98a34c127b3308d0ef3accf7ea1a2bb999085)
2021-12-03 22:22:35 +01:00
jackpoz 8dd1f39153 Dep/Jemalloc: Update to Jemalloc 5.2.0
(cherry picked from commit 5d986f0be46bf439caf227f3c228ac1c8efddfde)
2021-12-03 22:02:24 +01:00
jackpoz a855e6221d Core/Vehicles: Fix accessories disappearing on reset
(cherry picked from commit 6dae4a747da558ca46a777186d4519c32fc1bf04)
2021-12-03 22:02:13 +01:00
jackpoz eb25fbd485 Core/Misc: Apply fatigue when flying too
Fix #22856

(cherry picked from commit a76d01278a8f7986414edd0eaefaa42344926dbd)
2021-12-03 22:01:02 +01:00
Killyana 19ce65c01b Remove deprecated code
(cherry picked from commit fe311260f7fab3b6fb4d7dd2ee88826820379d94)
2021-12-03 22:00:47 +01:00
Killyana 1ced6d2192 Remove Deprecated code
(cherry picked from commit fd166025c857477d654cdea6cd6f700e53bfe64b)
2021-12-03 22:00:39 +01:00
Killyana 7c50e300ba DB/GameObject: Fissure Plant
(cherry picked from commit 758814f9098051e1eab21fde8d91a8a3cf0587aa)
2021-12-03 21:59:23 +01:00
Killyana b2d1a6e610 DB/Quest: The Stagnant Oasis
(cherry picked from commit a720b7caccc7c062b6474b4246b090e4b41bb4e6)
(cherry picked from commit 1f3ef1d6f5967c27cef952ef3e616f032b4ac194)
2021-12-03 21:58:50 +01:00
Shauren 768ed2cbdc Core/Spells: Use 3D distance for calculating speed from movement time instead of 2D 2021-12-03 16:12:10 +01:00
Giacomo Pozzoni 910e0b70ef Core/Vehicles: Fix multiple vehicle join events on same seat (#23233)
(cherry picked from commit d4414af2d4f0736a842c4c596546c9583692ec3c)
2021-12-03 00:23:24 +01:00
Jozef Dúc a13a765610 Core/Object: Range check vol. 2 (#23226)
* Core/Object: Fix all missing parts for #23062

* Update GameObject.cpp

(cherry picked from commit 78070163dc6b9bb34ab2d006e9cc218548e861b7)
2021-12-03 00:21:19 +01:00
sirikfoll 03e03f3fc6 Core/Scripts: Fix Skadi dismount issue
Closes #23005

(cherry picked from commit fe3bf57aba9a5009e7e17922391a0d9374915ab5)
2021-12-02 23:51:51 +01:00
Giacomo Pozzoni 46170fdf01 Scripts/Spells: Fix implementation of #22332 (#23228)
Change the way #22332 moved spell damage calculations from SpellEffectDMG to scripts, using OnEffectLaunchTarget and SetEffectValue instead

(cherry picked from commit 20772dbf5d10c6ec2891a068fb556c9f5fc7d324)
2021-12-02 23:46:00 +01:00
jackpoz 97be87b7d5 Core/LFG: Remove dungeon cooldown when completing random dungeons
(cherry picked from commit 24fbbee4b9af7b5226772378dd83b78c103d969d)
2021-12-02 23:45:29 +01:00
ccrs c22431936e Core/Creature: couple refactors/renaming
(cherry picked from commit 69c15f5ae769612c89346c6a308655d0987caae7)
2021-12-02 23:45:14 +01:00
PolarCookie fcd78193f2 DB/Loot: White Tuxedo Shirt
Closes #23223

(cherry picked from commit 2dffb85762b89327818b5172e410a9bf5c497c73)
2021-12-02 23:40:23 +01:00
ZenoX92 6b24a6f3a8 DB/Quest: The Calling
Closes #23222

(cherry picked from commit 2084bcbeccc627f67064933af562bdf22365c515)
2021-12-02 23:39:25 +01:00
Killyana f65898016b DB/Creature: A some missing auras
By ZenoX92 and AnonXS from https://github.com/cmangos/tbc-db/commit/33b6252f8ce395fdefe16399568cbca3ffe87f37
Closes #23221

(cherry picked from commit 9dda85bfd7bd3e90d50e9be7656b733e53c0f052)
2021-12-02 23:35:58 +01:00
ZenoX92 6944f59496 DB/Creature: Prince Thunderaan
Closes #23220

(cherry picked from commit f0028c888fe10095e30f3e688d683cfb5138112a)
2021-12-02 23:08:22 +01:00
ZenoX92 51e6a95a3b DB/Gossip: Highlord Demitrian
Closes #23219

(cherry picked from commit a3a883e3aae5d8bb6f8d6ff78f6fd8418d39a9d6)
2021-12-02 23:07:27 +01:00
Sorikoff 5f916b039b DB/SAI: Isle of Spears
Closes #23217
Closes #23218

(cherry picked from commit 38d911d4edacea89824fea6ad50585dd70f1e4e3)
2021-12-02 21:24:55 +01:00
ZenoX92 44ae5c34a7 DB/Quest: Quest Emotes (Silithus)
Closes #23214

(cherry picked from commit c82ef1261be332eebb9d93083416a53a6f57149a)
2021-12-02 21:23:23 +01:00
ZenoX92 5321d57038 DB/Quest: Securing the Supply Lines
Closes #23213

(cherry picked from commit ea6213c45874725c3ef4454d705680d562e5fd3e)
2021-12-02 19:36:34 +01:00
Killyana 5163559c1e Quest/Script: Breakfast Of Champions
Set both Earthshaker Drum Events to 50%

(cherry picked from commit 14445088ea0b03d556619a9e5cd5f138cca09561)
2021-12-02 19:35:47 +01:00
Killyana fcff93e725 DB/Creature: Deathless Watcher
(cherry picked from commit 0b66c46af12c1827e6d1f9c9e95e032ea2fca153)
2021-12-02 19:26:13 +01:00
Shauren a4d40c9e34 Core: Updated allowed build to 9.1.5.41288 2021-12-02 11:59:23 +01:00
ccrs 1ba002ef3d Core/Object: re-change faction template related logs
(cherry picked from commit dfa54d3bf41897dbdfc0acf42f39b173dd39e857)
2021-12-02 00:39:28 +01:00
ccrs 356358ee15 Core/Misc: standarize a couple logs
(cherry picked from commit aee26eb46727171593ef7cc1d2652a7847dc88fc)
2021-12-02 00:39:28 +01:00
jackpoz 57411da5b2 Core/Pet: Change assert to error log
Change assert added in 43dec9e4d0b6f7da3c2051624742e9fb8a9bcb31 to error log since charmed creatures lose their AI until next map update

(cherry picked from commit 70fcdc687d1227a796c03f6353fc8dbfc4f4aea3)
(cherry picked from commit f45ebe71b0d8f6e3008514324a58a92c0db3810e)
2021-12-02 00:39:28 +01:00
jackpoz 49414acaef Core/CrashHandler: Remove sensitive data from crashlogs
(cherry picked from commit 25bcb1a0b2d9326519d9226dfe968caf26bb4e2d)
(cherry picked from commit 37478c5ac1efb8e4f19ffc94f444e160600c7b27)
2021-12-02 00:39:28 +01:00
jackpoz cf979de813 Core/Misc: Fix some GCC 8 warnings
(cherry picked from commit 26b6cb0584b50a2540e977cac8fa040c82fe7bb4)
2021-12-02 00:39:28 +01:00
jackpoz 841f0452a4 Core/MMaps: Revert PATHFIND_INCOMPLETE handling change in ChaseMovementGenerator in 386b5a6fd948b4866cbd9a8a9892e8777922e9c9 since the current hp reset code in Creature::Update() will reset the hp of bosses as soon as CanNotReachTarget() is true. In case of boss mechanics like Abub'Rekhan at Naxx where the boss throws the player in the air, a PATHFIND_INCOMPLETE path is returned.
The code in Creature::Update() should be modified to wait a few seconds before resetting the hp. PATHFIND_NOPATH / PATHFIND_INCOMPLETE don't really mean that the Creature can't attack the player anyway either.

(cherry picked from commit d910ffd77949f422bd08f12079866962fb53c4dc)
2021-12-02 00:39:28 +01:00
jackpoz a4fcfbb3af Core/Scripts: Rename recent GameObject spell overloads to fix GCC warnings
Rename recent GameObject spell overloads (they used to accept only Unit as parameters) to fix GCC warnings about partial function override.

(cherry picked from commit e3a9a9bfb2cba3fc1f6ed616b07fb0ea88de461f)
2021-12-02 00:39:28 +01:00
jackpoz c73fd0e6e3 Scripts/Commands: Add .debug asan commands
Add ".debug asan memoryleak" and ".debug asan outofbounds" commands to trigger Address Sanitizer warnings at runtime (or other dynamic analysis tools)

(cherry picked from commit 71d15ea25be3e86646faaa3266617a0b8177972f)
2021-12-02 00:39:20 +01:00
jackpoz dc2fed13c8 Shared/Metric: Fix a rare memory leak
Fix a memory leak in Metric happening only when enabling/disabling Metric from configs at runtime, leaking the metric added between last SendBatch() call and the ScheduleSend() call in the same function. The only way to reproduce this is to actually freeze the thread calling SendBatch(), disable metric, reload config, unfreeze the thread.

(cherry picked from commit 0d1ff7446dce7b0641f49ac55a008669838612cd)
2021-12-02 00:39:20 +01:00
jackpoz 98863659bb Scripts/Guards: Fix infinite loop in npc_air_force_bots
Fix infinite loop in npc_air_force_bots happening when aura 38067 was removed, triggering MoveInLineOfSight() that would add back the aura. Only 1 aura add/remove for guard for player is allowed now.

(cherry picked from commit 844e7ee9262a5ba035ac9e8a6ffc298fb97fd3a9)
2021-12-02 00:39:20 +01:00
jackpoz 519e3c9ab7 Core/Commands: Fix .cheat god command letting you die
Fix .cheat god command still letting you die with Area Aura like Slime near Thaddius, broken since 777b287dff

(cherry picked from commit f26f716714fefa2af4c6e3eea263206682d45236)
2021-12-02 00:39:20 +01:00
jackpoz dd825c5614 Core/Maps: Fix crash caused by setActive(false) called after DespawnOrUnsummon()
Fix crash caused by WorldObject::setActive(false) called after WorldObject::DespawnOrUnsummon() happening because the WorldObject would be set as not active but then Map::RemoveFromActiveHelper() would not be called because of not being in world anymore.
Whenever setActive() gets desync'd with what Map actually contains a rare crash would happen since Map only reads a few values of the active WorldObject, making it hard to reproduce. If this happens again some ASSERT calls should be added (or a check in Map::RemoveFromMap() could be added about if the WorldObject is in Map::m_activeNonPlayers container).

(cherry picked from commit 1c833f28e471e3787f1d328e44af5f065ad9ca8c)
2021-12-02 00:39:20 +01:00