Commit Graph
3211 Commits
Author SHA1 Message Date
PKX 47b7e75149 Core/Spells: Removed some obsolete code
This removes some unused and obsolete code:
- "Test of Faith" now doesn't increase crit anymore;
- same goes for "Renewed Hope" (in addition that code isn't working);
- "Ebon Plague" part was deleted from Unit::SpellDamageBonus but not from Unit::MeleeDamageBonus (in addition this code is not working anymore)
- "Blessing of Sanctuary" was working only on melee damage, plus this is not the way it should be fixed

Signed-off-by: PKX <[email protected]>
2011-11-23 15:48:01 +01:00
megamage 298c162c86 Do not allow an instance map to be created twice if it already exists. Fix #4018. 2011-11-23 09:34:08 -05:00
Shocker e9cd4c6e80 Merge pull request #3988 from kandera/tempbranch2
Core/Mechanic: Resurrection (fixed the issue with players ressing in pla...
2011-11-23 04:03:47 -08:00
Machiavelli 8444532746 Core/Units: Second part of SMSG_MOVE_SET_COLLISION_HGT implementation: compute proper collision height according to client formulae and send this to the client when mounting up. 2011-11-22 20:28:10 +01:00
Spp 99ad58233b Core/Opcodes: Change status of CMSG_MOVE_SET_COLLISION_HGT_ACK to Unhandled to kill spam log 2011-11-22 13:26:54 +01:00
Machiavelli 367122dd62 Core/Packets: Allow CMSG_MOVE_SET_COLLISION_HGT_ACK to be received from the client (currently unhandled) 2011-11-22 06:02:53 +01:00
megamage 23186b24e2 Merge pull request #3421 from Chipsi/master
Core/Items: Added case for Darkmoon Card: Madness trinket
2011-11-21 14:12:46 -08:00
megamage 811d1f85a5 Merge pull request #3990 from kandera/lfgfix
Core/LFG: Fix being unable to enter an instance to retrieve body when yo...
2011-11-21 13:58:23 -08:00
megamage 0992f27cad Fix the correct exit from the dungeon finder queue.
By Giuseppe Montesanto

Conflicts:

	src/server/game/DungeonFinding/LFGScripts.cpp
2011-11-21 16:56:39 -05:00
Machiavelli a14cbcaa3e Core/Units: Partial implementation of SMSG_MOVE_SET_COLLISION_HGT - send proper character collision height on dismount.
Fixes #2642

NOTE: Still have to properly implement collision height calculation for mounting up.
2011-11-21 22:54:25 +01:00
Machiavelli 32bcee40bf Core/Spells: Fix crash in Glyph of Rake 2011-11-20 16:05:41 +01:00
Machiavelli cab3def3a4 Core/Units: Revert previous 3 commits about Unit::_IsValidAttackTarget and Unit::GetReactionn until some conclusive research can be done 2011-11-20 12:56:14 +01:00
Kandera 04183cb8de Core/LFG: Fix being unable to enter an instance to retrieve body when you have 5 or more instances in the database. 2011-11-18 16:47:06 -05:00
Kandera e814cd8c35 Core/Mechanic: Resurrection (fixed the issue with players ressing in place then being ported to the person who revived them.) 2011-11-18 14:57:30 -05:00
Machiavelli 28d1cc9cfe Core/Units: Fix more issues in Unit::_IsValidAttackTarget. (Documentation on changes compared to the client function included) 2011-11-17 19:05:25 +01:00
Machiavelli 8ea8dd4f3d Core/Units: Replace wrong usage of UNIT_FLAG_PVP_ATTACKABLE with UNIT_FLAG_PLAYER_CONTROLLED in Unit::IsValidAttackTarget, Unit::IsValidAssistTarget and Unit::GetReactionTo. Using 4.1 flags in 3.3.5 doesn't always work out like it should... Also remove now unneeded change from 70b558d
Fixes SPELL_AURA_FORCE_REACTION amongst other things
2011-11-16 23:12:31 +01:00
Machiavelli 70b558dd39 Core/Units: Fix Unit::_IsValidAttackTarget (UNIT_FLAG_OOC_NOT_ATTACKABLE check specifically)
Closes #3172
2011-11-16 21:02:37 +01:00
Machiavelli c67af87eda Core/Spells: Fix SPELL_EFFECT_SEND_EVENT handler being executed more than once when targets != (0, 0). Closes #3934 2011-11-16 19:09:51 +01:00
Shauren 6cd78a520a Core/World
* Update character name cache after player rename
* Add character name data for characters loaded with PlayerDump

Closes #3653
Closes #3970
2011-11-16 10:31:38 +01:00
megamage 10b89d976f A temp fix for crash caused by remove corpse. 2011-11-14 21:01:53 -05:00
kaelima 17e1f8a0d5 Core/SmartAI: Remove the requirement for only players to trigger SMART_ACTION_SOUND.
Closes #517
2011-11-13 06:40:14 +01:00
megamage 0bb964285f Fix a crash caused by removecorpse 2011-11-12 23:04:51 -05:00
kaelima 163515341e Core/Spells: Fix Item - Hunter T9 4P Bonus 2011-11-13 05:00:26 +01:00
kaelima 9b7e9a1ee3 Core/Movement:
- Lower movement radius and speed when confused/disoriented.
- Force attackstop when confused or feared. Should fix issue with creatures "teleporting" after fear.

Close #2689
Close #466
Close #3743
2011-11-13 02:36:51 +01:00
kaelima 79903f31ce Core/Spells: Add own diminishing category for Dragon's Breath.
Will no longer share diminishing with Polymorph
Closes #3081
2011-11-13 00:51:33 +01:00
megamage d9e4d991c9 Fix a crash when player is logged out when not in map. 2011-11-12 08:16:52 -05:00
megamage 077a2194ba Fix another place where corpse is added twice to a grid. 2011-11-11 18:57:50 -05:00
megamage 07cf71fdd4 Some cleanup of add/remove to/from map. 2011-11-11 17:50:26 -05:00
tobmaps 3569f01adc Core/Spells: Fixed resist calculations for spells with multiple schools. Thx to Shauren for tips
Closes #3875
2011-11-12 04:40:44 +07:00
tobmaps c5e316164f Core/Vehicles: Fix some movable turrets 2011-11-12 04:04:22 +07:00
tobmaps 70aafbda94 Core/Spells: Partially fix RP-GG 2011-11-12 02:36:18 +07:00
megamage f47c0e661c Add some comments for the previous crash fix. Thanks to Amit86. 2011-11-11 14:20:49 -05:00
megamage 9e3b4fe409 Cleanup before deleting objects when unloading grid. Fix #3922. 2011-11-11 14:11:58 -05:00
megamage 360c9dd635 Add detailed crash info when aura owner is not in the same map as target in Aura::UpdateTargetMap. 2011-11-11 11:29:59 -05:00
megamage 583f6575e1 Do not add a corpse to grid twice. Should fix #3918. 2011-11-11 08:50:16 -05:00
tobmaps 4c44085dfa Core/Spells: Fix typo in 922a174683 and drop wrong check that breaks Judgements of the Just talent. Thx to Greymane for pointing out problem
Closes #2377
2011-11-11 19:05:12 +07:00
megamage 31a88d4fe5 Fix the crash when removing object from an unloaded grid. Object should always be unlinked from grid no matter if the grid is loaded. 2011-11-10 17:31:45 -05:00
megamage 23b3f16f3a Add some ASSERT in add/remove obj to/from grid. 2011-11-10 10:18:32 -05:00
Jorge 4749c853cc Merge pull request #3901 from Yelvann/master
Core/Arenas: Members of same arena team were able to fight each othe...
2011-11-09 11:59:13 -08:00
Yelvann 74dad924fc Core/Arenas: Members of same arena team were able to fight each other
and minor refactoring
Closes #3753
2011-11-09 20:33:01 +01:00
Shocker c2a2a4f713 Merge pull request #3872 from Bootz/master
Codestyle clean-up
2011-11-09 02:31:18 -08:00
megamage 462a2b9876 Change more ace_guard to trinity_guard 2011-11-08 10:48:49 -05:00
kaelima 8ba790ef35 Core/Creature: Prevent Spirit Guides (bg spirit healers) to be seen by alive players. 2011-11-07 18:18:59 +01:00
Bootz d1334624da Core: Codestyle clean-up
"pl"->"player"

 Note: codestyle methods needs maintained, Player* player.
still to do properly clean-up chat.cpp.
2011-11-07 11:18:00 -06:00
Bootz f75ec5ba2b Core: Codestyle clean-up
"plr"->player

Note: codestyle methods needs maintained, Player* player.
2011-11-07 11:06:39 -06:00
megamage 495ef10b0d Change ObjectAccessor to an ACE_Null_Mutex singleton, since its members have been protected by individual locks.
Also make some of its member functions static.
2011-11-07 09:44:09 -05:00
kaelima b5cb41b4ea Core/Player: Make chat tag (last byte in SMSG_MESSAGECHAT) a bitmask. 2011-11-07 07:16:31 +01:00
tobmaps ae600a0ea2 BG/Isle of Conquest: Fix bug with immediate respawn of Glaive Thrower 2011-11-07 06:09:16 +07:00
Machiavelli 92d32ab7f5 Merge pull request #3833 from Fredi/listitem
Core/Commands: Fix SQL typo in 'list item' command
2011-11-05 03:52:28 -07:00
tobmaps 8fd7720318 Core/Misc: Rename Spell::CalcCastTime to Spell::GetCastTime as it does not calculate anything 2011-11-05 05:33:52 +07:00