Commit Graph
371 Commits
Author SHA1 Message Date
click 461590832a Core: Generic cleanup (tab2spaces/whitespace removal)
--HG--
branch : trunk
2010-09-25 22:03:57 +02:00
Shocker 6b65e886f2 Core/Chat: Use universal language for party leader too when allowing twoside groups
--HG--
branch : trunk
2010-09-25 18:50:36 +03:00
Machiavelli a312a667cb Core/Player: Correctly send social list to player on login. Fixes display of number of online friends in the icon on the chat pane.
Fixes issue #3807.

--HG--
branch : trunk
2010-09-25 17:08:55 +02:00
Machiavelli 3c6dc32030 Core/DBLayer:
- Rewrite Field class to be able to store both binary prepared statement data and data from adhoc query resultsets
- Buffer the data of prepared statements using ResultSet and Field classes and let go of mysql c api structures after PreparedResultSet constructor. Fixes a race condition and thus a possible crash/data corruption (issue pointed out to Derex, basic suggestion by raczman)
- Conform PreparedResultSet and ResultSet to the same design standards, and using Field class as data buffer class for both
* NOTE: This means the fetching methods are uniform again, using ¨Field* fields = result->Fetch();¨ and access to elements trough fields[x].
* NOTE: for access to the correct row in prepared statements, ¨Field* fields = result->Fetch();¨ must ALWAYS be called inside the do { }while(result->NextRow()) loop.
* NOTE: This means that Field::GetString() returns std::string object and Field::GetCString() returns const char* pointer.

Still experimental and all that jazz, not recommended for production servers until feedback is given.

--HG--
branch : trunk
2010-09-24 22:16:21 +02:00
Spp b8cc05f747 Core/Opcodes: Re-enable error log for received opcodes marked as not allowed
--HG--
branch : trunk
2010-09-24 15:08:52 +02:00
Spp 9b56aadde1 Core/Opcodes: Add unhandled status, by balrok
--HG--
branch : trunk
2010-09-24 14:41:07 +02:00
Shauren d8ddf38453 Core/Items: Implemented trading soulbound loot items
Core/DBLayer: Converted more more player-related queries into prepared statements
Core/Items: Fixed loading of enchantments

Closes issue #4130.

--HG--
branch : trunk
2010-09-21 21:55:16 +02:00
Shauren 38be7aab55 Core/Player: Fixed client crashes at login (issue introduced in revision 1c33354f20)
--HG--
branch : trunk
2010-09-21 16:16:58 +02:00
Shauren a509976369 Core/DBLayer: Converted player login queries into prepared statements
Core/DBLayer: Added missing implementation for SQLQueryHolder::SetPreparedQuery

--HG--
branch : trunk
2010-09-20 18:20:40 +02:00
Spp 33dc6b9d5f Core/Dungeon Finder: Multiple changes
- Code Style
- Explicit removal of the proposal if player leaves the queue (do not waits to ::Update)
- Force to leave LFG system if group/player is joining and its already in
- Change some debug msgs and fix some typos (error --> debug)
- Offer to continue: Remove duplicate checks
- Move body functions from .h to .cpp
- Revert 11e39d620d and check if group recently joined by comparing joinTimes

--HG--
branch : trunk
2010-09-20 14:06:21 +02:00
Rat 2fb80e4a86 Core/ConditionMgr: You can now hide/show the quest marks with conditions (! ?)
note: check only runs at quest giver query!
Using together with CONDITION_SOURCE_TYPE_QUEST_ACCEPT you can totally hide quests

--HG--
branch : trunk
2010-09-20 10:19:20 +02:00
click 1d6d11d367 Core/CharHandler: Correction on SQL-statement - fixes logincrashes when testing for banned characters
--HG--
branch : trunk
2010-09-20 03:37:49 +02:00
Shauren 97aeb251b8 Core/Players: Added support for single character bans
Core/Commands: Renamed .ban character to .ban playeraccount (.ban character will ban only the player, not account)

This revision reaches 10000, congratulations and thanks to everyone who contributed!

--HG--
branch : trunk
2010-09-19 17:02:14 +02:00
Shauren 639a906664 Core/Pets: Fixed range check for water elemental Freeze
Closes issue #3628.

--HG--
branch : trunk
2010-09-19 17:02:08 +02:00
silinoron 52282986e1 Core/Movement: Some cleanup in MovementHandler.cpp.
--HG--
branch : trunk
2010-09-18 19:08:18 -07:00
linencloth 19a76020bc Core: more cleanup at locale handling.
Also fixes some problems mainly with non English languages.

--HG--
branch : trunk
2010-09-17 19:55:54 +02:00
linencloth d8a854d6e0 Core: Cleanup locale handling.
It also fixes the recent problem of strange strings.

--HG--
branch : trunk
2010-09-17 07:04:29 +02:00
Spp c7354dd66b Core/Dungeon Finder: Ignore multiple join queue petitions while joining
--HG--
branch : trunk
2010-09-16 18:55:00 +02:00
click 4d88ce57d2 Core/: Set correct sizes of SMSG_ATTACKSTOP packets
--HG--
branch : trunk
2010-09-16 18:05:50 +02:00
linencloth 9739bea487 Core/Loot: Reimplement the proper check for loot recipient to prevent rewarding loot without tagging the creature by the player.
Also fix the related skinning problem, and do not set the skinnable flag for creatures without any loot recipient.

--HG--
branch : trunk
2010-09-15 17:44:56 +02:00
Spp cc3d4cc823 Core/Scripts: Add OnPlayerLogin, OnPlayerLogout, OnPlayerCreate and OnPlayerDelete
--HG--
branch : trunk
2010-09-15 13:23:07 +02:00
Spp b5172ea7d4 Core/Dungeon Finder: LfgUpdatePlayer and LfgUpdateParty opcodes will be sent only when LfgUpdate is active
--HG--
branch : trunk
2010-09-14 20:09:34 +02:00
Spp 64e60aaeda Core/Dungeon Finder: Add extended debug info to handler
--HG--
branch : trunk
2010-09-14 20:05:30 +02:00
Spp 61bbd284de Core/Player: Add default remove Method to RemoveFromGroup
--HG--
branch : trunk
2010-09-14 16:38:08 +02:00
Shauren 6d0a031a77 Core/Quests: Some cleanup in quest relation accessing
--HG--
branch : trunk
2010-09-13 13:18:27 +02:00
Shocker fef504e365 Core/Loot: Looting should interrupt casting, fixes issue 3676.
--HG--
branch : trunk
2010-09-13 04:02:57 +03:00
click 4da2cdffea Core/ItemHandler: Force size on abs() value calaulation
The size of the return value of abs() is natively defined, and can exceed 32 bits on x64 systems
Fix by Zor

--HG--
branch : trunk
2010-09-12 02:59:19 +02:00
click 26ec6042be Core/PetitionsHandler: Slight cleanup on enums (sorting by ID, types and costs)
--HG--
branch : trunk
2010-09-12 02:52:44 +02:00
click bc28f2ab25 Core/Petitions: Remove some magic numbers, and classify types into enums (based on Amkis patch)
Fixes issue #3228

--HG--
branch : trunk
2010-09-12 02:00:42 +02:00
click bf664b7a44 Cleanup/Core: Remove whitespace and tabs
--HG--
branch : trunk
2010-09-12 01:40:27 +02:00
Shauren d714d0eb20 Core/Loot: Reverted revision 44a1f284dd3e
Core/Loot: Implemented automatic currency distribution in better way, applying all conditions and updating achievements

Closes issue #3912.

--HG--
branch : trunk
extra : rebase_source : 35c2a59d213793ee29dfd0fc1acb7c15b375b049
2010-09-11 21:28:55 +02:00
Machiavelli a41e99223e Core/DBLayer:
* Rename QueryResult class to ResultSet
* Rename QueryResult_AutoPtr to QueryResult
* Declare ACE refcounted auto pointer for PreparedResultSet class

--HG--
branch : trunk
2010-09-11 21:10:54 +02:00
Spp 52bc38615c Core/WorldSession: use extra param in SendPartyResult for future use
--HG--
branch : trunk
2010-09-10 13:45:21 +02:00
Machiavelli 9dd6e8f4d0 Core/Worldsession: Fix possible crash in 6 query callbacks
--HG--
branch : trunk
2010-09-09 20:26:56 +02:00
Spp a9782329ab Core/Dungeon Finder: Move all packet handling from Mgr to Handler (also minor cleanups)
--HG--
branch : trunk
2010-09-09 14:49:52 +02:00
Spp 8509d50a39 Core/Dungeon finder: Missing changes from previous commit
--HG--
branch : trunk
2010-09-08 13:44:57 +02:00
Spp fcc8d1e4a8 Core/Dungeon Finder: Properly expand random dungeons before adding to queue and minor cleanup
- Groups were being added to queue even with no dungeons. Client was not informed so group couldn't join queue anymore
- Some cleanup in error msgs and function order
Fixes issue 3851

--HG--
branch : trunk
2010-09-08 13:19:05 +02:00
Shocker 6284854965 Core/Handlers: Prevent possible movement hijacking exploit, original code by VladimirMangos
--HG--
branch : trunk
2010-09-08 09:46:42 +03:00
silinoron b1e7dc1ad2 Core: Disallow race and faction transfers to races for which character creation is not allowed.
--HG--
branch : trunk
2010-09-06 10:42:53 -07:00
azazel 7afc640ef4 Core: add possibility to disable creating of characters of specified races/classes.
--HG--
branch : trunk
2010-09-06 23:34:16 +06:00
click db0b166116 Core/LFG: Include ObjectMgr.h in LFGHandler (fixes nonPCH-compiles)
--HG--
branch : trunk
2010-09-06 11:39:32 +02:00
silinoron c8f872da49 May as well make sure of no SQL errors for spells, too.
--HG--
branch : trunk
2010-09-05 16:45:18 -07:00
silinoron 66cc9a5d67 Fix a typo in race and faction transfers - reported by 0xFuture
Fixes issue #3844
Fix a SQL collision in race and faction transfers - reported by Aokromes

--HG--
branch : trunk
2010-09-05 16:34:38 -07:00
Spp b80e1b4b5b Core/Dungeon Finder: Minor cleanups
--HG--
branch : trunk
2010-09-05 21:29:52 +02:00
Spp 9e4dd760ba Code/Dungeon Finder: Move some packets from Mgr to Handler
--HG--
branch : trunk
2010-09-04 18:20:10 +02:00
silinoron be7d94f24e Add support for character race and faction transfers.
Based (loosely) on patch by Ner'zhul, DarkXuan, and [email protected].
Fixes issue #3429.

--HG--
branch : trunk
2010-09-05 13:12:24 -07:00
silinoron 2dae023649 Core/[Mail, WorldPacket]: Pull mail packet handlers out of Mail.cpp into MailHandler.cpp
Core/ScriptSystem: Remove unneeded TODO.

--HG--
branch : trunk
2010-09-04 13:46:01 -07:00
silinoron 5179d3149a Core/Game: Fix remaining warnings on windows (and most likely almost all of the ones on *nix)
--HG--
branch : trunk
2010-09-03 21:55:57 -07:00
silinoron 1e1c596dda Core/WorldPacket: Fix the core spamming complaints about CMSG_QUEST_QUERY being sent post-logout
Core/Spells: A little bit of "cleanup"

--HG--
branch : trunk
2010-09-03 20:30:29 -07:00
Machiavelli 273679c5ba Core/DBLayer
- Store threadbundlemask internally per database pool and prevent direct access to config file post startup
- Fix threadbundlemask flag checking for ReactorRunnable, WorldRunnable
- Remove CLI threadbundlemask flag, CLI doesn´t need a seperate mysql connection nor thread
- Remove unused Character Database connection from WorldSocketMgr / ReactorRunnable
- Add proper LoginDatabase connection to RA Runnable (soon to be overhauled)

Note: still experimental and not tested for live use

--HG--
branch : trunk
2010-09-03 10:52:32 +02:00