The code in Creature::Update() should be modified to wait a few seconds before resetting the hp. PATHFIND_NOPATH / PATHFIND_INCOMPLETE don't really mean that the Creature can't attack the player anyway either.
(cherry picked from commit d910ffd77949f422bd08f12079866962fb53c4dc)
Rename recent GameObject spell overloads (they used to accept only Unit as parameters) to fix GCC warnings about partial function override.
(cherry picked from commit e3a9a9bfb2cba3fc1f6ed616b07fb0ea88de461f)
Add ".debug asan memoryleak" and ".debug asan outofbounds" commands to trigger Address Sanitizer warnings at runtime (or other dynamic analysis tools)
(cherry picked from commit 71d15ea25be3e86646faaa3266617a0b8177972f)
Fix a memory leak in Metric happening only when enabling/disabling Metric from configs at runtime, leaking the metric added between last SendBatch() call and the ScheduleSend() call in the same function. The only way to reproduce this is to actually freeze the thread calling SendBatch(), disable metric, reload config, unfreeze the thread.
(cherry picked from commit 0d1ff7446dce7b0641f49ac55a008669838612cd)
Fix infinite loop in npc_air_force_bots happening when aura 38067 was removed, triggering MoveInLineOfSight() that would add back the aura. Only 1 aura add/remove for guard for player is allowed now.
(cherry picked from commit 844e7ee9262a5ba035ac9e8a6ffc298fb97fd3a9)
Fix .cheat god command still letting you die with Area Aura like Slime near Thaddius, broken since 777b287dff
(cherry picked from commit f26f716714fefa2af4c6e3eea263206682d45236)
Fix crash caused by WorldObject::setActive(false) called after WorldObject::DespawnOrUnsummon() happening because the WorldObject would be set as not active but then Map::RemoveFromActiveHelper() would not be called because of not being in world anymore.
Whenever setActive() gets desync'd with what Map actually contains a rare crash would happen since Map only reads a few values of the active WorldObject, making it hard to reproduce. If this happens again some ASSERT calls should be added (or a check in Map::RemoveFromMap() could be added about if the WorldObject is in Map::m_activeNonPlayers container).
(cherry picked from commit 1c833f28e471e3787f1d328e44af5f065ad9ca8c)
(cherry picked from commit 0e8e3828f48120629b642d0de1db704fd0bb86cb)
(cherry picked from commit 65afe47580e84a006eb6ce506623d3719ae5bc9b)
(cherry picked from commit 21667f97cbd519dbef1650cd29d53f26443441f3)
Restore original data3: Time in ms before the initial state is restored, and remove the manual despawn as it's called once the gob change state
(cherry picked from commit 90e0131676099c7173022ca5e84f2d0f806a6b05)
- Typo and spelling corrections
- Grammar corrections, English grammar
- Minor adjustments in example code readability
- Capitalization adjustments to keep consistency
with existing idioms, phrases and concepts
(cherry picked from commit f9b1e4a03259c39af0d24e63f877455944b8af2e)
Improve calendar timezone handling by at least creating events with the correct time if both client and server are in the same timezone. There is currently no information received from the client about in which timezone it is.
(cherry picked from commit b33934f6ce9b0227597c712dd6a76b7ed49deea3)
All erases within MotionMaster are now done by itr.
Previous impl used value erase which uses the custom comparator which does not identify elements uniquely --> wrong values were deleted
ref #23187#discussion_r275791179
(cherry picked from commit 11de6b5f866e087307a719b931be8c51b984c54e)
* Migrate spells to scripts
* Simplify code
* I need to sleep
* Update chapter1.cpp
* Use actual damage
* No need in null check here
(cherry picked from commit 2cfaeb14004cfbb5500855472ad89ab9238df13d)
jackpoz