josh/TCPlayerbotCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
39,271 Commits 1 Branch 0 Tags
7b2ff1c1fc47d1fd9a79225dfb7dbc031dcda53e
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Treeston d8de3ac118 Core/Warden: Max packet size 500 -> 450 
(cherry picked from commit de33d50c1940512985887f916118014c98b53ecb)
 2022-03-05 21:47:08 +01:00
Treeston 5b9fec5f0b Core/Maps: Move some more Map internals to actually be... internals. 
(cherry picked from commit 94c03b2107ad6603aaf185d58d63480e79c97e76)
 2022-03-05 17:12:51 +01:00
Treeston b5f3a6fd80 Core/Maps: All RespawnInfo* handed to outside code are now RespawnInfo const*, to signify that outside code has zero business changing these. 
(cherry picked from commit 803dc789e42ea2298a8bd1822849b6f2df82efe6)
 2022-03-05 17:12:23 +01:00
Treeston a8d00ddd69 Core/Maps: move pooling hand-off outside of Map::CheckRespawn (PR#25785) 
fixes #25777

(cherry picked from commit f8afcec9f3efc58ce8a38a6c63e2ebfc24d2e01d)
 2022-03-05 17:07:46 +01:00
Treeston 57f382d91c Game/ChatCommands: Make sure ChatHandler::extractPlayerTarget populates the strtok buffer for non-nullptr returns. Closes #25692, supersedes #25698. 
(cherry picked from commit c8c572d9800ae20cb0a89fb666003213655704c8)
 2022-03-05 01:02:18 +01:00
Treeston 2319a99d87 [3.3.5] Scripts/Commands: .learn adjustments (PR #25454) 
(cherry picked from commit cc8287927b9c9f0bf20143972fd4d3c338bff688)
 2022-03-01 22:48:06 +01:00
Treeston 1bbf61ef02 AI/CreatureAI: Properly update Victim even while spell focusing 
(cherry picked from commit 684910a230b2e8e780ad24bc0c4eece835bc249a)
 2022-02-28 21:36:50 +01:00
Treeston 1feb53939d Core/ChatCommands: Fix a potential crash if a custom chat command does not have a specified help string 
(cherry picked from commit 3ec98bf2410bb8fa73fe6b386a6e766bef575e97)
 2022-02-28 15:54:08 +01:00
Treeston 525dabc377 whitespace to make CI happy, 7bf9a06 follow-up 
(cherry picked from commit 837e32fe118c2f1da2a2f43b8937df0fe9f66d84)
 2022-02-27 23:53:33 +01:00
Treeston 150f108174 Scripts/Commands: Fix a potential crash in cs_account.cpp 
(cherry picked from commit 7bf9a0640e57f4e44a80b6fd91e8f46fd7fb9c72)
 2022-02-27 23:53:16 +01:00
Treeston 167a2c5da9 Scripts/ChatCommands: Rename 'lookup itemset' to 'lookup item set' to remove ambiguity. 
(cherry picked from commit f45600fb2e6bbd4870a74e0bcb359984d3007c22)
 2022-02-27 23:41:55 +01:00
Treeston a788e0c3e1 Core/ChatCommand: Improve feedback for ambiguous commands 
(cherry picked from commit a6d8a7ad1e5e507aacc90546982a7590b62d2d78)
 2022-02-27 23:26:40 +01:00
Treeston 6439aefa42 Scripts/Commands: Move .account to trinity_string 
(cherry picked from commit 899932a2753d6a1522c8ae49a21361bba6a9a438)
 2022-02-27 23:15:02 +01:00
Treeston 5e013a9996 Core/ChatCommands: Add trinity_string support for chat command help 
(cherry picked from commit 26c510775c6a1995d81b16ad7459227381801dcc)
 2022-02-27 21:23:11 +01:00
Treeston 106c9b7541 Scripts/Commands: Rename .additemset to .additem set to avoid ambiguity 
(cherry picked from commit e11b466897752eb400428eafd05c7dbf08c562bf)
 2022-02-27 21:03:20 +01:00
Treeston c13d7df72b Scripts/ChatCommands: Constrain how char const* may be used as a command handler parameter. It may now only be used in the legacy configuration, as the only argument. 
(cherry picked from commit 9fda67d016798260dcab4b2110c00ab85e1fff2f)
 2022-02-27 20:59:37 +01:00
Treeston 46d4e2fa83 1eca51b follow-up, nuke command.permission from orbit; it was only duplicating data already stored in the core. 
(cherry picked from commit 991dc8e050777b5e33ff22b008ab2125bae22437)
 2022-02-27 20:59:19 +01:00
Treeston 3fd2eb126c [3.3.5] ChatCommands, the other half: chat command resolution refactor (PR #25463) 
(cherry picked from commit 1eca51b417678b9a48b28552925d5694105f82bb)
 2022-02-27 20:08:41 +01:00
Treeston 2aa9d9a67a Scripts/Commands: Correct some unexpected behavior in .level 
(cherry picked from commit d2f51569d12f3cb72e53351914d2535eb6ef2dbe)
 2022-02-06 01:15:37 +01:00
Treeston 6ede274024 Core/ChatCommands: Fix an issue that caused trailing variant options to sometimes not be selected 
(cherry picked from commit 14fa6c3a725f617e02af74eea95f5074b9095704)
 2022-02-06 00:07:47 +01:00
Treeston 378691aaa2 [3.3.5] Core/ChatCommands: Show error messages from argument parsers (PR #25443) 
(cherry picked from commit 75f9e7396e35360f3016cc0cb21e72e20f5d96d5)
 2022-02-05 23:42:15 +01:00
Treeston 7d0586812a Core/Misc: Fix some static analysis warnings exposed after 6b8f3d0. 
(cherry picked from commit 59be657ca267667b3cbeb1f34d47df0382e97f53)
 2022-02-05 23:05:14 +01:00
Treeston 013c9b2cb7 Core/ChatCommands: make ExactSequence more readable 
(cherry picked from commit feaaa595cae735bb6093b24a88562c27b2723cfe)
 2022-02-05 21:29:53 +01:00
Treeston 54fc62db52 Core/Misc: Convert leftover DatabaseTransactions-by-reference (pass them by value!) 
(cherry picked from commit 6b8f3d0f94b7a611eba81b7a2ff476cf75d09f4a)
 2022-02-05 19:56:31 +01:00
Treeston b6635be041 [3.3.5] Core/Guilds: Guild cleanup (PR #25422) 
(cherry picked from commit cd28423a4e813baf6833f38c93613a7f82a721f8)
 2022-02-05 19:20:18 +01:00
Treeston 42be7836df Chat/Commands: Eradicate ChatHandler::extractOptFirstArg 
(cherry picked from commit 4f636b80e4942c4c9c4811496d1c1b77f767378d)
 2022-02-05 16:21:54 +01:00
Treeston 358dc78e47 Scripts/AreaTrigger: Rename OnlyOnceAreaTriggerScript::_OnTrigger to TryHandleOnce, and make its return value useful. 
(cherry picked from commit 0c7f6ac89fcc5fdc7f4435a6c1b673c752eb1e41)
 2022-02-05 14:53:54 +01:00
Treeston 1e9d60b4ac Scripts/Commands: .character command conversion 
(cherry picked from commit 00dd337b5d2c91907424828d7eebe3191931b036)
 2022-02-05 14:44:01 +01:00
Treeston 706163743d [3.3.5] Scripts/Commands: .arena command conversion (PR #25407) 
(cherry picked from commit b63d655e20a0facf14fc77798c52ea67d8551fa7)
 2022-02-05 13:57:50 +01:00
Treeston 75e5c44638 Scripts/IcecrownCitadel: correct Rimefang's script name 
(cherry picked from commit fc3feebee9e26ec5bc21a46f37b5affe416582c6)
 2022-02-05 13:32:55 +01:00
Treeston fc094509e9 Core/Scripts: Remove now-unused WaypointPathStarted hook. WaypointStarted does everything it used to do, anyway. b3694bf follow-up. 
(cherry picked from commit c9356190b7891deb7878bc30064eaf1c81857c2c)
 2022-02-05 13:31:50 +01:00
Treeston e0e3bae82c Core/Authserver: Removal of sha_pass_hash, compatibility fields, and everything that uses them (PR #25156) 
(cherry picked from commit bcdbdd6f23ce65cc0e381e61d2840140dce79311)
 2022-02-05 13:29:21 +01:00
Treeston 3bf33628fc Scripts/Commands: trinity_string updates 
(cherry picked from commit 3b1e911da3551cf9c69798bbb8b5f52d34be8522)
 2022-02-05 13:09:28 +01:00
Treeston 970cd097de Core/Combat: When entering a vehicle, transfer any current threat to that vehicle. Closes #1340. 
(cherry picked from commit 47c7910036d5a32a92aa58b48553a1b8c8891e08)
 2022-02-05 13:08:46 +01:00
Treeston 4d62cc70d6 Scripts/Commands: Convert argument parsing of .npc commands 
(And I snuck some chat command cleanup in there, more de-cluttering!)

(cherry picked from commit 88d446dadf65bf47c72d3042834281233b1174ac)
 2022-02-05 00:43:55 +01:00
Treeston 6fded37e86 Scripts/Commands: Convert argument parsing of gameobject commands 
(cherry picked from commit 35b3ba90b03143f2dc700cc4baeb88a58089c102)
 2022-02-05 00:24:39 +01:00
Treeston da8a66a05e Common/Util: Trinity::StringTo<double> support (PR #25364) 
(cherry picked from commit f45aa5cac1579e87cbc599ffb58e10e662066792)
 2022-02-04 23:50:25 +01:00
Treeston 0d54a5ecb4 Core/Misc: Add support for custom link colors. Clean-up hyperlink validation, no more long-ass defines. Remove UI.ShowQuestLevelsInDialogs. 
(cherry picked from commit eaf8fa75a1c76131ecbf2585db6d6236b7334b8e)
 2022-02-04 23:49:59 +01:00
Treeston c4b287c7bf Core/Misc: DBC std::array refactors, and |Hachievement unit tests 
(cherry picked from commit 3fbbe7cfbe1bc51db12bdc1ec7b21c16d1716366)
 2022-02-04 23:37:29 +01:00
Treeston c82b107b6b UnitTests: Add a first set of item hyperlink tests 
(cherry picked from commit 5394b2ef0f1c7b48e8886257b93698358abb575f)
 2022-02-04 22:11:42 +01:00
Treeston 627ff1587d UnitTests: Add basic hyperlink unit test 
(cherry picked from commit 86e6438008cf5179a2ff3b22c2e0459ee7aaa20c)
 2022-02-04 21:33:27 +01:00
Treeston 03fd9b038e Core/Chat: Correct Hyperlink validation for incomplete achievements. 
(cherry picked from commit fdcb1c8b2e142acc012f2ecb2ece082302e8fb15)
 2022-02-04 21:27:25 +01:00
Treeston a65e7e0213 Scripts/Commands: Fix a crash in .help - closes #25360 
(cherry picked from commit 944f49d61355926e0d9e5c2d16eb4ad1af03d13c)
 2022-02-04 21:21:40 +01:00
Treeston 45e9e94311 Core/ChatCommands: C++17 cleanup (again) (PR #25323) 
(cherry picked from commit 2f7d2ef3e979ecd0536f3a3713e56c8e59652a47)
 2022-02-04 21:21:17 +01:00
Treeston 2aaebc193c UnitTests: Cleanup + StringConvert/ChatCommand tests (PR #25353) 
(cherry picked from commit 8ce3635d39dbdd101ddf180a66c483162df99c04)
 2022-02-04 13:03:29 +01:00
Treeston 1303ca0e7e Common/Utilities: Make StringTo<bool>'s signature match that of the other integral types, making for easier templating. Default behavior unchanged. 
(cherry picked from commit f54cec4db7c67b623383c140159e1171876ace89)
 2022-02-04 12:06:26 +01:00
Treeston 9f97fdd31a Core/Common: Tokenizer -> Trinity::Tokenize (PR: #25327) 
(cherry picked from commit 534a2388b7c662c8796aabb1ec8cb424879799b6)
 2022-02-04 00:27:14 +01:00
Treeston 6e45c371c4 Common/Utilities: Properly read std::from_chars documentation and check for out_of_range errors. 
(cherry picked from commit 7478c2c65aea853a2086c9c7ecc56c14ad6ee338)
 2022-02-04 00:27:14 +01:00
Treeston be9dadc189 Common/Utilities: Centralize string -> T conversion in StringConvert.h (PR #25335) 
(cherry picked from commit cd30e0b86ce6ee88386a91cebdf353fc55805c57)
 2022-02-04 00:27:13 +01:00
Treeston 7b88fd607e Core/Warden: Ensure Warden packets do not exceed 512 bytes. This should rectify random Warden timeouts. 
(cherry picked from commit 7cc027401e4a2837872db54c835a4ed1a98e4a03)
 2022-02-04 00:27:13 +01:00
Treeston cfcfe71097 Build: Add Clang version guard to CMake (PR #25324) 
(cherry picked from commit 27b1930d97d541c241655d8b820cbaebe6eec44e)
 2022-02-04 00:27:13 +01:00
Treeston 03b5c17863 Common/Utilities: Move EnumUtils' implementation struct from Trinity::Impl to Trinity::Impl::EnumUtilsImpl. This avoids confusing name clashes for other implementations in sub-namespaces of Trinity::Impl. 
(cherry picked from commit 91744de3162bab23d7c5a0dd65fc8b4249eb803a)
 2022-02-04 00:27:12 +01:00
Treeston 0473beff2b Core/Misc: std::string -> std::string_view in a bunch of places, notably chat commands and Util.h 
(cherry picked from commit a41bbd9ad9adedb15c7133bdef1575a6ec0eb1ab)
 2022-02-04 00:27:12 +01:00
Treeston 6303fbc449 Core/Misc: Update worldserver.conf.dist to match actual defaults. 
(cherry picked from commit d717b9dc3e0a25fc0c6f7d55e08740e295697c67)
 2022-02-04 00:27:11 +01:00
Treeston c6582096ab Core/Warden: Add Lua checks to Warden (PR #25286) 
(cherry picked from commit 0531463a3c02d98ed77e9c7689ad7237ecaddc09)
 2022-02-04 00:27:11 +01:00
Treeston 669b6bea21 Core/Warden: Ignore the length value in the database for MEM_CHECK checks. Hi there Aokromes. 
(cherry picked from commit fc32c3fd3b2e91702a41798ef962cbc8475c8584)
 2022-02-04 00:27:11 +01:00
Treeston 15d75dea10 Core/Warden: More refactors lifted from #25286. 
(cherry picked from commit a3971ca4b05e2913850b6d4fe7d40884fa645fa0)
 2022-02-04 00:27:11 +01:00
Treeston 317bb198b1 Core/Warden: Some Warden refactors lifted from #25286. 
(cherry picked from commit 5b4288f05f7e2360bcdc80872787ee2e7a7a2f56)
 2022-02-04 00:27:11 +01:00
Treeston eaa3c7e5a0 Core/Warden: Add .debug warden force, allowing you to force specific warden checks to be sent 
(cherry picked from commit f04f4e91ff3afbf89f30659b85e8593c3206138e)
 2022-02-02 22:47:55 +01:00
Treeston e0ddc676d6 Scripts/Commands: Move .debug asan command bodies inside #ifdef ASAN 
(cherry picked from commit e18f7aaa4d1bc9f6ad4b524c25fd3f111493b774)
(cherry picked from commit 0b13fc192698f65cc6e338ef92c22d4d783281b9)
(cherry picked from commit 5ecbe93f7d75ea3c4808ce45ccc7d14e1d42b26b)
 2022-02-02 21:27:52 +01:00
Treeston 673521bc87 Core/ChatCommands: Move Trinity::ChatCommands::Variant from boost::variant to std::variant (for real this time) 
(cherry picked from commit ffc3e355fe2adfe48d37759091a537b699b12753)
 2022-02-02 20:49:42 +01:00
Treeston d297f65df2 Core/DB: Move every gameobject that uses the spawntimesecs < 0 hack into the legacy spawn group 
(cherry picked from commit b74dc4754d8c1edb81e9564beea1783bdd39d87c)
 2022-01-26 22:14:24 +01:00
Treeston 319ddd9bcd Core/Warden: Warden refactors (PR #25235) 
(cherry picked from commit 6116e5b38522ccfb00f6c941c75482e05b4c0799)
 2022-01-26 19:42:11 +01:00
Treeston 7603dacc64 Core/Authserver: Deprecation of sha_pass_hash (PR #25138) 
see also #25157

(cherry picked from commit 44a3aad0af4bdd132b8761761dc83df2d7d6c601)
 2022-01-26 16:21:43 +01:00
Treeston fa8ab6eb98 Core/Common: Move old-style pointer+size HexStr methods to Trinity::Impl where they can't hurt anyone 
(cherry picked from commit 7b8b999516a824b0c417631a77f133eb47b8b2f4)
 2022-01-26 14:36:42 +01:00
Treeston 23ad14526c Core/Common: Allow config settings to be loaded as optional (PR #25137) 
If the config setting is not present, returns the default without issuing a warning.

(cherry picked from commit 5ad064976edfc931cdda6faffe723d7c3dfb0ae4)
 2022-01-24 15:08:46 +01:00
Treeston d11c3807b3 Core/Time: Rename GetGameTime{System, Steady}Point methods 
The names are a bit unhandy. Rename them (shorter but still meaningful).

GetGameTimeSystemPoint() -> GetSystemTime()
GetGameTimeSteadyPoint() -> Now()

Also add 2 new typedefs:

typedef std::chrono::steady_clock::time_point TimePoint;
typedef std::chrono::system_clock::time_point SystemTimePoint;

Closes #25042

(cherry picked from commit 896b68d5c297b06587645caebc98b704978ecaa7)
 2022-01-23 21:36:03 +01:00
Treeston a6332f5dec Core/Misc: C++17 cleanups, commit 3, the header commit 
(cherry picked from commit ca0c50bc450f5259acc6af0f4123690969b7e9cb)
 2021-12-24 00:37:25 +01:00
Treeston ea0aa63d96 Core/Misc: C++17 cleanups, commit 2, the advstd commit 
(cherry picked from commit 857f8d9231d148d4f2def9c83548b40059923029)
 2021-12-24 00:37:21 +01:00
Treeston 632609b897 Core/Misc: C++17 cleanups, commit 1 
(cherry picked from commit ac9004a2f9fa7af7c7735168e7bc5c08d6cacca7)
 2021-12-24 00:34:10 +01:00
Treeston fdcef115e0 Core/Chat: Add SpellInfo const* handler for command args. Use it to update .cast <spellId/link> <triggered>. 
(cherry picked from commit 7ac6ccb36ba6ffba542f3e9a60bca4d9e6a6b84d)
 2021-12-24 00:34:08 +01:00
treeston ee5c0e5372 Core/Chat: Disallow hyperlinks from being inserted in various guild-related freetext fields (the client already blocks this) 
(cherry picked from commit 01b2ac3ed425a3f94480c2b8a453c62ae30f6708)
 2021-12-23 21:09:24 +01:00
Treeston 94a79bac7a Core/Misc: Some refactoring, #23603 prep: (#23676) 
- Split SpawnMetadata off from SpawnData
- No longer allocate Creature/Gameobject objects in ObjectGridLoader just to check their typeid and delete them afterwards

Co-authored-by: Giacomo Pozzoni <[email protected]>
(cherry picked from commit 9304e496cbf6ab6c028671fb8526c732ae5d799f)
 2021-12-21 15:16:26 +01:00
Treeston 12f9423efa Common/Encoding: fix Base32 alphabet (oops) 
(cherry picked from commit e457b77b4b8d8fcb8dcb916170e3b40273f0b966)
 2021-12-19 01:46:30 +01:00
Treeston 0bffed380d Scripts/ICC: Professor Putricide no longer tries to add threat on units it cannot add threat on because of immunity flags. Instead, its AI manually controls the engagement state. Should close #23727. 
(cherry picked from commit 23fd193e4e489bb5f231653987e98ba24448832b)
 2021-12-18 21:31:31 +01:00
Treeston 97bf9278a8 Entities/Creature: Fix an edge case assertion failure with pets dying in specific situations while casting spells. 
(cherry picked from commit 6590a0bfcefe7b8e5f87c82ba5ab4df2c72be418)
 2021-12-18 20:31:57 +01:00
Treeston e0e1978b08 Entities/Player: ReacquireSpellFocusTarget is now private. It should've been private all along. 
(cherry picked from commit 1c2b1cbba82fcd523ccd0cceafe532f35d71dcc1)
 2021-12-18 20:29:29 +01:00
Treeston 4b588694ca Core/Creature: Fix an issue that sometimes prevented spellcast focus targets from being reacquired. 
(cherry picked from commit fcce90508d899641494d7c281a0e08e411a0d5ab)
 2021-12-18 20:29:05 +01:00
Treeston 0b61c3b7b1 [3.3.5] Core/Authserver: TOTP rewrite: (PR #23633) 
- Proper management commands (.account 2fa)
- Secrets can now be encrypted (set TOTPTokenSecret in .conf)
- Secret now stored in binary
- Argon2 and AES primitives
- Base32/64 support

(cherry picked from commit 4211645834c467a03c60248e80818d3607be9ea7)
 2021-12-18 20:24:50 +01:00
Treeston f434241305 Core/Channels: Fix a bug that would cause channel settings to disappear in certain settings. Fix a bug that would cause channels to not be saved on .server shutdown without delay. Closes #23699. 
(cherry picked from commit 464b0b059b5ccb7db6d2f282937711032005b5c3)
 2021-12-18 19:16:47 +01:00
Treeston 7704d8fc7a Scripts/Commands: Add .go boss, and do a usability pass over .go instance to match it. 
(cherry picked from commit 57b36dfdc6b077cc4eba29406e3ded4dbf9f8ce6)
 2021-12-18 16:13:24 +01:00
Treeston c7e7c52c1a Scripts/Commands: Cleanup some output from .go instance 
(cherry picked from commit 4320a021e93423122745684e2689aa1a7028f8b4)
 2021-12-18 16:00:20 +01:00
Treeston dcf9854e6a coverity 
(cherry picked from commit 268384d2af505964a422552f5684a502d6814194)
 2021-12-18 15:49:44 +01:00
Treeston a8ceed265a typo fix in comment 
(cherry picked from commit 4fcb322010edb6a80fa08e633ce331f80410f301)
 2021-12-18 15:47:18 +01:00
Treeston 28942db431 Common/Util: Sorry about that unexpected downtime at 3AM last night, everyone. (We call them happy little features.) 
(cherry picked from commit a4d5b24874e7f6f09efc69119785c7c9113870b4)
 2021-12-18 15:33:44 +01:00
Treeston 51fbda4223 Core/Pooling: Quest pooling rewrite: (PR#23627) 
- Split quest pooling from PoolMgr (into QuestPoolMgr)
- Proper saving/restoring on server restart
- No more hacking into sObjectMgr to insert/remove available quests

(cherry picked from commit a5e73e41c0e813e674bb0a644e0052052435494e)
 2021-12-18 15:28:45 +01:00
Treeston a90073dadd no idea what happened there (4a219ed follow-up) 
(cherry picked from commit b159921099e3d10fbe282d9496b9ffb56f28f16d)
 2021-12-18 11:37:33 +01:00
Treeston a18268156a Core/Chat: Always save channel info to database on shutdown if persistence is enabled. 
(cherry picked from commit 2d74652b5bfb4455791ff872fac13fb0f6bcc02a)
 2021-12-18 11:37:14 +01:00
Treeston 14c38a1c52 Core/Unit: Spell focusing now no longer nonsensical. HasSpellFocus always const. Error logs for various stuff. 
(cherry picked from commit 4a219eda07c353139608065f7d0a016094ee4ce0)
 2021-12-18 11:36:50 +01:00
Treeston 82d62a3d4c This is not the critical chat system bug fix you were looking for. No sir. (Oops.) 
(cherry picked from commit 6a330214a112460f4e492135e76f1277328af406)
 2021-12-18 11:27:02 +01:00
Treeston 87c2d247d9 Core/Misc: Rewrite some old name handling functions that use raw buffers to no longer be old name handling functions that use raw buffers. 
(cherry picked from commit 309851ea2442457c87f791bb44abfa89e04af1af)
 2021-12-18 11:25:59 +01:00
Treeston 3db58c4d96 Core/SmartAI: SmartAI creatures no longer process health-based hooks after death. 
(cherry picked from commit 1faa54fe8b2690507e4177a9a7373c0b24855291)
 2021-12-18 00:03:55 +01:00
Treeston 87786b1ebc Scripts/Hyjal: Seriously, who calls EnterEvadeMode in a AI constructor???? 
(cherry picked from commit c444cb17e10e118e704012e23c86e1b47f94031b)
 2021-12-17 23:57:18 +01:00
Treeston 8839fa3fe2 Core/Chat: Custom channel preservation rewrite. Channel data is now loaded at startup, and written to the DB periodically, instead of both things happening in real time. 
(cherry picked from commit fedf1f557b2aa1cbb0f4bc722b24afb59cc30855)
 2021-12-17 23:22:13 +01:00
Treeston 8c3eb07889 Scripts/FollowerAI: Some cleanup: 
- FollowerAI properly resumes follow after evading.
- Removed duplicated getters from CreatureAI (IsEscorted vs IsEscortNPC), they were used to do the same thing
- FollowerAI properly assists in combat.
- FollowerAI properly despawns if quest is abandoned.
- FollowerAI now supports dynamic respawning for escort NPCs.

(cherry picked from commit 3d4bebd8d9210fbb84f8fc75742e248071192b09)
 2021-12-17 23:05:55 +01:00
Treeston 4330b7c921 Entities/Unit: fix an unrelated check from doing nothing because somebody didn't understand how type-casting works 
(cherry picked from commit 0b722e23cf0cdbd7b9753ffe77b349930c34779e)
 2021-12-17 22:54:01 +01:00
Treeston 970a89a8c3 Entities/Unit: Add a missing underflow check to prevent really really low damage from underflowing when paired with flat damage modifiers. Closes #23655. 
(cherry picked from commit a8b1b9a3c6266d589afb378f07c505f79c75a6a4)
 2021-12-17 22:50:25 +01:00
Treeston 917d9b7621 Scripts/ICC: Prevent Professor Putricide from displaying weird behavior during the Rotface/Festergut encounters as a result of his boss boundary 
(cherry picked from commit 7fa990edc6cbae05e8b68da58313fd675ac5fa81)
 2021-12-17 22:46:06 +01:00
Treeston 6b1ca0ca12 Core/Combat: Properly unset engagement flag on death. 
(cherry picked from commit 9c603ea87f09c47d52f093ccc73ee75c15eff6f5)
 2021-12-17 22:45:55 +01:00
Treeston 0c4a2a33fd Core/Misc: Add even more RBAC/Language values I need for #23633. 
(cherry picked from commit 5378fc450061a8fe125429925c43b3de22aeaf2b)
 2021-12-17 22:42:02 +01:00