Commit Graph
15287 Commits
Author SHA1 Message Date
click 766475ea4f Core/Guild: Fix guildbank tab loading after recent changes (returned value of a COUNT() is always BIGINT) 2012-03-29 14:41:55 +02:00
Shauren 022143460a Core/DBLayer: Fixed some crashes caused by incorrect prepared statements usage
Closes #5934
2012-03-29 11:30:37 +02:00
Discover- e77f51df5d Merge pull request #5932 from GyxTom/master
Core/Game: Code style.
2012-03-28 22:50:22 -07:00
Gyx 360014856d Core/Game: Code style.
Signed-off-by: Gyx <[email protected]>
2012-03-29 13:42:04 +08:00
click b5fb1b5b64 Core: Fix a minor mistake from previous mistake and adjust some more field-types 2012-03-29 07:10:21 +02:00
click 0ce62a159d Core: Fix type-mismatch in GameEventMgr 2012-03-29 05:23:01 +02:00
click c65cabb33c Core: Fix some type-errors in the Petitionshandler. Fixes #5916.
Also fixes charterhandling for arenateams, mentioned in #5907.
2012-03-29 05:08:32 +02:00
click be947eed76 Core: Fix fieldtype-errors in Guild-code - should now allow loading guildtabs etc correctly 2012-03-29 04:45:10 +02:00
click 40c35b095c Core: Adjust fieldtype size for loading completed achievements 2012-03-29 04:09:02 +02:00
click 5e795a61e8 Core/Warden: Fix a startupcrash with warden enabled (another fieldtype-error) 2012-03-29 03:43:46 +02:00
Shocker a08cb234c0 Merge pull request #5918 from GyxTom/master
Core/Misc: Various cleanups
2012-03-28 18:00:42 -07:00
kaelima 72d3e856de Core/Grid: revert f9caf79b16 - led to some unexpected behavior. 2012-03-29 02:56:18 +02:00
click cf29214364 Core/AI: Fix some wannabe-invinceable typos here and there... 2012-03-29 00:47:56 +02:00
kandera d94608777c Core/Scripts: Fix invincibility hp level for smart scripts. 2012-03-28 19:21:40 -03:00
leak a14aa37585 Core/DBLayer: Fix value list from recent changes 2012-03-28 21:34:26 +02:00
leak 4bead55dcd SQL: Proper prefixing 2012-03-28 19:51:13 +02:00
leak 7309ee5621 SQL: Auth db data type cleanup logs, realmcharacters, realmlist, uptime / Storage engine switched to InnoDB Note:
As for the redundant `uptime`.`startstring` being removed, this page might be of interest how to generate time strings from unix timestamps
http://dev.mysql.com/doc/refman/5.1/en/date-and-time-functions.html#function_from-unixtime
2012-03-28 19:46:38 +02:00
click 6237ddac34 Partially revert a36a0a77ef.
Cleaning databases for old/deprecated and expired quests should never be a
developers choice specifically. This should be done by admins, not developers,
through the use of the already existing paramters found in the worldserver config :
CleanCharacterDB / PersistentCharacterCleanFlags

An adjustment to the respective questloader prepared statement has been done to
accomodate for the earlier change (by not loading such quests into memory at all).

Documentation for how this cleanup-procedures work already exists in the core :
doc/CharacterDBCleanup.txt.
2012-03-28 19:31:06 +02:00
Nay 007e9269fe Core/GameEventMgr: Fix a compile warning 2012-03-28 18:56:22 +02:00
leak a01e2a59cd SQL: Auth db data type cleanup account_access, account_banned, ip_banned / Storage engine switched to InnoDB 2012-03-28 16:48:49 +02:00
leak b21725ecac SQL: Auth db data type cleanup account / Storage engine switched to InnoDB 2012-03-28 16:39:59 +02:00
Kandera 6763c23777 Core/Spells: attempt to fix penance doing nothing on "friendly" non faction targets. should return invalid targets 2012-03-28 08:29:42 -04:00
Gyx 1544b208da Core/Game: Code style again.
Signed-off-by: Gyx <[email protected]>
2012-03-28 20:00:29 +08:00
Gyx 72cdcbfced Core/Game: Code style.
Signed-off-by: Gyx <[email protected]>
2012-03-28 19:11:50 +08:00
Machiavelli e95d614f52 Core/Misc: Prevent calling ACE_Task_Base::wait() on an invalid handle. WorldSocketMgr::Wait is already called in WorldRunnable post-service hook 2012-03-28 12:50:02 +02:00
Machiavelli cc0448a017 Core/Battleground/SOTA: Initialize uninitialized variables.
Fixes:

==8111== Conditional jump or move depends on uninitialised value(s)
==8111==    at 0x12B542C: BattlegroundSA::FillInitialWorldStates(WorldPacket&) (BattlegroundSA.cpp:421)
==8111==    by 0xF93CD9: Player::SendInitWorldStates(unsigned int, unsigned int) (Player.cpp:9664)'

And similar.
2012-03-28 13:17:45 +03:00
Machiavelli 91228d2711 Core/Player: Similarly initialize m_SeasonalQuestChanged
Fixes:

==8111== Conditional jump or move depends on uninitialised value(s)
==8111==    at 0xFB7C42: Player::_SaveSeasonalQuestStatus(Trinity::AutoPtr<Transaction, ACE_Thread_Mutex>&) (Player.cpp:19375)
==8111==    by 0xFB56BA: Player::SaveToDB(bool) (Player.cpp:18898)
2012-03-28 13:07:37 +03:00
Machiavelli c3db19b80b Core/Player: Initialize m_WeeklyQuestChanged
Fixes:

==8111== Conditional jump or move depends on uninitialised value(s)
==8111==    at 0xFB7AD2: Player::_SaveWeeklyQuestStatus(Trinity::AutoPtr<Transaction, ACE_Thread_Mutex>&) (Player.cpp:19352)
2012-03-28 13:06:02 +03:00
Gyx a20fa23ea6 Core/Script: Code style and remove unused core.
Signed-off-by: Gyx <[email protected]>
2012-03-28 15:15:48 +08:00
Gyx e050945c91 Core/Script: Code style and remove unused core.
Signed-off-by: Gyx <[email protected]>
2012-03-28 11:13:37 +08:00
click 63c4d2b96e Core/DB: Adjust AP-bonuses for Hunter Volley (thanks to Jildor) 2012-03-28 04:33:51 +02:00
kaelima 6613cbafa6 Core/Protocol:
- Correct the use of first byte in SMSG_NAME_QUERY_RESPONSE
- Send guid and name in SMSG_CHAR_RENAME for failing results too
2012-03-28 04:02:02 +02:00
kaelima 820f45c424 Core/Protocol:
- Correct and rename response message from creating/updating a ticket
- Prevent some trailing data in CMSG_GMTICKET_CREATE and add comment on stuff missing from its structure.
- Random cleanup
2012-03-28 03:59:03 +02:00
kaelima f9caf79b16 Core/Grid: Fix crashes when closing up to the edge of a map.
Closes #5085
2012-03-28 02:38:16 +02:00
Nay ff070bd17e Core/LFG: (Config) Enable DungeonFinder by default, it was proven to be stable and working.
It is still not perfect and that's why we are waiting for feedback (a.k.a guinea pigs)
2012-03-28 00:43:59 +01:00
Nay f44e6834df Core/DBLayer: Fix remaining errors in loading world tables and a couple of them in characters database
Also removed World::LoadIp2nation(), it was not doing anything.
Closes #5897
2012-03-28 00:38:24 +01:00
Shauren 76397cf931 Core/Grids: Removed unsafe substraction, fixes possible freezes 2012-03-28 01:26:45 +02:00
Shauren ae0511a2a4 Core/Spells: Fix DynamicObject AoE effects for invisible targets e.g Flare. Original patch by Elron
Closes #5898
2012-03-28 01:13:58 +02:00
Shocker b4f9cb6aa8 Core/Spells: Correct diminishing returns for Horror category 2012-03-28 01:30:12 +03:00
Shauren 697fda7d27 Core/Players: Fixed copy paste mistake 2012-03-28 00:03:11 +02:00
click ef3835655c Core. Fix a mishap in the ObjectMgr after the recent changes 2012-03-27 23:12:01 +02:00
Nay 729f419af1 Core/DBLayer: Correct few more wrong read types (No. 4)
DB/World: Some consistency in the ints "length" field (not really a length)

All world dbs checked
2012-03-27 21:36:16 +01:00
Nay 8e87fe2744 Typo 2012-03-27 19:29:54 +01:00
Nay ead019b061 Core/DBLayer: Correct few more wrong read types (No. 3)
DB/World: Some consistency in the ints "length" field (not really a length)

From A to G world tables verified; missing all the others
2012-03-27 19:26:58 +01:00
kandera def4643896 Core/Spells: correctly fix the issue with dispel over time auras. thx shauren 2012-03-27 14:46:19 -03:00
Shauren 38deaa5dba Core/Players: Fixed saving glyphs to database
Closes #5909
2012-03-27 19:00:41 +02:00
Nay e40eb4bfbc Core/DBLayer: Correct few more wrong read types (No. 2)
DB/World: Some consistency in the ints "length" field (not really a length)

From A to G world tables verified; missing all the others
2012-03-27 15:47:40 +01:00
click 13757731b7 Merge pull request #5811 from Elron103/pull-requests3
Core/Units: Fix issues with threat management on phase changes
This is the cleaner version of the two suggested on pull-requests, and handles the threatlist correctly as well.
2012-03-27 07:08:03 -07:00
Kandera 0550f1dc05 Core/Spells: fix the issue with dispel auras. (thx warpten) closes #5902 2012-03-27 08:42:54 -04:00
Machiavelli 79a782f143 Core/Misc: Make World::m_stopEvent thread-safe. Note that the 'virtual' keyword in C/C++ is pretty useless for multithreading 2012-03-27 13:19:27 +02:00