Commit Graph
50 Commits
Author SHA1 Message Date
QAston c8adcc95f9 Core/Unit: Move spell specific code from Unit::CalcAbsorbResist to AuraScripts. 2010-12-30 02:03:46 +01:00
QAston ef968f4b15 Core/Unit: Big cleanup in Unit::CalcAbsorbResist
Core/AuraScript:
	Fix compile time check for AuraScript functions
	Remove AuraApplication from hook functions parameter list, use GetTarget() and GetTargetApplication() instead
	Add OnEffectAbsorb hook
Scripts: move handlers of Spell Deflection, Savage Defense, Primal Tenacity, Nerves of Steel, Astral shift from core to scripts.

--HG--
branch : trunk
2010-12-27 20:14:54 +01:00
QAston f4e46db38a Core/Auras: Add some asserions to hunt down reason of a crash in Aura::UpdateTargetMap. Thanks to Shauren for inspiration.
--HG--
branch : trunk
2010-12-26 00:14:13 +01:00
Shauren 928443d899 Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
--HG--
branch : trunk
2010-12-23 23:25:44 +01:00
Shauren 0f3b9019a8 Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
--HG--
branch : trunk
2010-12-22 21:25:23 +01:00
Shauren 5809c1fa3b Core/Auras: Fixed auras incorrectly stacking with different item casters introduced in r19f21916a940
Closes issue #5218.

--HG--
branch : trunk
2010-12-21 11:40:20 +01:00
Shauren 756ee5832b Core/Auras: Allow stacking of auras proced from different items
Closes issue #2296.

--HG--
branch : trunk
2010-12-20 11:04:48 +01:00
QAston 251f7f2121 Core/Auras: Add some assertions to make sure that AuraEffects are not added twice to UnitAuraEffect containers.
--HG--
branch : trunk
2010-12-19 19:43:53 +01:00
linencloth 59da698189 Core: Rename spell attributes, use more general names
--HG--
branch : trunk
2010-12-19 05:15:47 +01:00
Shauren 7196b880d6 Core/Spells: Fixed possible crashes in Shadow's Fate proc (71169) introduced in r91073dc6ace3
Core/AuctionHouse: Removed "using namespace std" and fixed crash in AuctionHouseMgr destructor

Closes issue #5132.
Closes issue #5134.

--HG--
branch : trunk
2010-12-18 23:16:55 +01:00
Shauren 82f45966fc Core/Unit: Renamed addUnitState/hasUnitState/clearUnitState to AddUnitState/HasUnitState/ClearUnitState
Core/Vehicles: Allow the vehicle to always damage the passenger (removed unneded dbc hacks from scripts)

--HG--
branch : trunk
2010-12-17 13:43:24 +01:00
azazel d2d62eab50 Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
NOTE: Initially I just wanted to fix some warnings, but noticed that there is no common method for percentage calculation and various formulas are used many time in the code making it difficult to read and understand what the code actually does. So, I introduced several template methods for calculating percent values and adding those values to the original base. I replaced all the raw calculations throughout the code where found, but I could have missed something or could have made a mistake. So, please report any strange behaviour after this commit.
If you ask me why I did it: for the sake of consistency and exact understanding what code means. If you see CalculatePct method, you clearly understand, that it find the value of x percent of y. And you can easily express, for example, spell behviour "reduces smth by x%" by the means of a method instead of recalling school maths.

--HG--
branch : trunk
2010-12-11 20:37:38 +06:00
Xanadu 48cb3c1552 Core/Spells: Remove Vanish on Stealth removal. Fix by thenecromancer.
--HG--
branch : trunk
2010-11-13 07:14:56 +01:00
Shauren 09260ee6c1 Scripts/Forge of Souls: Revisited Bronjahm script, removed ugly hacks and fixed spells properly
--HG--
branch : trunk
2010-10-18 13:19:04 +02:00
click f0c4241ea4 Remove the accidental additions of CRLF-crap from the header updates
--HG--
branch : trunk
2010-10-07 15:35:36 +02:00
click 8ea4b32fab Update copyright headers (following the same standard in all files = good)
--HG--
branch : trunk
2010-10-07 12:41:56 +02:00
QAston caaa77deb2 Core/ScriptSystem:
Add basic code for runtime checks of function calls in AuraScripts
 Make AuraScript::PreventDefaultAction() do not take parameters and add description for the function
 Remove PreventDefaultEffect() from aura script, use PreventDefaultAction() instead
 Unload aura scripts memory on aura delete

--HG--
branch : trunk
2010-10-04 17:44:49 +02:00
Xanadu 781592d63a Core/Spells: * Removed special handling of SPELL_AURA_ABILITY_IGNORE_AURASTATE, now handled by the proc system (again).
* Fixed Fingers of Frost buff display. Closes issue #3324.

--HG--
branch : trunk
2010-09-27 20:30:47 +02:00
azazel 5fa14f58dc Core/Cleanup:
* move repeating code into separate method for storing locale strings in ObjectMgr (copy/paste sucks, you know)
* fix 'signed/unsigned' warnings (at least in VS)
* fix some other warnings and cleanup relative code

--HG--
branch : trunk
2010-08-26 15:54:56 +06:00
azazel 341e6303ef Core:
* add helping methods for manipulating unit's health and use it where applicable
* fix some conversion warnings and cleanup code (formatting, CRLF, tabs to spaces)

--HG--
branch : trunk
2010-08-26 01:20:57 +06:00
Shocker 4da71ac657 * Fix a crash in Culling of Stratholme
* Typo fix from previous rev

--HG--
branch : trunk
2010-08-25 03:53:43 +03:00
Shocker d3c6edeb4a Correct usage of basePoints in various locations
--HG--
branch : trunk
2010-08-25 03:21:22 +03:00
QAston 07a3a1254b *Add AuraScript class for scripting aura objects - scripts are registered same way as SpellScripts, bound to SpellScriptNames table. For more details see example_spell.cpp and SpellScript.h
*Rename SpellHandlerScript to SpellScriptLoader, EffectHandlerFn to SpellEffectFn, HitHandlerFn to SpellHitFn, SpellScript::EffectHandlers to SpellScript::OnEffect, these changes were neccesary to prevent namespace collisions, happily you can solve these by simple find and replace
*Make spells 66244 and 5581 example scripts.

--HG--
branch : trunk
2010-08-24 00:10:49 +02:00
John Holiver ad5c8cadf1 Fixes Mage T10 bonus. Thanks to Dr.Tenma. Close issue #3423
--HG--
branch : trunk
2010-08-23 13:26:25 -03:00
silinoron 5cbae843d5 Core/Game: fix all warnings related to converting doubles and floats.
--HG--
branch : trunk
2010-08-22 12:39:39 -07:00
Spp c3343638cb Core: Remove lots warnings:
- All "'xxx' will be initialized after 'yyy' when initialized here"
- Some "unused variable"
- Some "enumeration value 'xxx' not handled in switch"

--HG--
branch : trunk
2010-08-21 20:08:47 +02:00
click 1f80c7b3c0 Sourcefile sleanups -> tabs to spaces, remove whitespace - also update the cleanupscripts very slightly
--HG--
branch : trunk
2010-08-08 19:45:53 +02:00
XTZGZoReX 9083271a2f * Some singleton renames for consistency:
accmgr -> AccountMgr
objmgr -> ObjectMgr
auctionmgr -> sAuctionMgr
spellmgr -> sSpellMgr
CreatureEAI_Mgr -> sEventAIMgr
achievementmgr -> sAchievementMgr
gameeventmgr -> sGameEventMgr
sInstanceSaveManager -> sInstanceSaveMgr
poolhandler -> sPoolMgr

--HG--
branch : trunk
2010-08-08 05:25:45 +02:00
QAston bc8c74475e *Fix a crash in Aura::UnregisterSingleTarget.
--HG--
branch : trunk
2010-08-04 20:03:33 +02:00
QAston c5a9d3b463 *Add m_duringRemoveFromWorld lock to prevent adding single target auras during or after remove from world process.
--HG--
branch : trunk
2010-08-03 06:11:03 +02:00
QAston 18dd177308 *Search for aura caster in our out of world in Aura::UnregisterSingleTarget().
--HG--
branch : trunk
2010-08-02 18:05:07 +02:00
Xanadu cf4d89990e Don't save Call Stabled Pet aura on player save, since it is impossible to open the stable dialog when player is loaded.
--HG--
branch : trunk
2010-07-31 03:23:14 +02:00
QAston 48b360097c *use ASSERT macro instead of regular assert for better output.
--HG--
branch : trunk
2010-07-30 20:04:28 +02:00
QAston d666ba26c1 *Thread safe player searcher in scripts.
--HG--
branch : trunk
2010-07-30 15:51:07 +02:00
thenecromancer a71d11149f Make passive auras always visible when they've got some area effect.
--HG--
branch : trunk
2010-07-21 01:22:52 +02:00
QAston 974e120235 *Remove no longer needed check in Arcane Potency script - by A.Metaphysical.Drama.
--HG--
branch : trunk
2010-07-16 18:05:25 +02:00
QAston d59cc55351 *Typofix
--HG--
branch : trunk
2010-07-14 17:09:30 +02:00
QAston a43ec3f158 *Add SpellMgr::CalculateSpellEffectAmount function for consistency of effect amount calculations in core
*Remove SpellEntry::CalculateSimpleValue function and use the new cuntion instead
*Remove some workarounds made because of incorrect effect amount calculations
*Since now aura effect amount problems should be gone.

--HG--
branch : trunk
2010-07-14 16:57:13 +02:00
QAston c783cacbe6 *Remove unsafe call of Aura::CheckTarget() which was causing aura list corruption on some units.
*Change the function name to Aura::CheckAreaTarget()
*Move some functions in SpellAuras.cpp to match order from SpellAuras.h

--HG--
branch : trunk
2010-07-13 21:41:21 +02:00
click 673c652ba6 change "IN_MILISECONDS" to proper english "IN_MILLISECONDS"
--HG--
branch : trunk
2010-07-12 00:30:17 +02:00
Shauren 2484df3918 Revert revision 4b8a7a570412 until properly fixed, caused auras to get stuck at client sometimes
--HG--
branch : trunk
2010-07-07 09:42:18 +02:00
Shauren 9ba91d50d0 Fixed sending aura remove packet at stack modification
--HG--
branch : trunk
2010-07-06 13:22:24 +02:00
click c834a45ba5 Initialize m_flags after m_isNeedManyNegativeEffects, as m_isNeedManyNegativeEffects is used in _CheckPositive()
Thanks to ge0rg and his valgrind-running

--HG--
branch : trunk
2010-07-04 16:57:26 +02:00
Machiavelli 95ddfbd9e2 Remove some redundant explicit NULL checks for pointers before ´delete´ or ´delete[]´ calls since this check is done implicitly when deleting.
Also fixes a memory leak in .reload creature_template command

--HG--
branch : trunk
2010-06-21 23:20:58 +02:00
Tartalo 1c42795081 Backed out changeset 444ae3a9769f
Going to use a spell_linked_spell based better approach

--HG--
branch : trunk
2010-06-20 11:44:18 +02:00
Tartalo 77565846c6 Fix Spell 20066 (Paladin, Repeteance), by maxdestroyer
Now removes Righteous Vengeance

--HG--
branch : trunk
2010-06-20 06:05:16 +02:00
Tartalo fb7dc51826 Fix spells 50811 & 61547 (Krystallus shatter), by microbius51
--HG--
branch : trunk
2010-06-19 23:51:33 +02:00
Machiavelli 7120513afe Fix logic.
--HG--
branch : trunk
2010-06-07 20:12:14 +02:00
Machiavelli f260a4d4ad Attempt to trace down a crash issue related to Aura::__UnapplyForTarget
--HG--
branch : trunk
2010-06-07 09:06:17 +02:00
Rat 75b80d9f5b rearranged core files
--HG--
branch : trunk
2010-06-05 23:40:08 +02:00