Commit Graph
518 Commits
Author SHA1 Message Date
Shauren c94046b065 Make typecasting methods *really* safe and get rid of redundant typeId/Typemask checks, thanks Zor and Machiavelli for help
--HG--
branch : trunk
2010-08-05 17:01:25 +02:00
azazel 885fc368fd * Implement item limit category (based on changes by VladimirMangos)
* Additional check for HandleAutoBankItemOpcode (thanks to VladimitMangos)
* Properly show empty vendor list for empty item list (author: a1ien)
* More stricted checks for store operations (thanks to VladimirMangos)
* Prevent autostoring of not empty bags (thanks to L1ghtGu4rd)

Changes need testing. Please post bugs on our tracker.

--HG--
branch : trunk
2010-08-05 22:08:07 +06:00
Shauren a042b972ed Fixed pet talents amount exploit
Closes issue #3273.

--HG--
branch : trunk
2010-08-05 11:33:54 +02:00
QAston 96eb7c513f *Some more research about spell target flags - thanks to Zor for info.
--HG--
branch : trunk
2010-08-04 19:16:44 +02:00
azazel 40e16bbbdb Add gender field to SMSG_WHO packet (author: MaS0n)
Fix compile error

--HG--
branch : trunk
2010-08-04 22:12:43 +06:00
Shauren 362ae2d4c6 Fixed pet talents: Guard Dog and Silverback
Removed pre-3.3.0 code for Improved Cower

Closes issue #3198.

--HG--
branch : trunk
2010-08-04 17:49:23 +02:00
QAston 6353e7dd8c *Update movement enums - thanks to Zor for info.
*Add functions for position data streaming.

--HG--
branch : trunk
2010-08-04 14:39:45 +02:00
Shauren 850868c8a3 Fixed issues with taking items from mail
Closes issue #3263.

--HG--
branch : trunk
2010-08-04 14:31:47 +02:00
Shauren 1058d7b37d Fixed timer displaying for timed quests
--HG--
branch : trunk
2010-08-04 13:17:33 +02:00
Shauren b7d34dcb53 Cleaned up item flags: separated item proto flags and item field flags
Implemented use of:
ITEM_PROTO_FLAG_PROSPECTABLE and ITEM_PROTO_FLAG_MILLABLE now checked instead of bag family mask
ITEM_PROTO_FLAG_SMART_LOOT for profession recipes, player has to have skillline and not know the recipe
ITEM_PROTO_FLAG_OPENABLE item has to have it set to use item_loot_template
ITEM_PROTO_FLAG_NOT_USEABLE_IN_ARENA if this is set item can never be used in arena
ITEM_FLAG_UNLOCKED marks unlocked items

Simplified BoA check for mail sending
Stackable items are no longer refundable
Removed useless code that always set ITEM_FIELD_FLAGS equal to proto flags
Unlocking items (lockpicking) is now blizzlike

--HG--
branch : trunk
2010-08-04 10:34:30 +02:00
QAston 846aa12260 *Fix crashy implementation of aura type 305.
--HG--
branch : trunk
2010-08-04 08:21:58 +02:00
Shauren 682ebafdc0 Removed useless code setting gameobject flag locked with each use of gameobject type 22
--HG--
branch : trunk
2010-08-03 17:00:02 +02:00
QAston e7ee828fe1 *Update spell_bonus_data for Garrote - by svetilo12.
*Fix build.

--HG--
branch : trunk
2010-08-03 06:36:25 +02:00
QAston 12c339f421 *Add missing Bestial wrath and The Beast Withing immunities after client change. Original patch by Visagalis.
*Little typo from prev rev.

--HG--
branch : trunk
2010-08-03 06:16:59 +02:00
QAston c5a9d3b463 *Add m_duringRemoveFromWorld lock to prevent adding single target auras during or after remove from world process.
--HG--
branch : trunk
2010-08-03 06:11:03 +02:00
silinoron 14827321bf Add support for CreatureAI::DamageDealt used in a Zul'Aman script. Thanks joshwhedon.
--HG--
branch : trunk
2010-08-02 14:18:30 -07:00
Shauren 46c1a4640d Groups are now stored by low guid in map
Creatures and gameobjects also store looting group by low guid instead of full guid

--HG--
branch : trunk
2010-08-02 17:28:47 +02:00
QAston 2212eb604d *Add helpers for checking auras present on unit by type and spell affect mask
*Add linked SPELL_AURA_PERIODIC_HASTE to shadowform spell - by dr.tenma

--HG--
branch : trunk
2010-08-01 01:22:13 +02:00
QAston 73b481073d *Fix talent Will of the NEcropolis
*Backout unintentional change from ra299f0b248.

--HG--
branch : trunk
2010-07-31 23:39:03 +02:00
thenecromancer 270367abfc Prevent players from gaining rest state in hostile capital zones.
Fix a bug where PvP status never resets when not moving to another zone.
Reset PvP status at Taxi node end/worldport when moving into friendly territory.

--HG--
branch : trunk
2010-07-31 13:55:23 +02:00
thenecromancer bdf20fa420 Fix exploit with Shiv giving 100% chance to apply any enchant on offhand items
--HG--
branch : trunk
2010-07-31 13:49:13 +02:00
thenecromancer 99efabdbd3 Remove crude check in proc system preventing charges drop in proc system for absorbs.
To preserve effect, code must be placed for charge handler to skip procs with 0 damage.
This code is preventing procs that should happen (like Savage Defense, or CCs)

--HG--
branch : trunk
2010-07-31 13:45:00 +02:00
thenecromancer 06caa4a945 Typo in some function usage
--HG--
branch : trunk
2010-07-31 13:40:32 +02:00
silinoron 71b1c781e3 Add basic support for NPCs on transports; DB data required.
Currently no support for combat while the transport is in motion.
Based on a patch by Socolin.
Fixes issue #168

--HG--
branch : trunk
2010-07-30 21:54:46 -07:00
click c298bdb662 Remove duplicate "Error:" from some outError messages...
--HG--
branch : trunk
2010-07-31 03:12:51 +02:00
QAston e5881d9590 *Cleanup in single target auras (thanks to JuliuSZS some useable debug info)
*Add ToInstanceMap() and ToMapInstanced() typecast functions and CAST_INST macro to use in scripts.

--HG--
branch : trunk
2010-07-31 01:41:32 +02:00
QAston 48b360097c *use ASSERT macro instead of regular assert for better output.
--HG--
branch : trunk
2010-07-30 20:04:28 +02:00
Shauren 3dc29732b7 Fixed a very silly mistake at item loading
--HG--
branch : trunk
2010-07-30 17:54:01 +02:00
Shauren ab95e5a6dc Fixed remaining bank/bag issues added in r9090
Added temporary hack to item creation to prevent new items from bugging (heroic+sockets issue), this will be removed after my work on item flags is done

--HG--
branch : trunk
2010-07-30 17:36:28 +02:00
Shauren 350864de80 Fixed saving new items to database, thx GMKretol for spotting the typo
--HG--
branch : trunk
2010-07-30 16:01:43 +02:00
QAston d666ba26c1 *Thread safe player searcher in scripts.
--HG--
branch : trunk
2010-07-30 15:51:07 +02:00
Shauren 9bda35c7df Killed the last blob field (corpse)
--HG--
branch : trunk
2010-07-30 15:15:07 +02:00
Shauren 77fc91bde8 Deleted data blob in item_instance
Fixed issues with displaying sockets/enchants/durability on heroic items

--HG--
branch : trunk
2010-07-30 13:15:31 +02:00
Xanadu 3565bbccf3 Fixed NPCs not offering quests with warlock or druid in SkillOrClassMask to these classes.
--HG--
branch : trunk
2010-07-30 06:22:55 +02:00
QAston 272e954a70 *Lock on RemoveAllAuras till all auras and applications are removed with all linked events they may cause.
*Add assertion after error log, just in case you've missed it.

--HG--
branch : trunk
2010-07-30 03:07:34 +02:00
Shauren ade1bbdd62 Remade access_requirement table, now each difficulty mode for each instance has its own entry (for future Dungeon Finder development)
Added completed achievement as new requirement type
Removed obsolete access_id from areatrigger_teleport table
Implemented automatic downscaling of raid difficulty when requested mode does not exist
Changed dungeon_difficulty in characters table to instance_mode_mask saving both dungeon and raid difficulty in form (dungeon diff | raid diff << 4)

--HG--
branch : trunk
2010-07-29 18:11:41 +02:00
click 140bc313d2 branchmerge - urgh!
--HG--
branch : trunk
2010-07-28 19:40:37 +02:00
click c595eb8ae9 First part of petAI logic cleanup : Hunter PetAI change: Ignore attacking CC'ed targets unless explicitly asked for by player
(thanks to QAston, Shauren, Liberate for the discussions and codehelp to sort this out properly)

--HG--
branch : trunk
2010-07-28 19:39:56 +02:00
Liberate f5e3943e54 Makes Auto-accepted quests show up the way they should. They should work perfectly again now.
--HG--
branch : trunk
2010-07-28 13:47:32 +02:00
QAston 86576de982 *Remove assert from opcode handler - to prevent remote crashing the server.
--HG--
branch : trunk
2010-07-28 01:39:37 +02:00
Liberate 4476247f10 Makes mechanicals immune to heals other than those specifically targeting mechanicals. had to bribe quite some Gnomes and Goblins to make this happen.
--HG--
branch : trunk
2010-07-28 01:26:18 +02:00
QAston e232c0e235 *Cleanup in ObjectAccessor - this should fix some crashes
--HG--
branch : trunk
2010-07-28 00:08:21 +02:00
click e5b7f6ad01 Add option for search distance to getHeight() functions and make Creature::FallGround() use VMaps properly. (Fix by Lynx3d)
This finally prevents flying creatures from falling to infinity (basically instantly diappearing) in several instances, aswell
as prevent creatures from falling inside larger solid object around the world.

--HG--
branch : trunk
2010-07-27 17:29:33 +02:00
QAston dd8d6701b8 *Implement RepRewardRate for spells.
--HG--
branch : trunk
2010-07-27 02:25:22 +02:00
Brian 4565242e94 * Implement reputation reward rate for quest / creatures
* Need DB data for this to work
* Original patch by NoFantasy

--HG--
branch : trunk
2010-07-26 16:21:10 -06:00
QAston 8e7f30eb61 *Add debug log to trac reason of a crash in Spell::DoAllEffectOnTarget.
--HG--
branch : trunk
2010-07-26 22:57:25 +02:00
Shauren 4fb256254c Fixed bug in Player::Satisfy that allowed to sometimes bypass instance requirements
Fixed DisableMgr incorrectly blocking entry into maps when only one mode was disabled

--HG--
branch : trunk
2010-07-26 22:25:03 +02:00
QAston 31820f0340 *Typofix - forgotten assigment in 00dc724412 - fixes weapon usage.
--HG--
branch : trunk
2010-07-26 19:54:32 +02:00
QAston fc4087cd98 *Resurrection sickness and similar debuffs are no longer dispelable.
--HG--
branch : trunk
2010-07-26 19:27:28 +02:00
QAston 7b87ab4de7 *Add more Player::CanUseAttackType checks in places where item bonuses are applied.
--HG--
branch : trunk
2010-07-26 16:08:55 +02:00