Commit Graph
1212 Commits
Author SHA1 Message Date
Machiavelli bc96df1aae Core/Shared: Move container functions to shared project under Trinity::Container namespace. Also implement RandomResizeList which takes a predicate function as parameter.
Core/ScriptedAI: Extend SummonList::DoAction to take a predicate function as parameter and allow specifying a maximum number of units to be selected.
2012-04-08 17:40:05 +02:00
Machiavelli e636531da3 Core/Movement: Fix pushback issues and client freeze. 2012-04-08 17:03:44 +02:00
Subv f8e9dedbe5 Scripts/Spells: Removed redundant code for spell 54798.
Closes #519

Signed-off-by: Subv <[email protected]>
2012-04-07 21:09:04 -05:00
Subv fd9c4d9c43 Core/Spells: Health leech spells should still do damage even if the caster is dead (Devouring Plague)
Closes #470

Signed-off-by: Subv <[email protected]>
2012-04-07 20:34:21 -05:00
Subv 7ce33ca0a6 Core/Spells: Fixes the rune cooldown when a hit mises the target
Closes #412

Signed-off-by: Subv <[email protected]>
2012-04-07 16:36:43 -05:00
Shocker 1fccaae4b0 Merge pull request #6070 from MrSmite/PetAI_3.1
Core/Pets: Improve PetAI

Closes #6048
Closes #6070
2012-04-06 18:42:37 -07:00
Shauren 33d5e7c753 Scripts/Icecrown Citadel: Fixed Ice Bomb visual synchronization
Closes #5179
2012-04-07 01:06:56 +02:00
Nay 2560642f07 Merge pull request #6072 from Vincent-Michael/elixir
Core/Spell: Fix Elixir of Minor Fortitude
Closes #1135
2012-04-06 11:53:38 -07:00
Nay a074497880 Core&DB/Spells: Fix Warr T8 4p bonus
- Added missing spell to DB
- Corrected DBC data that is, very likely, wrong
Closes #2386
2012-04-06 19:33:32 +01:00
Vincent-Core d1f8dff47a Core/Spell: Fix Elixir of Minor Fortitude 2012-04-06 20:25:36 +02:00
Nay d546a531c3 Core&DB/Spells: Fix DK T8 4p bonus
- Added missing spell to DB
- Corrected DBC data that is, very likely, wrong
Closes #6062
2012-04-06 18:49:40 +01:00
MrSmite cc03f2db36 Fix coding style 2012-04-06 12:33:34 -04:00
MrSmite b843688fa8 PeAI update
* Better handle target selection for defensive pets. Adds triggers for when owner is damaged or begins attacking something.

* Defensive pets no longer run off as soon as a mob aggros the owner but rather at first damage to owner or owner first attack

* Pets on stay will continue to attack unless target unreachable
2012-04-06 12:26:45 -04:00
Jildor 74565045f2 Core/Spells: Fix Rabbit Costume and Noblegarden Bunny 2012-04-06 11:48:29 +02:00
Liberate 926f02f792 Core/Spells: Implement SPELL_ATTR4_PROC_ONLY_ON_CASTER properly. Closes #5204 2012-04-05 20:09:20 +02:00
Subv 24b699d904 Core/Spells: Fixed Dancing Rune Weapon double-applying the duration bonus of the glyph
Closes #6032

Signed-off-by: Subv <[email protected]>
2012-04-05 08:32:58 -05:00
Subv 5468e8eeb5 Core/Spells: The first target of a chained spell should be explicit.
Closes #5643
2012-04-04 17:06:50 -05:00
Gyx 360014856d Core/Game: Code style.
Signed-off-by: Gyx <[email protected]>
2012-03-29 13:42:04 +08:00
Gyx 1544b208da Core/Game: Code style again.
Signed-off-by: Gyx <[email protected]>
2012-03-28 20:00:29 +08:00
Gyx 72cdcbfced Core/Game: Code style.
Signed-off-by: Gyx <[email protected]>
2012-03-28 19:11:50 +08:00
kaelima 820f45c424 Core/Protocol:
- Correct and rename response message from creating/updating a ticket
- Prevent some trailing data in CMSG_GMTICKET_CREATE and add comment on stuff missing from its structure.
- Random cleanup
2012-03-28 03:59:03 +02:00
Shocker b4f9cb6aa8 Core/Spells: Correct diminishing returns for Horror category 2012-03-28 01:30:12 +03:00
Nay 729f419af1 Core/DBLayer: Correct few more wrong read types (No. 4)
DB/World: Some consistency in the ints "length" field (not really a length)

All world dbs checked
2012-03-27 21:36:16 +01:00
kandera def4643896 Core/Spells: correctly fix the issue with dispel over time auras. thx shauren 2012-03-27 14:46:19 -03:00
Kandera 0550f1dc05 Core/Spells: fix the issue with dispel auras. (thx warpten) closes #5902 2012-03-27 08:42:54 -04:00
Nay 8f365de4b2 Core/DBLayer: Fix creature and spell_rank loading 2012-03-26 21:06:50 +01:00
Kandera 7b357a5028 Core/Spells: Fix Misdirection (thx to elron) closes #5869, #4343 2012-03-26 11:37:03 -04:00
kaelima c38bf4498a Fix compile and fix a possible crash for mob_kiljaeden_controller 2012-03-26 03:12:56 +02:00
Shocker fab1944ae4 Core/Spells: Don't remove summoned gameobjects for non-channeled spells when spell cast was canceled
Fixes issues like Demonic Circle: Summon removing the last summoned circle when the new cast was canceled
2012-03-26 03:03:32 +03:00
Shocker 4c16421cde Core/Spells: Fix periodic aura log for SPELL_AURA_PERIODIC_HEAL and SPELL_AURA_OBS_MOD_HEALTH when there is heal absorption 2012-03-24 20:21:17 +02:00
Shauren 25c13de8b3 Core/Auras: Corrected check relying on a not yet initialized variable 2012-03-24 13:43:28 +01:00
Shauren 568e524c45 Core/Spells: Implemented CREATURE_TYPEFLAGS_PARTY_MEMBER, creature with this type_flag set can be targeted by spells that require target to be in caster's party/raid 2012-03-19 20:44:30 +01:00
Machiavelli 41cc704bf8 Core/Movement:
- Don't abort relocation if movementflag restrictions were violated. There might be lag between client and server and even different parts of the core that made this approach improper.
- MOVEMENTFLAG_ROOT cannot be used in conjunction with MOVEMENTFLAG_MASK_MOVING, but it's a valid flag to receive from client.
- Fix falling to ground when unapplying fly/waterwalk aura. NOTE: This is a client-side initiated fall, in the future this should be initiated and updated by the server. (Working on it)
- Rename MOVEMENTFLAG_FALLING to MOVEMENTFLAG_FALLING_FAR
- Rename MOVEMENTFLAG_JUMPING to MOVEMENTFLAG_FALLING

Closes #5751
2012-03-17 20:36:12 +01:00
Shauren 01f3620d45 Core/Movement: Corrected movement info structure written in WriteMovementInfo 2012-03-17 18:01:56 +01:00
Gyx 1e94ab8d51 Core/Game: Code style and remove unused core.
Signed-off-by: Gyx <[email protected]>
2012-03-17 20:13:37 +08:00
Machiavelli cf5ed0a7b6 Core/Movement: Remove MOVEMENTFLAG_FLYING on fly aura unapply as well as _CAN_FLY 2012-03-16 23:41:43 +01:00
Kandera aad4e41ca5 Core/Spells: finish fixing dispel functionality. closes #5745 2012-03-16 17:59:10 -04:00
Machiavelli f8c04b1bc5 Core/Movement: Fix players still able to fly on SPELL_AURA_FLY and SPELL_AURA_MOD_INCREASE_MOUNTED_FLIGHT_SPEED unapply.
Closes #5731
2012-03-16 17:10:01 +01:00
Kandera bea8fcfbfa Core/Spells: fix shield slam giving nothing to dispel error. 2012-03-16 09:08:46 -04:00
kaelima ef53bde176 Core/Spell: Add some missing cast results which require additional data when sent. And rename two researched castflags (thanks TOMRUS) 2012-03-16 08:59:18 +01:00
Kandera b23ff228a4 Core/Spells: Used correct implementation for checking if a spell effect targets an area. 2012-03-15 14:14:42 -04:00
Kandera 5406a0fd93 Core/Spells: Fix bugged mass dispel after previous commits 2012-03-15 14:12:40 -04:00
Kandera fe46cf9796 Core/Spells: Fix being unable to use spells due hasDispellableAura being false if no spell effects were SPELL_EFFECT_DISPEL 2012-03-15 12:41:16 -04:00
Kandera 5e25791bff whitespace cleanup 2012-03-15 11:08:45 -04:00
Kandera 01bc6c483b Core/Spells: add correct checking for dispeling errors. Fixes spammable cleanse. 2012-03-15 10:56:56 -04:00
Shauren 84891377b5 Core/Spells: Fixed copy paste mistake that caused all area spells to search targets starting from caster's coordinates instead of targeted destination 2012-03-15 13:15:25 +01:00
Machiavelli afaed98b7a Core/Movement: Send correct packet to client when unapplying hover, feather fall and water walking auras.
Closes #5704
2012-03-15 10:03:25 +01:00
leak 2a5caef4a6 Revert "Core: more more cleanup" - Build test anyone?
This reverts commit 20cd4c71ee.
2012-03-14 18:51:51 +01:00
thomas33 20cd4c71ee Core: more more cleanup 2012-03-14 17:51:11 +01:00
Machiavelli 03a24a84e4 Core/Units:
- Implement UNIT_FIELD_HOVERHEIGHT (requires DB data). This field, sent in update object packet, will determine the height at which a creature hovers if it has movementflag_hover applied. Note that hovering will now update the server-sided z-coordinate by the value of this field, and that all subsequent positional updates to the client will need to send z coordinate MINUS the hover height offset, or the hoverheight will be visually doubled client side.
- Correct our usage of movementflag_flying, movementflag_can_fly, movementflag_hover and movementflag_disable_gravity (previously levitate), and how they relate to InhabitType in the database. This fixes "flying creatures on steroids" bug (wings flapping too fast), and potentially a lot of visual issues in AI scripts. Note that a lot of scripts still set wrong movementflags, these need to be fixed on a case by case basis.
- Send correct packets for SPELL_AURA_FEATHER_FALL, SPELL_AURA_WATER_WALK and SPELL_AURA_HOVER apply/unapply.
- Send correct packet contents for movement update in Unit::SetSpeed.
- Misc. cleanup in affected scripts.
2012-03-12 00:53:45 +01:00