josh/TCPlayerbotCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
34,872 Commits 1 Branch 0 Tags
60ff73eeba93c7f97abff0eeb504cb4b5ff8a6cd
Commit Graph
17644 Commits
Author SHA1 Message Date
ariel- 60ff73eeba Core/Spell: fix SendSpellMiss requiring caster Unit 
(cherry picked from commit 7f947646f9d51b53b5297bfdddbada09500c53d3)
 2021-09-05 22:48:28 +02:00
ariel- a2ea26816e Core/Spell: fix target checks 
- Aura will be applied at last moment possible (after damage) to prevent regressions on #18395
- Partial revert of 9b38a6352c0fe2499de54fd769aa1c721a410bda as it wasnt handling correctly checks without spells

Closes #21578
Closes #21579
Closes #21581

(cherry picked from commit d6b9f148a772d07b9353a0db95a6f05c9c848a63)
 2021-09-05 22:43:48 +02:00
sirikfoll 7c63a99bab Scripts/Spells: Quest King of the Mountain 
Added missing jump jets and battle standard visuals
Added allowed area conditions for the vehicle
Fixed Jumpbot's attack spell (thanks @keader for fixing the proc)

(cherry picked from commit e7e46b2a822cd0179b30ba5b0fa7c6fe7cea8774)
 2021-09-05 22:19:03 +02:00
Shauren f832a96c4e Warning fix 2021-09-05 16:30:13 +02:00
Shauren 7e09deea3a Scripts/Spells: Fixed mage ice block to not heal without aura 320913 2021-09-05 15:58:30 +02:00
ariel- c07b9188df Core/Spells: register and apply individual aura effects on hit handler 
- Remove area aura processing from spell system, they're fully handled by aura owner update now

Closes #21577

(cherry picked from commit 4ca9d6469da435cb818e3b56840669775627e050)
 2021-09-05 15:19:55 +02:00
ariel- 46537c6bcb Core/Spells: tweak 'neutral' spell positivity 
- Fixes Mind Control dummy self aura appearing as a debuff

(cherry picked from commit d46f36f7737e6c558c50e1d2a4eadb202ed666bb)
 2021-09-05 15:16:05 +02:00
ariel- 9fa95b4b57 Core/Spells: Fix periodic rolling adding bonuses twice 
Calculation is now done in CalculateAmount

(cherry picked from commit 93eda20d5cf6eeb34e1aee1b81469ba6e8fa7f0c)
 2021-09-04 22:52:31 +02:00
Shauren 8a4e1119ac Core/Spells: Unify spell effect access api in both branches 2021-09-04 15:13:15 +02:00
Shauren 9d7eee1a8c Core/Auras: Fixed cherry-pick mistakes in Unit::RemoveMovementImpairingAuras and Unit::HasAuraWithMechanic 2021-08-30 23:21:14 +02:00
Shauren 407e5aea1a Core/Spells: Remove leftover code from old mechanic - default spellpower scaling coefficients 2021-08-30 23:17:12 +02:00
Shauren 6031b95ea7 Core/Spells: Remove outdated damage calculations from Spell::EffectSchoolDMG and Spell::EffectWeaponDmg 2021-08-30 21:21:51 +02:00
Shauren 3af33b9ff9 Warning fixes 2021-08-28 20:24:21 +02:00
Shauren aebf308368 Core/Spells: Fixed Spell::EffectWeaponDmg for spells with multiple damage effects 
Closes #26717
 2021-08-28 19:53:53 +02:00
Shauren 3dd75a49b1 Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler 2021-08-28 19:51:29 +02:00
Shauren bc2c76a5b8 Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast 2021-08-28 18:30:45 +02:00
Shauren b9647bdecc Core/Reputation: Fixed FriendshipReputationFlags::NoRepGainModifiers implementation 2021-08-28 18:03:30 +02:00
Shauren 8cc418460f Core/Misc: Fix gcc warnings 2021-08-28 16:08:33 +02:00
ariel- 962f6d7988 Core/Spells: rework part 5: GameObject casting 
Closes #21330
Closes #18885
Ref #18752

(cherry picked from commit 45c5e1b9d63796d168339a44f63418f220cf2403)
 2021-08-28 15:59:11 +02:00
ariel- 65dca120d3 Core/Spells: rework part 4: iterate over effects first 
Ref #18395

Implement far spell queue processing
Closes #7395

(cherry picked from commit 080d2c6cd439acb2059adc4e24a279de98aa0db6)
 2021-08-28 15:59:11 +02:00
ariel- f3548d45d0 Core/Spells: rework part 3: spells only handle at most one UnitAura and one DynObjAura during its lifetime 
Closes #15088

(cherry picked from commit e8d5aa56cc48572d81e1898b7b4ff10cfa6d1957)
 2021-08-28 15:59:11 +02:00
ariel- 52ae3c89d1 Core/Spells: rework part 2: Split up target selection logic 
Target check only determines what kind of entities we can target, spell positivity determines if that entity is valid for attack/assist

Closes #8844

(cherry picked from commit 9b38a6352c0fe2499de54fd769aa1c721a410bda)
 2021-08-28 15:59:11 +02:00
ariel- 1e1415a491 Core/Spells: rework part 1: Improved positive detection logic 
(cherry picked from commit efeae33495c8b57ae04aeeb382ee85099ac0b600)
 2021-08-28 15:59:11 +02:00
Shauren a91edcb952 Core/Creatures: Remove hover on death 
(cherry picked from commit 241109327bf573460d488d707d7eb19f82f1350c)
 2021-08-24 13:45:34 +02:00
Shauren f8c03a9066 Core/Creatures: Reworked setting move types in database 
* Each move type has its own field instead of trying to combine everything in InhabitType
* Allow overriding movement separately for each spawn

(cherry picked from commit 592516ae69d89da3bcb0ede144644a3d2e0186e0)
 2021-08-24 13:43:06 +02:00
joschiwald c94c561b85 Scripts/Misc: Fixed hover movement for Stormcaller Brundir 
(cherry picked from commit e9aba10695cdf3520c6ae61815610051502b6f0b)
 2021-08-24 12:46:53 +02:00
Chaouki Dhib 246699a173 Scripts/Misc: Hover script fixes 
(cherry picked from commit 510bc0b7a0d4e8de60f69b922d03ad3a43c2a2cc)
 2021-08-24 12:46:02 +02:00
Shauren 2e2b298618 Core/Movement: Fixed creature hover 
Closes #15177

(cherry picked from commit 2baa81065ba27f0a6d278a8dd8a79b7c831e0a2b)
 2021-08-24 12:44:38 +02:00
Treeston 994121e671 Core/CreatureAI: CheckBoundary -> IsInBoundary, better reflects what it does. Also moved to public so spellscript can use it. 
(cherry picked from commit df639d85e4e82add71432ea0a4cba91f238a30ba)
 2021-08-23 23:28:48 +02:00
Gooyeth 90b81a212e Core/Player: Do not remove auras from Gamemasters in arenas (#21568) 
(cherry picked from commit 92b8a870bf423b439806ab39a8d5af0485e60ed8)
 2021-08-23 20:03:40 +02:00
ariel- 08f4f9b324 Core/Conditions: validate object types when conditioning implicit spell targets with CONDITION_OBJECT_ENTRY_GUID 
Closes #21569

(cherry picked from commit 34c3962b09dbb2b7a11e4ff0c08b2ab05ff63762)
 2021-08-23 20:02:44 +02:00
ariel- e8e501609f Core/Entities: ghouls start with full energy 
(cherry picked from commit 0c1e485e13d065b26e24b4226044246ae8ca0e4d)
 2021-08-23 19:29:41 +02:00
ariel- 9f0204b357 Scripts/Command: build fix for horrible outdated boost version used by travis 
(cherry picked from commit 68dde9f8c5467c5983078b190e58105f99dad75c)
 2021-08-23 19:18:49 +02:00
Jeremy 43b944bf92 Core/Maps: Fixed outdoors check (#21551) 
(cherry picked from commit 367db4e1d641b56d8d7df83320c14b283bd007ce)
 2021-08-22 21:09:18 +02:00
Meji bca465a569 Core/Achievements: Several criteria fixes (#26839) 2021-08-20 09:41:13 +02:00
ariel- 0ae1ebedfe Core/Spells: explicitly disable non proccing auras when generating default procs 
Closes #21529

(cherry picked from commit ad796318e8c34df177a935892f27c6a7b4f2f901)
 2021-08-18 23:22:46 +02:00
ariel- 95c8eae123 Core/Auras: remove too strict checks in area auras, since a few aren't owned by its caster 
Closes #21528

(cherry picked from commit 2d10429a2d788d6b3aead19bd91ed662bad38751)
 2021-08-18 23:06:33 +02:00
ariel- b0a05812d2 Core/Auras: fixed SPELL_AURA_MOD_HIT_CHANCE honoring stack rules in all cases 
Updates #21367

(cherry picked from commit 23808fe349e78118461c08ebe78c8892391be236)
 2021-08-18 22:59:50 +02:00
ariel- 6c642f33b5 Core/Auras: added sanity checks for area auras having a different owner unit than caster 
Closes #21517

(cherry picked from commit 54e841888621ce2ea6fbfde2f86842ec088cd575)
 2021-08-18 22:57:52 +02:00
Shauren 065794ed66 Core/PacketIO: Do not send hotfix Status::Valid when we don't have a hotfix blob for current locale 2021-08-17 20:02:43 +02:00
Shauren 2fe70e5fd6 Core/Misc: Fix cherry-pick errors 2021-08-16 22:24:34 +02:00
Shauren c0261468c5 Core/Quests: Fixed quests not working after relogging 
Closes #26823
 2021-08-16 16:33:43 +02:00
Jeremy 38aa015196 Core/Battlegrounds: Update BattlemasterListFlags (#26819) 2021-08-15 23:41:27 +02:00
Traesh fb6761c273 Core/Spells Implement targets 133, 134, 135 : TARGET_UNIT_LINE_CASTER_TO_DEST_*** (#26786) 2021-08-15 11:09:46 +02:00
Traesh 4725941567 Core/AreaTrigger Update box searching to handle oriented boxes (#26772) 2021-08-14 20:08:40 +02:00
Jeremy 20d70abb2c Core/Battlegrounds: Change Battleground* argument to BattlegroundQueueTypeId (#26806) 2021-08-14 19:56:30 +02:00
Shauren 03f09ea16a Core/Items: Implemented secondary shoulder transmog appearance 2021-08-11 22:32:14 +02:00
Chaouki Dhib 30cfe3741a Core/Movement: Correct distance checking 
Distance checking should always be in 3D, independently on if the mover has the ability to fly or not.

(cherry picked from commit 0fb133013c0c1c2c7f47c215435990822454d8f8)
 2021-08-08 21:21:34 +02:00
Treeston 4b93059ec7 Core/Creature: Temporarily let Creatures violate dynspawn assumptions for pooled creatures. This should fix startup crashes until I can investigate and find a long-term fix. Tag #21519. 
(cherry picked from commit 9fc6b13027d2d66a99b6bee49d3add23f2c0c8af)
 2021-08-08 21:21:34 +02:00
Treeston 8757a80767 Core/Creature: Add another aggressive compatibility mode assertion to catch faulty dynspawn code. 
(cherry picked from commit 3eab2d7efcc225696fe32f94687fd8e7b6755a2a)
 2021-08-08 21:21:34 +02:00