Commit Graph
36378 Commits
Author SHA1 Message Date
Killyana 55c3e1f9dd DB/Creature: Remove some wrong waypoint actions
(cherry picked from commit bb60122f2c0a67fbb7e1a7e31e1be9b5722ef6ee)
2021-12-10 21:36:41 +01:00
Killyana ad0bc1794f DB/Creature: Seer Nakha
(cherry picked from commit 9e167dd9cbe40a89f9df5b99eb6a543f1d3bebb3)
2021-12-10 21:18:17 +01:00
Killyana c5eebd9ebe DB/Creature: Or'kaos the Insane
Originally Toranaku was supposed to give a quest to kill Or'kaos upon a player reaching Exalted with Netherwing in order for him or her obtain a netherdrake mount; but the idea was replaced with : Lord Illidan Stormrage quest.
Currently serves no useful purpose, including lacks loot.

(cherry picked from commit 26e859051e865603acffde69d6d86054538468b2)
2021-12-10 21:17:25 +01:00
Wyrserth b6d28b5497 Script/GunDrak: fix order for yell and altar texts on death for two bosses (#23357)
(cherry picked from commit 65aea13c252b22003a41ff7f6fba7139b6681768)
2021-12-10 21:16:10 +01:00
Wyrserth 647893597c Script/Creature: implement spell effect for the item Prototype Neural Needler used on Imprisoned Beryl Sorcerer (#23349)
* Script/Creature: implement spell effect for the item Prototype Neural Needler used on Imprisoned Beryl Sorcerer.

* Rename 9999_99_99_99_world.sql to 2019_06_03_02_world.sql

(cherry picked from commit eb5d1d32485bc305e53d7a3229467050b02a1b0e)
2021-12-10 21:15:56 +01:00
Killyana 34b52c6d26 DB/Creature: Bash'ir Surveyor
(cherry picked from commit acd462d83f6b5c87ec4e441e8775571d1713dbe3)
2021-12-10 21:14:51 +01:00
Killyana c016a6a768 DB/Quests: Remove deprecated quests from Horde Warbringer
(cherry picked from commit 47add89a11b319ff9acab726a0587d2af56dd2d0)
2021-12-10 21:13:50 +01:00
Wyrserth b3e7be5387 Script/Creature: calculate Traveler's Tundra Mammoth's NPCs' exit position based on current player's position (#23344)
* Script/Creature: calculate Traveler's Tundra Mammoth's NPCs' exit position based on current player's position.

* Comment out unused argument.

(cherry picked from commit d71a0608bfa93b0733489fc138431ec0918220af)
2021-12-10 21:12:48 +01:00
Wyrserth d037c6b086 Core/SAI: add action_param3 to SMART_ACTION_REMOVEAURASFROMSPELL to allow it to remove only auras from spells that were cast by the entity itself. (#23345)
(cherry picked from commit d365dd915715d4608ae69fa54f094ab65f02e984)
2021-12-10 21:12:25 +01:00
illfated 84010d2372 DB/Quest: Old Whitebark's Pendant (8474) - spacing & words missing in RewardText
Closes #23339

(cherry picked from commit 345133d75ea72b5361835e25fd4b10a8ae4fe3da)
2021-12-10 21:10:11 +01:00
ZenoX92 803e677963 DB/Quest: A Mission of Mercy
Closes #23329

(cherry picked from commit f4e9b2901ccf1c7edfe49da91c9699edb9db1a72)
2021-12-10 21:08:24 +01:00
Killyana 5c549e5a5a DB/Quest: The Black Box
The quest is not repeatable

(cherry picked from commit d1c279ccda33b7245cb9a3d9661937debb25b64b)
2021-12-10 21:07:12 +01:00
Meji 0a8f79ad5a Core/BattlePets: Improvements when enabling battle pets (#27367) 2021-12-10 20:17:21 +01:00
Shauren 747da1f804 Core/Spells: Implemented SPELL_ATTR1_CAST_WHEN_LEARNED 2021-12-10 18:47:09 +01:00
Naddley c28ac3ce67 DB/Spawns: Added spawns on Exiles Reach/NPE ship for Horde
Closes #27354
2021-12-09 01:31:12 +01:00
jackpoz efbb6f5b7d Core/Map: Don't log errors about Area ID 0
Restore a check about Area ID 0 that would silently ignore this case instead of spamming log errors. Check removed in e79c595b695ea5f35b8324efbb7741ccb102bce9
Fix #23085

(cherry picked from commit bda351d7f1cb3ff663a9d231afa85864ea0f8078)
2021-12-09 00:32:48 +01:00
jackpoz 363f385fc0 Scripts/HallsOfLightning: Fix Volkhan spamming in chat when wiping at 10% health
Ref #23082

(cherry picked from commit 2d5387ea425fc4c31d664fcccad02c83a9f41aa0)
2021-12-09 00:32:32 +01:00
Ovah 0feebcdf5b Core/Groups: do not allow lfg groups to change the loot mode (#23336)
While the UI does not allow changing the loot mode you can still trigger the opcode by running interface scripts which we will now block as well so nobody can ninja-loot anymore.

(cherry picked from commit 49a9cbf20a483da006e45f2ff953583c75c689f0)
2021-12-09 00:32:17 +01:00
jackpoz b4652a38d3 Core/Misc: Headers cleanup
Use simple std::string concatenation instead of stringstream to avoid including <sstream> header.

(cherry picked from commit 9c790e231ef00c29a33b037ac2ae28d526474539)
2021-12-09 00:32:05 +01:00
Killyana a265e5bed1 DB/Creature: Forgus
(cherry picked from commit 33074b34c8bcdcb7005af12dc5bf21665e495f5b)
2021-12-09 00:28:47 +01:00
Killyana cfaeb72237 DB/Quest: Dark Iron Legacy
(cherry picked from commit a99f67c381915cbf4407e18244304d7624c63966)
2021-12-09 00:27:44 +01:00
Killyana b325f738d1 DB/Misc: Skorn - Howling Fjord
From https://github.com/cmangos/wotlk-db/commit/cce38b05fb3f70483217644f6596d297d77def22
By Grz3s
Closes #14839

(cherry picked from commit d823c6896eb35a6a81ccc2551d7ffb561ce3486b)
2021-12-09 00:27:04 +01:00
Giacomo Pozzoni 33347c7d5f Core/Misc: Fix static analysis issues
Fix static analysis issues reported by Coverity Scan

(cherry picked from commit e12398afdc0ffa878b31af1dbd98fb0c995cf020)
2021-12-09 00:24:41 +01:00
Nitair f6048aca9a Scripts/Stratholme: Baron Rivendare rewrite (#22572)
* Adding last state of rivendare rewrite

* Fix aura beeing removed on reset, fix death pact

* Not needed

* SQL: Changed remove/inset into update, fixed delete at conditions part

* Typo

* Remove link spell, fix blank lines, change magic numbers to enum

* Test changes with SpellScript and DoCastSelf

* Revert SpellScript and moved DoCastSelf for the aura into UpdateAI part

* Damn, copyright.

* Fix Unholy Aura

* Fix again (does attack now / does cast if encounter resets)

* Adding handling of the aura to the db

* Rename 2018_99_99_99_world_335.sql to 2019_05_31_02_world_335.sql

(cherry picked from commit ee5101fbf74b0fa924a8467ee766b39c1d06875b)
2021-12-09 00:24:26 +01:00
Killyana c77a4e6281 DB/Quest: Slain by the Wretched
Closes #23332

(cherry picked from commit d333cd0ccfdaaab822eae4a6f5cc0d47ce521875)
2021-12-09 00:16:04 +01:00
Killyana 200db638ee DB/Quest: Jack Likes His Drink
From https://github.com/azerothcore/azerothcore-wotlk/commit/b97e6f36c6ae21c9b0539e68086863a6e6e74892
By sluggor

(cherry picked from commit 5f1d9fc3047f0d11c6ef59d6d905b1b36c311d74)
2021-12-09 00:14:48 +01:00
Wyrserth 9d865f7536 Core/Misc: don't allow players to use/activate/loot non-allowed gameobjects while under the effect of a damage immunity aura (#23319)
* Core/Misc: don't allow players to use/activate/loot non-allowed gameobjects while under the effect of a damage immunity aura.

* Forgot to change this in last-second rename.

* Apply suggested changes, thanks Shauren!

(cherry picked from commit 8bc5451864570c07eff6d427846335044f85a509)
2021-12-09 00:13:59 +01:00
jackpoz 049606e31e Core/MovementGenerator: Add more details to asserts
Implement GetDebugInfo in MovementGenerator, PathMovementBase, FlightPathMovementGenerator, WaypointMovementGenerator.
Add an additional assert in FlightPathMovementGenerator::DoEventIfAny(), the input node must not be null

(cherry picked from commit 9da81239596bf798b1beafc5ddeaeb37dcc330ff)
2021-12-08 23:51:21 +01:00
Wyrserth 1edd93bc0c Core/Script: add script hook to allow overriding of a vehicle passenger's exit position (#23322)
* Core/Script: add script hook to allow overriding of a vehicle passenger's exit position.

* Allow to change orientation, and fix nopch.

* Keep original orientation, thanks jackpoz!

* Update Unit.cpp

Code cleanup

* Update Unit.cpp

(cherry picked from commit 88c6c61b95ac2b2f911b519136770479d31de27d)
2021-12-08 23:51:07 +01:00
jackpoz 2cade0e6e3 Core/Channel: Sanitize channel names
(cherry picked from commit 7b8f294c024230451f82ff67150e11fc31b61293)
2021-12-08 23:47:07 +01:00
jackpoz 97249ff7b4 Core/Channel: Fix CRT Debug Assert triggered with invalid channel names
(cherry picked from commit f0bd90cc35098475b20e736cf98885c99c04be3d)
2021-12-08 23:43:19 +01:00
Killyana 3796978a8f DB/Quest: The Wrath of Neptulon
(cherry picked from commit 22888f80e98dc7b96769ece590ea87166cef908e)
2021-12-08 23:40:56 +01:00
Killyana d036411cd7 DB/Creature: Scryer Cavalier
(cherry picked from commit d1e3de15d9e5648dc518e0aee09ef2bd7a5bd6f8)
2021-12-08 23:38:46 +01:00
Killyana 1ccb3fa847 DB/Creature: Add Grip immunity to Nightbane
(cherry picked from commit c946966275f1f7aab19bcfb80589cc9b6491f3df)
2021-12-08 23:37:57 +01:00
Killyana 438cedb711 DB/Creature: Lightsworn Elekk Rider
(cherry picked from commit f41761551459a247540979ef8f650842f9fd9410)
2021-12-08 23:37:26 +01:00
Giacomo Pozzoni 6e28ecd22e Core/Movement: Fix assertion triggered in SplineChainMovementGenerator
Fix an assertion triggered in SplineChainMovementGenerator happening when a new generator is added while last spline of the SplineChainMovementGenerator is being processed but is not finalized yet.
Fix #23077

(cherry picked from commit 5d7f0eef6e2f89d5dbeb0a702f7a35c95626240e)
2021-12-08 23:35:01 +01:00
Killyana f45befd607 DB/Creature: Black Temple Battle Sensor
(cherry picked from commit 1cc7944f725f0863eb76ef9bab1808fc8fccec17)
2021-12-08 23:34:50 +01:00
dr-j b0b9492e44 DB/Creature: Wolver Orphan & Oracle Orphan event in Dalaran
Closes #14621

(cherry picked from commit 64dabaad8007f632388f6147a24cacd453a365fc)
2021-12-08 23:34:02 +01:00
Killyana d45bc9b47b DB/Creature: Outland Children's Week Dark Portal Trigger
(cherry picked from commit 2717b72f3e18788f0e02e38a847801b4d04155f1)
2021-12-08 23:32:55 +01:00
Killyana 69d5093c66 DB/Creature: Ethereum Avenger
(cherry picked from commit c99193325bf403dee392c8d1048b3e4a7cbb7cea)
2021-12-08 23:32:02 +01:00
Killyana 2139c07aab DB/Creature: Arcane Burst
(cherry picked from commit 16bf11ab20fcd5e3984dd90d011d13f56288d1ea)
2021-12-08 23:31:02 +01:00
Killyana eab9d57108 DB/Creature: Eclipsion Hawkstrider
(cherry picked from commit e8b7cc6e1ccda1bb1d9561c94d4f74ca1effe410)
2021-12-08 23:30:29 +01:00
Killyana b16fa8f493 DB/Creature: Dragonmaw Nether Drake
(cherry picked from commit f024c0d2f7347ecd9c472caf0e6a263781084311)
2021-12-08 23:29:43 +01:00
Killyana 952d48bf46 DB/Creature: Enslaved Doomguard
(cherry picked from commit 4f6bf01a19e055fb3e158dedc47de8e98557bd1e)
2021-12-08 23:28:03 +01:00
Ovah 0d433b1bc8 Core/Players: out of range group updates will now get sent every 5 seconds instead of as soon as they are available to reflect retail behaivior. (#23323)
* according to sniffs the group update packet for out of range members has a fixed 5 seconds interval instead of spaming packets like crazy for example when updating positions. On 4.x and above this will fix a very nasty and ugly fps drop
* validated with 4.3.4 and 3.3.5 sniffs

(cherry picked from commit 635cefc67e25c4318d67bf557b66958081c02ac4)
2021-12-08 23:22:12 +01:00
lactoseti 6b2e40257a Creature/Script: npc_tallhorn_stag
Ref #2623

(cherry picked from commit bfffa5d45e9d07636930e89916986edf7c086c1e)
2021-12-08 23:20:51 +01:00
Killyana 2bf8ffd5d9 DB/Quest: Vyletongue Corruption
Ref #21078

(cherry picked from commit 6023d7e7e10b970033c322b6de902e9eae42561b)
2021-12-08 23:19:53 +01:00
Wyrserth 2344671af5 Core/Console: start CliRunnable thread after all log messages have been printed. (#23321)
(cherry picked from commit d8ce37e0c90a3da2d42a09d33523e4403aab2723)
2021-12-08 21:55:04 +01:00
Ovah 09fe78dd59 Core/GameObjects: goober gameobjects may reset only if they have a lock id or a reset time specified (#23298)
* Core/GameObjects: goober gameobjects may reset only if they have a lock id

Tests have shown that Goobers without a lock id (Data0=0) are not allowed to reset their go state such as the teleporters in Ulduar and Icecrown Citadel. The tests has been expanded by checking 4.x goobers as well and the perfect example that confirms that result is the Ancient Bell for Atramedes' intro which also is not suposed to reset after using it.

* Core/GameObjects: allow to reset goobers without a lock id if a reset time is defined

* fixed a typo

(cherry picked from commit a70845c93de0902c4c6fa55ff10293f7e3679ac5)
2021-12-08 21:54:41 +01:00
jackpoz e9aed3e442 Core/SmartAI: Improve SMART_EVENT_GOSSIP_HELLO
Add another value to event_param1 for SMART_EVENT_GOSSIP_HELLO to support all cases of OnGossipHello/OnReportUse in GameObjects:
- event_param1 set to 0: execute the action for both OnGossipHello and OnReportUse. This might result in the action being executed twice when clicking the GameObject
- event_param1 set to 1: execute the action for only OnGossipHello
- event_param1 set to 2: execute the action for only OnReportUse

(cherry picked from commit 9e58ef6940c78d92f1553cf7ab75e87a6e2cf112)
2021-12-08 21:33:58 +01:00