Commit Graph
32872 Commits
Author SHA1 Message Date
tkrokli 50008f692a Rename last 2 SQL files with correct date
(cherry picked from commit 912351febd43043798746a2f5bd46595ffea467f)
2020-04-27 12:25:52 +02:00
Killyana 95830889df DB: Fix some DB errors
(cherry picked from commit 10d7ae488e32b51b66e0ab3fb44feca68aaa7a8b)
2020-04-27 12:25:52 +02:00
Killyana abf425b281 DB/Creature: Add some Winterfin Tadpole missing spawns
(cherry picked from commit 5563b14d7a780bd3cb51135d3f62f5594730215b)
2020-04-27 12:25:52 +02:00
ariel- f31e380499 Core/Spell: check aura positivity per effect on spell hit
- Fixes applying DR to positive effects, and changing duration of whole aura

Closes #19447

(cherry picked from commit 232e631390a504b51d82a7b678b7cf26d49d182a)
2020-04-27 12:25:52 +02:00
ariel- 296abf3e12 Core/Player: fix use after free crash
(cherry picked from commit d914c55c0585fe31a9a1b9fe4e9d4a9b498e8e8f)
2020-04-27 12:25:52 +02:00
ariel- fc0a037eef Core/Spell: fix SPELL_ATTR3_IGNORE_HIT_RESULT bypassing reflects
Closes #19440

(cherry picked from commit 83177e771a373514913d066e14d5a7f9775407fe)
2020-04-27 12:25:52 +02:00
ariel- 070c2483f3 DB/Spell: Egg of mortal essence should proc with HoTs
Closes #19441

(cherry picked from commit 947a1f7be3080270b921e9bf69155bfc068ea301)
2020-04-27 12:25:52 +02:00
ariel- 7dcc185a15 Core/Instance: stop updating the instance resettimes based on creature respawns
- Rather update normal instance reset time to 2 hours after last creature kill
- This fixes yet another integer overflow due to the possibility of having time_t max showing up
- Also change respawntime and resettime fields to bigint on respawn/instance related tables
- Start using prepared statements on the InstanceSaveMgr

(cherry picked from commit 4c593f12caa162c1bfb831bdbed934bb39155ddb)
2020-04-27 12:25:52 +02:00
ariel- a2ee35d9a3 Core/Misc: pch fixes pt 2
(cherry picked from commit e32a4f26aaa51fba2647aeb8ef751dd398bc09d8)
2020-04-27 12:25:52 +02:00
ariel- 0d8c1b49b8 Core/Creature: fix integer overflow in Creature::Update leading to endless thrashing of characters database
Closes #19182

(cherry picked from commit 66755eecf117d21504b13a86410aa01cfc44c3ba)
2020-04-27 12:25:52 +02:00
ariel- 7c571c5b0a Core/Misc: fix non-pch build
(cherry picked from commit 5e0485178de0ab794c72d845e331559171301b22)
2020-04-27 12:25:52 +02:00
xinef1 090fd8304a Core/Loot: implement Loot Item Storage (#19018)
* Created Item Loot Storage, no more synchronous DB selects
* Fixed buyback case, where stored loot was not removed from db
* Added Primary key, and changed field types to be unsigned for table item_loot_money

(cherry picked from commit 9dc3de10f0044c35a95e9b72e7b874f4b5b8e867)
2020-04-27 12:25:52 +02:00
ccrs 4e03d2717a Core/Movement: correct no point recalculation on speed change in TargetedMovementGenerator
(cherry picked from commit 4d7e7a97b329dc8ee4354f7be26c5e5efbaeba6b)
2020-04-27 12:25:52 +02:00
ariel- e5e37f0d86 Core/Unit: fix crash on magic school autoattacks
Closes #19436

(cherry picked from commit 0b50ea072e504ac7d5bf87b08d564955785f7197)
2020-04-27 12:25:52 +02:00
ariel- 1960a95425 Core/Unit: cleanup and minor fixes of miss and resist calculations
- Removed Unit::GetUnitMeleeSkill as it was basically a copy of GetMaxSkillValueForLevel
- Removed static from GetEffectiveResistChance, as this was passed anyways, changed name to CalculateAverageResistReduction, which better reflects what it does
- Fix melee miss chances calculated from attacker maxskill instead of victim maxskill
- Do actual checks if spell can be resisted/missed in MagicSpellHitResult (ie chances > 0)
- Fixed SPELLMOD_RESIST_MISS_CHANCE calculation in MeleeSpellMissChance
- Minor codestyle and cleanup of diminishing returns calcs

(cherry picked from commit e565b34f6d24411e210151d0d03e524f94cdff85)
2020-04-27 12:25:52 +02:00
ariel- 16e3796c7f Core/Misc: fix static analysis issues
CID 1373466
CID 1373481
CID 1373482

(cherry picked from commit e478434146fd479fab955aaa80eb925c15e29809)
2020-04-27 12:25:52 +02:00
ariel- 9e945615bc Core/Quest: fix RewardNextQuest being used to condition previous quests in chain
(cherry picked from commit 214b8e53c5598695915c1392702e059d79cfc260)
2020-04-27 12:25:52 +02:00
Killyana 041cdcf833 DB/Gossip: Add broadcast gossip text for Argent Gruntling/Argent Squire
Closes #19402

(cherry picked from commit 33ce20b021a0d848a3c33058e8757bc3bddee970)
2020-04-27 12:25:52 +02:00
Killyana 75686795f1 DB/Script: Fix Captain Dranarus sound range
By offl
Closes #19427

(cherry picked from commit f7bb1d899da27b62a54193e158c1400ef107015a)
2020-04-27 12:25:52 +02:00
Keader 304eeea570 Core/Scripts: Baltharus the Warborn preincrement _cloneCount
(cherry picked from commit 2921449a333ea27a62c7b21d003650421c982917)
2020-04-27 12:25:52 +02:00
ccrs 84df2c57a3 Core/Movement: FormationMovementGenerator
Use own movement generator for creatures following on a formation.
First step of implementation, huge room for improvement.

Closes #19422

(cherry picked from commit 46221b6dc1272989e0de85a4563fc49dba8e7851)
2020-04-27 12:25:52 +02:00
jackpoz c31f875cc8 Core/Misc: Fix static analysis issues
(cherry picked from commit 3c4c67160afbe15cc48e5390201157c416cb9a09)
2020-04-27 12:25:52 +02:00
ccrs 14c6a4d823 [3.3.5] Core/Movement: MotionMaster & MovementGenerators cleaning (#19361)
(cherry picked from commit 21b8c4997a260b5e2dc24ab07df17d3daa6b8b5d)
2020-04-27 12:25:52 +02:00
ariel- 7f64eaa3ee Core/Player: fix weapon dependent aura talents not applied on talent learn
Closes #19408

(cherry picked from commit 5cb1555de6db43db03d6202b7edaa9c6835ecfab)
2020-04-27 12:25:52 +02:00
ariel- af3934e8ce Core/Auction: wrap item deletions from AHBot auction on a transaction
This speeds up the query execution time tremendously
Refs #19182

(cherry picked from commit ae9995f463ec9797eaa4a803bdca4fbf5978a9b7)
2020-04-27 12:25:52 +02:00
Keader f623fea923 Core/Scripts: Baltharus the Warborn make clone count more readable
*Also fixed issue that make Baltharus summons alot of clones when he is casting

(cherry picked from commit 58f2e62098f2c78b77b6b3851709c83f33e1cafd)
2020-04-27 12:25:52 +02:00
ariel- f97c28f2f1 Core/AHBot: fix price calc
- priceRatio is already a factor

(cherry picked from commit 4a654be2fbb1857f31180f8d4edca91f7825c34a)
2020-04-27 12:25:52 +02:00
ariel- 847990f030 Core/AHBot: fixed assert check
(cherry picked from commit c36854677c4cef0c83a81afa23b45ba322d354cc)
2020-04-27 12:25:52 +02:00
ariel- d80350da68 Core/Spell: don't set scaleAura for some special spells
Closes #14541

(cherry picked from commit 1ca8434b365687dbd12ca232a615d126234eba5e)
2020-04-27 12:25:52 +02:00
ariel- 8be8b7cff4 Core/AHBot: fix a typo
(cherry picked from commit e594c2d096c101a5b722793612febb6276b3b48e)
2020-04-27 12:25:52 +02:00
ariel- d6e293c718 Core/AHBot: Refactor of AuctionHouseBotSeller:
- Use AuctionHouseBot.Class.* for what they really are, priorities, factor them when calculating item amount per class, changed enums to CONFIG_AHBOT_CLASS_*_PRIORITY to reflect this change
- Don't factor in the priority calc empty item lists:
  * Let's say you had AuctionHouseBot.Class.Glyph set to 10, sum of AuctionHouseBot.Class.* is 20, and AuctionHouseBot.Items.Amount.White is 5000
  * If there were no glyphs on the item list, you automatically lost 50% of the total item amount, meaning only 2500 of original 5000 were alloted to fill
- Fixed AuctionHouseBot.AH.Price.Ratio to be an actual percentage factor

- Separated containers in SellerConfiguration, each one better reflects what kind of data is stored there, now we won't use magic index 0 from _ItemInfo :P
- General cleanup, removal of bad voodoo and magical numbers
- Use unordered_sets for loading item lists, as they were only used to check for item presence

(cherry picked from commit 7f8bfe68d0f660643c8bd4c63d2129d220c2184c)
2020-04-27 12:25:52 +02:00
ariel- 1e294f753e DB/Schema: add unsigned to some guid fields in characters
(cherry picked from commit 0c698b4567044f67eb52f6459308fb6edf693966)
2020-04-27 12:25:52 +02:00
Keader 14cf4c0692 Core/Scripts: Fixing Carbonion/Travis
(cherry picked from commit 270a6396783ccb2b8dff181fca2760adb47d2110)
2020-04-27 12:25:52 +02:00
Keader 287ed04c8b Core/Scripts: Fixed Baltharus the Warborn clones
*Clones not working after wipe
*Changed Clone Action for a event (to check casting)

(cherry picked from commit 6b8c4fb74feb2210d2fb9ea60ec23ab407ffeb39)
2020-04-27 12:25:52 +02:00
Dr-J 2ff501d15f DB/Misc: Fix error in my last commit
(cherry picked from commit 650a2d3d5062badb58c806901f4db6217a81e05e)
2020-04-27 12:25:52 +02:00
Keader 410585361a Core/Scripts: Typo in last commit
(cherry picked from commit a2a8ffe72328590b43481b430b9a6f281ccdd4be)
2020-04-27 12:25:52 +02:00
Keader fc2872e16c Core/Scripts: Fixed Volatile Ooze/Gas Cloud issues in Professor Putricide
Closes #18925

(cherry picked from commit 8d198cb36050e63811f8f7f81a3daf2a3c961950)
2020-04-27 12:25:52 +02:00
Dr-J d74a21a1b8 DB/SAI: Underbog
*  Rescript underbog  lord has regrowth is not linked to hp as was previously scripted infact you don't even have to damage npc for it to use this abilitie and it should stack 10 times increasing damage by 150% not only cast once hp is below 50%, also cast knock-away on range instead of ic so it only uses this abilitie If there is a target in range rather than ic even if there is no target in range
* Naturalist bite - make gossip and option available in heroic mode too not only normal mode

(cherry picked from commit 7bfc62639a8d6d378900c7878a0d1763e62344ee)
2020-04-27 12:25:52 +02:00
Keader 7edc9246b8 DB/LinkedRespawn: Fixed evade issue in Ruby Sanctum mini-bosses
(cherry picked from commit 43c19f17abcf58a7edf3a17e419f4991e1ad100e)
2020-04-27 12:25:52 +02:00
xinef1 e36497aef5 Core/Misc: Always reward all necessary reputations on creature kill (#19106)
(cherry picked from commit fb2aebe46be7439a8f9b99067edb27fd844c1a28)
2020-04-27 12:25:52 +02:00
ariel- 76dde4e3e9 DB/Spell: fix some enchants proc chances and reduced effects for levels > 60
- Deathfrost:  Slow effect should not work on targets 73 or higher.
- Icy Weapon: proc chance reduced, made to a %-per-hit, should only proc on white hits
- Unholy Weapon: proc chance increased to 3 PPM (based on comments data)
- Battlemaster: should only proc on white hits
- Crusader: effect reduced for players above 60

Closes #7789

(cherry picked from commit e0376d56444f3fa895d321e88b98848a9c9074c7)
2020-04-27 12:25:52 +02:00
xinef1 8df577ebfe Corrected points per level calculation for some spells (#19105)
(cherry picked from commit 9142c778dd861eda188ba868433af05038c4e13c)
2020-04-27 12:25:52 +02:00
Xinef 6f7ff9a3ef Core/Achievements: Optimized resetting achievement criteria by condition and changed the functionality to properly reset all possible criteria with given condition
Closes #18905

(cherry picked from commit 7c7b877c3fc0292f33f54f4e8b514be3bf8514a6)
2020-04-26 22:58:51 +02:00
Shauren 0763844fb6 Core/Misc: Improve enum flags with type safe operators 2020-04-26 15:27:48 +02:00
Ujp8LfXBJ6wCPR d994707ba1 Core/Misc: Remove redundant copy constructor for Position and WorldLocation (#24151)
* Default compiler generated ones do the same

(cherry picked from commit b92e4af460e72f8e6180cd5e6aac0250d64800e0)
2020-04-26 11:42:47 +02:00
Shauren 7fdeb259ba Build system: Set -Wno-deprecated-copy only for clang 10 2020-04-26 01:48:41 +02:00
Shauren 7272508cb4 Core: Fix clang 10 warnings 2020-04-26 01:25:50 +02:00
jackpoz 70c2b4e5ba Scripts/GruulsLair: Fix indentation
(cherry picked from commit 9d77b2be3b72810db1f12b6fde5e39583d521bc9)
2020-04-26 00:51:55 +02:00
Ovah 030d942efe Scripts/Antorus: implement Garothi Worldbreaker encounter for normal and heroic difficulty
* added base script support for the encounter for normal and heroic difficulty
* added instance script for Antorus the Burning Throne
* added sniffed template data for involved gameobjects
* added encounter related spawns to Antorus the Burning Throne
* added instance encounter entry for Garothi Worldbreaker
2020-04-25 19:04:31 +02:00
Shauren af76dc6b88 Core/DataStores: Speedup loading hotfix database and change hotfix database character set to utf8mb4 2020-04-25 17:01:26 +02:00