Commit Graph
100 Commits
Author SHA1 Message Date
Nay d5d0802262 Merge pull request #10718 from jackpoz/console_fix
Core/Command Line: Fix memory leak
2013-09-04 13:56:33 -07:00
Nay 9b92bc9409 Core: Fix compile with PCH enabled and warnings
Few corrections to worldserver.conf
2013-09-02 16:18:55 +01:00
Nay 28f9317698 Core/RBAC: Move cast and characters commands to RBAC (using individual permissions) 2013-09-02 13:25:07 +01:00
Nay 69a0800cb7 Merge pull request #10696 from jackpoz/socket_race_condition
Core/Socket: Fix race condition in WorldSocket
2013-09-01 15:52:57 -07:00
Nay 68b447b24c Merge pull request #10563 from Ascathor/master
Core/Account: Make account password change security variable and various changes
2013-09-01 15:52:13 -07:00
Nay cd11366690 Merge pull request #10694 from jackpoz/loopcounter_race_condition
Core/Thread: Fix race condition in FreezeDetectorRunnable
2013-09-01 10:05:39 -07:00
Nay 582686090d Merge pull request #10685 from Discover-/SmartAI-Target-Casting
Core/SmartAI: Add a spellid to SMART_EVENT_TARGET_CASTING. If left on 0,...
2013-09-01 10:03:45 -07:00
Nay c4bd91ceb9 Merge pull request #10690 from Discover-/SmartAI-Set-Home-Pos
Core/SAI: Allow using SMART_ACTION_SET_HOME_POS with multiple target typ...
2013-09-01 10:03:09 -07:00
Nay b324646005 Merge pull request #10689 from Discover-/SmartAI-Killed-Monster-Credit
Core/SAI: Also use loot recipient for SMART_ACTION_CALL_KILLEDMONSTER wh...
2013-09-01 10:02:43 -07:00
Nay a762df0aba Core/SAI: Fix processing linked events when return is used in ProcessAction
Thanks Discover-

Closes #10688
2013-09-01 18:01:59 +01:00
Nay 271a1011ca Dep/G3D: Fix encoding of G3D-v8.0_hotfix8.diff 2013-09-01 17:50:48 +01:00
Nay 6f9099c0fb Merge pull request #10693 from Chaplain/g3d-typos
Dep/G3D: Fix a typo in Vector3int32 += operator
2013-09-01 09:41:45 -07:00
Nay cdc71659e7 DB/TrinityString: Fix an issue with non-ascii characters encoding
Thanks Warpten for the fix (always import files with mysql --default-char-set=utf8 < file)
Thanks eragon for reporting the issue and testing the fix
2013-09-01 14:19:45 +01:00
Nay 8dfb977cc6 Dep/G3D: Update Readme.txt 2013-09-01 13:37:57 +01:00
Nay 1bbd726e88 Merge branch 'master' of github.com:TrinityCore/TrinityCore 2013-08-31 22:48:01 +01:00
Nay 0394238a29 Dep/G3D: Fix a typo in Matrix4 == operator 2013-08-31 22:44:10 +01:00
Nay 16fcac1991 Core/RBAC: Move bf commands to RBAC (using individual permissions) 2013-08-31 21:02:14 +01:00
Nay 2d93059114 SQL: Fix a typo in e375c6075b 2013-08-31 12:45:44 +01:00
Nay 7ecf4fdec1 Core/Quests: Split Flags and SpecialFlags 2013-08-30 23:08:40 +02:00
Nay 7776016106 Core/Quests: Remove CastedCreatureOrGO method
- Remove EAI's ACTION_T_CAST_EVENT and ACTION_T_CAST_EVENT_ALL
- Remove SAI's SMART_ACTION_CALL_CASTEDCREATUREORGO
- Split QUEST_TRINITY_FLAGS_KILL_OR_CAST into QUEST_TRINITY_FLAGS_KILL and QUEST_TRINITY_FLAGS_CAST
- Assign QUEST_TRINITY_FLAGS_CAST to all the quests that were using RequiredSpellCastX
- (unrelated) Fix a warning in Player.cpp
- Replace CastedCreatureOrGO usage in scripts by KilledMonsterCredit

TODO: Convert the two EAI scripts commented out in the .sql to proper SAI

Closes #10667
2013-08-30 19:32:08 +01:00
Nay aa5bc37e9c Core: Yet more warning fixes 2013-08-30 16:03:37 +01:00
Nay 1903d4ca7d Core/Server: Fix a spammy warning in WorldSession and move code to .cpp 2013-08-30 15:44:17 +01:00
Nay d805a2dc0e SQLS: Rename wrong named sql file 2013-08-30 14:09:21 +01:00
Nay ec837b1d7d Merge pull request #10666 from xjose93/SmartScripts-StartEvent
Implement SMART_ACTION_GAME_EVENT_STOP (111) and SMART_ACTION_GAME_EVENT_START (112).
2013-08-29 16:36:42 -07:00
Nay 3b71172e8a Core/Quests: Fix a typo in a previous commit
Closes #10664
2013-08-29 16:01:48 +01:00
Nay 62d1ee680b Core/Quests: Drop world.quest_template.RequiredSpellCastX
These were non-wdb fields that didn't have much use.
Most quests that were using these fields (not many) should still work,
however, if you find any quest that worked before and is now broken
please report it in the issue tracker and it will be promptly fixed.
2013-08-29 15:36:38 +01:00
Nay 577e320809 DB/Schema: Fix typo in reputation_reward_rate.quest_repeatable_rate name 2013-08-28 16:31:43 +01:00
Nay 83e5168a5b DB/Reputation: Reward 3x reputation for Sporegar on repeteable quests
Closes #5789
2013-08-28 15:15:14 +01:00
Nay 7135abf3a0 Merge branch 'master' of github.com:TrinityCore/TrinityCore 2013-08-27 23:56:34 +01:00
Nay 78786c7b54 Core&Scripts: Fix clang compiler warnings 2013-08-27 23:47:03 +01:00
Nay e5dc70118a Server/Collision: Fix build on clang 2013-08-27 19:34:03 +01:00
Nay cc14e18664 Core/Misc: Fix compiler warnings 2013-08-27 16:06:18 +01:00
Nay 2050a36b58 SAI & Scripts: Fix unitialized values found by Valgrind
==3064== Conditional jump or move depends on uninitialised value(s)
==3064==    at 0x19B3031: boss_skarvald_the_constructor::boss_skarvald_the_constructorAI::UpdateAI(unsigned int) (boss_skarvald_dalronn.cpp:217)

==3064== Conditional jump or move depends on uninitialised value(s)
==3064==    at 0x19B3948: boss_dalronn_the_controller::boss_dalronn_the_controllerAI::UpdateAI(unsigned int) (boss_skarvald_dalronn.cpp:388)

==3064== Conditional jump or move depends on uninitialised value(s)
==3064==    at 0x15E2FCC: SmartScript::ProcessAction(SmartScriptHolder&, Unit*, unsigned int, unsigned int, bool, SpellInfo const*, GameObject*) (SmartScript.cpp:144)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064==    at 0x191CB98: dummy_dragonAI::UpdateAI(unsigned int) (boss_sartharion.cpp:961)
==3064==    by 0x191D242: npc_shadron::npc_shadronAI::UpdateAI(unsigned int) (boss_sartharion.cpp:1122)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064==    at 0x19AE913: boss_ymiron::boss_ymironAI::UpdateAI(unsigned int) (boss_ymiron.cpp:215)

==3064== Use of uninitialised value of size 8
...
==3064==    by 0x18A9F4A: boss_illidan_stormrage::boss_illidan_stormrageAI::Reset() (boss_illidan.cpp:1805)

==3064== Conditional jump or move depends on uninitialised value(s)
...
==3064==    by 0x18A9F4A: boss_illidan_stormrage::boss_illidan_stormrageAI::Reset() (boss_illidan.cpp:1805)

==3064== Conditional jump or move depends on uninitialised value(s)
==3064==    at 0x191CB98: dummy_dragonAI::UpdateAI(unsigned int) (boss_sartharion.cpp:961)
==3064==    by 0x191CE88: npc_tenebron::npc_tenebronAI::UpdateAI(unsigned int) (boss_sartharion.cpp:1027)

==3064== Conditional jump or move depends on uninitialised value(s)
==3064==    at 0x191CB98: dummy_dragonAI::UpdateAI(unsigned int) (boss_sartharion.cpp:961)
==3064==    by 0x191D5B8: npc_vesperon::npc_vesperonAI::UpdateAI(unsigned int) (boss_sartharion.cpp:1220)

==3064== Conditional jump or move depends on uninitialised value(s)
...
==3064==    by 0x1868F59: boss_lady_vashj::boss_lady_vashjAI::Reset() (boss_lady_vashj.cpp:206)

==3064== Conditional jump or move depends on uninitialised value(s)
==3064==    at 0x191C14C: dummy_dragonAI::MovementInform(unsigned int, unsigned int) (boss_sartharion.cpp:802)

==3064== Conditional jump or move depends on uninitialised value(s)
==3064==    at 0x1046986: Position::NormalizeOrientation(float) (Object.h:388)
...
==3064==    by 0x17D9463: boss_malchezaar::boss_malchezaarAI::SummonInfernal(unsigned int) (boss_prince_malchezaar.cpp:373)
2013-08-26 16:13:26 +01:00
Nay 9327832896 Merge pull request #10633 from jackpoz/createguild_fix
Core/Guild: Fix uninitialized value on guild creation
2013-08-26 05:27:31 -07:00
Nay 8eaf763235 Core&Tools: Fix multiple issues found by a static code coverage tool 2013-08-26 02:00:18 +01:00
Nay 3e2f037b20 Core&Tools: Fix warnings and non-pch build 2013-08-25 14:27:40 +01:00
Nay 12973de799 Core&Tools: Fix multiple issues found by a static code coverage tool 2013-08-24 22:57:22 +01:00
Nay 573c919c5b Merge pull request #10617 from jackpoz/updatemask_fix
Fix uninitialized UpdateMask field
2013-08-24 09:12:49 -07:00
Nay 58e6503eef Core/Settings: Fix build in non cpp11 compilers
std::string back() was only introduced in C++11, a pity..
2013-08-24 15:45:19 +01:00
Nay cc3055f344 Core/Settings: Fix a crash if worldserver.conf DataDir setting is empty 2013-08-24 14:30:17 +01:00
Nay 0d5181af4d Merge pull request #10559 from Discover-/Taxi-Benchmarking
Core/Misc: Implement CMSG_SET_TAXI_BENCHMARK_MODE to toggle PLAYER_FLAGS...
2013-08-23 17:57:21 -07:00
Nay a0a377a0ce Scripts: Fix two issues found by Valgrind
==3400== Invalid write of size 8
==3400==    at 0x1241C32: instance_ahnkahet::GetInstanceScript(InstanceMap*) const (instance_ahnkahet.cpp:54)
...
==3400== Conditional jump or move depends on uninitialised value(s)
==3400==    at 0xB5DEAE: std::tr1::_Hashtable<unsigned long, std::pair<unsigned long const, Creature*>, std::allocator<std::pair<unsigned long const, Creature*> >, std::_Select1st<std::pair<unsigned long const, Creature*> >, std::equal_to<unsigned long>, std::tr1::hash<unsigned long>, std::tr1::__detail::_Mod_range_hashing, std::tr1::__detail::_Default_ranged_hash, std::tr1::__detail::_Prime_rehash_policy, false, false, true>::_M_find_node(std::tr1::__detail::_Hash_node<std::pair<unsigned long const, Creature*>, false>*, unsigned long const&, unsigned long) const (hashtable.h:830)
==3400==    by 0xBDA4CA: std::tr1::_Hashtable<unsigned long, std::pair<unsigned long const, Creature*>, std::allocator<std::pair<unsigned long const, Creature*> >, std::_Select1st<std::pair<unsigned long const, Creature*> >, std::equal_to<unsigned long>, std::tr1::hash<unsigned long>, std::tr1::__detail::_Mod_range_hashing, std::tr1::__detail::_Default_ranged_hash, std::tr1::__detail::_Prime_rehash_policy, false, false, true>::find(unsigned long const&) (hashtable.h:698)
==3400==    by 0xBDA5BF: HashMapHolder<Creature>::Find(unsigned long) (ObjectAccessor.h:67)
==3400==    by 0xCB5C03: Map::GetCreature(unsigned long) (ObjectAccessor.h:114)
==3400==    by 0xB6E6EF: Unit::GetCreature(WorldObject&, unsigned long) (Unit.cpp:13023)
==3400==    by 0x10F0790: boss_hydross_the_unstable::boss_hydross_the_unstableAI::Reset() (boss_hydross_the_unstable.cpp:164)
2013-08-24 01:54:37 +01:00
Nay 556c478e68 Tools: Fix compiler warnings 2013-08-23 20:42:22 +01:00
Nay 5ebe71712f Dependencies/bzip: Remove bzip2.c and bzip2recover.c, they are not required
Fixes "warning LNK4006: _main already defined in bzip2recover.obj; second definition ignored"
2013-08-11 20:08:33 +01:00
Nay 2abaf6224e Core/Player: Add debug log when SendCanTakeQuestResponse(INVALIDREASON_*) is used
Intent is to find broken quest chains
Requested by Aokromes
2013-08-11 16:36:36 +01:00
Nay d0bde02b21 Core/CreatureAI: Do not remove clone_caster auras on evade (in addition to control_vehicle auras) 2013-08-11 15:52:23 +01:00
Nay 54d2b73f3c Merge pull request #10513 from Discover-/SmartAI-Casted-CreatureOrGo
Core/SmartAI: Drop support for SMART_ACTION_SEND_CASTCREATUREORGO. It is...
2013-08-11 06:26:52 -07:00
Nay 8b08fba98d Merge pull request #10501 from Discover-/SmartAI-Action-Set-Power
Core/SmartAI: Implement MART_ACTION_SET_POWER, SMART_ACTION_ADD_POWER and SMART_ACTION_REMOVE_POWER (param1 = powertype, para...
2013-08-10 12:39:32 -07:00
Nay 181a3cad00 Merge pull request #10511 from MitchesD/Mobs
DB/SAI: Draktharon Keep mobs
2013-08-10 11:05:48 -07:00
Nay 482720da50 Core/BattlegroundAV: Fix team variable type, "if (team == ALLIANCE)" would always return false
Ref 33f8c3ead4da07ff024a94b5e8cf0d05c2ebc23a#L4R1626
2013-08-10 17:35:23 +01:00
Nay b33f80aa18 Scripts/Pet: Fix non pch compile 2013-08-10 16:00:58 +01:00
Nay b7d88a3c46 Merge pull request #9817 from drskull/master
Core/Spell add another condition in AnyGroupedUnitInObjectRangeCheck
2013-08-09 08:46:19 -07:00
Nay eba8c2d345 Merge pull request #10464 from Discover-/SmartAI-Set-Active
Core/SmartAI: Allow SMART_ACTION_SET_ACTIVE to take a parameter for on/o...
2013-08-09 08:44:56 -07:00
Nay edf77a4cf6 Merge pull request #10493 from Discover-/SmartAI-Action-Sound-Update
Core/SmartAI: Rename SMART_ACTION_SOUND's parameters and get rid of an e...
2013-08-09 08:38:09 -07:00
Nay 32c8555e1e DB/NPCs: Remove AIName from npcs that do not have EAI or SAI scripts
Closes #10483
2013-08-09 14:21:34 +01:00
Nay 9f05cf7548 DB/NPCs: Because of some silly reason there are NPCs with AIName 0 2013-08-08 00:35:33 +01:00
Nay fa9144fa39 DB: Fix startup errors 2013-08-07 23:16:33 +01:00
Nay fee62f500c DB/Commands: Re-add help text for reload gameobject_questender 2013-08-06 21:17:06 +01:00
Nay ebaee135c9 Server/Player: Fix a logical mistake in ApplyEquipCooldown
Thanks Joschiwald
2013-08-06 18:19:18 +01:00
Nay 8dfaf27d25 Merge pull request #10245 from Mihapro/master
Core/SmartScripts
2013-08-06 08:55:41 -07:00
Nay 8dccf61005 Merge pull request #10445 from Discover-/Cooldown-Exploit
Core/Items: Fix an exploit where players would be able to reset the cool...
2013-08-06 08:35:57 -07:00
Nay 1bf1f95a8e Merge pull request #10455 from Discover-/Battleground-Reinterpret-Casts
Core/Misc: Implement reinterpret casts for all battleground classes and ...
2013-08-06 08:31:59 -07:00
Nay dc8385f4c0 DB/Items: Remove unlimited charges from Jillian's Tonic of Stoneblood
Closes #10444
2013-08-06 00:16:55 +01:00
Nay a71fcee27d DB/Schema: Rename _questrelation tables to _queststarter and _involvedrelation to _questender, for creature and gameobject 2013-08-06 00:04:29 +01:00
Nay 2bd4049890 Scripts/Commands: Fix compile (v2) 2013-08-05 22:55:06 +01:00
Nay df6e66555b Scripts/Commands: Fix compile 2013-08-05 22:41:37 +01:00
Nay 8af6e6ca79 Merge branch 'master' of github.com:TrinityCore/TrinityCore 2013-08-05 20:00:08 +01:00
Nay ccdba0859d Core/Items: Correct randomProperlyId type when reading to/from DB
Ref #10446
2013-08-05 19:59:54 +01:00
Nay a7d876e8b5 Config: Change ProcessPriority default to 0 (Normal)
On Linux, superuser (root) is required to set a process high priority and we shouldn't force that.
(It's already set to 0 (Normal) in worldserver\Master.cpp and authserver\Main.cpp)
2013-07-30 15:34:38 +01:00
Nay 7165fd769e Merge pull request #9862 from Ric101/condition_creature_type
Core/Conditions: Implement CONDITION_CREATURE_TYPE - 24
2013-07-30 06:25:04 -07:00
Nay 1b0c604848 Revert "CMake/MSVC: Fix VS 2013 compile -- Zm500 hack is no longer required"
This reverts commit ca7377369f.
2013-07-30 13:50:29 +01:00
Nay 394b2c6845 Scripts/OnyxiasLair: Fix a crash in boss_onyxia
Closes #10393

Note: this just fixes the crash, not the issues the script has (a.k.a rewrite this)
2013-07-29 21:46:49 +01:00
Nay a91e42f20d SQLs: Rename files
From now on, 3.3.5 (master branch)-only SQL files will be suffixed with _335 in the filename
2013-07-29 16:14:29 +01:00
Nay 1bb3c4a2b4 Misc: Fix warnings and build
Closes #10396
2013-07-29 14:24:53 +01:00
Nay 4559e99e0d Docs: Prettify README
Thanks to Guybrush for the help
2013-07-28 21:17:32 +01:00
Nay 3330239a02 Servers: Fix typo 2013-07-28 20:12:06 +01:00
Nay e3f7be12ef Servers: Enable UseProcessors and ProcessPriority settings to be used on Linux 2013-07-28 18:58:12 +01:00
Nay f71d894a21 Servers: Fix some code style issues in world and authserver 2013-07-28 16:59:07 +01:00
Nay 009317d2a0 SQLS/Old: Move some misplaced files 2013-07-28 16:54:13 +01:00
Nay a3aa3f65fd Scripts/VH: Refactor commit 999843d 2013-07-23 02:13:09 +01:00
Nay 5463f211b4 Merge pull request #10323 from joschiwald/spellranks
Core/Spells: use SpellInfo class to get spellrank node instead of SpellMgr helpers
2013-07-22 16:28:35 -07:00
Nay f5a44b19a8 Merge pull request #10320 from joschiwald/battleground
Core/Battleground: use generic function to relocate players to closest g...
2013-07-22 16:27:10 -07:00
Nay cd2c33c4eb Merge pull request #10319 from joschiwald/casts
Core/Misc: replace (Player*) casts with ToPlayer()
2013-07-22 16:26:41 -07:00
Nay bf100ffc3c Scripts/Icecrown: Fix a double function call typo in npc_margrave_dhakar
Thanks Josh
2013-07-20 15:00:36 +01:00
Nay 7ce340bbd6 Core/Dependencies: Update utf8-cpp to version 2.3.4 2013-07-20 14:55:25 +01:00
Nay d04bb0dd61 Merge pull request #10317 from FireEmerald/master
Collection of Feedback-PatchFixes / 20.07.2013
2013-07-20 06:51:25 -07:00
Nay ebd9090d80 DB/NPCs: Fix Margrave Dhakar equipment 2013-07-19 03:25:52 +01:00
Nay 0691a4310f Scripts/Icecrown: Use guid instead of cached Creature* to avoid crashes in npc_margrave_dhakar 2013-07-19 02:27:56 +01:00
Nay ca7377369f CMake/MSVC: Fix VS 2013 compile -- Zm500 hack is no longer required
Signed-off-by: Nay <[email protected]>
2013-07-19 01:13:26 +01:00
Nay ff01602906 Scripts/Icecrown: Fix code style and use "best practices" on previous commit (c536ba510) 2013-07-19 00:42:59 +01:00
Nay c536ba510d Scripts/Icecrown: Fix quest The Flesh Giant Champion
Closes #9040
Closes #10294
2013-07-19 00:03:27 +01:00
Nay eca90db56b Scripts/Commands/Arena: Replace a call of GetPlayerNameByGUID by GetCharacterNameData 2013-07-18 21:07:00 +01:00
Nay 3875ae0c66 TDB 335.52 - 2013/07/17 2013-07-17 00:27:42 +01:00
Nay 8b0cea7a5e SQL: Prevent a warning in 2013_07_14_01_world_item_template.sql 2013-07-14 18:46:48 +01:00
Nay ee31174caa DB/Items: Change item_template.Flags to uint32 (int(10) unsigned) 2013-07-14 18:15:42 +01:00
Nay bedb2e56e2 DB/Errors: Fix a db startup error 2013-07-14 14:46:03 +01:00
Nay d6f3460796 Script/Commands: Fix a crash in .arena captain command 2013-07-13 23:07:01 +01:00
Nay 4ecc68d3a5 DB/EAI: Remove forgotten EAI scripts
984fa01b61
2013-07-12 14:40:54 +01:00
Nay 3561ab98ba Misc: Use override and final C++11 keywords in a few places (mostly scripts)
OVERRIDE and FINAL are TC macros (expand to nothing if compiler does not  support C++11)
2013-07-06 20:21:45 +01:00
Nay 85db1fc943 Scripts/Razorfen Kraul: Fix build and a possible crash 2013-07-04 17:12:29 +01:00