Commit Graph
32798 Commits
Author SHA1 Message Date
Aokromes 4aa19b20ff DB/Item: Improved Land Mines
By Rushor, closes #10205

(cherry picked from commit ff816f404dea49773678090f20923e25d0565ee0)
2020-04-24 17:18:50 +02:00
Aokromes 4ee1d4b44b DB/Creature: Fix Verifonix faction and reputation
By offl, Closes #19323

(cherry picked from commit 5b3819424706ae34a787ba3e8112ff181a744011)
2020-04-24 17:18:50 +02:00
Aokromes be0de1ce70 DB/Creature: Fix Guardian of Icecrown creature_text typo
By TecDian
Closes #19226

(cherry picked from commit e4492dd0bdda6e9f778993c24889c8aea10f79ab)
2020-04-24 17:18:50 +02:00
ariel- da12320937 Core/Auras: fix a deleted memory access crash
Closes #19319

(cherry picked from commit 01aaafb0834d22ff41d7d9904e59d82a4a7f5381)
2020-04-24 17:18:50 +02:00
Aokromes 054a6a9e2e Rename 2017_03_25_00_world.sql to 2017_03_25_01_world.sql
(cherry picked from commit 9d6902331b4d70152623154964ca0308408ada72)
2020-04-24 17:18:50 +02:00
ccrs 953cdbf205 Fix warning
field '_top' will be initialized after field '_owner'

(cherry picked from commit 2b5c765bcdd57e55b62db70527d85723f5a021eb)
2020-04-24 17:18:50 +02:00
ccrs f135b7aea1 Core/Movement: 96f4c7c followup
(cherry picked from commit 9be7f5f57b897888983a9ca6f441479f3571513c)
2020-04-24 17:18:50 +02:00
ccrs b2d1b11326 Core/MotionMaster: cleanup use of _expireList
And restore broken _cleanFlag check/use on update (eca3645d8bb655b88e39f05e36b435171f738f70)

(cherry picked from commit 96f4c7c187e03aeb61e905421751f3d5a1df060e)
2020-04-24 17:18:50 +02:00
ccrs 1f0dc07ef1 Core/Unit: cleanup UnitState enum
(cherry picked from commit bf56049f2f95a67ccaf0cff46c977cb7e0925a38)
2020-04-24 17:18:50 +02:00
ccrs dbe54973fb Core/Movement: cleanup MovementGeneratorType
(cherry picked from commit fce974c3b33b38b71166960d37ca8cff67fa8f14)
2020-04-24 17:18:49 +02:00
Gustavo 6f523b4fb6 Core/Scripts: minor fixes in boss_the_lich_king (#19311)
Closes #4427
Closes #7091

(cherry picked from commit 2792046dc7a229180d27dfdc4ce37ccfb84c8a27)
2020-04-24 17:18:49 +02:00
ariel- 7a561ad045 Core/Scripts: Updated Ulduar instance model
- Codestyle/indent fixes
- Added ObjectData for some GOs
- Added GetUlduarAI to creatures
- Fixed possible out-of-bounds access in boss_razorscale_controllerAI (boss AI number beyond allocated boss size)

(cherry picked from commit b74cc8085946fed1eb41a6332e3a5cca6f9edd7f)
2020-04-24 17:18:49 +02:00
Chaouki Dhib 5d076cfe29 Core/Spells: fix wrong distance calculations in AoE spells [Needs testing] (#16290)
Core/Spells: Fix wrong distance calculations in AoE spells.
Pull request #16290 by chaodhib.
God bless, finally.

(cherry picked from commit a1f2f30c145f6ad9c4baeffeff32618e71ff537c)
2020-04-24 17:18:49 +02:00
S.V b8b6fd9ca0 Core/Creatures: Fixed GMs being considered in party/raid with nearby creatures without CREATURE_TYPE_FLAG_TREAT_AS_RAID_UNIT
Ref #19340

(cherry picked from commit eea16ce35630762703b8f71d31c827179c37bfc4)
2020-04-24 17:18:49 +02:00
Keader b234658617 Core/Scripts: Fixed wrong calculation of Aura of Desire
Closes #19322

(cherry picked from commit 333a4034099e262db8db0a1736d01c30a8cf9d52)
2020-04-24 17:18:49 +02:00
xinef1 ca4720662d Core/Items: Fixed durability problems for wrapped item (#19003)
(cherry picked from commit 81d011170d48e7d4cce7892897d24528254615af)
2020-04-24 17:18:49 +02:00
ariel- e44d0c8873 Core/Spell: fix an issue with vehicle spells changing orientation of base vehicle
Closes #17234

(cherry picked from commit 4096b02a560499d2cb2f40c67ac0b30ed4c48ffd)
2020-04-24 17:18:49 +02:00
ariel- 786bb561ca Core/AchievementMgr: fix integer underflow neglecting already completed realm firsts
Closes #19334

(cherry picked from commit 9cfa7c752e1d61b02acb852d2fd304a80d10b60a)
2020-04-24 17:18:49 +02:00
ariel- 848f0d1323 Core/Entities: don't finalize movesplines before deleting.
- The whole MotionMaster will be destroyed along with the unit, freeing the allocated memory.

Closes #19324

(cherry picked from commit b53d0530cd9be97d549993a6b6c46e2cb7a4e779)
2020-04-24 17:18:49 +02:00
robinsch 8874a3ac5d Core/Social: Implement FRIEND_STATUS_RAF (#19317)
(cherry picked from commit d209aaa00fdf0ca5fd3939b4b830d8948141900b)
2020-04-24 17:18:49 +02:00
Golrag b8c8dcdbfc Core/Object: Fix Line of Sight issue with object edges
Fixes: https://github.com/TrinityCore/TrinityCore/pull/15807#issuecomment-268077802
(cherry picked from commit 020a6b984d6f6c04a57211e433a8d995514c6c0a)
2020-04-24 17:18:48 +02:00
jackpoz bfcb276781 Core/Crash: Refactor and fixes
Code cleanup.
Fix buffer overflow crash.
Fix type being truncated to 199 characters.

(cherry picked from commit 9226e212053ef8ec10eeb9509f2ce6ec002d8e3b)
2020-04-24 17:18:48 +02:00
ariel- 6098c4549c Core/Spell: add assert checks on SpellMgr::CheckSpellGroupStackRules
Ref #19319

(cherry picked from commit 36bb4cabae01c591cf6151bae2f65a1f578ed9f3)
2020-04-24 17:18:48 +02:00
Killyana 8b8b6bf319 DB/Creature: Doctor Razorgrin
(cherry picked from commit 957d3cda1eca1f4cf7936f587ba2b1c11c9a99b3)
2020-04-24 17:18:48 +02:00
ariel- 053d0cfda5 Core/Pet: load template immunities when creating (except for hunters)
Fixes #19275

(cherry picked from commit e33263c677a3d1af61b7c2e53d72b5360ba7de4d)
2020-04-24 17:18:48 +02:00
ariel- c16cebca64 Core/Unit: properly reset displayIds when having a shapeshift aura active
Closes #19309

(cherry picked from commit 7a38eaa5a1fe23d8fedb2bfce518abb972b823f7)
2020-04-24 17:18:48 +02:00
Aokromes dbb21ea844 DB/Misc: Fix startup errors / typo fix
(cherry picked from commit 3d43a92fb3aa6de3109581b04ed3795eb14b5354)
2020-04-24 17:18:48 +02:00
ariel- 1536f01a74 Core/Quests: fixed exclusivegroup interaction with prevquestId and nextQuestId.
- They should work as documented by wiki now.
- Add some consts to Player methods
- Fixed negative PrevQuestID to mean only active quest (ie not rewarded/complete, as those quests are required to complete another)

Closes #19300

(cherry picked from commit 3b27a06265e4f022ec81b00ab99255246e8dd467)
2020-04-24 17:18:48 +02:00
ariel- c03373c59f Core/Quests: changed quest_template_addon.NextQuestID to unsigned
- No reason to keep this anymore after 4349adf0f25210e5b26201523a09bc26b4a83394, this is a broken functionality.

(cherry picked from commit dca276716fecb819fec668f59954113a77f9e393)
2020-04-24 17:18:48 +02:00
ariel- feb8205d6a Core/Globals: some changes in quest loading
- Made load/reload associated quest tables data-driven, so removed a bunch of similar looking code from ObjectMgr (yay!)
- Codestyle and encapsulation for ExclusiveQuestGroups

(cherry picked from commit 076293f1f269b8f681c97f23872915bdfeccef1d)
2020-04-24 17:18:48 +02:00
ariel- 4472a3cbf3 Core/Globals: Fix Quest codestyle and member variable initialization
(cherry picked from commit 09701b0229f84e3c0b014f6a161f945f3d226d8b)
2020-04-24 17:18:48 +02:00
ariel- a098b454b8 Core/Entities: virtualize CheckAttackFitToAuraRequirement
- Should've been like this to begin with

(cherry picked from commit 21d95a1d767c95910d4508e0e83f34b4f89f587a)
2020-04-24 17:18:47 +02:00
Killyana f793a43cee DB/Creature: Fix a type on creature text related to Lord Thorval
Ref https://github.com/TrinityCore/TrinityCore/commit/80a0c3cfc779abab18447fbeca78dd0024294f94

(cherry picked from commit 63236f97af03b9745e1a12d1df56a0c885230caf)
2020-04-24 17:18:47 +02:00
ariel- 5979f4f396 Core/Auras: fix more unused parameter warnings
(cherry picked from commit 7de5befbc39cd6bf45166fd2c5d0532065f7e99e)
2020-04-24 17:18:47 +02:00
ariel- 1c4b1ba498 Core/Auras: fix comparison of integers of different signs warning
(cherry picked from commit 9047d8bd6f549d4a30665cdaabf8811eeb516362)
2020-04-24 17:18:47 +02:00
ariel- e39ea201ce Core/Auras: fix unused parameter warning
(cherry picked from commit 40489b8d5722969cef11b9c48ee50ef366333073)
2020-04-24 17:18:47 +02:00
ariel- ebc06b1d04 Core/Auras: reworked multiplicative AuraEffects calculation
- Splitted containers for flat modifiers and pct modifiers, as they now have different handling
- Amount is now multiplied only on apply; on unapply, iterate through auras and reset the counter
- Fixes many cases of rounding error due to applying/unapplying of small factors
- Allows amounts to be zeroed (ie with an AuraEffect of amount -100)
- Do a partial revert of 6dc37a9add631888fe5fbcd43d19c2b07bed8a57, auras should update amounts only for items allowed (ie no more giving crit to a sword while having an axe in the other hand and being Poleaxe spec'd)
- SPELL_AURA_MOD_SCALE now scales additively, rather than multiplicatively (checked in sniffs)

Closes #18687

(cherry picked from commit c69a7d1223b2ce108a221e5cc70f76cd80ae6675)
2020-04-24 17:18:47 +02:00
ariel- 73ea9ecec1 Core/Misc: moved WeaponAttackType definition to SharedDefines to avoid including Unit.h
(cherry picked from commit 6d991e9361fdda66391a7f4774ea908763998074)
2020-04-24 17:18:47 +02:00
ariel- de2cae6a58 DB/Spell: Recently Bandaged debuff shouldn't break stealth
Closes #18951
By Noryad

(cherry picked from commit 5f901d3d75660118f705c27c84e1ae895ad8e3e7)
2020-04-24 17:18:47 +02:00
Rushor 1abe7530df DB/Creature: Savage Hill Brute/Mystic/Scavenger
Closes #18922

(cherry picked from commit abed5e1586d01dfa75bd4102f8be3d8b645d9f9d)
2020-04-24 17:18:47 +02:00
ariel- cdbe16fabe Core/Scripts: implemented Gnomish Harm Prevention Belt
Updates #18542

(cherry picked from commit 2db3e86d9bf200e5049e553160bc47b7bacac621)
2020-04-24 17:18:47 +02:00
Rushor 2d2cf2533e DB/Creature: Footman Rob, Footman Chuck and Footman George
Closes #18770

(cherry picked from commit 6732c1c2e1d26c52d0ab0817a7a19e013a3ea57d)
2020-04-24 17:18:47 +02:00
Rushor 49af1080aa DB/Creature: Bellinger and Bailey
Closes #18908

(cherry picked from commit b9bd4cd19856ca902cef1ea70b016ae312a07b52)
2020-04-24 17:18:47 +02:00
Rushor fb25fccefa DB: Janks's mine event
Closes #18907

(cherry picked from commit 7b578cb14281eaeb165477662a23c24546e3a7fd)
2020-04-24 17:18:47 +02:00
Rushor 554a36ae24 DB/Creature: Torseg the Exiled
Closes #18902

(cherry picked from commit 2f19d78b2adab5cb8ce5d7c7a57e10f0e1236a2b)
2020-04-24 17:18:46 +02:00
Rushor 08870077ad DB/Creature: Zalduun
Closes #18886

(cherry picked from commit 5b46f5180cf30db047768df10b7c4c2d1b42b30f)
2020-04-24 17:18:46 +02:00
Rushor 52f6738cd1 DB/Creature: Gothik the Harvester 2
Closes #18884

(cherry picked from commit 5edd8557938547af4d9b2ef0024302c40c34d052)
2020-04-24 17:18:46 +02:00
Rushor 70396c5ad7 DB/Creature: Gothik the Harvester
Closes #18881

(cherry picked from commit f86fa0f52666d06680e96866fca332b0838e9285)
2020-04-24 17:18:46 +02:00
Rushor 7597fda20a DB/Creature: Lord Thorval
Closes #18880

(cherry picked from commit 80a0c3cfc779abab18447fbeca78dd0024294f94)
2020-04-24 17:18:46 +02:00
Keader f3d946cee9 Core/Spell: Fixed Val'kyr Target Search exploit
Closes #16347
by ariel-

(cherry picked from commit 28b955bd25dce9c153ba4e1d16d70778d41d5d9b)
2020-04-24 17:18:46 +02:00