Commit Graph
143 Commits
Author SHA1 Message Date
zergtmn 6e217b6e6a Allow AURA_FORCE_MOVE_FORWARD to work on creatures and vehicles. For example, it fixes spell 68284.
Signed-off-by: Manuel Carrasco <[email protected]>
2011-02-14 19:18:05 -03:00
Shauren 8d7a6cd611 Core/Spells: Moved Glacial Strike removal to spell script, thanks Destalker for pointing it out 2011-01-31 20:06:47 +01:00
Shauren 6bbff14083 Core/Auras: Fixed Glacial Strike (Pit of Saron trash spell) not being removed 2011-01-31 12:20:59 +01:00
Shauren c3c2a807f0 Core/Auras: Fixed displaying SPELL_AURA_MOD_DAMAGE_PERCENT_DONE damage bonus in character stats 2011-01-28 20:41:03 +01:00
Shauren ea00b2ac10 Fixed compile warning 2011-01-28 12:02:51 +01:00
johnholiver 2df58e5d8f Core/Spells: Fixed Rip damage.
Signed-off-by: Shauren <[email protected]>
2011-01-28 11:22:52 +01:00
JohnHoliver f3317ea1d5 Core/Spells - Fixed Bestial Wrath immunities
Signed-off-by: Shauren <[email protected]>
2011-01-28 11:22:51 +01:00
leak e00e57b570 Core/Spells: Remove movement impairing effects for druids when shifting back to normal form
fixes #320
2011-01-26 20:05:36 +01:00
leak 137b079eea Core: Generic cleanup (tab2spaces/trailing whitespace removal) 2011-01-26 01:03:35 +01:00
Shauren 9dfa00bb60 Core/Auras: Removed unneeded typecasting from aura 54798 handler 2011-01-23 11:09:26 +01:00
Shauren 5adf9c5d30 Scripts/Spells: Moved all special target filtering cases to scripts 2011-01-22 17:21:24 +01:00
Machiavelli deed0d0781 Core/General: Fix some comment style. //* to // *. Fixes certain code display errors on nano. Thanks to Aokromes for pointing out. 2011-01-16 12:23:17 +01:00
Machiavelli 09f2a48227 Core/Spells: Add unittarget check for spell 54798 2011-01-16 00:50:57 +01:00
Sarjuuk 06314c9387 Core/Spells: Implemented Pygmy oil use effect
Signed-off-by: Machiavelli <[email protected]>
2011-01-06 21:40:32 +01:00
sarjuuk dfc848b88e Core/Spells: Periodic Dummy for spell 54798. Fixes quest 12851
Signed-off-by: Machiavelli <[email protected]>
2011-01-06 20:25:51 +01:00
sarjuuk 20b49bccb0 Core/Spells: Set energy in cat form to zero on shapeshift before calculating energy gain from furor talent.
Signed-off-by: Machiavelli <[email protected]>
2011-01-06 19:43:36 +01:00
Shauren 3208b7ae1f Core/Auras: Prevent phase aura handler from incorrectly being stopped on aura removal
Closes #32
2011-01-04 22:41:44 +01:00
Shauren 9c0cd63e93 Core/Scripts: Added wrapper method for despawning creatures DespawnOrUnsummon 2011-01-02 21:33:37 +01:00
Shauren a3eff12b33 Core/Auras: Fixed transform aura stacking logic 2011-01-02 17:22:45 +01:00
Machiavelli 957c69de83 Update copyright note for 2011.
Happy new year.
2011-01-01 15:01:13 +01:00
QAston 42d3130a56 Core/Auras:
Fix a crash with spell 33499 - BIG thanks to Shauren for finding the reason of this crash
 Corrections in managing stacked auras which change unit model.
2010-12-31 18:12:20 +01:00
QAston dd5a77bebc Core/Auras: Recheck aura presence on target after calling linked events in charm and vehicle aura effect handlers. 2010-12-31 15:37:44 +01:00
QAston 4eccbb81af Core/Auras: Recheck aura presence on target after calling linked events in aura effect handlers. Prevents undefined behavious when aura effect remove handler is called before apply handler is finished. 2010-12-31 14:39:18 +01:00
John Holiver 3a053c6cd3 Scripts/Trial of the Crusader:
1) Fix Leeching Swarm damage and create spell difficulty links to code. Closes  issue #4909 .
2) Fix Valkyr's Touch. Closes  issue #4553 .
3) Fix Permafrost aura difficulty check.
4) Reduce Slime Pool damage range.
5) Avoid Shaman Champion Heroism spam using 5 minutes (CD) as timer.
6) Fix many spell target selection to only select players (no more totens or pets).
7) Fix Anub'arak Spike being able to receibe the permafrost aura in order to cast spike fail, hopefully.
2010-12-31 06:01:01 +01:00
leak 1c244cced5 Core/Entities: Fixed disarming and related exploits
- Disarm shouldn't deduct stats other than weapon damage
- Ferals shouldn't be affected by disarm
- Fixed meta gem stacking exploit
2010-12-29 17:18:29 +01:00
Machiavelli 88fe1da9eb Core/Spells: Fix caster selection in aura´s of type 284 (SPELL_LINKED_AURA).
Huge thanks to QAston for the brainstorming session.

--HG--
branch : trunk
2010-12-27 23:56:41 +01:00
Machiavelli dd745ef326 Core/Vehicles: Some research on VehicleSeatFlagsB.
It is assumed that VehicleSeatFlagsB & 322 means the seat can be used indirectly (ie. by aura 236 (SPELL_AURA_CONTROL_VEHICLE)) even though !(VehicleSeatFlags & VEHICLE_SEAT_FLAG_USABLE).
More research to be done Soon (tm).

--HG--
branch : trunk
2010-12-27 16:55:17 +01:00
Shauren 2c1be8e182 Core/Auras: Prevent model changing when shapeshifted and restore transforms when changing out of shapeshift
Closes issue #4754.

--HG--
branch : trunk
2010-12-26 17:58:41 +01:00
Machiavelli 821c0f6c42 Core/Spells: Add dummy effect for Saronite Vapors (63322) (Used in General Vezax encounter)
Based on original code by Lopin

--HG--
branch : trunk
2010-12-26 16:25:40 +01:00
click 8fdbe7c4e6 Core/Spells: Update auraeffects for shapeshift forms with a few missing ones (kills off some more logspam as well)
--HG--
branch : trunk
2010-12-26 01:55:48 +01:00
click b181ba21d9 Core: Fix a few warnings here and there.
--HG--
branch : trunk
2010-12-25 06:28:38 +01:00
Shauren 928443d899 Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
--HG--
branch : trunk
2010-12-23 23:25:44 +01:00
Shauren b098c15674 Core/Auras: Removed pointless checks in SPELL_AURA_MOD_THREAT (10)
--HG--
branch : trunk
2010-12-23 19:58:00 +01:00
Machiavelli 392a312c6b Core/Spells: Fix SPELL_AURA_MOD_DAMAGE_PERCENT_DONE(79) to affect proper spellschools based on EffectMiscValue.
Author: Dr.Tenma
Fixes issue #4019
Fixes issue #5059

--HG--
branch : trunk
2010-12-23 16:22:30 +01:00
Shauren 0f3b9019a8 Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
--HG--
branch : trunk
2010-12-22 21:25:23 +01:00
Shauren 7b4e1c6387 Core/ObjectMgr: Static members are no longer accessed through singleton
--HG--
branch : trunk
2010-12-22 20:23:47 +01:00
Machiavelli 5e826806ba Core/Aura´s: Remove a redundant NULL check, because QAston saideth so.
--HG--
branch : trunk
2010-12-19 17:50:50 +01:00
linencloth 59da698189 Core: Rename spell attributes, use more general names
--HG--
branch : trunk
2010-12-19 05:15:47 +01:00
Machiavelli 837e50ea23 Core/Spells: Allow aura´s with SPELL_AURA_MOD_THREAT (10) to properly reduce threat modifiers on death.
Inspired by effort of james.gml
Fixes issue #3444

--HG--
branch : trunk
2010-12-19 00:38:35 +01:00
Shauren 43377b4daf Core/Players: Remove player from transport before teleporting to graveyard, will fix infinite recursion when trying to access unavailable map
Core/Auras: Removed unneeded typecasting

Closes issue #4862.

--HG--
branch : trunk
2010-12-19 00:01:22 +01:00
Shauren 24193966dd Core/Auras: Fixed crash in AuraEffect::TriggerSpell (dummy effect) and removed some useless code
Scripts/AI: Changed sOnDummyEffect to return bool value

Closes issue #5190.

--HG--
branch : trunk
2010-12-18 22:04:19 +01:00
Machiavelli 32d94ed52a Core/Units: Aura´s of type SPELL_AURA_MOD_RESISTANCE_EXCLUSIVE (143) should stack with eachother in the way that only the strongest aura of each magical school applies.
Author: Iskander
Fixes issue #3897

--HG--
branch : trunk
2010-12-17 20:31:46 +01:00
Shauren 3df2310417 Core/Auras: Fixed Festive Holiday Mount transformation (3.0.8 update)
--HG--
branch : trunk
2010-12-17 19:03:12 +01:00
Shauren 82f45966fc Core/Unit: Renamed addUnitState/hasUnitState/clearUnitState to AddUnitState/HasUnitState/ClearUnitState
Core/Vehicles: Allow the vehicle to always damage the passenger (removed unneded dbc hacks from scripts)

--HG--
branch : trunk
2010-12-17 13:43:24 +01:00
Machiavelli 5d887159c6 Core/Spells: Fix Power Word: Shield absorb amount after r5badab6d42.
(casting TotalAuraMultiplier to int32 effectively meant setting amount to 0)

--HG--
branch : trunk
2010-12-16 23:16:14 +01:00
Anubisss 6d9029c12e Make some cleanup.
My thank goes to Az@zel for the code analysis.

--HG--
branch : trunk
2010-12-16 18:08:23 +01:00
Shauren 58a9b15443 Core: Fixes some warnings
Core/SmartAI: Fixed DamageTaken and DamageDealt hooks

--HG--
branch : trunk
extra : rebase_source : 062f1c68cd1d318d192b294a493db17a1943bee2
2010-12-14 22:45:23 +01:00
click 2642894342 Core: Add new system for parallelizing client packet processing. Handle WorldSession updates in Map::Update() where we are safe to proceed. Patch by Ambal.
(And clean up tabs and whitespace while rummaging around in there)
Closes issue 5084.

--HG--
branch : trunk
2010-12-13 22:37:56 +01:00
azazel d2d62eab50 Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
NOTE: Initially I just wanted to fix some warnings, but noticed that there is no common method for percentage calculation and various formulas are used many time in the code making it difficult to read and understand what the code actually does. So, I introduced several template methods for calculating percent values and adding those values to the original base. I replaced all the raw calculations throughout the code where found, but I could have missed something or could have made a mistake. So, please report any strange behaviour after this commit.
If you ask me why I did it: for the sake of consistency and exact understanding what code means. If you see CalculatePct method, you clearly understand, that it find the value of x percent of y. And you can easily express, for example, spell behviour "reduces smth by x%" by the means of a method instead of recalling school maths.

--HG--
branch : trunk
2010-12-11 20:37:38 +06:00
azazel e7eb4e22e2 Core/Mechanics: cleanup shapeshift form code (by VladimirMangos)
--HG--
branch : trunk
2010-12-09 17:03:42 +06:00