Commit Graph
410 Commits
Author SHA1 Message Date
John Holiver 3a053c6cd3 Scripts/Trial of the Crusader:
1) Fix Leeching Swarm damage and create spell difficulty links to code. Closes  issue #4909 .
2) Fix Valkyr's Touch. Closes  issue #4553 .
3) Fix Permafrost aura difficulty check.
4) Reduce Slime Pool damage range.
5) Avoid Shaman Champion Heroism spam using 5 minutes (CD) as timer.
6) Fix many spell target selection to only select players (no more totens or pets).
7) Fix Anub'arak Spike being able to receibe the permafrost aura in order to cast spike fail, hopefully.
2010-12-31 06:01:01 +01:00
QAston 8cd2c73e45 Core/ScriptSystem: Add OnEffectManaShield and AfterEffectManaShield hooks to AuraScript class. Usage of these is the same as similar Absorb hooks.
Scripts: Move Incanter's Absorbtion script from Unit::CalcAbsorbResist to AuraScript.
2010-12-30 19:05:19 +01:00
QAston c8adcc95f9 Core/Unit: Move spell specific code from Unit::CalcAbsorbResist to AuraScripts. 2010-12-30 02:03:46 +01:00
leak 1c244cced5 Core/Entities: Fixed disarming and related exploits
- Disarm shouldn't deduct stats other than weapon damage
- Ferals shouldn't be affected by disarm
- Fixed meta gem stacking exploit
2010-12-29 17:18:29 +01:00
Machiavelli 88fe1da9eb Core/Spells: Fix caster selection in aura´s of type 284 (SPELL_LINKED_AURA).
Huge thanks to QAston for the brainstorming session.

--HG--
branch : trunk
2010-12-27 23:56:41 +01:00
click 464f1a9f8f Core: Kill off some warnings
--HG--
branch : trunk
2010-12-27 22:58:22 +01:00
Shauren 52620db629 Core/Auras: Fixed enchant proc stack rules
Closes issue #5222.

--HG--
branch : trunk
2010-12-27 22:27:11 +01:00
QAston ef968f4b15 Core/Unit: Big cleanup in Unit::CalcAbsorbResist
Core/AuraScript:
	Fix compile time check for AuraScript functions
	Remove AuraApplication from hook functions parameter list, use GetTarget() and GetTargetApplication() instead
	Add OnEffectAbsorb hook
Scripts: move handlers of Spell Deflection, Savage Defense, Primal Tenacity, Nerves of Steel, Astral shift from core to scripts.

--HG--
branch : trunk
2010-12-27 20:14:54 +01:00
Machiavelli dd745ef326 Core/Vehicles: Some research on VehicleSeatFlagsB.
It is assumed that VehicleSeatFlagsB & 322 means the seat can be used indirectly (ie. by aura 236 (SPELL_AURA_CONTROL_VEHICLE)) even though !(VehicleSeatFlags & VEHICLE_SEAT_FLAG_USABLE).
More research to be done Soon (tm).

--HG--
branch : trunk
2010-12-27 16:55:17 +01:00
Machiavelli bdc47053cc Core/Spells: Partial fix spells 62056, 63985 (Stone Grip Force Cast - Part of Kologarn encounter), underlying AuraEffect::HandleAuraControlVehicle will no longer prematurely return.
--HG--
branch : trunk
2010-12-27 14:53:47 +01:00
Machiavelli d951407822 Revert 0a95c34021 (thanks QAston for talking sense into me)
--HG--
branch : trunk
2010-12-27 11:06:53 +01:00
Machiavelli 299118cd3a Remove missing lines from previous commit, thanks click for pointing out.
(WTB Coffee)

--HG--
branch : trunk
2010-12-27 09:49:38 +01:00
Machiavelli d69a1c3629 Core/Spells: Fix SPELL_EFFECT_FORCE_CAST(140), SPELL_EFFECT_FORCE_CAST_WITH_VALUE(141). These should force the target to cast a certain spell, not serve as a proxy for the original caster to cast another spell.
--HG--
branch : trunk
2010-12-27 09:21:08 +01:00
Machiavelli 4a169412b7 Core/Spells: Implement 65594 (Cancel Stone Grip - Used in Kologarn encounter) spell
--HG--
branch : trunk
2010-12-27 09:19:06 +01:00
linencloth efbc73d025 Core/Player: Split RemoveQuest into 2 separate functions
--HG--
branch : trunk
2010-12-26 21:34:08 +01:00
linencloth 6b58081e63 Core/QuestStatus: Fix EffectQuestClear, also clear rewarded quests again
--HG--
branch : trunk
2010-12-26 21:18:22 +01:00
Shauren 2c1be8e182 Core/Auras: Prevent model changing when shapeshifted and restore transforms when changing out of shapeshift
Closes issue #4754.

--HG--
branch : trunk
2010-12-26 17:58:41 +01:00
Shauren f00a589b2a Scripts/Icecrown Citadel: Mutated Abomination should not damage its owner
Closes issue #5252.

--HG--
branch : trunk
2010-12-26 17:15:41 +01:00
Shauren 79070ca820 Scripts/Serpentshrine Cavern: Fixed "The Lurker Above" achievement and removed hacks for the event
--HG--
branch : trunk
2010-12-26 16:35:29 +01:00
Machiavelli 821c0f6c42 Core/Spells: Add dummy effect for Saronite Vapors (63322) (Used in General Vezax encounter)
Based on original code by Lopin

--HG--
branch : trunk
2010-12-26 16:25:40 +01:00
linencloth b150172521 Core/QuestStatus:
- Separate rewarded quests from active quests, and store them in a new table to reduce database size
- Drop the no longer needed `rewarded` column from character_queststatus for smaller table size
- Prevent filling the database with dropped quests
  - Delete useless records
- Implement queststatus save "queues" instead of states
- Minor optimizations

WARNING: Backup your database!

--HG--
branch : trunk
2010-12-26 04:16:18 +01:00
click 8fdbe7c4e6 Core/Spells: Update auraeffects for shapeshift forms with a few missing ones (kills off some more logspam as well)
--HG--
branch : trunk
2010-12-26 01:55:48 +01:00
QAston f4e46db38a Core/Auras: Add some asserions to hunt down reason of a crash in Aura::UpdateTargetMap. Thanks to Shauren for inspiration.
--HG--
branch : trunk
2010-12-26 00:14:13 +01:00
click b181ba21d9 Core: Fix a few warnings here and there.
--HG--
branch : trunk
2010-12-25 06:28:38 +01:00
click 088ed9404b Core/Entities: Fix a minor disrepancy in the handling of weapon specializations introduced in revision a83f26ef71 - patch by Dr.Tenma
Fixes issue 5059.
Fixes issue 5265.

--HG--
branch : trunk
2010-12-25 04:03:04 +01:00
Machiavelli d587948a0f Core/Spells: Use a workaround for Grab Crate, cast triggered spell with original caster as caster instead of target. Previous approach was prone to out of range errors.
Spell will now correctly restore 25 Pyrite energy (assuming aura 62495 is present to trigger the initial handler)

--HG--
branch : trunk
2010-12-25 03:18:21 +01:00
Shauren 928443d899 Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
--HG--
branch : trunk
2010-12-23 23:25:44 +01:00
Shauren b098c15674 Core/Auras: Removed pointless checks in SPELL_AURA_MOD_THREAT (10)
--HG--
branch : trunk
2010-12-23 19:58:00 +01:00
Machiavelli f3dd337c6a Core/Spells: Fix Glyph of Felhunter
Author: Lopin

--HG--
branch : trunk
2010-12-23 19:03:28 +01:00
Machiavelli 392a312c6b Core/Spells: Fix SPELL_AURA_MOD_DAMAGE_PERCENT_DONE(79) to affect proper spellschools based on EffectMiscValue.
Author: Dr.Tenma
Fixes issue #4019
Fixes issue #5059

--HG--
branch : trunk
2010-12-23 16:22:30 +01:00
Shauren 66b4c8003c Core/Spells: Removed a really retarded hack that searched for GameObject targets 50 yards further than it should
--HG--
branch : trunk
2010-12-22 23:04:05 +01:00
Shauren 0f3b9019a8 Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
--HG--
branch : trunk
2010-12-22 21:25:23 +01:00
Shauren 0948fc5bbe Core: Converted (hopefully) all remaining singletons to use ACE_Singleton class
--HG--
branch : trunk
2010-12-22 20:52:47 +01:00
Shauren 7b4e1c6387 Core/ObjectMgr: Static members are no longer accessed through singleton
--HG--
branch : trunk
2010-12-22 20:23:47 +01:00
Shocker 446c300505 Core/Spells: Small cleanup in SpellEffects, spells always have caster
--HG--
branch : trunk
2010-12-22 20:18:34 +02:00
Shocker 42304c0b25 Core/Spells: Implement SPELL_EFFECT_UNTRAIN_TALENTS, thanks to Heisenberg, closes issue #5238
--HG--
branch : trunk
2010-12-22 20:14:30 +02:00
leak 6115b0bd5f Removing ProgressBars as they are performing badly on startup.
[**************************************************] 100%
R.I.P

--HG--
branch : trunk
2010-12-22 00:12:03 +01:00
Shauren 5809c1fa3b Core/Auras: Fixed auras incorrectly stacking with different item casters introduced in r19f21916a940
Closes issue #5218.

--HG--
branch : trunk
2010-12-21 11:40:20 +01:00
Shauren 756ee5832b Core/Auras: Allow stacking of auras proced from different items
Closes issue #2296.

--HG--
branch : trunk
2010-12-20 11:04:48 +01:00
Machiavelli baff745be1 Core/Spells: Fix Improved Felhunter mana energize part.
Based on code by Karolis.Rudzevicius
Fixes issue #2125
Fixes issue #2109

--HG--
branch : trunk
2010-12-20 00:35:11 +01:00
QAston 251f7f2121 Core/Auras: Add some assertions to make sure that AuraEffects are not added twice to UnitAuraEffect containers.
--HG--
branch : trunk
2010-12-19 19:43:53 +01:00
Machiavelli 5e826806ba Core/Aura´s: Remove a redundant NULL check, because QAston saideth so.
--HG--
branch : trunk
2010-12-19 17:50:50 +01:00
leak fd694cd232 Streamlining loading functions for server startup
- Added a couple of timer outputs
- Improved code consistency between loading functions
- Progess bars should look and behave similar on all OS now (sLog.outString() is not needed anymore to replace the progress bar in log files)

--HG--
branch : trunk
2010-12-19 17:06:33 +01:00
linencloth 59da698189 Core: Rename spell attributes, use more general names
--HG--
branch : trunk
2010-12-19 05:15:47 +01:00
Machiavelli 837e50ea23 Core/Spells: Allow aura´s with SPELL_AURA_MOD_THREAT (10) to properly reduce threat modifiers on death.
Inspired by effort of james.gml
Fixes issue #3444

--HG--
branch : trunk
2010-12-19 00:38:35 +01:00
Shauren 43377b4daf Core/Players: Remove player from transport before teleporting to graveyard, will fix infinite recursion when trying to access unavailable map
Core/Auras: Removed unneeded typecasting

Closes issue #4862.

--HG--
branch : trunk
2010-12-19 00:01:22 +01:00
Shauren 7196b880d6 Core/Spells: Fixed possible crashes in Shadow's Fate proc (71169) introduced in r91073dc6ace3
Core/AuctionHouse: Removed "using namespace std" and fixed crash in AuctionHouseMgr destructor

Closes issue #5132.
Closes issue #5134.

--HG--
branch : trunk
2010-12-18 23:16:55 +01:00
silinoron f339ced1bf merge
--HG--
branch : trunk
2010-12-18 13:07:15 -08:00
silinoron 41a9d3216c Core/Auras: Fix Cold Blood handling on misses and parries.
Patch by dr.tenma.
Fixes issue #2291

--HG--
branch : trunk
2010-12-18 13:06:38 -08:00
Shauren 24193966dd Core/Auras: Fixed crash in AuraEffect::TriggerSpell (dummy effect) and removed some useless code
Scripts/AI: Changed sOnDummyEffect to return bool value

Closes issue #5190.

--HG--
branch : trunk
2010-12-18 22:04:19 +01:00