Commit Graph
35961 Commits
Author SHA1 Message Date
Ovah 2dda5fb477 Scripts/MGT: Kael'thas intro can now be skipped when not killing the trash pack in his room
Scripts/MGT: Kael'thas will now despawn at evade

Cherry picked from
https://github.com/Ovahlord/TrinityCore/commit/f6e9ff5ca4ed1a174052b350db0802e1fca9a1aa
https://github.com/Ovahlord/TrinityCore/commit/ed8c1830f58e0b9db629bbae9ee80f8ad76331e5

(cherry picked from commit c10c8c6bba27625e49016de8c1a1cc9fa7944fa5)
2021-11-23 23:17:08 +01:00
Shauren 7a413ae543 Core/Spells: Fixed spells using MovePositionToFirstCollision for selecting target position getting Z coord offset by caster or target collision height (depending on spell target type)
(cherry picked from commit d63d15c505708d175c52d87afc76cbe4ac59497b)
2021-11-23 23:16:49 +01:00
Keader dba7e2507f Scripts/Illidan: Fixed Parasitic shadowfiends reproducing like rabbits
(cherry picked from commit a617cc40977b7b019f79a198daebede90c59f5c1)
2021-11-23 23:16:43 +01:00
jackpoz ef04a26bf4 Core/Pet: Add assert
Add additional assert to check if it's possible for a Pet not to have an active AI when the Player owner kills an enemy.
Ref #23036

(cherry picked from commit 43dec9e4d0b6f7da3c2051624742e9fb8a9bcb31)
2021-11-23 23:10:45 +01:00
Heaven31415 0ea3fe545c Refactor SendSysMessage, SendGlobalSysMessage, SendGlobalGMSysMessage (#23029)
(cherry picked from commit 9db50f05cb7d225f3bd7b2a209509a072f915fd3)
2021-11-23 23:07:23 +01:00
Sorikoff ee0662ca3d Scripts/Scarlet Enclave: Stable Master Kitrik's spell Repo (#23023)
(cherry picked from commit f0f4d0280daf81a841c30332f608f7acdfb1f374)
2021-11-23 23:04:34 +01:00
Killyana 2f21c11979 DB/SAI: Shoveltusks
Closes #23040
Closes #23041

(cherry picked from commit 7dc893fcf228b09eba789c7e48c41e1b64019b29)
2021-11-23 23:03:02 +01:00
Shauren c14cf5a892 Core/Misc: Added lambda support to EventProcessor
Closes #22909

(cherry picked from commit 813f693768ee94864b0d24423b9265bde2c9903d)
2021-11-23 23:01:47 +01:00
Giacomo Pozzoni ed5ba915f1 Core/Scripts: Change PlayerScript and CreatureScript inheritance (#23048)
Remove UnitScript from PlayerScript and CreatureScript classes as that's how the original system that was PR'd worked, see https://github.com/TrinityCore/TrinityCore/pull/7867 for reference.
Please note these are used as global hooks and should really just invoke stateless functions.
If you need to hook methods from PlayerScript/CreatureScript and UnitScript, just define 2 different scripts (this is how the original system worked and how it was designed to work)

(cherry picked from commit 5b7ead65bb116195f4336934bcff830e1b2af5bb)
2021-11-23 22:54:24 +01:00
TheWinchesters 47adf2e4c8 [3.3.5] Commands: lookup player shows which character is online (#23039)
* Show 'online' for every online player in lookup player commands

(cherry picked from commit a0056951f7e425341760ebf3a7770477ef7f4446)
2021-11-23 22:52:53 +01:00
Giacomo Pozzoni 31dca39c05 3.3.5 threat assert (#23034)
* Core/Creature: Change assert about Threat to log

(cherry picked from commit cb8ff7976b1419c6a1334bb49783480d543aff16)
2021-11-23 22:48:39 +01:00
Giacomo Pozzoni 24f9b41622 Shared/Utilities: Handle string format exceptions
Handle StringFormat() exceptions in case of malformed string format to avoid causing unhandled exception crashes

(cherry picked from commit c79811de4fbf2b22cd74f55853516c7fc307055f)
2021-11-23 22:48:28 +01:00
Aokromes 95b8c9df84 Misc/Extractor: Clarify a bit
(cherry picked from commit 58c5dfac1d8d314b9243fde52466b3c933fb7d7f)
2021-11-23 22:48:17 +01:00
Rushor bc3dc38d17 Creature/Script: Move "Bartleby" script to SAI
(cherry picked from commit d69ef2ab1d0ecc0f32436b978137c89a0bc86a02)
2021-11-23 22:48:03 +01:00
Killyana 254df28c1e DB/Creature: Add night spawns for Dwarf mounts
(cherry picked from commit 59682bbd9b333a8e6dbfd3c6884b16afdb510197)
2021-11-23 22:45:32 +01:00
jackpoz b0703f943c Core/MMaps: Change infinite loop fix in Detour
Change the infinite loop fix in Detour to allow looping through all the m_nodePool nodes max once, otherwise it most likely means that we entered an infinite loop. This is currently set to 1024.

(cherry picked from commit 12e6faa0fa0cf389bcebd4a6f2220e71c697250c)
2021-11-23 22:29:58 +01:00
Aokromes 2682bf0fca Core/Misc: Add categories to 3 logs
(cherry picked from commit 2d22c027fe0df505ddc63d4faaad032cddd5e258)
2021-11-23 22:29:21 +01:00
Aokromes f5827770fc Core/Spells: Add categories to 2 logs
(cherry picked from commit 1cba3633606291823dc0184ac4bca8fced8fefcd)
2021-11-23 22:29:01 +01:00
Aokromes c5720e37c1 Core/Entities: Add categories to 2 logs
Closes #22922

(cherry picked from commit 578c796625859656b788565378250f783a348b09)
2021-11-23 22:28:38 +01:00
jackpoz 23489568db Core/MMaps: Fix infinite loop in Detour
Fix an infinite loop in Detour happening in Dalaran Sewers.
This is more of an emergency patch until we figure out why dtNodes have a circular reference (A -> B -> C -> A) happening quite often in this place

(cherry picked from commit c8ec2dd95d07e3eec00027cdb9605529a49d6475)
2021-11-23 22:28:28 +01:00
Killyana cefd1f94d7 DB/Creature: Add invisibility auras related Roanauk Icemist
(cherry picked from commit 3a83dc60d5bde02312c4efe5c59506fe2d5ca8b8)
2021-11-23 22:27:15 +01:00
Killyana 15e844b854 DB/Quest: The Might of the Horde
Add missing texts and despawn action

(cherry picked from commit 7514c3106d2fb9c97dede837e3e53d638dfca998)
2021-11-23 22:26:07 +01:00
illfated 98be760151 DB/Creature: Warsong Battle Standard
Closes #23024

(cherry picked from commit 6443dee2868de47576c3f5a0ec6bc16859880079)
2021-11-23 22:25:36 +01:00
jackpoz 3ddbf02dc7 Core/Misc: Fix issues reported by static analysis
Fix issues reported by Coverity Scan

(cherry picked from commit 2fda1572d214d0b114e0291106363f49c2d3179e)
2021-11-23 22:20:39 +01:00
jackpoz 9807f32334 Core/Misc: Fix issues reported by dynamic analysis
Closes #23021

(cherry picked from commit 9942047c721110b4d2135028ec4c17060e0301bc)
2021-11-23 22:19:06 +01:00
Killyana aa9b86a90e DB/Misc: Plaguelands: The Scarlet Enclave
From https://github.com/cmangos/wotlk-db/commit/8c647dcfb8241b94365669edd240be6a379192c5
By Grz3s

(cherry picked from commit b54b372a39d2852402b8663b9bd2404176a426b5)
2021-11-23 22:18:49 +01:00
Killyana f6a89f4b42 DB/Creature: Fix phase for one Scourge Necromancer spawn
(cherry picked from commit 42edba699dc8f47084756a4e3ab7d85ea96e81fb)
2021-11-23 22:01:48 +01:00
jackpoz 927e62e88e Core/Group: Fix memory leak
Fix memory leak happening when disbanding a group with an ongoing roll.
Please note this is not blizz-like but at least we don't leak memory anymore.

(cherry picked from commit f04e90f638425c0e0ef2e40f0cd29ab7eec625d1)
2021-11-23 21:28:23 +01:00
Sorikoff fc9106054b Scripts/Scarlet Enclave: Grand Theft Palomino (#22967)
* Grand Theft Palomino

* Cosmetic issues

* Address CR

(cherry picked from commit d5f565f42992d5142b30c7fbd694f8a5b1245f4c)
2021-11-23 21:28:03 +01:00
Chaouki Dhib 4507a02ada Core/Movement: Implement move time skipped handler (#22994)
* Implement CMSG_MOVE_TIME_SKIPPED handler and move it to MovementHandler.cpp

* Add better error handling

* Update MovementHandler.cpp

(cherry picked from commit f9ed72e351ecdafe77da2036d9fd68e46da2f3ab)
2021-11-23 21:18:07 +01:00
jackpoz e475cac631 Core/Spells: Fix assert triggered
Fix assert triggered when a spell would trigger another spell in OnEffectHitTarget that would kill the aura owner, then processing the main spell effects. The triggered spell can kill the aura owner, changing its death state to CORPSE and removing auras created.

Fix #21856
Ref 518e6299ca08a362bc3709daaaa5e5d5633d1bf1

(cherry picked from commit 46c7446bd4ef606b1091c1582df50e027fab28b6)
2021-11-23 20:47:31 +01:00
Sorikoff 31f4bb1436 DB/Quest: Sniff Out the Enemy
Closes #23006

(cherry picked from commit 806dd940cec8352cc3a619b9cab39c95d7b86e59)
2021-11-23 20:46:27 +01:00
Killyana 13aef5574b DB/Creature: Fix Saviana Ragefire movements
Closes #18773

(cherry picked from commit b1604ba0cd6db77cf168f957e828984811735bc1)
2021-11-23 20:44:33 +01:00
Killyana a482f97a5a DB/Creature: Fix Val'kyr Herald movements
Closes #23004

(cherry picked from commit a19c21d4eb55a630f6c3fbde34c9fe0172aec114)
2021-11-23 20:42:38 +01:00
Killyana ce6a6acc5c DB/Creature: Fix some spawns in Ogri'la
(cherry picked from commit 9c6e838083f1b7f7941187b866209e1d51f0f90b)
2021-11-23 20:40:46 +01:00
Killyana 4cdecf0076 DB/Quest: Improvements for "Bombing Run"
(cherry picked from commit 9d37d395119a805ee05daaf41485b591d613d744)
2021-11-23 20:38:24 +01:00
Killyana ffa427b7e4 DB/Creature: Remove Priestess Tyriona wrong spawn
(cherry picked from commit 6679e3010eb5fe773f5d6ebe0d1f7c50571feaba)
2021-11-23 20:35:29 +01:00
Killyana 8d13e41bf2 DB/Spell: Freezing Circle
Updates #11312

(cherry picked from commit 3432edf3dc1b6bda671c18b8baa40b9bdf0d824b)
2021-11-23 20:34:37 +01:00
Killyana d410971d89 DB/Creature: Blockade Cannon and blockade pirate
Closes #22489
By illfated and ZenoX92

(cherry picked from commit e21a1a68250b7e3d10031c26aa294641b034ffc9)
2021-11-23 20:33:09 +01:00
Sorikoff aeb614a21a DB/SAI: Gjalerbron
Closes #22961

(cherry picked from commit d8572e1fb804f6e8c1f794a9f0c94d84cb13bb2b)
2021-11-23 20:32:20 +01:00
Keader 084491669e Scripts/Magister Terrace: Fixed a enum mistake
(cherry picked from commit 33b0654f8eb7aedf2a5a7d6b88f222ce31d20331)
2021-11-23 00:40:07 +01:00
Keader cfd0e18b81 Core/Misc: Fixed shaman elementals and magister terrace first boss access
(cherry picked from commit 6545cd33b91468de7c1b4beb77cdeb4ecb77f501)
2021-11-23 00:39:59 +01:00
Keader 4a943fd3d2 Scripts/Utgarde Keep: Fix Ingvar Evading (again)
UNIT_FLAG_NON_ATTACKABLE makes ingvar become a invalid target and lose threatlist, so me->IsThreatened() will return false.
We dont need it at all, since UpdateAI will handle evade already.

(cherry picked from commit 71dde16ce9a9c7904a2902ae288b3f05851224ac)
2021-11-23 00:39:17 +01:00
Keader 5c48cac6f9 Scripts/Temple of Ahn Qiraj: Scripted doors of AQ40
Doors added in https://github.com/TrinityCore/TrinityCore/commit/1ba09572b5a49d5cd247cdca47109d3325ec12f3

(cherry picked from commit 06078e30c6f1d6e2ab1dcecbba15127b07b32bb7)
2021-11-23 00:39:17 +01:00
Ovah 3027458338 Scripts/Magister Terrace: Update InstanceScript and more fixes
Cherrypicked of https://github.com/Ovahlord/TrinityCore/commits/4.3.4

(cherry picked from commit 1b346485e40ddee958c116579d93bcff063021a5)
2021-11-23 00:39:13 +01:00
Ovah 3847d7b277 Scripts/Magister Terrace: Felblood Kaelthas rewrite
Cherrypick of https://github.com/Ovahlord/TrinityCore/commit/ae440400aaf90de11cf92010839ab98a8403c003

(cherry picked from commit 00958c9178781ac11a9dcabd034ed2e82120fad6)
2021-11-23 00:21:42 +01:00
Keader 4af2894626 Scripts/Black Temple: Mother Shahraz fatal attraction need be random
Higher distance showed in my sniffs is 48 yards (rounding 50 yards). If someone find more then that, please let me know.
Ty killerwife

(cherry picked from commit fd69c133b10e289167f34438cb34fb5d4a141b4c)
2021-11-22 23:57:54 +01:00
Keader c3210798f0 Scripts/Black Temple: Fixed some issues in Illidari Council
Ty killerwife for all help :)

(cherry picked from commit ef6240312ceb08f253a492db88eebd182925211f)
2021-11-22 23:57:19 +01:00
jackpoz 3f4bedd803 Tools/MMaps: Allow to specify different Recast settings for different maps
Allow to specify different Recast settings for different maps, currently handled in GetMapSpecificConfig() as a switch statement.
Set walkableRadius to 0 in Blade's Edge Arena (Map ID 562) so the pets can walk on the thin rope between the bridge and the pillar.

(cherry picked from commit e4658a1307b1d52a4e6a0ed67f7dff92f02c090d)
2021-11-22 23:54:43 +01:00
Shauren 7b11d17f49 Core/Players: Load faction change items from db2 instead of db 2021-11-22 23:54:14 +01:00