Commit Graph
100 Commits
Author SHA1 Message Date
Shauren 1b6eea7eee Core/Spells: Fixed Reign of the Dead/Unliving trinket, patch by un.spike
Closes issue #3661.

--HG--
branch : trunk
2010-09-05 14:03:29 +02:00
Shauren 1863960da8 Core/Spell: Fixed Escape artist, patch by Heisenberg
Closes issue #3536.

--HG--
branch : trunk
2010-09-05 13:59:49 +02:00
Shauren 14c8fa4925 Core/Spells: Fixed Nevermelting Ice Crystal trinket
--HG--
branch : trunk
2010-09-05 13:39:10 +02:00
Shauren d42cfb6aa6 Core/Battlegrounds: Fixed scoreboard packet (and possible core crash) for TBC arenas, thx Maxdestroyer for pointing it out
--HG--
branch : trunk
2010-09-05 12:38:52 +02:00
Shauren 51eac1215c Scripts/Forge of Souls: Bronjahm should only cast Spirit Bolts if tank is not within melee range during phase 1, patch by Ottowayne
Closes issue #3657.

--HG--
branch : trunk
2010-09-05 12:22:08 +02:00
Shauren 0b743795d6 Core/Spells: Implemented aura type 303 (SPELL_AURA_MOD_DAMAGE_DONE_VERSUS_AURASTATE), patch by Azuritus
Closes issue #3773.

--HG--
branch : trunk
2010-09-05 12:05:49 +02:00
Shauren b39a21b795 Core/Spells: Check correct Attributes field in CanSpellPierceImmuneAura, patch by Maxdestroyer
Closes issue #3785.

--HG--
branch : trunk
2010-09-05 11:33:35 +02:00
Shauren 67c37b37cc Core/Battlegrounds: Added sanity checks for bg scoreboard packet handler, should fix client crashes in AV, thx Timothy003 for research
Closes issue #2165.

--HG--
branch : trunk
extra : rebase_source : b12e4ccf42d0d38064f1694242461eb0d9ad1605
2010-09-05 11:24:43 +02:00
Machiavelli 1608ebf7bf Core/DBLayer: Move some syncrhonisation error prone methods into the guarded scope in MySQLConnection:Execute(PreparedStatement*)
--HG--
branch : trunk
2010-09-05 10:34:46 +02:00
Shocker f769e88f5c Core/Commands: Implement possibility to unbind specific maps/difficulties with .instance unbind, based on svetilo12's idea, closes issue 3792
--HG--
branch : trunk
2010-09-05 04:03:02 +03:00
Shocker adf1ae6286 Cleanup: Some typo fixes, closes issue 3798, thanks tru.bazoozoo and Lopin
--HG--
branch : trunk
2010-09-05 00:48:31 +03:00
Shocker d4763852cf Core/Unit: Fix some health-related calculations by adjusting maximum size to 64 bit integers, closes issue 3778
--HG--
branch : trunk
2010-09-05 00:38:19 +03:00
Shauren 481c1fedd3 Core/Spells: Fixed Scent of Blood removal
SQLs: Fixed typo in previous revision

Closes issue #2668.

--HG--
branch : trunk
2010-09-04 23:09:46 +02:00
Shauren b4b8acf457 Core/Spells: Fixed Rune of Cinderglacier removal
Closes issue #2105.

--HG--
branch : trunk
2010-09-04 22:58:54 +02:00
silinoron 2dae023649 Core/[Mail, WorldPacket]: Pull mail packet handlers out of Mail.cpp into MailHandler.cpp
Core/ScriptSystem: Remove unneeded TODO.

--HG--
branch : trunk
2010-09-04 13:46:01 -07:00
azazel f500ef201b Scripts/Texts:
* fix script texts in various locations (thanks TerrorBringer for the heads up). Closes issue #2055. Closes issue #3087.
* cleanup world_script_texts.sql file (remove spaces, order entries)
Scripts/Misc:
* remove obsolete random seed initialization from scripts
* fix some warnings in scripts
* some cleanup in chat_log.cpp

--HG--
branch : trunk
2010-09-05 02:16:58 +06:00
silinoron 0f997162ee Core/ScriptSystem: Refactor ScriptMgr::OnPlayerChat to no longer accept a C-style parameter of type void*.
Instead, use overloaded methods for the different types.

--HG--
branch : trunk
2010-09-04 12:49:39 -07:00
Shauren 0f9fe8dbeb Core/Players: Don't set instanceId to 0 when player is on transport during loading, there CAN be transports inside instances
Core/Scripts: Added waypoint id to OnRelocate transport hook
Core/Scripts: Make use of ZoneScript::GetGameObjectEntry at gameobject creation (makes it possible to override gameobject entries in instances)
Core/Transports: Call InstanceScript::EventInform for transport events
Core/Transports: Use guid from db for transports, not just its entry - adds partial support for instancing them (still cannot use transports table for it, but can spawn manually now)
Scripts/Icecrown Citadel: Fixed crash in Deathbringer Saurfang when event is started by more than one person (can't do this anymore)

Closes isssue #3749.

--HG--
branch : trunk
2010-09-02 10:40:32 +02:00
Machiavelli 320cd16f20 Core/ArenaTeam: Correct player_divider use in ArenaTeam::GetAverageMMR and add a sanity check
--HG--
branch : trunk
2010-09-04 18:11:36 +02:00
Machiavelli e3957bd6de DB-Schema/Characters: Store game_event_save.next_start as unix timestamp and remove runtime typecasts for this field.
--HG--
branch : trunk
2010-09-04 18:01:03 +02:00
Machiavelli a9ca3d5ed1 Core/ArenaTeam: Add a check to determine if a player is account for an accurate calculation of ArenaTeam::GetAverageMMR
Fixes issue #3789

--HG--
branch : trunk
2010-09-04 17:39:23 +02:00
Machiavelli f19d7c2ec7 Core/WorldRunnable: Convert the last part of autobroadcast (interval config) to Trinity standards (proper caching) as well. Patch by [email protected].
Closes issue #3796

--HG--
branch : trunk
2010-09-04 17:27:28 +02:00
Machiavelli 27c00a8cbb Core/DBLayer:
- Allow transactions to contain both raw ad-hoc queries and prepared statement elements
* When coding on high level code, just make sure you use the right argument type for Transaction::Append and the proper execution will be done automagically

--HG--
branch : trunk
2010-09-04 16:49:23 +02:00
Machiavelli fd1c6c5440 Core/DBLayer: Add an assert in TransactionTask::Execute to make sure valid queries are held
Core/Logging: Tiny cleanup in sLog.outSQLDriver

--HG--
branch : trunk
2010-09-04 16:06:04 +02:00
Shocker 94b59b4f0e Fix encoding for a previous core sql file
--HG--
branch : trunk
2010-09-04 16:47:57 +03:00
Supabad a0585adb37 Scripts/Ulduar: Ulduar Teleporter
- add check for formation grounds thanks to silentstormpt
- fix gossip for ulduar teleporter

--HG--
branch : trunk
2010-09-04 15:42:43 +02:00
silinoron c05d0722f4 Core/Game: forgotten changes from r3cc82905662712385f0d03895a426310e6cc96bd
--HG--
branch : trunk
2010-09-03 22:40:16 -07:00
silinoron 5179d3149a Core/Game: Fix remaining warnings on windows (and most likely almost all of the ones on *nix)
--HG--
branch : trunk
2010-09-03 21:55:57 -07:00
silinoron 1e1c596dda Core/WorldPacket: Fix the core spamming complaints about CMSG_QUEST_QUERY being sent post-logout
Core/Spells: A little bit of "cleanup"

--HG--
branch : trunk
2010-09-03 20:30:29 -07:00
silinoron d2c259fe76 Core/ScriptSystem: Add a PlayerScript::OnSpellCast(Player *player, Spell *spell, bool skipCheck) function.
Requested by Zor.

--HG--
branch : trunk
2010-09-03 19:58:16 -07:00
click 128c60c84a Core/PetAI: Add additional safeguard against possible crash if me->GetCharmerOrOwner() is NULL in agressiontest
Patch by JacB667. Fixes issue #3766.

--HG--
branch : trunk
2010-09-03 22:47:03 +02:00
azazel 7884fd927a Spell Scripts:
* moved some generic spell dummy effects to scripts
* implemented two spell scripts for quests: 8913 Sacred Cleansing (Quest 55), 44936 Quest - Fel Siphon Dummy (Quest 11515). Closes issue #3040
* did some cleanup in spell scripts and added more comments

--HG--
branch : trunk
2010-09-04 02:33:57 +06:00
click d4e2fdad78 Core/Worldpacket: Correct size of SMSG_AUTH_RESPONSE (thanks to Ramus for orig patch, and svetilo for notification)
--HG--
branch : trunk
2010-09-03 22:14:42 +02:00
Shauren 8f1d660a4b Core/Dungeon Finder: Added missing check in previous revision and moved RewardDungeonDoneFor to proper place in the file
--HG--
branch : trunk
2010-09-03 20:25:03 +02:00
Shauren d5115ca687 Core/Dungeon Finder: Added support for rewards for random dungeons
Core/Quests: Simplified rewarding money from quests, now ModifyMoney and UpdateAchievementCriteria are called only once per quest
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_USE_LFD_TO_GROUP_WITH_PLAYERS

--HG--
branch : trunk
2010-09-03 20:11:14 +02:00
Machiavelli d7f9cea305 Core/WorldRunnable: Convert autobroadcast to trinity standards (properly cache configs, change function name to better reflect purpose)
--HG--
branch : trunk
2010-09-03 18:29:35 +02:00
Shocker ee83ffdfca Fix snake's HP for hunter's Snake Trap
--HG--
branch : trunk
2010-09-03 19:04:32 +03:00
Machiavelli 5469af3775 Core/DBLayer: Add an assert to detetct calls to invalid prepared statements.
--HG--
branch : trunk
2010-09-03 17:30:23 +02:00
Shocker d207f0d9a5 Fix compilation, thanks tru.bazoozoo, closes issue 3778
--HG--
branch : trunk
2010-09-03 16:56:17 +03:00
Machiavelli 273679c5ba Core/DBLayer
- Store threadbundlemask internally per database pool and prevent direct access to config file post startup
- Fix threadbundlemask flag checking for ReactorRunnable, WorldRunnable
- Remove CLI threadbundlemask flag, CLI doesn´t need a seperate mysql connection nor thread
- Remove unused Character Database connection from WorldSocketMgr / ReactorRunnable
- Add proper LoginDatabase connection to RA Runnable (soon to be overhauled)

Note: still experimental and not tested for live use

--HG--
branch : trunk
2010-09-03 10:52:32 +02:00
Shauren 277f2674ac Core/Tickets: Fixed lag report db saving query
--HG--
branch : trunk
2010-09-03 09:58:26 +02:00
Machiavelli 387ee751a9 Core/DBLayer
- Add some small documentation on prepared statement defines naming contention (placed in the 3 database implementation header files so it can´t be missed)
- Remove obsolete mutex declaration in DatabaseWorkerPool (was unused as of recently)

--HG--
branch : trunk
2010-09-03 09:21:28 +02:00
runningnak3d a15c45808c Core/Build: Fix non-PCH compile for Linux (don't know about Windows)
--HG--
branch : trunk
2010-09-02 17:55:55 -06:00
runningnak3d 7433768a55 Core/Build: Partial work of fixing non-PCH Linux compile
--HG--
branch : trunk
2010-09-02 17:19:53 -06:00
Machiavelli 7982cc0f7d Core/DBLayer:
- A few prepared statement implementations in authsocket as example.
- Add an ASSERT in MySQLConnection::Execute(PreparedStatement*) to catch faulty created statements

--HG--
branch : trunk
2010-09-03 01:00:49 +02:00
Machiavelli 2c1c391597 Core/DBLayer:
- Example implementation of prepared statement in ObjectMgr::SaveCreatureRespawntime
- #include "MYSQLThreading.h" -> #include "MySQLThreading.h" (*really* fixes Linux build)

--HG--
branch : trunk
2010-09-03 00:44:27 +02:00
Machiavelli 1e8a294659 Missing include from previous rev.
--HG--
branch : trunk
2010-09-03 00:08:20 +02:00
Machiavelli 39027133e4 Fix Linux build
--HG--
branch : trunk
2010-09-03 00:04:14 +02:00
Shauren e25846a08e Core/Spells: Fixed crash in EffectFeedPet
Closes issue #3728.
Closes issue #3752.

--HG--
branch : trunk
2010-09-02 22:04:08 +02:00
Machiavelli 1198591bac Core/DBLayer:
- Add basic prepared statement interface (without implementation and thus without testing, without resultset support).
- Based on raczman/Albator´s work on TrinityCore3

Build:
- Add sLog define ¨hack¨ in DatbaseWorkerPool.h to fix some more sLog errors temporarily

FYI: Builds on windows

--HG--
branch : trunk
2010-09-02 20:54:43 +02:00
Shauren cd182a1e8f Fixed build
Fixed wrong header includes in new database files, thx Thyros

--HG--
branch : trunk
2010-09-02 20:22:19 +02:00
Shauren e9ff90a967 Fix *SOME* build errors
--HG--
branch : trunk
2010-09-02 18:20:59 +02:00
Machiavelli c47f45694f Core/DBLayer: Add Login-/Characters-/Worlddatabase class implementations
--HG--
branch : trunk
2010-09-02 17:56:49 +02:00
Machiavelli 5ef738c16e Core/DBLayer:
- Better way to shutdown worker thread, prevents a crash. Fixes issue #3696
- Delete missing file from previous rev

--HG--
branch : trunk
2010-09-02 17:55:03 +02:00
Machiavelli 0117af4c37 Core/DBLayer:
- Implement deriviate classes of MySQLConnection for every database type (world, realm, characters)
- Make DatabaseWorkerPool templatized and use the above mentioned classes as parameter
- Implementation of the new types in code
(This is in preparation of prepared statement interface)

--HG--
branch : trunk
2010-09-02 17:47:50 +02:00
runningnak3d 39f901d566 SQL: add exploration base XP date for levels 71-79. Patch by Svannon
--HG--
branch : trunk
2010-09-02 08:56:18 -06:00
Machiavelli d2edf39feb Core/DBLayer: Remove as of recent redundant DatabaseWorkerPoolEnd operation
--HG--
branch : trunk
2010-09-02 16:45:33 +02:00
Shocker 55c54c9ad2 Database/Table: Forgotten data from previous commit regarding auctionhousebot removal
--HG--
branch : trunk
2010-09-02 17:43:27 +03:00
Shocker c8cf877d1a Merge
--HG--
branch : trunk
2010-09-02 17:40:24 +03:00
Shocker 661cd04c27 Remove auctionhousebot from base too
--HG--
branch : trunk
2010-09-02 17:37:32 +03:00
Shocker 0e865c9f72 Break monstrous lines from world_database.sql into multiple lines, once for each row
--HG--
branch : trunk
2010-09-02 17:30:40 +03:00
Brian a32528f8d1 Database/Table: drop unused auctionhousebot table.
--HG--
branch : trunk
2010-09-02 08:30:24 -06:00
Shocker 0c4c139b94 * Allow Waylay to proc from Backstab too (also remove PROC_EX_CRITICAL_HIT flag, invalid), closes issue 3009.
* Small filename typo fix

--HG--
branch : trunk
2010-09-02 16:48:03 +03:00
Shauren 15880d27ea Core/Spells: Fixed Health Leech effect, should not apply healing multiplier to damage done
--HG--
branch : trunk
2010-09-02 15:34:36 +02:00
Shocker ee31212cd5 Glyph of Prayer of Healing shouldn't benefit from spell power, thanks arielazuz (Fixes issue 2827)
--HG--
branch : trunk
2010-09-02 16:32:30 +03:00
Shocker 21313bec57 Missing data from spell_threat for various Warrior abilities, closes issue 2258, thanks maeh.sheep for collecting data. Most of the values are blizzlike, but since some of them are variable depending on AP/damage, we're using general increase for those based on previous ranks
--HG--
branch : trunk
2010-09-02 16:24:08 +03:00
Shocker 8331da627d Some old typo fixes, closes issues #3747, #2756, #2607, thanks 2010phenix/jean-michele.nefen/toshik.777
--HG--
branch : trunk
2010-09-02 15:25:02 +03:00
Shocker c8dfbdac35 Conflagrate direct & DoT damage shouldn't scale with duration increases of Immolate/Shadowflame, fixes issue 3376.
--HG--
branch : trunk
2010-09-02 06:02:51 +03:00
Shocker 96765bc6e0 creature_respawn should be InnoDB since it's prone to continuous writes
--HG--
branch : trunk
2010-09-01 17:03:43 +03:00
Spp 90a2e23a97 SQLS/Creation: Fix default engine for tables in world and characters
--HG--
branch : trunk
2010-09-01 12:51:35 +02:00
azazel b2a49ad79a Scripts/Blackrock Depths: fix spectral chalice spawning for quest with the same name (thanks niksad8). Closes issue #3086. Closes issue #2989.
--HG--
branch : trunk
2010-09-01 10:40:44 +06:00
silinoron 80df469a38 Oooh, C++... How I love you.
--HG--
branch : trunk
2010-08-31 17:41:18 -07:00
click 64d77369fc Docs: Update UnixInstall with the current list of CMake parameters
--HG--
branch : trunk
2010-09-01 01:07:20 +02:00
Shocker 4e067dd313 Add LoS check for melee autoattacks, fixes issue 3535
--HG--
branch : trunk
2010-09-01 01:16:43 +03:00
John Holiver 3a765da2fa Small fix to Chimera Shot Serpent dmg and Scorpid CD.
Thanks to Arcane.

--HG--
branch : trunk
2010-08-31 19:13:59 -03:00
Shocker 6d64365e8f Allow Immolate DoT ticks to critically hit, fixes issue #1932
--HG--
branch : trunk
2010-09-01 00:38:13 +03:00
Shauren 6c3b39ac01 Scripts/Icecrown Citadel: Added Festergut script, thx Cromash for providing the base and Cyrax for sniffs
Scripts/Icecrown Citadel: Added Professor Putricide script handling ONLY Festergut related events

--HG--
branch : trunk
2010-08-30 11:36:15 +02:00
Shauren dc2c28985f Scripts/Icecrown Citadel: Remove Mark of the Fallen Champion when Saurfang dies
Scripts/Icecrown Citadel: Change previous scripts to use BossAI instead of ScriptedAI

--HG--
branch : trunk
2010-08-31 21:47:45 +02:00
Shauren 6048d2ec5e Core/Achievements: Pass killed unit pointer to UpdateAchievementCriteria for ACHIEVEMENT_CRITERIA_TYPE_KILL_CREATURE (use in scripts)
--HG--
branch : trunk
2010-08-31 21:47:44 +02:00
Shauren 996e7741a1 Scripts/Icecrown Citadel: Corrected vehicleId for Deathbringer Saurfang, patch by Heisenberg/bolvor
Closes issue #3704.

--HG--
branch : trunk
2010-08-31 21:47:43 +02:00
click 174f2884b7 Buildsystem/MSVC: Only use /bigobj on x64 platforms - should solve x86 debug compilations (needs feedback)
--HG--
branch : trunk
2010-08-31 20:14:16 +02:00
John Holiver 258398ed30 Fixes Druid T10 Balance 4P bonus.
Fixes DK T10 Melee 4P bonus.

--HG--
branch : trunk
2010-08-31 15:01:04 -03:00
Shocker e32ece52ea Pet level-synchronization with owner should be done before initializing stats, closes issue 3732, thanks moriquendu
--HG--
branch : trunk
2010-08-31 20:40:43 +03:00
John Holiver 46679c1bf7 File missing in the last commit.
--HG--
branch : trunk
2010-08-31 12:39:16 -03:00
John Holiver 5bf31a5e81 Fix to DK Tank 4P and Paladin Holy 4P T10 bonus.
Fixes issue 2684.
Fixes issue 2681.
Thanks to svetilo12.

--HG--
branch : trunk
2010-08-31 12:35:06 -03:00
Shauren 58ce3c77af Core/Scripts: Revert revision 619ba8b76250 and fix it properly
--HG--
branch : trunk
2010-08-31 15:37:29 +02:00
Spp b5beb1c706 Better way to fix some warnings from rev 621c100eeb.
--HG--
branch : trunk
2010-08-31 13:31:38 +02:00
Spp 866c28fbec Core/Groups: Fix a crash loading groups from DB
Fixes issue 3693

--HG--
branch : trunk
2010-08-31 11:50:07 +02:00
Spp b9e19572c4 Core: Fix more warnings (very few left under linux 32)
--HG--
branch : trunk
2010-08-31 11:39:51 +02:00
Spp 849ae84f5b Core: Fix more warnings and fix compile under linux 64
--HG--
branch : trunk
2010-08-31 10:23:22 +02:00
Spp e252b8abe7 Core: Fix more warnings
--HG--
branch : trunk
2010-08-30 23:07:14 +02:00
click a6d075dfc6 Buildsystem: Whops, forgot to remove the last endif() in g3dlite CMakeLists.txt
--HG--
branch : trunk
2010-08-30 23:10:32 +02:00
click 9fb9254810 Buildsystem: Remove some cruft (double set) of SCRIPT_LIB in worldserver CMakeLists.txt - if this breaks OSX build, notify us.
--HG--
branch : trunk
2010-08-30 23:06:07 +02:00
click 511d571d25 Buildsystem: Clean up target link-definitions a bit
--HG--
branch : trunk
2010-08-30 22:58:37 +02:00
Machiavelli 376958d474 Call _SaveTalents along side of _SaveSpells in Player::resetTalents.
Please leave feedback on how this affects your character_spell duplicate entry errors.

--HG--
branch : trunk
2010-08-30 22:15:42 +02:00
Shocker b19c1396dd Allow Soul Leech to proc from Conflagrate, fixes issue 2257
--HG--
branch : trunk
2010-08-30 22:10:52 +03:00
Machiavelli 9f5708f4f5 Wrap guild_bank_item save queries in transactions.
Fixes a potential dataloss issue

--HG--
branch : trunk
2010-08-30 19:19:47 +02:00
QAston ee8d61eaa4 *Missing function from commit r90b0ebdba9 :(.
--HG--
branch : trunk
2010-08-30 18:33:02 +02:00
click 8d0f2f8a31 Buildsystem/MSVC: Correct 'bigobj' flag to lowercase
--HG--
branch : trunk
2010-08-30 18:29:39 +02:00
QAston a8de57559b *Allow channeled spells to be casted on dead target
*Define relted spell attributes

--HG--
branch : trunk
2010-08-30 17:32:51 +02:00