Commit Graph
100 Commits
Author SHA1 Message Date
Machiavelli 1a4fe4baca Core/Guilds: Fix logic in bank withdrawal method (unsigned comparison with signed value). Should fix certain guild bank related bugs.
--HG--
branch : trunk
2010-12-13 16:42:09 +01:00
Machiavelli 976225a9dd Core/DBLayer: Implement global ExecuteOrAppend methods to DatabaseWorkerPool for executing queries in a diverse context (transaction or non transaction) - instead of local to Guild.cpp
--HG--
branch : trunk
2010-12-13 16:27:14 +01:00
Machiavelli 426b28e344 Fix wrong vsprintf parameter added in merge.
--HG--
branch : trunk
2010-12-13 16:18:07 +01:00
Machiavelli f1a73e89b8 Merge
--HG--
branch : trunk
2010-12-13 16:13:32 +01:00
Machiavelli ea29d87dcc Backed out changeset: 8326a2411148
--HG--
branch : trunk
2010-12-13 09:18:49 +01:00
Shauren dd2602d3ec Fixed line endings in 10623_world_spell_bonus_data
Scripts/Naxxramas: Fixed a possible crash in instance script

--HG--
branch : trunk
2010-12-12 17:32:26 +01:00
Shocker 4b0ffeb0bd Core/ChatHandler: Cleanup in HandleMessagechatOpcode. Now commands are parsed and security checks are made in all channels
--HG--
branch : trunk
2010-12-11 17:47:43 +02:00
azazel d2d62eab50 Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
NOTE: Initially I just wanted to fix some warnings, but noticed that there is no common method for percentage calculation and various formulas are used many time in the code making it difficult to read and understand what the code actually does. So, I introduced several template methods for calculating percent values and adding those values to the original base. I replaced all the raw calculations throughout the code where found, but I could have missed something or could have made a mistake. So, please report any strange behaviour after this commit.
If you ask me why I did it: for the sake of consistency and exact understanding what code means. If you see CalculatePct method, you clearly understand, that it find the value of x percent of y. And you can easily express, for example, spell behviour "reduces smth by x%" by the means of a method instead of recalling school maths.

--HG--
branch : trunk
2010-12-11 20:37:38 +06:00
click 81db111ffd Core/Spells: Fix mage talent Frost Warding (and a little cleanup on CalcAbsorbResist) - patch by DrTenma
Fixes issue 2715.
Closes issue 3770.

--HG--
branch : trunk
2010-12-11 12:00:57 +01:00
click 0e33e73d39 Core/ChatHandler: Allow GM/server-commands to be executed through whisper-channels - patch by Ramus
Closes issue 5006.

--HG--
branch : trunk
2010-12-11 03:25:31 +01:00
Spp a791df6415 Core/Dungeon Finder: Fix crash in Join
(trying to delete a const iterator)

Closes issue 5083

--HG--
branch : trunk
2010-12-10 14:58:45 +01:00
Machiavelli 4f468f9552 Core/RA: Calculate password hash internally instead of sending plaintext password to mysql.
Convert tabs to spaces.

--HG--
branch : trunk
2010-12-10 09:02:59 +01:00
azazel e3c68e4ada Misc: fix CR/LF (my bad, sorry)
--HG--
branch : trunk
2010-12-10 12:06:28 +06:00
azazel 08f205722a Scripts/Quest: implement dummy effects for spells 43882, 50133 and aura 43874 for quests 11396/11399 Bring Down Those Shields (based on code by NoFantasy)
--HG--
branch : trunk
2010-12-10 12:01:57 +06:00
click 7e0dee8cb1 Fix build
--HG--
branch : trunk
2010-12-10 01:44:34 +01:00
click 456f29c089 Core/Worldserver: Remove external dependency to sockets-library after RemoteAccess being converted to ACE, and fix one minor hiccup on non-PCH builds
--HG--
branch : trunk
2010-12-10 00:33:55 +01:00
Rat b5e24cbb9c Core/SmartAI: ACTION_CALL_CASTEDCREATUREORGO can now be used with GameObjects too
--HG--
branch : trunk
2010-12-09 22:21:11 +01:00
leak 855b8bcd20 Core/Spells: Prevent Mind Sear from damaging the target itself. Patch by PrinceCreed.
Fixes issue 2534

--HG--
branch : trunk
2010-12-09 21:45:04 +01:00
Spp be73926ab3 Core/Dungeon Finder: Fix incorrect Lfg state after multiple actions.
- Clear state after get out DF system
- Fix player not getting reward after finish a random dungeon
- Remove OnDisband Hook, it's already handled by OnRemoveMember

--HG--
branch : trunk
2010-12-09 19:13:11 +01:00
Spp 4914ca575b Core/Dungeon Finder: Fix a crash in Join
After a random dungeon is expanded to the corresponding dungeons and checked compatible dungeons of players joining. We have no dungeons and no lockmap.

This may only happen when a random dungeon is expanded to no dungeon. And this may be impossible to happen

Closes issue 5066

--HG--
branch : trunk
2010-12-09 14:25:48 +01:00
Spp 4537ba2766 Core/Dungeon Finder: Fix a possible crash in rolechecks when not success
--HG--
branch : trunk
2010-12-09 13:49:04 +01:00
azazel e7eb4e22e2 Core/Mechanics: cleanup shapeshift form code (by VladimirMangos)
--HG--
branch : trunk
2010-12-09 17:03:42 +06:00
azazel 8c2ce7f86d Core/Auras: fix AuraType 138 to not affect ranged haste, and rename to SPELL_AURA_MOD_MELEE_HASTE (by michalpolko)
--HG--
branch : trunk
2010-12-09 14:40:59 +06:00
Spp b434273ed8 Core/Dungeon Finder: Some optimizations
- Reduce core dependencies with LFGMgr
- Remove reduntant calculations in RoleCheck code
- Remove no longer needed functions
- Fix some packet data (Missing 0 when arrays were null)
- Add some debug msgs

closes issue 5042

--HG--
branch : trunk
2010-12-08 21:29:43 +01:00
Shauren e4e048ed57 Core/Scripts: Fixed possible crashes in instance scripts (Icecrown Citadel and Naxxramas)
Scripts/Sunwell Plateau: Fixed crash in Kil'jaeden
Scripts/Icecrown Citadel: Fixed crash in Blood-Queen Lana'thel

Closes issue #5051.
Closes issue #5050.
Closes issue #5035.

--HG--
branch : trunk
2010-12-08 17:24:31 +01:00
Shauren 611dc153b0 Core/Units: Corrected PLAYER_FIELD_BYTES2 invisibility/stealth flags, by VladimirMangos
--HG--
branch : trunk
2010-12-08 14:51:50 +01:00
Rat cebf8590e3 Core/SmartAI: some error checks for actionlists, and enabled lists for GOs
--HG--
branch : trunk
2010-12-07 20:25:45 +01:00
Rat bb09a4a50f Core/SmartAI: all actions regarding to TIMED_ACTIONLIST will now use targeting:
you can now 'send' a list of timed actions to any targeted creature if it has SmartAI

NOTE: already made script with timed actions should be remade to use self as target

--HG--
branch : trunk
2010-12-07 18:31:34 +01:00
Shauren 703835ee94 Core/Quests: Fixed Unholy Infusion (24749), Blood Infusion (24756) and added partial support for Frost Infusion (24757)
--HG--
branch : trunk
2010-12-06 22:54:19 +01:00
leak 20cc4ace5d Core/OutdoorPvP: Fixed a crash that occured on accessing CapturePoints after GO removal
--HG--
branch : trunk
2010-12-06 20:55:26 +01:00
Machiavelli 3ae225247a Core/Groups: Remove unused (and costly) return value from Group::RemoveInvite
--HG--
branch : trunk
2010-12-06 20:25:43 +01:00
Machiavelli cac0664150 Fix linux compile.
Closes issue #5044

--HG--
branch : trunk
2010-12-06 20:06:31 +01:00
Machiavelli f35c85acbe Core/DBLayer: Optimization in transaction code, and prevent a crash and memleak on shutdown.
--HG--
branch : trunk
2010-12-06 19:52:37 +01:00
Machiavelli 988a6f5c93 Core/DBLayer: Simplify template usage for DatabaseWorker
--HG--
branch : trunk
2010-12-06 19:28:05 +01:00
Spp fbf525218b Core/Dungeon Finder: revert r14440b0b82 and fix it properly.
That msg was just for debugging purposed and its not needed anymore

--HG--
branch : trunk
2010-12-06 17:23:52 +01:00
Spp 2581c2f70f Core/Dungeon Finder: Fix console spam msg in Leave
--HG--
branch : trunk
2010-12-06 16:48:23 +01:00
Spp 7ef59e3872 Core/SmartScripts: Fix a typo in action 'set instance data (64)'
--HG--
branch : trunk
2010-12-06 06:38:50 +01:00
QAston bb2a715afc Core/Scripts: Comment out code sanitizing hook type - will be fixed soon.
--HG--
branch : trunk
2010-12-06 07:16:39 +01:00
leak 59d12e3b4a Core/Entities: Fixed a crash by accessing the GameObjectAI of a GameObject before the next Update cycle. Patch by Rat. Thanks to Visagalis for testing.
Fixes issue 4863

--HG--
branch : trunk
2010-12-06 04:52:33 +01:00
leak 72d8b18c5c SQL error corrections.
Fixes issue 5021

--HG--
branch : trunk
2010-12-06 04:32:20 +01:00
Spp 090fb3572f Core: Fix non-PCH build
--HG--
branch : trunk
2010-12-06 02:35:28 +01:00
Spp 408fce1de6 Core: Some optimizations
- Declare some functions const
- Fix some mem leak
- Fix some resource leak
- Remove unused variables and functions
- Remove duplicate functions
- Reduce the scope of some variables
- Remove unused file

--HG--
branch : trunk
2010-12-06 02:07:53 +01:00
leak e226c4ac34 - Added Perl based conf merger script
- Removed LogSQL config option until reimplementation on code side
- A bit of cosmetics for .conf files

--HG--
branch : trunk
2010-12-06 00:24:45 +01:00
QAston 59c1a238f5 Scripts/AuraScript: Make AuraApplication in OnEffectPeriodic never be NULL.
Scripts: remove some unnecessary NULL checks from scripts.

--HG--
branch : trunk
2010-12-05 21:38:52 +01:00
Shauren e2c9453442 Core/Auras: Small correction on PLAYER_FIELD_BYTES2 usage in SPELL_AURA_OVERRIDE_SPELLS (293)
--HG--
branch : trunk
2010-12-05 21:20:45 +01:00
QAston 7db1b39224 Core/Auras: backout r2bf34fd7ac and add alternative - not spell specific sollution for the problem.
--HG--
branch : trunk
2010-12-05 20:43:09 +01:00
leak 6fe19b5a86 Core/Scripts: Split OnCreatureCreate() and OnGameObjectCreate() into two virtual functions each.
Note to scripters: be aware that you will need to hook into the Remove functions if you want to do stuff at GO/creature removal.
Closes issue 5011.

--HG--
branch : trunk
2010-12-05 18:04:10 +01:00
Spp dfa1e9532b Core/Dungeon Finder: Use different queues for each team
--HG--
branch : trunk
2010-12-05 17:50:32 +01:00
Spp e621f5fe98 Core/Dungeon Finder: Code cleanup and minor optimizations
- Extend LfgState to keep control of the state of group and players using LFG
- Move scripts to its own class and initialize only if Dungeon finder is enabled
- Updated comments to doxygen format
- Use constructor initialization list
- All variables are declared in the inner most scope
- Fix some mem leaks
- Remove no longer needed code (Cleaner)
- Normalize handler function names

--HG--
branch : trunk
2010-12-05 17:50:26 +01:00
silinoron 71c2698faf Core/Auras: Really add forgotten changes (as in do it properly).
--HG--
branch : trunk
2010-12-05 08:34:01 -08:00
Machiavelli b845b9d0fd Core/DBLayer:
- Make time format of MaxPingTime consistent between authserver and worldserver. Note that the value is in minutes, update your config files accordingly if needed.
- Remove obsolete atomic uint32 and prevent concurrent calls to vector::size() in DatabaseWorkerPool

--HG--
branch : trunk
2010-12-05 16:48:47 +01:00
Machiavelli 82ccfa9830 Really fix nonPCH build. With thanks to Aokromes
--HG--
branch : trunk
2010-12-04 23:42:23 +01:00
Machiavelli 1c385ea036 Merge
--HG--
branch : trunk
2010-12-04 23:16:22 +01:00
Machiavelli 533f27e732 Core: Fix non-PCH build (sorry)
--HG--
branch : trunk
2010-12-04 23:14:37 +01:00
silinoron 141a9017d4 Core/Auras: Add forgotten changes from r91eb5c3bd59e63d3025fd7ec9ca4f1f05924a517.
Thanks tassader1000 for telling me it was important.

--HG--
branch : trunk
2010-12-04 14:02:55 -08:00
Machiavelli f5d6319d4d Core/DBLayer:
- Make the mysql connectionpool shared for async and syncrhonous connections.
- Allow configurable amount of connections for the pool
- Allow configurable amount of delaythreads
Note that delaythreads now only represent in-core threads. Whenever they execute a task they will pick a free connection from the pool instead of using their previously unique assigned connection.
The purpose of this design change is better distribution of SQL requests (no bottlenecks paired with idling) among available resources.
This also prevents a ¨memory waste¨ of preparing async prepared statements on synchronous connections (that were never called) - and vice versa. Now, connections aren´t explicitly async or synchronous, they serve both purposes.

Use at own risk, might cause instabilities.
Don´t forget to update your config files and clear your cmake cache.

--HG--
branch : trunk
2010-12-04 21:50:36 +01:00
silinoron b8bf37264b Core/Authserver: Cleanup.
--HG--
branch : trunk
2010-12-04 11:19:41 -08:00
silinoron 3201338eac Core/Auras: Allow spell 64381 to stack four times.
Patch by Lopin.

--HG--
branch : trunk
2010-12-04 10:59:45 -08:00
silinoron 1b5ff62314 Core/Auras: Replenishment should stack duration, not several instances.
Patch by dr.tenma.
Fixes issue #4370.

--HG--
branch : trunk
2010-12-04 10:59:06 -08:00
silinoron 3661ed8231 Core/Auras: Fix wrong durations on certain reflected spells.
Patch by dr.tenma.
Fixes issue #3611.

--HG--
branch : trunk
2010-12-04 10:51:46 -08:00
linencloth 4cd2f3dae6 Core/Traveller: Calculate the travel time correctly for zero distance
Closes issue #4857

--HG--
branch : trunk
2010-12-04 17:25:33 +01:00
Machiavelli b9fb7554c5 Core/Disables: Add flags SPELL_DISABLE_MAP and SPELL_DISABLE_AREA for sourceType DISABLE_TYPE_SPELL.
This will allow you to disable spells on certain maps/areas. Note that you must have at least flag SPELL_DISABLE_PLAYER or SPELL_DISABLE_CREATURE or SPELL_DISABLE_PET set too, as they take preference.
The parameters for mapIds and areaIds are defined in new columns params_0 and params_1 respectively, in a comma-seperated string.

Example:
INSERT INTO disables VALUES(0, 8921, (1+16+32), "571,1", "1519", "Moonfire Example");

This will disable spell moonfire for players in maps 571,1 and area 1519.

--HG--
branch : trunk
2010-12-04 18:29:14 +01:00
Rat 3240a4ec33 Core/SmartScripts: Fix a typo in action 'set instance data'
--HG--
branch : trunk
2010-12-04 15:04:46 +01:00
Shauren 04b4364908 Scripts/Icecrown Citadel: Fixed crash in Blood-Queen Lana'thel script
Closes issue #5017.

--HG--
branch : trunk
2010-12-04 12:53:01 +01:00
Machiavelli bbf619c20d Core/Spells: Fix spell damage/healing multipliers for spells that affect multiple targets (ie. Heart Strike, Chain Lightning, Chain Healing)
Author: dr.tenma
Closes issue #4506
Closes issue #1874

--HG--
branch : trunk
2010-12-04 10:31:14 +01:00
Machiavelli 737aeae50c Core/Gridnotifiers: Fix a possible crash in MessageDistDeliverer::SendPacket
Updates issue #5016
Please try to re-reproduce

--HG--
branch : trunk
2010-12-04 10:14:12 +01:00
Liberate 526c15336d Scripts/Pit of Saron: Fix a crash at Scourgelord Tyrannus.
Closes issue #4601

--HG--
branch : trunk
2010-12-04 02:20:32 +01:00
Liberate 418f704e92 Core/Battlegrounds: Actually remove 16 rating from the teams if the match was ended because of the 45 minutes time limit.
--HG--
branch : trunk
2010-12-03 23:14:38 +01:00
Shauren e0c992a8ba Scripts/Icecrown Citadel: Added script for Blood Queen Lana'Thel
Scripts/Icecrown Citadel: Fixed Invocation of Blood announcement emote for Blood Prince Council
Scripts/Icecrown Citadel: Fixed intro for Lady Deathwhisper
Scripts/Icecrown Citadel: Fixed Bone Spike for Lord Marrowgar

--HG--
branch : trunk
2010-12-03 17:47:33 +01:00
Shauren 892f56c37d Fixed compile, missed these changes
--HG--
branch : trunk
2010-12-03 14:14:08 +01:00
Shauren 96ab1a102f Scripts/Trial of the Crusader: Fixed crashes in Gormok the Impaler
Closes issue #4515.

--HG--
branch : trunk
2010-12-03 14:02:41 +01:00
Shauren 3badf69b63 Core/Spells: Fixed bad Z coordinate for Spell::EffectBind with location stored in database
Core/Scripts: Corrected few mistakes in misc scripts

--HG--
branch : trunk
2010-12-03 13:54:00 +01:00
Shauren bd4b47af0e Core/SQL: Added missing scriptnames to full sql, fixed typos and corrected delete statement in 10418_world_spell_script_names.sql (no need to reapply)
--HG--
branch : trunk
2010-12-03 13:36:14 +01:00
click 1ec9f7b828 Core/Scripts: Adjust SQL-update for 10462 to include a delete-query for the affected spell (prevents a possible reinsert-error during import)
Thanks to leak for noticing.

--HG--
branch : trunk
2010-12-03 00:26:48 +01:00
click e672793a3c Core/Battlegrounds: Add dampening-spells for battlegrounds and arenas (thanks to Dr.Tenma and Svetilo/przem-something)
Additional data required for this commit :
http://forum.trinitycore.org/topic/30684-10555-add-dampening-spells-for-battlegrounds-arenas-and-wintergrasp/

--HG--
branch : trunk
2010-12-02 23:50:36 +01:00
click cf5e7b255d Core/Battleground: Fix compile - forgot to remove one '(' when pushing
(AND YES IT WAS TESTED - I was just thinking of cleaning it slightly, dropped it, and forgot I had changed it)

--HG--
branch : trunk
2010-12-02 23:14:26 +01:00
click 28c2e270db Core/Battlegrounds: Implement power resets on arena-fight preparations (first 60 seconds before arena-fight kicks off) (Thanks to Kaelima)
Restores all player powers every 5 seconds untill arena starts (fixes possible exploit with entering arena battle with full rage or runic power)
(The 5 second timer is not 100% confirmed, as official pages only states that the power is reset after prep-time - needs feedback)
Closes issue 4805

--HG--
branch : trunk
2010-12-02 22:50:30 +01:00
click 2338eae0ff Core/Battlegrounds: Stop arena matches after 45 minutes of no win/loss candidate, and deduct 16 points from each team (blizzlike) - Thanks to Alez
Closes issue 2017

--HG--
branch : trunk
2010-12-02 22:25:32 +01:00
click 94fd1487d0 Core/Chat: Fix issues introduced in 177d6f86ca
+ Wrong update-query for the channels-table (SQL from 10548 sorted properly)
+ Add a small correction on Channel.cpp say handling (thanks to Lazzalf/Leak)

--HG--
branch : trunk
2010-12-02 17:30:48 +01:00
click 0efefa6854 Tag revision 10532 as stable
--HG--
branch : trunk
2010-12-02 16:29:19 +01:00
click 590a426d16 And remove the patch, yeye...
--HG--
branch : trunk
2010-12-02 03:56:57 +01:00
click bc098658c6 Core/Chat: Configure automatic owner declaration for custom chat channels (patch by leak)
Closes issue 4974.

--HG--
branch : trunk
2010-12-02 03:54:52 +01:00
Shocker 0c44bd33ee Core/Items: Enforce item attributes stored in DBC files by default and add config option to allow overriding with database values, patch by ZxBiohazardZx.
Closes issue 4785.

--HG--
branch : trunk
2010-12-01 21:20:28 +02:00
Shocker a23ae5c94c Core/Spells: Implement SPELL_EFFECT_WMO_CHANGE, patch by Heisenberg
Closes issue 4984.

--HG--
branch : trunk
2010-12-01 20:59:05 +02:00
click 1d52e3a7b5 Core/Database: Rename update-file for previous commit, it's for characters, not for world ... danged old habbits...
--HG--
branch : trunk
rename : sql/updates/10543_world_group_member.sql => sql/updates/10543_characters_group_member.sql
2010-12-01 18:30:02 +01:00
click aa35190c42 Core/Database: Adjust character database fields to have an existing default value (group_member) - fixes a transactionerror
--HG--
branch : trunk
2010-12-01 18:17:33 +01:00
Shauren 4e0735196e Core/Spells: Spell id being cast by player can now be changed depending on map difficulty
--HG--
branch : trunk
2010-12-01 14:12:08 +01:00
Shauren 445dc511f3 Core/Auras: Implemented aura SPELL_AURA_OVERRIDE_SPELLS (293), base patch by Heisenberg, research by TOM_RUS
Closes issue #4969.

--HG--
branch : trunk
2010-11-30 21:32:00 +01:00
click 782731f7e8 Revert an unintended change from 99a3929104
--HG--
branch : trunk
2010-11-30 00:20:58 +01:00
click e308d5cb44 Core: Fix creature_respawn handling in Outdoor PvP system, thanks to sombre for noticing
Closes issue 4971.

--HG--
branch : trunk
2010-11-30 00:18:17 +01:00
azazel 3cb4a52d59 Core/Misc: fix some warnings. As a result removed one redundant hook from FormulaScript.
--HG--
branch : trunk
2010-11-29 15:50:38 +06:00
Spp dd4b5f7b33 Fix typo in previous commit
--HG--
branch : trunk
2010-11-29 09:18:38 +01:00
Spp 25ac835507 Core/Groups: Move all function definition from .h to .cpp
Core/Groups: Remove Group.h dependency from any .h file

--HG--
branch : trunk
2010-11-29 07:50:31 +01:00
Spp 116d845601 Fix compile
--HG--
branch : trunk
2010-11-29 07:50:15 +01:00
click 6c495df702 Core/AuctionHouse: Correction on AH deposit value, minimum 1 silver required (blizzlike)
--HG--
branch : trunk
2010-11-29 07:20:28 +01:00
click efeb512fbf Core/AuctionHouse: Calculate deposit taken for item(s) being auctioned properly + pick up correct number of items being auctioned (Thanks to Paradox)
Comment issue 4958
Added and pending further testing. Also need testing for issue 3681 (related to AH packetsize?).
Closes issue 4089.
Closes issue 4919.

--HG--
branch : trunk
2010-11-29 00:59:02 +01:00
click 3fccb2b7bf Core/Chat: Disallow visual emotes when an entity is in dead-state (thanks to Vladimir)
Closes issue 4942.

--HG--
branch : trunk
2010-11-28 20:12:33 +01:00
Spp 916c0f98df Core/Dungeon Finder: Fix members of premade group not being teleported to dungeon after a proposal success
--HG--
branch : trunk
2010-11-28 14:11:22 +01:00
Spp c2791232c3 Core/Dungeon Finder: After a proposal success only teleport new players
--HG--
branch : trunk
2010-11-28 00:43:21 +01:00
Spp 9bb043d5b5 Core/Dungeon Finder: Fix Proposal not being shown to players in LFG group trying to do a new dungeon
(Missing code from rev 77918d0138)

--HG--
branch : trunk
2010-11-28 00:37:34 +01:00