Commit Graph
36947 Commits
Author SHA1 Message Date
jackpoz 0fb1bf8439 Core/Misc: Enable MaxCoreStuckTime setting by default
Enable MaxCoreStuckTime setting by default to force worldserver to exit in case of infinite loops.
Note that this will not affect existing setups with the setting MaxCoreStuckTime set to 0 in the local worldserver.conf .

(cherry picked from commit 00703ee238729a8d5b3d17edf8dc16d6c6c6b601)
2021-12-18 23:24:24 +01:00
Killyana e071f08ca7 DB/Quest: The Path to the Citadel
Make the credit for the party invoker

(cherry picked from commit 58b0ca864113e439d87289534607b83c1b9d1404)
2021-12-18 23:24:03 +01:00
ccrs bb1a4e884a Scripts/PoS: a7a96d4 followup
we cant despawn all summons since vehicle spawn their passengers as regular summons
ty Aokromes

(cherry picked from commit fcbcb43b2b9f2d3b77192ed779a98f43d7e1c486)
2021-12-18 23:23:08 +01:00
ccrs b7346bac48 Scripts/PoS: a7a96d4 followup
(cherry picked from commit 40116f10259585df28c6bb950afadb77834c1ceb)
2021-12-18 23:22:54 +01:00
ccrs 7594ae72d7 Scripts/PoS: little implementation cleanup in boss_krickandick with, you guessed it, movement related corrections
also, never forgetti  -->
                                     ¨¨Ç*^¿?_:;_^!"·Ç!Ñ·$%/(/)/()(=)(=]]{
Unit::StopMoving() is evil, and so is MotionMaster::Clear()

the first can really mess up existing movement generators
the second can interrupt "controlled" movements... can do it literally mid-air

(cherry picked from commit a7a96d427193163f8b7e3e2404d80b73fb6e63df)
2021-12-18 23:22:38 +01:00
ccrs a73e6a7438 Scripts/PoS: move boss_krickandick into new script definition
(cherry picked from commit d27fd717c14e096d7120ac967d295d93816054c6)
2021-12-18 23:22:08 +01:00
ccrs 1add1c31d8 Core/Movement: prevent any Initialize queue till AddToWorld is signaled
(cherry picked from commit c9c6871659bf2be52b4656bc641df5211fcb928f)
2021-12-18 23:18:26 +01:00
ccrs 7b21b53ac9 Core/Movement: d033032 followup
now THATS a typo... sorry folks

(cherry picked from commit bc9a9ad7e1226573493e3cb10885365322fdbbbf)
2021-12-18 23:18:16 +01:00
Killyana 3edf174d21 DB/Spell: Fix phasing in Foote Steppes (with the correct spell this time)
Ref https://github.com/TrinityCore/TrinityCore/commit/1e4f0619fd36c0c56812e43302e9e60ff20405b6#diff-c64f2de863d9cbe0fc088f5ed7eeeb04R3-R5

(cherry picked from commit 8dbceb421c9e366cad5763f704d6c004107d47e6)
2021-12-18 23:18:06 +01:00
Killyana 490c007827 DB/Spell: Fix phasing in Foote Steppes
Closes #22867

(cherry picked from commit 1e4f0619fd36c0c56812e43302e9e60ff20405b6)
2021-12-18 23:17:21 +01:00
Killyana b926f524ba DB/Quest: Pushed Too Far
(cherry picked from commit 5e1b828365b69e198c4b9b305b574022a7552aae)
2021-12-18 23:16:07 +01:00
ccrs a59e4da7f5 Core/Movement: d033032 followup
ty jackpoz

(cherry picked from commit 5d056f37c74b652b3a3372d6aa88ac5e183f9d98)
2021-12-18 23:14:40 +01:00
Killyana 8281c92dce DB/Creature: Brann Bronzebeard & Brann's Flying Machine
Closes #22650

(cherry picked from commit e10cab89f7173844b08b1bd7b3f4b7317a749b41)
2021-12-18 23:14:10 +01:00
ccrs 50c90728b2 Core/AI: 06443e3 followup
(cherry picked from commit bb9af06cd4ff80f078fcb6ae4871c74a1a174bcc)
2021-12-18 23:13:20 +01:00
ccrs 2f5d97b951 Core/AI: add missing public tag & correct alignment
(cherry picked from commit fe7c2c377288339a2ba95e2bba226b815d79ba55)
2021-12-18 23:10:45 +01:00
Killyana 64ad90a9d8 DB/Creature: Plaguehoof & Bloodsunder & Icefury
(cherry picked from commit 439c434164ff07c7e52e4536bf7e4366e6ff24e4)
2021-12-18 23:06:04 +01:00
Killyana 8b35d5b8fc DB/Creature: Spitzpatrick's Bomber
(cherry picked from commit cd32ef779864670ebcc4eba04f4b692347dbd213)
2021-12-18 23:04:28 +01:00
Killyana 294f232e4a DB/Creature: Argent Mason
(cherry picked from commit 77f857cb4e79dc31462b9ae626e73da4fa772662)
2021-12-18 23:03:00 +01:00
Killyana ae9ca35807 DB/Creature: Vanguard Sound Dummy
(cherry picked from commit db4a2a721fa68449a7be9616fa2a35986f7d667a)
2021-12-18 23:03:00 +01:00
ccrs c658ba2fc9 Core/Movement: d033032 followup
ty jackpoz

(cherry picked from commit bc507209a706cddb33a0a14bffc94d4db50ddce6)
2021-12-18 23:03:00 +01:00
ccrs d3ddb3726a Core/AI: 06443e3 followup
cause its not "that" horrible

(cherry picked from commit a71c5f4c7f35b074397abfcc9b925e80720f8c75)
2021-12-18 23:03:00 +01:00
ccrs dfb2221552 Core/Movement: delay movement update in MotionMaster until its owner signals AddToWorld
ref #23199
closes #23876

(cherry picked from commit d033032d33cff5dae76000f8432d78746cda9e06)
2021-12-18 23:03:00 +01:00
Aokromes 7f074efa04 Core/Totem: Change log level of a log
To much spam of people doing quests with totem-like creatures

(cherry picked from commit 69b7958ebcebbf52e95323f4578cfbffe51635d6)
2021-12-18 23:03:00 +01:00
Jildor c1b0ffbef8 DB/Creature: Bronjahm interrupt immunity
Closes #23870

(cherry picked from commit c023b7aeff22db2a31a3fb8e285a020c6f6cb23e)
2021-12-18 23:03:00 +01:00
Killyana c1a7a424df DB/Creature: Emissary Roman'khan
(cherry picked from commit ec81d1c6a9f4c5e27764f6a6c4111e1275195c0b)
2021-12-18 23:03:00 +01:00
Killyana cb13d0b185 DB/Creature: Obsidian Eradicator & Obsidian Nullifier
Closes  #23869

(cherry picked from commit fe479ec8fdd3b76e93efc9c00c2a13cbf8458734)
2021-12-18 23:03:00 +01:00
jackpoz 58fe0f9e4a Build/Misc: Add ASan CMake flag
Allow to enable/disable Address Sanitizer in Clang and GCC from CMake flag "ASAN" of type Boolean. It can be enabled passing -DASAN=TRUE to CMake.

(cherry picked from commit 580f40769c6c446284dd1f5738f67fb3ee802956)
2021-12-18 23:03:00 +01:00
jackpoz 7d63166ff3 Core/GameObject: Fix battleground flags not showing burning animation
Fix battleground flags not displaying the typical burning animation when they "despawn" (they don't actually despawn, they just change state)

(cherry picked from commit 90bb10aa3a490fc701e6f98b32310687af80dea5)
2021-12-18 23:02:49 +01:00
jackpoz d5d04a6c55 Core/Misc: Fix C++17 build errors
(cherry picked from commit 30823f9b79b4ad16f96e90692a900f68a7f63c0a)
2021-12-18 22:51:50 +01:00
ForesterDev 4a47e1c6be Core/Defines: define UNIT_FLAG_SWIMMING (#23630)
(cherry picked from commit c03c88d0c02c5dda9f14dec1ed151ca30a92118e)
2021-12-18 22:50:52 +01:00
Giacomo Pozzoni 3da3683a90 Scripts/Kologarn: Fix "stuck in combat" issues (#23866)
Fix players stuck in combat with NPC_ARM_SWEEP_STALKER and/or both arms after killing the boss.

(cherry picked from commit fed030da190c9c53ad013d3e460ba1afbe1f02a2)
2021-12-18 22:47:49 +01:00
ForesterDev 915d13020a Core/Achievements: fixed bug with counting honorless units for achievement type ACHIEVEMENT_CRITERIA_TYPE_SPECIAL_PVP_KILL (#23844)
* Core/Achievements: fixed bug with counting honorless units for achievement type ACHIEVEMENT_CRITERIA_TYPE_SPECIAL_PVP_KILL

* Remove codestyle changes

* Remove codestyle changes

(cherry picked from commit f4be5446293e9896fe8e1cd9db8dc739af848cae)
2021-12-18 22:47:37 +01:00
jackpoz 7d78ddcbd5 Core/AI: Add new method to force creatures around to stop combat
(cherry picked from commit 06443e38e761ed8ac7ce803c39bbbc7263983479)
2021-12-18 22:46:24 +01:00
Ovah 14c2a7fb92 Core/Taxis: teleport players to the destination taxi node location instead of their current ground position (#23835)
* Core/Taxis: teleport players to the destination taxi node location instead of straight to their current ground position

* fixed a typo

(cherry picked from commit 7fcb77ecd12c42b8a468e8f932948c99c249a458)
2021-12-18 22:45:49 +01:00
Giacomo Pozzoni 4062c9763f Core/LFG: Fix re-queueing while in a dungeon (#23862)
Fix an issue that wouldn't allow to re-queue after joining a dungeon, having 1 member leave/get kicked, queue, leave, queue.
In this case a message "One or more dungeons was not valid" would be displayed because LFG would try to queue the group as "continue dungeon" but the current group was not marked as "in dungeon" state anymore.

(cherry picked from commit abcad7cda5375478f475bb9624c578169e84c559)
2021-12-18 22:43:38 +01:00
jackpoz 6c0412c3d9 Core/LFG: Remove Dungeon Cooldown when getting kicked
(cherry picked from commit ada4e431ae77cf56e6f5e4441b494dd25d6b3fb9)
2021-12-18 22:42:38 +01:00
jackpoz d15b3c48b4 Core/Misc: Fix issues reported by static analysis
Fix issues reported by Coverity Scan

(cherry picked from commit 88317a4ec8a4fae2f914fb699e8fb0fff1da3205)
2021-12-18 22:41:20 +01:00
Keader db03975a57 Scripts/ICC: Fixed some issues with Rotface Oozes (#23845)
(cherry picked from commit a108f2ba61db47d60dc6698ec202dfd0a6574ac4)
2021-12-18 22:40:29 +01:00
Keader e5accfa71a Scripts/ICC: Fixed Death Plague (Frost Giant) (#23847)
(cherry picked from commit 8210b4a53976266f12585a2a4f546b33e25343af)
2021-12-18 22:40:16 +01:00
Keader 03a1b03633 Scripts/Forge of Souls: Fixed spell Soul Sickness (#23843)
(cherry picked from commit 34ee2effc89dc5bb34b4873dbfed6081ea8cb685)
2021-12-18 22:37:30 +01:00
Keader 9abdc4ee3d Scripts/ICC: Fixed Tear Gas not getting removed of Abomination in phase change of PP (#23846)
(cherry picked from commit 16fde1ffad38306f1f21eab6496f4826d6ed3498)
2021-12-18 22:33:47 +01:00
Giacomo Pozzoni 6e1ed95a63 Core/Pet: Fix guardians low damage (#23840)
Fix guardians low damage for unhandled cases in Guardian::InitStatsForLevel()

(cherry picked from commit b3b8ec811daab65d4b94cad950a460240b02390b)
2021-12-18 22:30:38 +01:00
Giacomo Pozzoni 02c2ee9a43 Scripts: Fix crossfaction combat issue (#23818)
* Scripts/PitOfSaron: Fix Martin Victus combat in crossfaction groups

Fix Martin Victus attacking players in crossfaction groups because it was spawned as summon of the boss, triggering DoCombatInZone()

* Scripts/ForgeOfSouls: Fix guards combat in crossfaction groups

Fix Devourer of Souls guardians attacking players in crossfaction groups because they were spawned as summons of the boss, triggering DoCombatInZone()

* Scripts/Misc: Fix no PCH build

(cherry picked from commit ef694cc251844d34a64ae03f79d28a5c76719f6b)
2021-12-18 22:27:40 +01:00
Ovah 0910843538 Core/Movement: fixed taxi pathings getting finalized earlier than intended (#23830)
* Core/Movement: fixed taxi pathings getting finalized earlier than intended

Since we handle the intial starting point of a spline properly now the update logic was still expecting the old handling which resulted in incrementing the current node index earlier than intended

* apply a missing change

(cherry picked from commit c1e3d79a4fb5b7b1a9bca36ecd16b9bb902ced92)
2021-12-18 22:27:20 +01:00
Giacomo Pozzoni 157eca58d7 Core/Misc: Fix static analysis issues
Fix static analysis issues reported by Coverity

(cherry picked from commit ca8953a0ec8356345147b2bbc7bbdf0fa97cd625)
2021-12-18 22:26:58 +01:00
ForesterDev 7da053be66 DB/Creature: Remove wrong SAI from guards
Closes #23824

(cherry picked from commit 176f51d1e80dc116c5a16bc6aad295016ad8b6cd)
2021-12-18 22:25:56 +01:00
Keader 5d2b37634b Scripts/Tempest Keep: Fixed a typo in Nethermancer Sepethrea
Closes #23828
Ty Rizztazz

(cherry picked from commit 746a1d89b34984f31ab66ef00e93a648dc42af5d)
2021-12-18 22:24:21 +01:00
Giacomo Pozzoni c886e87991 Core/Misc: Fix static analysis issue
Fix static analysis issue

(cherry picked from commit ed087546635331e4cff4e97772a9f9978f4b1833)
2021-12-18 22:24:09 +01:00
tarwyn 474d903d79 Fix inconsistent NPC aggro on spell miss (#23816)
(cherry picked from commit c8dc9fdc418d9703893e21603b7593b015f08fea)
2021-12-18 22:23:00 +01:00
Ovah f4ae34c5c9 Core/Movement: provide an extra spline path vertex for taxi pathings … (#23817)
* Core/Movement: provide an extra spline path vertex for taxi pathings so the first path point wont get lost.

* Update FlightPathMovementGenerator.cpp

(cherry picked from commit cf3277c641bd877b9fa1939da5da7cde1778561b)
2021-12-18 22:21:57 +01:00