Commit Graph
36589 Commits
Author SHA1 Message Date
Wyrserth 0d9a7f626d DB/Creature: remove wrong repairer npcflag from NPC Perascamin.
(cherry picked from commit cc5088369b43f25f68443e1018e994694158c2c2)
2021-12-14 00:06:37 +01:00
Wyrserth fdd5063ba2 DB/SAI: add some missing RP events to Culling of Stratholme.
Scripted RP events involving NPCs Stephanie Sindree, Brandon Eiredeck and Patricia O'Reilly.

(cherry picked from commit c63bbb97b4850abfd60917bd9b668f276f9ecedb)
2021-12-14 00:01:42 +01:00
Wyrserth 13519dc043 DB/Vendor: rework Griftah's inventory.
Remove deprecated items and fix slot ordering.

(cherry picked from commit f05891405ab40502cfa67fdcff0edb1391ff8719)
2021-12-13 23:51:44 +01:00
Treeston bba4696de7 Entities/Player: Clean up client control handling behavior around possession. Mind Control should no longer cause various weirdness. Closes #23539.
(cherry picked from commit f6f1c48aa592ea10c99fd23f46e94934b2f0cef2)
2021-12-13 23:44:13 +01:00
Shauren e01f3c81f9 DB/Hotfixes: Add missing hotfix optional data for each locale 2021-12-13 22:51:49 +01:00
Wyrserth 9cfa2ed71e Script/HallsOfLightning: fix mistake related to Shattering Stomp in Volkhan's script, introduced in 3bb0abcd525218c0423421979177675004787707.
Closes #23337.

(cherry picked from commit a8b8a43b8d86f0039f4b4ac2c251d55ba3b6a4ed)
2021-12-13 00:42:20 +01:00
ForesterDev 27886c7f5d Core/Player: add helper methods GetNativeGender/SetNativeGender/SetGender (#23520)
* Core/Player: add helper methods GetNativeGender/SetNativeGender/SetGender and fix some cases, where we should get player gender, instead of modified by display gender

* fix merge

* Add virtual methods for Unit class

(cherry picked from commit b47bb59e2a3e42aff3793517ef94f51678b54905)
2021-12-13 00:42:20 +01:00
ccrs 4e6c59dca7 Core/Unit: rename several getters to follow codestyle
uint8 GetLevel()
        uint8 GetLevelForTarget(WorldObject const* /*target*/)
        void SetLevel(uint8 lvl)
        uint8 GetRace()
        uint32 GetRaceMask()
        uint8 GetClass()
        uint32 GetClassMask()
        uint8 GetGender()

(cherry picked from commit 5c09ff51f7015b775def8d5cc1f678eaef37200f)
2021-12-13 00:42:20 +01:00
Sorikoff b8d675eba7 Scripts/Spells: Dimensional Ripper - Everlook (#23547)
(cherry picked from commit 5c09ff51f7015b775def8d5cc1f678eaef37200f)
2021-12-13 00:42:20 +01:00
Wyrserth 1005389b14 DB/SAI: remove delay between clicking gossip and creature text/change faction for NPC Victorious Challenger involved in quest Taking on All Challengers.
(cherry picked from commit 5a9516cd9c27fc9f4f444d8658d9bd6ac3afc027)
2021-12-13 00:42:20 +01:00
Wyrserth a117beb1b3 DB/Creature: Hyldsmeet Warbear shouldn't have random movement.
(cherry picked from commit 4a875ec392b41030ea8f394335edc2860079fbb9)
2021-12-13 00:42:20 +01:00
Wyrserth c9cb12afc3 DB/Creature: add emote state and out of combat emote for NPC Brunnhildar Challenger.
(cherry picked from commit dd870a141fd521d1e760f984bc93db6101d8e733)
2021-12-13 00:42:20 +01:00
Wyrserth 04675c2322 DB/Conditions: allow gossip option for NPC Agnetta Tyrsdottar to show only if the quest Is That Your Goblin? is taken but not completed.
(cherry picked from commit e621d40ddcb7b8d70012ea27aa78baf81d0a7902)
2021-12-13 00:42:20 +01:00
Wyrserth 819f8b1a2d Script/DarkmoonFaire: fix logical error in go_darkmoon_faire_music.
Closes #23548.

(cherry picked from commit 028d16a812bd3ff56f19da919ca1a35e7523fe8c)
2021-12-13 00:42:19 +01:00
Rynem ed85a1b701 DB/Quest: fix chaining for quests offered by Lantresor of the Blade.
Closes #22440.

(cherry picked from commit 72917d5036be071a7243c1faa602dd1ad17543ba)
2021-12-13 00:42:19 +01:00
Wyrserth ecce30a807 Core/Quest: do not send SMSG_QUESTGIVER_OFFER_REWARD right after SMSG_QUESTGIVER_QUEST_FAILED.
Allows the gossip window to close after the client receives a quest failed error (for example: not enough inventory space to store the reward).

(cherry picked from commit c8289ada7f7d31a5e608c932db71ee6ec7fce0e6)
2021-12-13 00:42:19 +01:00
ccrs 2e4f38d949 Scripts/ICC: cleanup ReadSaveDataMore definition
(cherry picked from commit 4c398743b9ea67090dcb390643a7aa5bd49348c3)
2021-12-13 00:42:19 +01:00
ccrs 3bc4fc65b9 Scripts/ICC: 3dbf3fe followup
repeat timer typo

(cherry picked from commit b19a23a5c6b7d6cac972ebb2e917dc378f61c993)
2021-12-13 00:42:19 +01:00
Wyrserth 0476ee41e1 DB/SAI: implement out-of-combat event for NPC Ranger Sareyn.
Closes #23538.

(cherry picked from commit ce3820031d4185d4124fa062baa99619e483a84c)
2021-12-13 00:42:19 +01:00
Wyrserth 5c2a9364a4 DB/SAI: implement out-of-combat event for NPC Ranger Jaela.
Closes #23535.

(cherry picked from commit fa0fc13fd06e1af3dc6cb2ea611c4012660bfbdb)
2021-12-13 00:42:19 +01:00
Wyrserth 1a65c72939 DB/SAI: add out-of-combat texts to Instructor Hroegar
(cherry picked from commit 45a2388bc0c8c0825f2f59c277da8d77f3b74942)
2021-12-13 00:42:19 +01:00
Wyrserth 04b02f3672 Core/Spell: Challenge Flag should only hit one target.
(cherry picked from commit 39aa91f9824ce3b3f574931d287753dd8d49581f)
2021-12-13 00:42:19 +01:00
Wyrserth 866a079600 DB/SAI: script creature Mjordin Combatant involved in the quest Honor Challenge.
(cherry picked from commit e803ba77326fd5a274ee1fb54a9e9c32e01b39c6)
2021-12-13 00:42:19 +01:00
ccrs 8be1927d31 Scripts/ICC: base support for Ymirjar Vrykuls AI
(cherry picked from commit 3dbf3fed7c10b5808d2c20bdd3a8a3598ddd7cf6)
2021-12-13 00:42:19 +01:00
Wyrserth 41df87d7aa DB/Creature: fix spawns and emote state for Mjordin Combatants in Icecrown.
(cherry picked from commit e1787b883e1dc4cd67d6b30c8a1ca6db4abb2660)
2021-12-13 00:42:19 +01:00
ccrs 9d84b56df1 Scripts/ICC: 1eb2aef followup
(cherry picked from commit 3e9b55361842337156a38d17200200b30ebb62ae)
2021-12-13 00:42:19 +01:00
Shauren 116285818b Core/Misc: Corrected file headers 2021-12-13 00:42:19 +01:00
ccrs bb321ccb02 Scripts/ICC: move Sister Svalna to her own file
I've almost guttered her, so lets try it more gently this time

(cherry picked from commit 1eb2aef1791df5942b3760162d5180cb0bdb51ec)
2021-12-13 00:42:19 +01:00
Wyrserth 94599bd323 DB/Quest: remove quest requirements from the Consortium monthly quests.
Only one is available each month, based on reputation standing. They're not chained.

(cherry picked from commit 5aedc4a5102858f4bab35721fd5ff8e2234f3181)
2021-12-13 00:42:19 +01:00
ccrs fce492d2e2 Core/Instance: 14788ce followup
No need to repeat code

(cherry picked from commit b9a80959673a377bce537d32a7dacaa732761d55)
2021-12-13 00:42:19 +01:00
Wyrserth 9d861a51c2 DB/SAI: improvements for quest Powering our Defenses:
- There are two waves of three Enraged Wraith each
- The quest does not fail when the Infused Crystal is killed, as the quest item is not consumable so the player can try again straight away

(cherry picked from commit d213970719bfcfeba16dd400217aa722e63b2615)
2021-12-13 00:42:19 +01:00
ccrs 5e3ba5e96f Scripts/ICC: 94b60ff followup
(cherry picked from commit eb6ea57e7f04b38bb0b02b158d08a926c88a3058)
2021-12-13 00:42:19 +01:00
ccrs 934b72262d Core/Instance: add new method
(cherry picked from commit 14788ce026b660fe14207fa8865df4604050eb2b)
2021-12-13 00:42:18 +01:00
ccrs 6a63200e40 Core/Instance: add new hook & method
(cherry picked from commit 953b05459a517fb83f18047ab82ac09021bc9440)
2021-12-13 00:42:18 +01:00
ccrs fc6dc06513 Build: fix error
/var/lib/jenkins/jobs/tc_335_release_clang40_boost_1.63.0_nopch/workspace/src/server/scripts/Kalimdor/CavernsOfTime/CullingOfStratholme/npc_arthas.cpp:583:132: warning: format specifies type 'unsigned int' but the argument has type 'float' [-Wformat]
                TC_LOG_TRACE("scripts.cos", "npc_arthas_stratholmeAI::AdvanceToState: has snapback for this state, distance = %u", target.SnapbackPosition->GetExactDist(me));
                                                                                                                              ~~   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                                                                                              %f
/var/lib/jenkins/jobs/tc_335_release_clang40_boost_1.63.0_nopch/workspace/src/common/Logging/Log.h:176:56: note: expanded from macro 'TC_LOG_TRACE'
    TC_LOG_MESSAGE_BODY(filterType__, LOG_LEVEL_TRACE, __VA_ARGS__)
                                                       ^~~~~~~~~~~
/var/lib/jenkins/jobs/tc_335_release_clang40_boost_1.63.0_nopch/workspace/src/common/Logging/Log.h:159:32: note: expanded from macro 'TC_LOG_MESSAGE_BODY'
                    check_args(__VA_ARGS__);                            \
                               ^~~~~~~~~~~

(cherry picked from commit 303811399f289184a5080207007ea1c906f6a4ba)
2021-12-13 00:42:18 +01:00
ccrs 70fd6e7398 Core/Instances: improve DoRemoveAurasDueToSpellOnPlayers & DoCastSpellOnPlayers handling
(cherry picked from commit 22b3b21ae3e60c1f38b8e3bf1d7cd50ee5efca21)
2021-12-13 00:42:18 +01:00
ccrs cadbf42ea4 Misc: some corrections after recent merges
(cherry picked from commit 626a24822b3c6a5d5b9a4b29861ecf393fd9288b)
2021-12-13 00:42:18 +01:00
Sorikoff 996b7c1f0e Scripts/Spells: Ultrasafe Transporter: Toshley's Station (#23537)
* Scripts/Spells: Ultrasafe Transporter: Toshley's Station

* Rename 9999_99_99_99_world.sql to 2019_06_29_01_world.sql

(cherry picked from commit 33b4ad5a89cae0d3d527b58e1a438772450d7e32)
2021-12-13 00:42:18 +01:00
Sorikoff 7b08125c23 Scripts/Spells: Remove Collapsing Cave Aura (#23533)
* Scripts/Spells: Remove Collapsing Cave Aura

* Rename 9999_99_99_99_world.sql to 2019_06_29_00_world.sql

(cherry picked from commit 8d1a5fa1266dc98438cabfb1ced7891791245ff0)
2021-12-13 00:42:18 +01:00
Wyrserth 5ca9f51033 Core/Loot: fix issue that prevented players from rolling for an unique-category item while an equipped item shares the same unique-category.
(cherry picked from commit eb7a6391aafa5e618b2a565f0c2cfc2516dcee7e)
2021-12-13 00:42:18 +01:00
jackpoz 841630fcc3 Core/Misc: Fix static analysis issues reported by Coverity Scan
(cherry picked from commit de88691e257af0bf078d9be74ab3bb578f016547)
2021-12-13 00:42:18 +01:00
Sorikoff 88457030cc Scripts/Spells: Deathbolt (#23531)
* Scripts/Spells: Deathbolt

* Rename 9999_99_99_99_world.sql to 2019_06_28_01_world.sql

(cherry picked from commit 62b2c379b37b843076eb4df379e7de86b18303eb)
2021-12-13 00:42:18 +01:00
Sorikoff ea4c1ae7d0 Scripts/Spells: Dimensional Ripper - Area 52 (#23505)
* Scripts/Spells: Dimensional Ripper - Area 52

* Rename 9999_99_99_99_world.sql to 2019_06_28_00_world.sql

(cherry picked from commit 63f548921c268cc9f30af68bf9b41c80df0492ac)
2021-12-13 00:42:18 +01:00
Wyrserth 2fea2a1e81 Core/GameObject: do not allow consumable chests to restock while partially looted.
(cherry picked from commit cd73664f53db3daad6c7e17edbcd0212ab383c0d)
2021-12-13 00:42:18 +01:00
Wyrserth f136d3cfe0 Core/GameObject: fix some cases where summoned gameobjects of a type different than chest or goober would behave wrongly.
(cherry picked from commit 9f0ac0c24376ec70b8227a8fb0a1e0e686cb3256)
2021-12-13 00:42:18 +01:00
Wyrserth 575f42089e Core/Spell: fix some issues with taunt spells (#23425)
(cherry picked from commit 5dc2dfd60c4ecd243729e86496d926976e383156)
2021-12-13 00:42:18 +01:00
Wyrserth 9d40a105e6 Core/Mail: include 100g in the mail sent after turning in the quest The Wrath of Neptulon (#23500)
(cherry picked from commit cf223370f3345a7cfa39f8bfb23835391603f985)
2021-12-13 00:42:18 +01:00
Wyrserth 5c5bcba65a Script/ZulGurub: rewrite High Priest Thekal's encounter script (#23429)
(cherry picked from commit 365e2f191efa5576c0045a9ebdffe63e1ea3bac7)
2021-12-13 00:42:18 +01:00
Wyrserth c637260a37 Core/GameObject: implement restock mechanic for non-consumable gameobjects (#23526)
(cherry picked from commit e77c2d55c40bc9d4a15de471de754376f4ec1c49)
2021-12-13 00:42:17 +01:00
Killyana a71823811e DB/Loot: remove wrong loot from gameobjects Worn Wooden Chest and Captain's Footlocker.
(cherry picked from commit 1c373f29ff178ae3562963f85734cc75b4b4b437)
2021-12-13 00:42:17 +01:00