QAston
0bc23239d8
Core/Spells: Remove some incorrect spell attribute checks and add custom attributes instead - it's better to know that there is no attribute for something than to pretend there's one and do ridiculous checks.
2011-07-04 23:14:20 +02:00
QAston
3bf7035fe1
Core/Spells: Remove some redundant code.
2011-07-04 22:10:42 +02:00
QAston
5b79175b7a
Core/Spells: More spell attribute definitions.
2011-07-03 10:03:13 +02:00
QAston
29a7535638
Core/Spells: Define 2 more spell attributes: SPELL_ATTR6_CAN_TARGET_POSSESSED_FRIENDS and SPELL_ATTR6_CAN_TARGET_UNTARGETABLE
2011-07-02 17:06:19 +02:00
QAston
1068583172
Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
2011-07-02 16:12:43 +02:00
QAston
86dde83dda
Core/Spells: Define many unknown SpellCastTargetFlags enum values, rename some target type enum values to follow standards, also correctly implement TARGET_UNIT_TARGET_PASSENGER.
2011-07-02 16:12:19 +02:00
QAston
ce75ced741
Core/Spells: define SPELL_ATTR1_CHANNEL_DISPLAY_SPELL_NAME(0x20000000)
2011-07-01 13:12:19 +02:00
QAston
06515b27b3
Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
2011-07-01 12:48:21 +02:00
QAston
3b8dce669d
Core/Spells: Define attributes: SPELL_ATTR0_CAST_TRACK_TARGET(0x00400000), SPELL_ATTR1_CHANNEL_TRACK_TARGET(0x00004000), SPELL_ATTR0_ON_NEXT_SWING_2(0x00000400), add some attribute flag comments based on client research.
2011-07-01 12:47:26 +02:00
QAston
d3e887060d
Fix build.
2011-06-30 02:17:07 +02:00
QAston
fb9719c653
Core/Spells: Define SPELL_ATTR0_ABILITY (old SPELL_ATTR0_UNK4)
2011-06-30 01:47:09 +02:00
QAston
e79d46e499
Core/Spells: Correctly define TARGET_UNIT_NEARBY_PARTY(3) and TARGET_UNIT_NEARBY_ALLY(4) target types.
2011-06-30 00:49:10 +02:00
QAston
d31f53c16a
Core/Auras: Don't cache aura object fields in periodic damage aura handler, as it's not needed.
2011-06-30 00:00:20 +02:00
QAston
348adaf791
Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
2011-06-28 16:18:42 +02:00
QAston
11c3c80732
Core/Spells: Add SMSG_PROCRESIST packet handler.
2011-06-28 16:17:49 +02:00
QAston
e5db97a28e
Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
2011-06-26 19:32:41 +02:00
QAston
faaba1aa65
Core/Auras: Improvements in spell_linked_spell table handling, now auras with using this table have linked stack amount, also linked aura removal is called now when aura is removed on target death.
2011-06-26 19:31:11 +02:00
QAston
d2e1f5a259
Misc: Rename update sqls to follow the standards.
2011-06-26 13:58:34 +02:00
QAston
557e06b1c1
Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
2011-06-26 13:56:11 +02:00
QAston
ac88fa026f
Database/Spells: Add spell_proc table which is a replacement for spell_proc_event table. This is the initial patch from series of patches changing the way we currently handle procs in the core, and doesn't interfere with existing code in any way.
2011-06-26 13:54:44 +02:00
QAston
6dcee0c0ea
Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
2011-06-26 00:29:36 +02:00
QAston
2bcf63d387
Core/Spells: don't allow spells which hit target only with SPELL_EFFECT_DUMMY to execute spell triggers on that targets, also cleanup related code a bit.
2011-06-26 00:29:12 +02:00
QAston
b54b72ba54
Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
2011-06-23 15:52:30 +02:00
QAston
dc8a926c8d
Core/Auras: fix a typo in PowerDrain auras periodic tick handler.
2011-06-23 15:51:14 +02:00
QAston
3352cabb49
Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
2011-06-23 13:50:45 +02:00
QAston
31d32e28ee
Fix build
2011-06-23 13:49:22 +02:00
QAston
3137a82c7c
Core/Spells: Cleanup in Spell.h:
...
- Codestyle (fix function naming) and cleanup changes in SpellCastTargets class, also access variables of this class by getters/setters
- Move IsQuestTameSpell function to SpellMgr.h
- Move UnitList typedef to Unit.h
Additionally - add missing copyright notice to SpellAuraEffects.h
2011-06-23 13:28:52 +02:00
QAston
c4818f1892
Core/Auras: Fix refresh of auras with spellmodifiers applied to currently cast spell.
2011-06-21 19:59:17 +02:00
QAston
2ac777f8ce
Revert "Core/Auras: Fix work of proc auras are refreshed during proc event routine."
...
This reverts commit 2a47163771 .
2011-06-21 15:58:30 +02:00
QAston
fcc02a045a
Core/Auras: Remove auras with AURA_INTERRUPT_FLAG_HITBYSPELL on spell hit, only when target hit is enemy.
2011-06-21 15:57:18 +02:00
QAston
2a47163771
Core/Auras: Fix work of proc auras are refreshed during proc event routine.
2011-06-21 12:03:54 +02:00
QAston
aebb75b816
Core/Auras: Move periodic aura effect handlers to separate functions, do a little cleanup in these, also allow periodic dummy/periodic trigger spell auras to tick when caster is not available.
2011-06-19 13:13:41 +02:00
QAston
ebc9ead617
Core/DynamicObject: Delete DynObjAura on DynObj delete, not on aura remove from object (prevents crashes)
2011-06-16 00:55:27 +02:00
QAston
5bbeccd00f
Merge pull request #1921 from zwerg/master
...
Fix problem with removing immunities by Unit::ApplySpellImmune
2011-06-11 04:19:50 -07:00
QAston
34d980ea4c
Core/Auras: Move AuraEffect::TriggerSpell missing spell error log to debug.
2011-06-11 13:16:19 +02:00
QAston
677cbbb93a
Scripts: Fix some crashes occuring due to unsafe use of AuraScript::GetCaster() method.
...
There's "returns unit which casted the aura or NULL if not avalible" written in description of the method, but who cares...
2011-06-11 12:42:01 +02:00
QAston
76bb3ca21c
Core/Auras: Call Aura::HandleAuraSpecificMods in Aura::SetStackAmount to preserve compatibility with older scripts.
2011-06-11 10:55:19 +02:00
QAston
38de636e30
Core/Spells: Define some unknown spell attributes.
2011-06-11 10:55:17 +02:00
QAston
3ec587e21e
Core/Auras:
...
Make Aura::ModStackAmount(1) an equivalent of reapplying the aura
Recalculate periodic aura timers on aura reapply.
2011-06-11 10:55:17 +02:00
QAston
23d43c72b2
Core/Spells: Drop some redundant code.
2011-06-11 10:55:16 +02:00
QAston
0c3e99c450
Core/Auras: Move repeating code for aura packet creation to separate function. Fixes usage of SPELL_ATTR5_HIDE_DURATION attribute.
2011-06-08 10:41:32 +02:00
QAston
0575dddbb3
Core/Auras: Fix visibility aura effect handlers to work correctly on amount change
2011-06-08 09:19:34 +02:00
QAston
8f7be3d48a
Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
2011-06-07 22:26:14 +02:00
QAston
f74bc25af1
Core/Auras: Fix SPELL_AURA_MOD_DAMAGE_PERCENT_DONE aura handler to work correctly on amount change.
2011-06-07 22:25:39 +02:00
QAston
6c5f68e8fc
Core/Auras: Do not use spellmod system to drop auras with spell proc event entry.
2011-06-07 19:09:20 +02:00
QAston
b9e8e6d3b4
Core/Auras: Add functions for common actions on aura charges.
2011-06-07 17:26:27 +02:00
QAston
9542077c38
Core/Auras: Use recalculated aura max duration on spell hit for duration calculations.
2011-06-07 14:19:47 +02:00
QAston
3effdb2c23
Core/Auras: Add Aura::TryRefreshStackOrCreate function and remove stack checks from Aura::Create
2011-06-07 12:47:32 +02:00
QAston
506fedcfea
Changes missing from last commit.
2011-05-31 20:28:36 +02:00
QAston
7b5b95966e
Core/AuraScript: Add DoCheckAreaTarget hook to allow explicit area aura target selection.
2011-05-31 20:24:44 +02:00
QAston
0196192c7a
Core/Auras: Fix a typo, which broke AuraEffect::ChangeAmount function
2011-05-31 16:20:27 +02:00
QAston
8ff2ed69bf
Core/Auras: Fix *nix build
2011-05-31 16:03:27 +02:00
QAston
f3428cbad4
Core/Auras: Fix a crash in Unit::RemoveAurasDueToSpellBySteal
2011-05-31 15:30:41 +02:00
QAston
2d3f4687e5
Core/Auras: Prevent assertion fail in AuraEffect::HandleEffect
2011-05-31 14:50:54 +02:00
QAston
14bc68a291
Missaved file, thanks to Shauren for catch.
2011-05-29 15:54:46 +02:00
QAston
3c93cccdb1
Core/Auras: Prevent assertion fail due code in AuraEffect::HandleAuraLinked, also improve the sync between auras linked by this aura type.
2011-05-29 15:49:32 +02:00
QAston
854438fb8a
Core/Auras: add missing parenthesis.
2011-05-29 13:23:49 +02:00
QAston
42a20f14ef
Core/Auras: Use existing aura object on aura reapply/stack increase instead of creating a new one.
...
You can hook on reapply/stack event by checking for AURA_EFFECT_HANDLE_REAPPLY aura handler mode, AURA_EFFECT_HANDLE_REAL is now not triggered on aura refresh/stack.
2011-05-29 13:18:47 +02:00
QAston
fb1772e8c9
Core/AuraScripts: Allow to use AuraScript::GetTarget in AfterEffectRemove and AfterEffectApply hooks.
2011-05-26 17:44:07 +02:00
QAston
0762791754
Core/AuraScripts: Fix runtime error messages appearing in aura scripts when one hook is called from inside of another one.
2011-05-26 16:12:33 +02:00
QAston
79aa5233d7
Scripts/AuraScripts: Use AfterEffectApply and AfterEffectRemove hooks in scripts, where they fit better than On* hooks.
2011-05-25 19:12:41 +02:00
QAston
0eb89fc282
Core/SpellScripts: Better debug output on startup script validation.
2011-05-25 18:00:35 +02:00
QAston
a1b8fd2054
Core/AuraScripts: Add AfterEffectRemove and AfterEffectApply hooks, to allow safe triggering of spellcasts or other actions which may call linked events while OnEffectApply and OnEffectRemove are still there for overriding the way effect is handled on target.
2011-05-25 17:13:32 +02:00
QAston
ca8eb707d7
Core/Auras:
...
- Use safer order of calls in AuraEffect handlers (unit modification goes before any calls which may result in linked events execution)
- Allow manual removal of further effects of an aura during aura removal (so Unit::RemoveAurasByType works well in such situations)
2011-05-25 15:13:55 +02:00
QAston
432136355e
Scripts/Spell: Share some code for Incantner's Absorbtion script.
2011-05-15 19:04:09 +02:00
QAston
1121fcfb90
Core/Scripts: Remove hook GetAuraEffectTriggerTarget from CreatureAI.h
...
The hook was made for one obsolete script, which turned out to not work anyways.
2011-05-15 18:53:02 +02:00
QAston
fcc57b2c95
Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
2011-02-12 11:03:06 +01:00
QAston
fe2a848b8f
Core/Auras: Temporary fix for Aura::UpdateTargetMap assertion failure.
2011-02-12 11:00:56 +01:00
QAston
0b2c6426e5
Core/Auras: Add some debug info to trac the reason of Aura::UpdateTargetMap crash.
2011-02-06 14:02:38 +01:00
QAston
6e08e51976
Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
2011-02-06 13:17:59 +01:00
QAston
b5e78bf208
Core/Auras: Move code which uses polymorphism out of Aura constructor.
2011-02-06 13:17:29 +01:00
QAston
e9bae2d0a0
Core/Auras: Prevent possible crash on SPELL_AURA_DAMAGE_SHIELD aura handler.
2011-02-04 03:14:01 +01:00
QAston
f862db8b92
Core/Unit: Move code using polymorphism out of CharmInfo destructor - fixes issues introduced with 38ea569525.
2011-02-04 02:51:12 +01:00
QAston
38ea569525
Core/Unit: Remove code which depends on polymorphism from Unit class destructor (at destruction time virtual methods aren't working as excpected)
2011-02-04 01:23:49 +01:00
QAston
d18193e52d
Core/DynamicObjects: Change the way how dynamic objects are bound to their owners, fixes some crashes in Aura::GetOwner.
2011-02-04 00:27:43 +01:00
QAston
42d3130a56
Core/Auras:
...
Fix a crash with spell 33499 - BIG thanks to Shauren for finding the reason of this crash
Corrections in managing stacked auras which change unit model.
2010-12-31 18:12:20 +01:00
QAston
1b18a0ac65
Core/Auras: Fix aura positivity check after rev bb4bd46d21.
2010-12-31 16:12:29 +01:00
QAston
dd5a77bebc
Core/Auras: Recheck aura presence on target after calling linked events in charm and vehicle aura effect handlers.
2010-12-31 15:37:44 +01:00
QAston
4eccbb81af
Core/Auras: Recheck aura presence on target after calling linked events in aura effect handlers. Prevents undefined behavious when aura effect remove handler is called before apply handler is finished.
2010-12-31 14:39:18 +01:00
QAston
c220fbbc45
Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
2010-12-31 12:52:37 +01:00
QAston
bb4bd46d21
Core/Auras: Do not recheck aura positivity every aura effect apply/remove.
2010-12-31 12:50:17 +01:00
QAston
6c56f9e1b7
Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
2010-12-30 19:47:28 +01:00
QAston
3fc69f8619
Core/Spells: Remove some incanter's absorbtion code forgotten in previous rev.
2010-12-30 19:44:13 +01:00
QAston
8cd2c73e45
Core/ScriptSystem: Add OnEffectManaShield and AfterEffectManaShield hooks to AuraScript class. Usage of these is the same as similar Absorb hooks.
...
Scripts: Move Incanter's Absorbtion script from Unit::CalcAbsorbResist to AuraScript.
2010-12-30 19:05:19 +01:00
QAston
c8adcc95f9
Core/Unit: Move spell specific code from Unit::CalcAbsorbResist to AuraScripts.
2010-12-30 02:03:46 +01:00