Xanadu
06d4918163
Added unit targets for TARGET_TYPE_DEST_TARGET and TARGET_TYPE_DEST_CASTER to tackle the cases where unit targets are required but there is no other implicit target to produce them (like in 53, 0 combination).
...
This works in conjunction with my next commit.
--HG--
branch : trunk
2010-03-18 20:41:38 +01:00
silverice
aca2d26bc5
remove unused player's class member,cleanup
...
--HG--
branch : trunk
2010-03-18 20:21:42 +02:00
Xanadu
59e0d42260
Added (blizzlike) packet broadcast to near teleport. Thanks to Zor and nalimleinad (AKA anonymous colleague #1 ) for research.
...
--HG--
branch : trunk
2010-03-18 17:58:27 +01:00
Machiavelli
302af79bc2
Implement vendor item refund system.
...
For info about this system, see: hxxp://us.blizzard.com/support/article.xml?locale=en_US&articleId=27351
Thanks to:
- Opterman, Malcrom, Xanadu + anonymous colleagues for aiding research on packet structure
- Aokromes and Svannon for testing
--HG--
branch : trunk
2010-03-18 17:27:40 +01:00
Xanadu
72833e1584
Identified a new spell attribute forbidding some spells to use caster's done dmg mods (spellpower etc).
...
--HG--
branch : trunk
2010-03-18 17:22:11 +01:00
XTZGZoReX
793a226692
* Remove typeid check and fix cast target for Improved Fear. Patch by jesper.vortex.
...
* Closes #946 .
--HG--
branch : trunk
2010-03-18 14:57:39 +01:00
XTZGZoReX
1a6f216e91
* Cleanups and comments in Player::SendInitWorldStates.
...
--HG--
branch : trunk
2010-03-18 14:48:33 +01:00
Rat
2b096c478a
*always remove UNIT_FLAG_OOC_NOT_ATTACKABLE if crature enters combat and reset on leave combat
...
-Please post feedback if it breaks any script!
--HG--
branch : trunk
2010-03-18 00:01:39 +01:00
Rat
4f948651df
*Fix possible exploits with flying paths. by QAston
...
--HG--
branch : trunk
2010-03-17 23:16:35 +01:00
[email protected]
bef85de621
Add script for Amberpine Woodsmen Grizzly Hills
...
--HG--
branch : trunk
2010-03-17 18:27:17 -02:30
Xanadu
5603de6048
Argent Tournament Post script by Malcrom
...
--HG--
branch : trunk
2010-03-17 21:20:21 +01:00
Xanadu
6f6c7a85af
Merge
...
--HG--
branch : trunk
2010-03-17 21:17:02 +01:00
Xanadu
2c605ee482
Upgraded SCRIPT_COMMAND_EMOTE to do state emotes, too, based on datalong2 value. By Malcrom.
...
--HG--
branch : trunk
2010-03-17 21:00:44 +01:00
silverice
4177b876f3
Added hack that was removed in [7443]
...
Closes issue #979
--HG--
branch : trunk
2010-03-17 21:34:42 +02:00
Xanadu
48d7ae707d
Fixed players not being able to resurrect after core crash.
...
--HG--
branch : trunk
2010-03-17 20:34:02 +01:00
Xanadu
a73b9b0f1e
Cleanup
...
--HG--
branch : trunk
2010-03-17 17:43:28 +01:00
Xanadu
e5cbe017f4
Fixed Drain Soul increased damage for targets below 25% HP. Closes issue #394 . Closes issue #748 . Closes issue #938 . Rejoice, new era of server-side spells has begun!
...
--HG--
branch : trunk
2010-03-17 16:38:31 +01:00
Rat
4fb7bf3664
*fix Feral Spirit's healing (Spirit Hunt)
...
--HG--
branch : trunk
2010-03-17 08:07:14 +01:00
Anubisss
fe67a3bc6e
Fix some possible crashes.
...
--HG--
branch : trunk
2010-03-16 23:46:20 +01:00
Trazom62
6d63c432e6
Fix Hunter's spell Snake Trap.
...
Fixes issue #896 .
--HG--
branch : trunk
2010-03-16 21:32:01 +01:00
Trazom62
b00c745455
Update Halls of Stones script text entries to correct range.
...
Fixes issue #607 .
--HG--
branch : trunk
2010-03-16 21:24:00 +01:00
Machiavelli
53bfd0934a
Remove some files that were accidentaly added to last changeset.
...
--HG--
branch : trunk
2010-03-16 08:11:33 +01:00
Machiavelli
bbfdc117c8
Overload Item::SetState correctly in Item::SetItemRandomProperties.
...
Fixes issue #1126
--HG--
branch : trunk
2010-03-16 08:05:09 +01:00
reno
e65dfc6a31
attempt to stop mobs casting and fleeing while stunned or confused
...
--HG--
branch : trunk
2010-03-15 14:38:30 -05:00
Machiavelli
b0b17e56de
- Overload Item::SetState with player argument where possible to ensure updated data is saved to DB properly.
...
- Alter Item::SetEnchantmentDuration function, add parameter Player* because GetOwner() cannot be called in the function due to hashtable locking in the SaveAllPlayers process.
- Remove a sanity check prior to Item::AddToUpdateQueueOf, so assertions can detect whenever a higher level function was not called properly. Please report any crashes related to these assertions to get them resolved asap.
--HG--
branch : trunk
2010-03-16 01:05:56 +01:00
teacher
5b277b11a7
Moved sql update files to 3.3.2_old directory.
...
Fixed my typo in world.sql.
--HG--
branch : trunk
2010-03-15 23:43:20 +01:00
thenecromancer
a81ad6986c
Remove Hack detecting spell 61988 in HasAura()
...
Correctly cast 61988/61987 after casting Avenging Wrath/Divine Shield respectively
(This will correctly show both spells disabled state)
Don't allow casting Lay on Hands on self when aura 61988 is present (ie. after using Avenging Wrath)
--HG--
branch : trunk
2010-03-15 18:03:43 +01:00
Machiavelli
3ba0862926
Fix guild bank money log display.
...
--HG--
branch : trunk
2010-03-15 17:17:19 +01:00
Machiavelli
f9a3aedc14
Don't call Item::AddToUpdateQueueOf if no player is specified as parameter for Item::SetState, since in this case, only data stored in the item_instance table is altered, not that of character_inventory.
...
--HG--
branch : trunk
2010-03-15 14:52:02 +01:00
Machiavelli
c47b8a89c1
Fix issue with .save or .saveall where either the core would freeze, or items would not be saved to the DB properly.
...
Fixes issue #381
Fixes issue #477
--HG--
branch : trunk
2010-03-15 14:03:13 +01:00
Machiavelli
ce51f24ff3
Change field crc in characters.addons to int(32) to support proper values.
...
--HG--
branch : trunk
2010-03-15 13:24:45 +01:00
Xanadu
f9566e08ac
Properly implemented CONDITION_ACHIEVEMENT for the DB gossip system.
...
--HG--
branch : trunk
2010-03-15 04:37:28 +01:00
Xanadu
8cc3d2ad7f
Fixed Drain Soul and Shadowburn Soul Shard on target death. Closes issue 1058.
...
--HG--
branch : trunk
2010-03-15 02:59:21 +01:00
Trazom62
1845a9588d
Fix lootable check in Player::isAllowedToLoot.
...
--HG--
branch : trunk
2010-03-15 00:21:37 +01:00
Rat
c8fd37a9dc
*small tweaks to Utgarde keep bosses
...
--HG--
branch : trunk
2010-03-14 23:44:27 +01:00
Spp
f1696c42c9
Send SMSG_DESTRUCTIBLE_BUILDING_DAMAGE when a destructible building takes damage
...
Thanks to Opterman for the packet structure.
--HG--
branch : trunk
2010-03-14 21:10:21 +01:00
Trazom62
8d51d23cc5
Fix Master's call. Thanks Gyullo.
...
Fixes issue #1059 .
--HG--
branch : trunk
2010-03-14 13:46:15 +01:00
Trazom62
6fdaf225f3
Fix creature tapped and lootable dynamic flags => fix creature not lootable.
...
Fixes issue #1067 .
--HG--
branch : trunk
2010-03-14 00:22:53 +01:00
teacher
274268a686
Random sql cleanup.
...
--HG--
branch : trunk
2010-03-13 20:51:59 +01:00
Trazom62
7ff698b505
Fix SQL errors in world_script_texts.
...
--HG--
branch : trunk
2010-03-13 18:28:19 +01:00
Machiavelli
f56d65dc2a
Fix display of item enchantments in mailbox
...
--HG--
branch : trunk
2010-03-13 17:22:42 +01:00
XTZGZoReX
f8c5b9a4a7
** Cleanup in ObjectAccessor/HashMapHolder:
...
* Correctly lock the HashMapHolder on access.
* Use ObjectAccessor wrappers (GetPlayers, GetCreatures, GetGameObjects) instead of raw HashMapHolder<Type>::GetContainer.
* General code style cleanup.
--HG--
branch : trunk
2010-03-13 16:17:25 +01:00
Trazom62
76afec204d
Yet another crash fix due to invalid cast.
...
Fixes issue #1079 .
--HG--
branch : trunk
2010-03-13 12:51:37 +01:00
Trazom62
75a63297ca
Fix ScriptedAI::SelectUnit to support SELECT_TARGET_NEAREST and SELECT_TARGET_FARTHEST.
...
Remove duplicate select target function CreatureEventAI::SelectUnit.
--HG--
branch : trunk
2010-03-13 12:15:32 +01:00
Trazom62
4c9a9a02b0
Fix crash in boss_svala script + some cleanup.
...
Fixes issue #880 .
--HG--
branch : trunk
2010-03-13 11:48:43 +01:00
Spp
eb96718b5f
Add missing file in previous commit.
...
--HG--
branch : trunk
2010-03-13 07:12:20 +01:00
Spp
ff89bad0fe
Allow Battlegrounds and arenas to be disabled by DB.
...
wtlk arenas disabled by default.
- Player will continue to see all bgs using UI, but won't be able to join disabled bg's
- Gossip menu not shown for disabled Bgs/arenas
- Id 6 disabled = all arenas disabled.
- Only id 6 arena enabled = Gossip shown but unable to join any arena
--HG--
branch : trunk
2010-03-13 00:47:24 +01:00
Spp
e1a8e1b2c9
Fix compile after 7548.
...
Also reorder the columns of account onlinelist command
--HG--
branch : trunk
2010-03-12 20:43:46 +01:00
Anubisss
cb72277769
Fix a typo in a SQL.
...
--HG--
branch : trunk
2010-03-12 19:28:48 +01:00
Spp
673ab0019c
Some Ticket text formating changes to help addons to parse data
...
Linked issue 466
--HG--
branch : trunk
2010-03-12 19:20:11 +01:00
Spp
2cac9671ca
Add map and zone to account onlinelist command.
...
Closes issue 466
--HG--
branch : trunk
2010-03-12 18:55:41 +01:00
Spp
d2a3f9670f
Move vehicle accesories to DB.
...
Credit to Malcrom and Manuel for the idea and original patch
--HG--
branch : trunk
2010-03-12 18:19:50 +01:00
Machiavelli
19b646cdff
Typo (sorry)
...
--HG--
branch : trunk
2010-03-12 14:28:43 +01:00
Machiavelli
b085d8eadc
Fix faulty debug logging and a crash caused by improper typecasting. Fixes issue #1068
...
--HG--
branch : trunk
2010-03-12 14:25:43 +01:00
raczman
b23a85e810
Correct faction of Titan Relic in SOTA.
...
author: maxdestroyer
--HG--
branch : trunk
2010-03-12 11:53:30 +01:00
Xanadu
9f81a8ba5c
Fixed crash on player kill and cleaned up the code a bit. Closes issue 1062. Closes issue 1064.
...
--HG--
branch : trunk
2010-03-12 05:46:32 +01:00
Trazom62
8210a97e73
Fix achievement title check at startup.
...
--HG--
branch : trunk
2010-03-11 23:25:04 +01:00
Trazom62
856d41a7b5
Fix Val'anyr, Hammer of Ancient Kings. Thanks sombre88.
...
Fixe issue #910 .
--HG--
branch : trunk
2010-03-11 23:18:05 +01:00
Trazom62
8947cfd41c
Fix crash in getFactionTemplateEntry.
...
Fixe issues #1050 .
--HG--
branch : trunk
2010-03-11 23:12:44 +01:00
Trazom62
ed8c5ef6ff
Implement group loot for chest having GroupLootRules (go type=3, data15=1).
...
Implement round robin loot.
Implement round robin for underthreshold items (group loot and need befor greed).
Fix "all players pass" bug on creature.
Add SMSG_LOOT_LIST message to indicate looter (round robin or master).
And some other minor loot bugs.
Fixes issue #167 .
Fixes issue #247 .
--HG--
branch : trunk
2010-03-11 22:55:02 +01:00
Machiavelli
d9f257a18c
Allow spellid_x fields in item_template to be signed integers. Thanks to Svannon and RedSonja for testing.
...
--HG--
branch : trunk
2010-03-11 21:40:42 +01:00
thenecromancer
e1542df90c
Convert some C style casts to new functions
...
--HG--
branch : trunk
2010-03-11 20:51:31 +01:00
thenecromancer
01ee5399a7
Remove some Debug logs nobody needed anymore
...
they've also contained wrong typecast function, therfore this'll fix issue 1054
--HG--
branch : trunk
2010-03-11 19:57:23 +01:00
Xanadu
d2dfe54916
Merge
...
--HG--
branch : trunk
2010-03-11 16:56:07 +01:00
Xanadu
ebee705452
Fixed SCRIPT_COMMAND_ORIENTATION, orientation needs to be float. Credit to Malcrom.
...
--HG--
branch : trunk
2010-03-11 16:54:25 +01:00
n0n4m3
d8db56ec48
Add report unknown packets in the error log and close this packets.
...
--HG--
branch : trunk
2010-03-11 15:09:51 +03:00
Xanadu
4c7e599802
Fixed ACTION_T_COMBAT_MOVEMENT preventing waypoint movement in OOC state.
...
--HG--
branch : trunk
2010-03-11 01:56:47 +01:00
XTZGZoReX
d8520c04e8
* Add 2 unknown target flags.
...
--HG--
branch : trunk
2010-03-10 20:24:04 +01:00
Machiavelli
bb38d246f4
Minor code style cleanup
...
--HG--
branch : trunk
2010-03-10 16:24:48 +01:00
Machiavelli
35e1a1eda8
Use "REPLACE INTO" instead of "DELETE" + "INSERT INTO" in Item::SaveToDB call to fix a cause of items randomly disappearing (issue 925).
...
Note: due to the hierarchy of the function calls, it's not possible to use DB transactions in this function.
--HG--
branch : trunk
2010-03-10 16:16:29 +01:00
Machiavelli
d8fdf47c17
Overlooked ObjectMgr changes to reflect group table structure updates. Fixes issue #1046
...
--HG--
branch : trunk
2010-03-10 16:00:17 +01:00
XTZGZoReX
c603afb23e
* Another update of AiReaction.
...
--HG--
branch : trunk
2010-03-10 11:26:57 +01:00
Spp
103a61a358
Fix debug msg in Unit::SetCharmedBy
...
--HG--
branch : trunk
2010-03-10 09:01:17 +01:00
Spp
b957b2736b
Fix crash in group loading.
...
--HG--
branch : trunk
2010-03-10 08:58:22 +01:00
raczman
7fd1789109
Totem* casts.
...
--HG--
branch : trunk
2010-03-10 07:58:11 +01:00
Xanadu
ac270db251
Removed forgotten nonexistent colums from a query. Thank Aokromes for pointing a finger on it
...
--HG--
branch : trunk
2010-03-10 04:42:59 +01:00
XTZGZoReX
0038b2be0e
* Add GUID logging in Unit::SetCharmedBy.
...
--HG--
branch : trunk
2010-03-10 02:41:16 +01:00
XTZGZoReX
54df245bb2
* Update AiReaction enum.
...
--HG--
branch : trunk
2010-03-10 02:02:24 +01:00
Machiavelli
41cf8c173e
Fix quest reward money showing up as experience reward in quest reward offering dialogue. Fixes issue #829
...
--HG--
branch : trunk
2010-03-09 22:37:07 +01:00
Machiavelli
cf0a646cc0
Fix removal of action buttons by removing some redundant code.
...
--HG--
branch : trunk
2010-03-09 22:07:43 +01:00
Spp
9df357f5d9
Fix enchant items in trade window.
...
Original patch by Kierkegaard
closes issue #985
--HG--
branch : trunk
2010-03-09 21:11:54 +01:00
Machiavelli
6c725aa530
One overlooked redundant piece of code related to previous commit removed.
...
--HG--
branch : trunk
2010-03-09 21:10:34 +01:00
Machiavelli
24ab54f213
Small update to the group/party system.
...
- Fixes raid assistant privileges, Fixes issue #248
- Proper designation for Main tank and Main assistant roles
- Remove 2 redundant columns in DB, namely groups.mainTank and groups.mainAssist. These are now defined by the value of group_member.memberFlags
--HG--
branch : trunk
2010-03-09 20:33:59 +01:00
n0n4m3
e5eaa46a7f
Removed not needed #include AuthSocket.
...
--HG--
branch : trunk
2010-03-09 19:01:45 +03:00
n0n4m3
5411468f5d
Removed unused function bool AuthSocket::IsLag, also small code cleanup.
...
--HG--
branch : trunk
2010-03-09 18:53:22 +03:00
n0n4m3
269728b9ae
Implement ACE netcode for realm server. Original author derex.
...
--HG--
branch : trunk
2010-03-09 18:01:42 +03:00
n0n4m3
04e7a5bd39
Cleanup and applying code style to some Database files.
...
--HG--
branch : trunk
2010-03-09 15:45:34 +03:00
Spp
bd7ca7fdf3
Fix an incorrect say_text index in Razorfen Kraul.
...
By Aokromes
--HG--
branch : trunk
2010-03-09 13:27:25 +01:00
Spp
25b0be95aa
Typo in server shutdown command.
...
Original author VladimirMangos
Closes issue #57
--HG--
branch : trunk
2010-03-09 13:13:20 +01:00
Spp
cef249ff2c
Add level restrictions to some commands:
...
say, yell, emote, whisper, channel use, trade, auction, mail, tickets
By azazel. Closes issue #598
--HG--
branch : trunk
2010-03-09 12:58:48 +01:00
Spp
8034a6c48e
Rename 'Hostil' to 'Hostile'
...
Credits to NoFantasy (Mangos)
Closes issue #411
--HG--
branch : trunk
2010-03-09 11:11:10 +01:00
Spp
c716c0e5e5
Optimize vmaps extraction.
...
Thanks to Splinter <[email protected] >
Closes issue #857
--HG--
branch : trunk
2010-03-09 10:41:42 +01:00
Spp
6f4be37051
Limit ChatHandler::HandleModifyHPCommand to players. Closes issue #1031
...
--HG--
branch : trunk
2010-03-09 10:40:42 +01:00
p0wer
a4513c2559
Fix line endings.
...
--HG--
branch : trunk
2010-03-08 21:19:52 -06:00
silver1ce
3847e3be42
fix my typo in a4f4c51dca,
...
could not detect it earlier
Сloses #1029
--HG--
branch : trunk
2010-03-08 23:40:46 +02:00
thenecromancer
2cc15aee31
Fix crash in AuraEffect::HandleShapeshiftBoosts
...
Add check to Spell::EffectSanctuary before casting
(ensuring all appearances of "(Player *)" (whitespace incl.) are correct)
--HG--
branch : trunk
2010-03-08 17:20:25 +01:00
silver1ce
f63ee4050c
fix my typo
...
thanks to KingPin for pointing the problem
--HG--
branch : trunk
2010-03-07 21:36:39 +02:00
raczman
07f3b91426
Some Creature* casts moved to new ToCreature.
...
Added const Creature* ToCreature()
--HG--
branch : trunk
2010-03-07 18:30:53 +01:00
silver1ce
9a8f10fa30
avoid send movement packet at death twice, cleanup
...
--HG--
branch : trunk
2010-03-07 18:17:37 +02:00
raczman
91b8ee104e
Added new type-safe cast functions.
...
This, when properly used, should get rid of most memory corruption issues,
currently, casting types C-style with no checks leads to some abstract crashing.
Functionality is same as with dynamic_cast<>, but with no RTTI check - so when
casting into invalid type you will receive NULL, and most probably crash.
At the same time, i took the liberty to convert most Player* casts to ToPlayer().
Still needs crapload of casts being moved to new facility.
--HG--
branch : trunk
2010-03-07 15:20:19 +01:00