Commit Graph
17637 Commits
Author SHA1 Message Date
ariel- 9fa95b4b57 Core/Spells: Fix periodic rolling adding bonuses twice
Calculation is now done in CalculateAmount

(cherry picked from commit 93eda20d5cf6eeb34e1aee1b81469ba6e8fa7f0c)
2021-09-04 22:52:31 +02:00
Shauren 8a4e1119ac Core/Spells: Unify spell effect access api in both branches 2021-09-04 15:13:15 +02:00
Shauren 9d7eee1a8c Core/Auras: Fixed cherry-pick mistakes in Unit::RemoveMovementImpairingAuras and Unit::HasAuraWithMechanic 2021-08-30 23:21:14 +02:00
Shauren 407e5aea1a Core/Spells: Remove leftover code from old mechanic - default spellpower scaling coefficients 2021-08-30 23:17:12 +02:00
Shauren 6031b95ea7 Core/Spells: Remove outdated damage calculations from Spell::EffectSchoolDMG and Spell::EffectWeaponDmg 2021-08-30 21:21:51 +02:00
Shauren 3af33b9ff9 Warning fixes 2021-08-28 20:24:21 +02:00
Shauren aebf308368 Core/Spells: Fixed Spell::EffectWeaponDmg for spells with multiple damage effects
Closes #26717
2021-08-28 19:53:53 +02:00
Shauren 3dd75a49b1 Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers, it was commented out in almost every handler 2021-08-28 19:51:29 +02:00
Shauren bc2c76a5b8 Core/Spells: Refactor building SMSG_SPELL_EXECUTE_LOG to not create 192 empty vectors on every spell cast 2021-08-28 18:30:45 +02:00
Shauren b9647bdecc Core/Reputation: Fixed FriendshipReputationFlags::NoRepGainModifiers implementation 2021-08-28 18:03:30 +02:00
Shauren 8cc418460f Core/Misc: Fix gcc warnings 2021-08-28 16:08:33 +02:00
ariel- 962f6d7988 Core/Spells: rework part 5: GameObject casting
Closes #21330
Closes #18885
Ref #18752

(cherry picked from commit 45c5e1b9d63796d168339a44f63418f220cf2403)
2021-08-28 15:59:11 +02:00
ariel- 65dca120d3 Core/Spells: rework part 4: iterate over effects first
Ref #18395

Implement far spell queue processing
Closes #7395

(cherry picked from commit 080d2c6cd439acb2059adc4e24a279de98aa0db6)
2021-08-28 15:59:11 +02:00
ariel- f3548d45d0 Core/Spells: rework part 3: spells only handle at most one UnitAura and one DynObjAura during its lifetime
Closes #15088

(cherry picked from commit e8d5aa56cc48572d81e1898b7b4ff10cfa6d1957)
2021-08-28 15:59:11 +02:00
ariel- 52ae3c89d1 Core/Spells: rework part 2: Split up target selection logic
Target check only determines what kind of entities we can target, spell positivity determines if that entity is valid for attack/assist

Closes #8844

(cherry picked from commit 9b38a6352c0fe2499de54fd769aa1c721a410bda)
2021-08-28 15:59:11 +02:00
ariel- 1e1415a491 Core/Spells: rework part 1: Improved positive detection logic
(cherry picked from commit efeae33495c8b57ae04aeeb382ee85099ac0b600)
2021-08-28 15:59:11 +02:00
Shauren a91edcb952 Core/Creatures: Remove hover on death
(cherry picked from commit 241109327bf573460d488d707d7eb19f82f1350c)
2021-08-24 13:45:34 +02:00
Shauren f8c03a9066 Core/Creatures: Reworked setting move types in database
* Each move type has its own field instead of trying to combine everything in InhabitType
* Allow overriding movement separately for each spawn

(cherry picked from commit 592516ae69d89da3bcb0ede144644a3d2e0186e0)
2021-08-24 13:43:06 +02:00
joschiwald c94c561b85 Scripts/Misc: Fixed hover movement for Stormcaller Brundir
(cherry picked from commit e9aba10695cdf3520c6ae61815610051502b6f0b)
2021-08-24 12:46:53 +02:00
Chaouki Dhib 246699a173 Scripts/Misc: Hover script fixes
(cherry picked from commit 510bc0b7a0d4e8de60f69b922d03ad3a43c2a2cc)
2021-08-24 12:46:02 +02:00
Shauren 2e2b298618 Core/Movement: Fixed creature hover
Closes #15177

(cherry picked from commit 2baa81065ba27f0a6d278a8dd8a79b7c831e0a2b)
2021-08-24 12:44:38 +02:00
Treeston 994121e671 Core/CreatureAI: CheckBoundary -> IsInBoundary, better reflects what it does. Also moved to public so spellscript can use it.
(cherry picked from commit df639d85e4e82add71432ea0a4cba91f238a30ba)
2021-08-23 23:28:48 +02:00
Gooyeth 90b81a212e Core/Player: Do not remove auras from Gamemasters in arenas (#21568)
(cherry picked from commit 92b8a870bf423b439806ab39a8d5af0485e60ed8)
2021-08-23 20:03:40 +02:00
ariel- 08f4f9b324 Core/Conditions: validate object types when conditioning implicit spell targets with CONDITION_OBJECT_ENTRY_GUID
Closes #21569

(cherry picked from commit 34c3962b09dbb2b7a11e4ff0c08b2ab05ff63762)
2021-08-23 20:02:44 +02:00
ariel- e8e501609f Core/Entities: ghouls start with full energy
(cherry picked from commit 0c1e485e13d065b26e24b4226044246ae8ca0e4d)
2021-08-23 19:29:41 +02:00
ariel- 9f0204b357 Scripts/Command: build fix for horrible outdated boost version used by travis
(cherry picked from commit 68dde9f8c5467c5983078b190e58105f99dad75c)
2021-08-23 19:18:49 +02:00
Jeremy 43b944bf92 Core/Maps: Fixed outdoors check (#21551)
(cherry picked from commit 367db4e1d641b56d8d7df83320c14b283bd007ce)
2021-08-22 21:09:18 +02:00
Meji bca465a569 Core/Achievements: Several criteria fixes (#26839) 2021-08-20 09:41:13 +02:00
ariel- 0ae1ebedfe Core/Spells: explicitly disable non proccing auras when generating default procs
Closes #21529

(cherry picked from commit ad796318e8c34df177a935892f27c6a7b4f2f901)
2021-08-18 23:22:46 +02:00
ariel- 95c8eae123 Core/Auras: remove too strict checks in area auras, since a few aren't owned by its caster
Closes #21528

(cherry picked from commit 2d10429a2d788d6b3aead19bd91ed662bad38751)
2021-08-18 23:06:33 +02:00
ariel- b0a05812d2 Core/Auras: fixed SPELL_AURA_MOD_HIT_CHANCE honoring stack rules in all cases
Updates #21367

(cherry picked from commit 23808fe349e78118461c08ebe78c8892391be236)
2021-08-18 22:59:50 +02:00
ariel- 6c642f33b5 Core/Auras: added sanity checks for area auras having a different owner unit than caster
Closes #21517

(cherry picked from commit 54e841888621ce2ea6fbfde2f86842ec088cd575)
2021-08-18 22:57:52 +02:00
Shauren 065794ed66 Core/PacketIO: Do not send hotfix Status::Valid when we don't have a hotfix blob for current locale 2021-08-17 20:02:43 +02:00
Shauren 2fe70e5fd6 Core/Misc: Fix cherry-pick errors 2021-08-16 22:24:34 +02:00
Shauren c0261468c5 Core/Quests: Fixed quests not working after relogging
Closes #26823
2021-08-16 16:33:43 +02:00
Jeremy 38aa015196 Core/Battlegrounds: Update BattlemasterListFlags (#26819) 2021-08-15 23:41:27 +02:00
Traesh fb6761c273 Core/Spells Implement targets 133, 134, 135 : TARGET_UNIT_LINE_CASTER_TO_DEST_*** (#26786) 2021-08-15 11:09:46 +02:00
Traesh 4725941567 Core/AreaTrigger Update box searching to handle oriented boxes (#26772) 2021-08-14 20:08:40 +02:00
Jeremy 20d70abb2c Core/Battlegrounds: Change Battleground* argument to BattlegroundQueueTypeId (#26806) 2021-08-14 19:56:30 +02:00
Shauren 03f09ea16a Core/Items: Implemented secondary shoulder transmog appearance 2021-08-11 22:32:14 +02:00
Chaouki Dhib 30cfe3741a Core/Movement: Correct distance checking
Distance checking should always be in 3D, independently on if the mover has the ability to fly or not.

(cherry picked from commit 0fb133013c0c1c2c7f47c215435990822454d8f8)
2021-08-08 21:21:34 +02:00
Treeston 4b93059ec7 Core/Creature: Temporarily let Creatures violate dynspawn assumptions for pooled creatures. This should fix startup crashes until I can investigate and find a long-term fix. Tag #21519.
(cherry picked from commit 9fc6b13027d2d66a99b6bee49d3add23f2c0c8af)
2021-08-08 21:21:34 +02:00
Treeston 8757a80767 Core/Creature: Add another aggressive compatibility mode assertion to catch faulty dynspawn code.
(cherry picked from commit 3eab2d7efcc225696fe32f94687fd8e7b6755a2a)
2021-08-08 21:21:34 +02:00
ariel- d2878d47c9 Core/Globals: use proper type for smallint
(cherry picked from commit c9b730c767072225fdc2142908455c1d26e91fa8)
2021-08-08 21:21:34 +02:00
Treeston 552ce7c286 Core/VMap: Use fuzzy equality and gridmap tolerance for floor-finding. Closes #21338. Supersedes #21479.
(cherry picked from commit ec916db294760576ef4466d7e558f038dacecf20)
2021-08-08 21:21:34 +02:00
Treeston e47e95b6dc Core/VMap: Add outdoor state to Map::GetFullTerrainStatusForPosition. Add WorldObject::IsOutdoors, basic member access.
Ref #21479.

(cherry picked from commit e79c595b695ea5f35b8324efbb7741ccb102bce9)
2021-08-08 21:21:34 +02:00
Treeston 74cdf260e1 Core/Threat: Fix taunt logic relying on unspecified behavior by unordered boost heap iterators. Use ordered iterators instead, this is cheap for our use case anyway. This will make taunt behave consistently again.
Closes #21499.

(cherry picked from commit 71b5ed6832ac4162754ec50f53cd76305f8a187a)
2021-08-08 21:21:34 +02:00
ariel- 67a1a1d29b Core/GameObject: implemented gameobject_overrides table to change faction and flags values on a per-spawn basis
Updates #20957
Closes #20958

(cherry picked from commit 34967e9c32b2c7e871bb93f41609a3b08ad92931)
2021-08-08 21:21:34 +02:00
ariel- 4c8a49302f Core/GameObject: kill uninitialized, unused field from GameObjectTemplateAddon struct
(cherry picked from commit 02739c2cbb1c6956e26a21120ddef42d017923c2)
2021-08-08 21:21:34 +02:00
ariel- a1a00f823e Core/Entities: kill unused return value from Unit::HandleSpellClick
- AI hook will now receive the result by copy, as modifying it had no effect
- Some renaming: result->spellClickHandled, clickPair is actually clickBounds, the clickPair is the pair <creatureID, SpellClickInfo>

(cherry picked from commit 98d6258efdc07b53808ba6177e5427c65163bc0d)
2021-08-08 21:21:34 +02:00