95 Commits
Author SHA1 Message Date
Trisjdc 781c5a3b82 Core/Creatures: Remove resetting of UNIT_FLAG_IMMUNE_TO_PC on combat clearing
(cherry picked from commit 34ef05ce0bfa34855ce33fcdf2bf82d257ae6672)
2017-01-12 00:02:30 +01:00
Trisjdc a51ec98044 Core/Creatures: Reset unit flags/dynamic flags on Creature::SetDeathState(JUST_RESPAWNED)
(cherry picked from commit 132be2d25a3766c1ef2099fb65ef3cbcdf9705ae)
2016-04-02 17:49:20 +02:00
Trisjdc 93e77bfc7b Core/Players: Improve rest state handling, allow several rest states to be active
Fixes https://github.com/TrinityCore/TrinityCore/issues/15325

(cherry picked from commit c14b66c24c3c0afe222a0401171e882d4a1f98d9)

Conflicts:
	src/server/game/Entities/Player/Player.cpp
	src/server/game/Handlers/MiscHandler.cpp
2015-09-24 23:24:13 +02:00
Trisjdc b9b8d83eb6 Core/BGs: Reputation gained in BGs should be affected by SPELL_AURA_MOD_REPUTATION_GAIN
An example would be Diplomacy (Racial Passive)
2014-07-24 04:16:36 +01:00
Trisjdc 2ae9afa9e8 Core/BGs: Reputation gained in BGs should be affected by SPELL_AURA_MOD_FACTION_REPUTATION_GAIN 2014-07-24 04:09:38 +01:00
Trisjdc e2d6b9bf8c Core/Units: Properly remove auras that don't pass IsHighestExclusiveAura 2014-07-24 04:06:49 +01:00
Trisjdc f79e7d7640 Core/Spells: Unrelenting Assault shouldn't proc if the target isn't explicitly casting (turns out that UNIT_STATE_CASTING even a instant cast has a 'cast time') 2014-07-24 03:52:19 +01:00
Trisjdc c541f4f5de Scripts/Four Horsemen: Horsemen's main spells should only explicitly target players 2014-07-24 03:48:35 +01:00
Trisjdc 3f9f2e3ee5 Core/Units: IsNonMeleeSpellCast will no longer return false if there's an instant cast spell still arriving at the target with the caster doing a channel 2014-07-24 03:47:04 +01:00
Trisjdc 0e91a0e54c Core/Spells: Solving the double dips in Hammer of the Righteous 2014-07-24 03:40:05 +01:00
Trisjdc 4a197ba22a Core/PathGenerator: Split raycast paths into more points for better path z normalization. Solves many of the 'falling underground with charge' issues 2014-07-12 13:13:38 +01:00
Trisjdc dad9b01b26 Core/Spells: Fix Blink/_DEST spell effects when cast inside/near water 2014-07-05 15:35:21 +01:00
Trisjdc 124398feef Core/Spells: Improve charge path logic, get a point to the target and then reduce it by the necessary distance 2014-07-04 22:22:28 +01:00
Trisjdc 531de49fe7 Core/Spells: Spells which do not apply auras should not apply DR
- Solves issue where Intimidating Shout applied DR twice on the main target
2014-07-03 00:42:55 +01:00
Trisjdc 0ac6f16896 Merge pull request #12268 from Unholychick/patch_mimironnew
Scripts/Ulduar: Implement Mimiron
2014-06-28 12:17:32 +01:00
Trisjdc 78ffaf6ca6 Core/Spells: Implement CREATURE_TYPEFLAGS_PROJECTILE_COLLISION, and solve some targeting problems with TARGET_DEST_TRAJ 2014-06-27 16:58:46 +01:00
Trisjdc 0a641bace9 Core/Spells: Ensure Haunt's healing takes in consideration crit damage 2014-06-27 00:40:59 +01:00
Trisjdc 4ed4b165f1 Core/Misc: Define CREATURE_TYPEFLAGS_PROJECTILE_COLLISION 2014-06-27 00:39:24 +01:00
Trisjdc cac491bef8 Fix a warning picked by static code analysis (assignment of a temporary variable before destruction) 2014-06-25 01:03:24 +01:00
Trisjdc 85176f1488 Typo fix 2014-06-23 19:23:46 +01:00
Trisjdc 7a78d60d34 Core/Spells: Cloak of Shadows should not remove physical debuffs
Closes htps://github.com/TrinityCore/TrinityCore/issues/7581, probably others
2014-06-23 19:18:20 +01:00
Trisjdc 6cd8f8374c Merge pull request #11495 from PortgasDAce/patch-4
[4.3.4] [Core/Spells]: Fixed Ice Barrier scale calculation
2014-06-23 10:16:00 +01:00
Trisjdc 40b4cbb7f3 Merge pull request #12306 from PortgasDAce/patch-6
[4.3.4] [Core/Spells]: Renamed unk to SPELL_ATTR8_BATTLE_RESURRECTION
2014-06-22 23:08:57 +01:00
Trisjdc ddc8c35d1b Merge pull request #11750 from gecko32/upstream_master
core/spells: Cyclone & Farie Fire Piercing Cyclone
2014-06-22 09:07:11 +01:00
Trisjdc 83ebab72ac Merge pull request #12299 from SeTM/patch-1
Update SpellAuraEffects.cpp
2014-06-17 15:21:55 +01:00
Trisjdc 4191ad4cb2 DB/SpellGroups: Fix a couple of runtime DB errors from f27821486b 2014-06-17 00:29:29 +01:00
Trisjdc 24d834af17 Fixup 2014-06-16 14:03:21 +01:00
Trisjdc ddaafdb720 DB/SpellGroups: Fix Poison Stacking 2014-06-16 13:45:03 +01:00
Trisjdc e8df8ff4df Core/Auras: Implement stacking interaction between SPELL_AURA_MOD_TOTAL_STAT_PERCENTAGE and SPELL_GROUP_STACK_RULE_EXCLUSIVE_SAME_EFFECT. Allows BoK/BoS to stack while maintaining the strongest buff 2014-06-16 02:48:48 +01:00
Trisjdc e9bc7edeff DB/SpellGroups: Quick fixes in latest SQL 2014-06-16 02:45:26 +01:00
Trisjdc 0442ff5c99 Merge pull request #12284 from Unholychick/patch-mana
Core/Spells: Implement SPELL_ATTR7_CAN_RESTORE_SECONDARY_POWER
2014-06-16 01:32:19 +01:00
Trisjdc f27821486b DB/SpellGroups: Completely review of WotLK Stack Rules
Closes https://github.com/TrinityCore/TrinityCore/issues/4313, https://github.com/TrinityCore/TrinityCore/issues/1626, https://github.com/TrinityCore/TrinityCore/issues/5173, https://github.com/TrinityCore/TrinityCore/issues/5822, https://github.com/TrinityCore/TrinityCore/issues/12212, https://github.com/TrinityCore/TrinityCore/issues/3814, and probably others
2014-06-15 23:22:53 +01:00
Trisjdc 6098a5e43a Core/Auras: Add a new stack rule to handle cases where the aura that is 'stronger' prevails (SPELL_GROUP_STACK_RULE_EXCLUSIVE_HIGHEST) 2014-06-15 17:27:57 +01:00
Trisjdc aca3795fa7 Core/Spells: Skip adding CAST_FLAG_RUNE_LIST to rune spells if it's a triggered cast. Solves some of the occasional Death Knight rune visual issues 2014-06-15 15:00:56 +01:00
Trisjdc 4e81e3c194 Core/Vehicles: Define and implement VEHICLE_SEAT_FLAG_B_KEEP_PET 2014-06-15 14:57:04 +01:00
Trisjdc 4615aa60a5 Core/Spells: Define and implement CAST_FLAG_NO_GCD 2014-06-15 14:49:03 +01:00
Trisjdc c75b7942a8 Core/Spells: Partially revert 4992c0290b, and further implement SPELL_ATTR3_NO_DONE_BONUS (which is the correct way of doing this) 2014-06-12 21:23:37 +01:00
Trisjdc 12b8bf037f Quick fixup for previous commit 2014-06-12 20:13:07 +01:00
Trisjdc 4992c0290b Core/Spells: Change haste benefit to cast time formulas, may need further correction
- With these changes, Paladin/Death Knight mount summons will no longer benefit from haste
2014-06-12 20:03:52 +01:00
Trisjdc 48f426abc5 Core/Auras: Correct a typo that caused bad stacking of SPELL_AURA_MOD_MELEE_HASTE 2014-06-10 20:51:28 +01:00
Trisjdc b96b7c291a Core/Handlers: Move a couple of logs to debug, they can appear without anything abnormal due to client latency 2014-06-09 23:11:07 +02:00
Trisjdc f80384a1f2 Core/Spells: Anti-Magic shell should give immunity to all spells that belong to SPELL_SCHOOL_MASK_MAGIC regardless of dispel type 2014-06-09 23:10:55 +02:00
Trisjdc 3aa5b01d4d Core/GOs: When unlinking Fishing Bobber from player to prevent despawning, unlink from spell as well to prevent removing unwanted auras 2014-06-09 23:10:53 +02:00
Trisjdc f14be42e0c Core/Utils: Move EventMap to Util.h 2014-06-09 23:10:48 +02:00
Trisjdc 78f1cbfba5 Scripts/Items: Imp in a Ball 2014-06-09 23:10:47 +02:00
Trisjdc 46c7524084 Core/Players: Improve quest item adding/removal checks, solves cases where quest item removal (under specific conditions) incorrectly incompletes quests 2014-06-09 23:10:46 +02:00
Trisjdc 281527a9c3 Core/Spells: *Properly* solve the Disarm vs Bladestorm issue 2014-06-09 23:10:42 +02:00
Trisjdc 3dce4fabae Core/Spells: Swift Retribution should be reapplied when needed to be able to gain spellmods 2014-06-09 23:10:42 +02:00
Trisjdc e3b8cd5c7e Scripts/ToCr: Bosses shouldn't despawn so quickly 2014-06-09 23:10:41 +02:00
Trisjdc e0d08f5afb Core/Spells: Corpse Explosion should not be able to pick the Ghoul out of implicit targets 2014-06-09 23:10:40 +02:00
Trisjdc fbae790c1d Warning fix 2014-06-09 23:10:39 +02:00
Trisjdc ca6e9112e9 Core/WorldSession: After sudden disconnects, session should persist for a minute
- With this change, if a player alt-f4, he'll only fade from world after a minute
2014-06-09 23:10:37 +02:00
Trisjdc 94b6c1b544 Core/Maps: Allow logging players to enter in instances that have an encounter in progress 2014-06-09 23:10:36 +02:00
Trisjdc c755a51ce0 Core/Auras: Update model overwriting rules for SPELL_AURA_TRANSFORM 2014-06-09 23:10:35 +02:00
Trisjdc 95a94f89b2 Core/Spells: Fix Cheat Death formula 2014-06-09 23:10:34 +02:00
Trisjdc eb414532fe Core/CreatureAI: Implement CreatureAI::TalkToMap for all your map-wide talking needs. Could also replace Battleground::SendChatMessage 2014-06-09 23:10:33 +02:00
Trisjdc 0b3e391ac4 Merge pull request #11739 from Golrag/master
Core/Spells: Fixed Shadowstep taking the caster out of combat while it shouldn't
2014-06-09 00:53:28 +01:00
Trisjdc 38e12321a5 Merge pull request #12069 from Trisjdc/cheat_death
Core/Spells: Fix Cheat Death formula
2014-06-09 00:45:12 +01:00
Trisjdc 551c565746 Core/Handlers: Move a couple of logs to debug, they can appear without anything abnormal due to client latency 2014-06-08 23:11:42 +01:00
Trisjdc 91052574ac Core/Auras: Expanding functionality of SPELL_GROUP_STACK_RULE_EXCLUSIVE_SAME_EFFECT to be able to take care of aura effects inside their handlers
Currently handled:
- SPELL_AURA_MOD_RESISTANCE_PCT
- SPELL_AURA_MOD_STAT
- SPELL_AURA_MELEE_SLOW
- SPELL_AURA_MOD_MELEE_HASTE
- SPELL_AURA_MOD_DAMAGE_PERCENT_DONE

Necessary to allow stack rules such as BoK/BoS/Bok-Drums and others to be all in a target with all of the aura effects, yet with only the 'highest' effect active
2014-06-07 23:43:11 +01:00
Trisjdc 97046283b5 Core/Spells: Anti-Magic shell should give immunity to all spells that belong to SPELL_SCHOOL_MASK_MAGIC regardless of dispel type 2014-06-07 18:06:22 +01:00
Trisjdc 6abfdc1cea Core/GOs: When unlinking Fishing Bobber from player to prevent despawning, unlink from spell as well to prevent removing unwanted auras 2014-06-07 17:58:45 +01:00
Trisjdc eae18d8ed0 Core/Utils: Move EventMap to Util.h 2014-06-06 11:14:32 +01:00
Trisjdc b4b3e6f3a2 Scripts/Items: Imp in a Ball 2014-06-06 11:01:36 +01:00
Trisjdc bb01c60a52 Core/Players: Improve quest item adding/removal checks, solves cases where quest item removal (under specific conditions) incorrectly incompletes quests 2014-06-06 10:41:45 +01:00
Trisjdc afb7c705c2 Core/Spells: *Properly* solve the Disarm vs Bladestorm issue 2014-06-05 11:48:43 +01:00
Trisjdc 2282a4c359 Core/Spells: Swift Retribution should be reapplied when needed to be able to gain spellmods 2014-06-05 11:43:59 +01:00
Trisjdc d4bdfebd9e Scripts/ToCr: Bosses shouldn't despawn so quickly 2014-06-05 11:37:24 +01:00
Trisjdc d05bf542a5 Core/Spells: Corpse Explosion should not be able to pick the Ghoul out of implicit targets 2014-06-05 11:35:32 +01:00
Trisjdc 2a6d3fa67c Warning fix 2014-06-04 19:12:02 +01:00
Trisjdc d12737d9bb Core/WorldSession: After sudden disconnects, session should persist for a minute
- With this change, if a player alt-f4, he'll only fade from world after a minute
2014-06-03 01:12:34 +01:00
Trisjdc 18868f5cbd Core/Maps: Allow logging players to enter in instances that have an encounter in progress 2014-06-03 00:57:36 +01:00
Trisjdc d99f0362cb Core/Auras: Update model overwriting rules for SPELL_AURA_TRANSFORM 2014-06-03 00:39:20 +01:00
Trisjdc 8db02c52ac Core/Util: A couple useful new functions for EventMap, as well as getting rid of some old junk 2014-06-02 23:59:35 +01:00
Trisjdc 1301ad800b Core/Spells: Break 'Fear' and similar auras on damage sharing of SPELL_AURA_SPLIT_DAMAGE_PCT 2014-05-28 22:22:54 +01:00
Trisjdc 9f50dd3bd6 Core/PetAI: Pin should not be interrupted if the victim has a breakable aura 2014-05-28 21:52:01 +01:00
Trisjdc 0e32789cd2 Core/Spells: Missing target conditions for Divine Hymn/Hymn of Hope's second effect 2014-05-26 20:42:53 +01:00
Trisjdc fd753a6105 Core/Players: Implement resting for areas with AREA_FLAG_REST_ZONE_ALLIANCE or AREA_FLAG_REST_ZONE_HORDE 2014-05-25 15:05:15 +01:00
Trisjdc 0ce6824a86 Core/Collision: Solve collision issues with GAMEOBJECT_TYPE_DOOR GOs 2014-05-25 11:35:51 +01:00
Trisjdc 45fcc2ff9d Core/Collision: Solve collision issues with non spawned GOs 2014-05-25 11:34:26 +01:00
Trisjdc 51b782a91e Core/Auras: Solve exploit involving SPELL_AURA_MOD_DAMAGE_DONE and weapon swapping 2014-05-24 19:01:05 +01:00
Trisjdc ea1c4a355c Core/Spells: Sniper Training should refresh every 6 seconds if all conditions are met 2014-05-24 18:57:26 +01:00
Trisjdc 4793f20506 Core/Spells: Nitro Boost should not fail in dungeon maps 2014-05-22 14:40:21 +01:00
Trisjdc 4d3156e0b8 Core/Achievements: Fix ACHIEVEMENT_CRITERIA_TYPE_GET_KILLING_BLOWS 2014-05-21 15:10:15 +01:00
Trisjdc c273f5368a Core/Spells: Players with active pets count as if they were players in combat against spells with SPELL_ATTR1_CANT_TARGET_IN_COMBAT 2014-05-18 11:36:12 +01:00
Trisjdc 8aee9dd948 Core/PetAI: Pet's owner should NOT enter combat when the pet attacks/enters combat 2014-05-18 11:00:48 +01:00
Trisjdc 9bad26fc88 Core/SAI: Clear UNIT_STATE_EVADE immediately if we're about to follow a target on EnterEvadeMode (MoveFollow does not clear evade) 2014-05-16 19:46:02 +01:00
Trisjdc 50336af1c7 Core/SAI: Prevent nullifying damage, because of player damage requirements 2014-05-15 17:05:02 +01:00
Trisjdc c85710e148 Core/Spells: Fix Cheat Death formula 2014-05-15 17:02:14 +01:00
Trisjdc 593fb9b68a Scripts/SWP: Sathrovarr will no longer cause player teleports on grid load 2014-05-13 11:32:56 +01:00
Trisjdc 11f6eb91c0 Core/Spells: Fix fishing on areas with liquid data but no valid height 2014-05-11 14:43:12 +01:00
Trisjdc 106c54cf25 Core/CreatureAI: Implement CreatureAI::TalkToMap for all your map-wide talking needs. Could also replace Battleground::SendChatMessage 2014-05-09 10:19:44 +01:00
Trisjdc 0c0dc2fdb9 Core/Players: Fix haste rating formulas. They're supposed to be the addition, not the multiplication of all available bonuses
- This change matches client formulas
2014-05-08 13:42:55 +01:00
Trisjdc cb7668ab5a Core/Spells: Replace MovePosition by MovePositionToFirstCollision in spell dest target handling.
- Solves issues such as being able to summon creatures inside terrain/gameobjects, being able to fall through terrain by using Shadowstep/Feral Charge (Cat), and much more
2014-05-07 11:58:08 +01:00
Trisjdc 719a00e926 Core/Spells: Define and implement SPELL_ATTR7_NO_PUSHBACK_ON_DAMAGE 2014-05-05 16:33:30 +01:00