Scripts/Ulduar: Fix a visual issue with Mimirons Rocket Strike and Fix Mimiron DB target attacking players
(cherry picked from commit 66bbdfb82cc27eb6fd39b93e8c11ea0aedf21c75)
Conflicts:
sql/updates/world/2015_07_26_05_world.sql
New Scripts:
Army Transform
Festering Strike
Glyph of Death's Embrace
Glyph of Foul Menagerie
Glyph of Runic Power
Glyph of the Geist
Glyph of the Skeleton
Periodic Taunt
Soul Reaper
Unholy Blight
Updated to 6.x:
Anti-Magic Shell
Blood Boil
Death and Decay
Death Coil
Death Pact
Death Strike
Icebound Fortitude
Raise Dead
Vampiric Blood
Will of the Necropolis
Deprecated and removed Scripts:
spell_dk_anti_magic_shell_raid
spell_dk_anti_magic_shell_self
spell_dk_anti_magic_zone
spell_dk_blood_gorged
spell_dk_butchery
spell_dk_death_strike_enabler
spell_dk_improved_blood_presence
spell_dk_improved_frost_presence
spell_dk_improved_unholy_presence
spell_dk_necrotic_strike
spell_dk_pestilence
spell_dk_presence
spell_dk_rune_tap_party
spell_dk_scent_of_blood
spell_dk_scourge_strike
Closes#13759
Adds SpellScript hook to execute scripts after succesful dispels, example could be warlock pets Devour Magic, which should only trigger when succesfully dispelling an aura.
Checking the worldobjects GUID against the iterators GUID instead of pointer to worldobject against pointer to iterator, as 2 different pointers may point to the same object.
Closes#12670
Closes#9754
Players should never have been affected by SPELL_AURA_PREVENTS_FLEEING in the first place.
Curse of Recklessness will no longer prevent Fear effects, only prevent NPCs from fleeing (e.g. at low health).
Judgement of Justice will no longer prevent Fear effects, but will only prevent NPCs from fleeing (e.g. at low health).
Source: http://www.wowwiki.com/Patch_3.0.2
TODO:
Make ACU hover properly (not fly, but hover).
Fix laser barrage visual not always being infront of VX-001. Problem is
caused by bad orientation update on spellcast.
spells without this attribute will no longer energize secondary power.
Druids in cat form will no longer be able to replenish mana from every kind of spell
Change behaviour of single target periodic aura ticks to be more blizzlike
Also add some missing handling of SPELL_AURA_MOD_CREATURE_AOE_DAMAGE_AVOIDANCE
Fixes Deep wounds and Chimera Shot Serpent
Remove an ancient hack with Drain Soul, spell id 100001 can now be deleted from spell_dbc table
Allows Rolling dot mechanics and allows DK's to roll diseases with pestilence,
see link for info:
http://forums.elitistjerks.com/topic/82503-frost-dps-in-333this-will-be-a-day-long-remembered/page-88
Change behaviour of single target periodic aura ticks to be more blizzlike
Also add some missing handling of SPELL_AURA_MOD_CREATURE_AOE_DAMAGE_AVOIDANCE
Fixes Deep wounds and Chimera Shot Serpent
Remove an ancient hack with Drain Soul, spell id 100001 can now be deleted from spell_dbc table
Allows Rolling dot mechanics and allows DK's to roll diseases with pestilence,
see link for info:
http://forums.elitistjerks.com/topic/82503-frost-dps-in-333this-will-be-a-day-long-remembered/page-88
Spells with this attribute will ignore damage taken auras except for mechanic damage taken (trauma, etc) and will ignore resilience because the damage caused by those spells is based off another spell' damage
Corrects the logic for dot/hot procs and fixes spells such as althor's abacus, egg of mortal essence, black magic, spiritual attunement etc etc.
Reverts the remaining part of 8edf6247c0
This wasnt the correct way to fix trinkets and talents that should proc on periodic heals, as it also made talents that procs off spells with casttime proc...
Mentioned are affected, but there is a potential fix in:
https://github.com/TrinityCore/TrinityCore/issues/1896
NOTE to self: learn to use the proc_flag table
Unholychick