100 Commits
Author SHA1 Message Date
Ovahlord f40c449734 Scripts/HoL: apply some missing scripting standards to all files
(cherry picked from commit adff72b485dcb1e7bf5558df01ef32415e46d776)
2026-06-23 22:44:09 +02:00
Ovahlord c255d62964 Core/Spells: allow players to absorb fire damage from environmental damage spell effects
(cherry picked from commit 6d81f226a071b4ee62e2b637b8d0ff3f06989f85)
2026-05-28 23:31:18 +02:00
Ovahlord 970a3dec18 Core/Player: return player corpse locations by reference instead of creating copies
(cherry picked from commit d11d992df9e15503c321ffcce566f13923f51508)
2026-05-26 23:08:27 +02:00
Ovahlord 2307a2313f Scripts/Westfall: scripted Overloarded Harvest Golem visuals * removed somple duplicate spawns and event related spawns that are already spawnt
(cherry picked from commit https://github.com/The-Cataclysm-Preservation-Project/TrinityCore/commit/7f6e63f850aaf71668dedd8394f023eff2ef8452)
2025-09-27 16:33:54 +02:00
Ovahlord 4dd4cfef8f Core/Guilds: corrected logging for guild reward db errors
(cherry picked from commit 3b2e2195eabec2f66edd805aa2582069e2335cad)
2025-04-16 12:14:09 +02:00
Ovahlord 642e0f2148 Core/Quests: corrected error logging for quest loading helpers
(cherry picked from commit 2e971321cf4648a5deceb73074967d48fc94c020)
2025-04-16 11:54:02 +02:00
Ovahlord 4fd81f6296 DB/Hotfixes: fixed sql added in 8ee03b0108 2025-04-12 23:49:47 +02:00
Ovahlord 8ee03b0108 DB/Gossips: added Classic exclusive npc_text entries to reduce differences between branches 2025-04-12 23:44:37 +02:00
Ovahlord 6de1e51a2f Core/Database: Implement accessing query result fields by name 2025-03-13 12:41:00 +01:00
Ovahlord da07737f9f Core/Scripts: updated more documentation comments for spell script hooks to match with the rest
(cherry picked from commit 71ec8c93acef3dce14eaf52e756ef68a3159050a)
2025-02-22 07:53:19 +01:00
Ovahlord 72ec1ae7c4 Core/Scripting: updated documentation for CalcDamage and CalcHealing hooks
(cherry picked from commit 6580687980bd3f5440eefd421dcbf894a39326fe)
2025-02-22 07:46:06 +01:00
Ovahlord 2b1ad96be1 Build: enable MSVC warning C5038 - member initialization order to get closer to the warning behavior of the other compilers
(cherry picked from commit e36a66d6322f51a201bb394a9fd4b7943cdd805f)
2025-02-04 16:20:39 +01:00
Ovahlord 4b7465aad8 Core/Spells: send rune cooldowns even after miss to match sniff data
(cherry picked from commit 7d5e794fd368a95d838b6ff33250460e6a6a634c)
2025-01-12 19:10:31 +01:00
Ovahlord 1dc2e8fdc5 Core/Spells: corrected refunding runes - they don't get put on a cooldown and don't send cooldowns for spells which had their runes refunded
(cherry picked from commit dbe2f1ee7ef90db0bdd60b29126f8a689a9e3548)
2025-01-12 19:10:19 +01:00
Ovahlord d9c2720393 Core/Spells: fixed power check for runes when casting spells - these have their own check and don't require the default one
(cherry picked from commit 7f29956937b807c371ee3f3057d96f7601b4bc19)
2025-01-11 21:43:31 +01:00
Ovahlord 06b106b06a DB/GameObjects: fixed phasing of several gameobject spawns in Acherus: The Ebon Hold
(cherry picked from commit 686e575b6faa9feb6d91908374bfe4716d477d04)
2025-01-02 16:38:08 +01:00
Ovahlord aefcd2fac7 Core/Units: moved melee attack rage generation into Unit::AttackerStateUpdate and send the generated rage in combat log packet instead of power update packets
(cherry picked from commit b179a7246d0383a6e0517107844611fa676b71c8)
2024-12-27 12:04:05 +01:00
Ovahlord 3997b857c2 Scripts/OutdoorPvp: converted two raw pointers into smart pointers to fix possible memory leaks
(cherry picked from commit 0b842d44d98c1d3fe3817e808a4eb07be9b6d6b0)
2024-12-25 10:45:47 +01:00
Ovahlord e721334828 Core/Database: removed more duplicate aliases from prepared statements 2024-12-14 22:50:34 +01:00
Ovahlord a69def739b Core/Quests: assign a unique alias to ID fields loaded from quest_visual_effect 2024-12-14 22:04:45 +01:00
Ovahlord e14648eaba Core/Player: moved zone/area updating and tavern resting checks into Heartbeat and movement updates
(cherry picked from commit cb4c9009b3706a2823ada05eec9803a773f9b34e)

# Conflicts:
#	src/server/game/Entities/Player/Player.cpp
2024-10-23 20:12:33 +02:00
Ovahlord f26c942053 Core/Auras: fixed a possible underflow when checking required powers for SPELL_AURA_TRIGGER_SPELL_ON_POWER_AMOUNT and SPELL_AURA_TRIGGER_SPELL_ON_POWER_PCT 2024-09-21 22:23:42 +02:00
Ovahlord b0b81dd31b Misc: added cata_classic to the issue template branch selection 2024-08-04 14:24:04 +02:00
Ovahlord bebd02925d Core/Logging: fixed nopch build for msvc compilers (#30126) 2024-07-31 16:37:48 +02:00
Ovahlord a3db80ce58 Core/PacketIO: increased allowed storage size of ByteBuffer from ~10mb to ~100mb and fixed a logic mistake that was allowing first-time append calls to bypass that size limit (#30037) 2024-06-15 18:12:18 +02:00
Ovahlord 728e7c7fcf Core/Cryptography: dropped support for OpenSSL 1.1
OpenSSL 1.1 has been deprecated for quite some time now so it is time to put it to rest. Please upgrade to OpenSSL 3.x
2024-05-12 15:48:39 +02:00
Ovahlord 24bda9c73d Core/Combat: reset the ThreatManager update interval upon engaging the creature and move ThreatClear packet sending into the update cycle to mimic retail behavior (#29949) 2024-05-02 22:50:20 +02:00
Ovahlord 11f32a2427 Core/Creatures: moved combat pulse into heartbeat handling and implemented CREATURE_STATIC_FLAG_2_FORCE_PARTY_MEMBERS_INTO_COMBAT (#29946) 2024-04-28 16:09:43 +02:00
Ovahlord 55ce5b150f Core/Auras: Implemented OnHeartbeat AuraScript hook and refactored an aurascript to use it as example (#29945)
* Updated Amalgam's Seventh Spine dummy aura script to use the new AuraScript hook
2024-04-27 19:04:10 +02:00
Ovahlord 253f306a41 Core/Units: moved Vignette updating into Heartbeat handling 2024-04-27 14:51:56 +02:00
Ovahlord d60b4e5b19 Core/Auras: implemented PROC_FLAG_HEARTBEAT and moved food/drink emote mechanic into heartbeat handling (#29943)
* also fixed an false assumption that only one of the food emotes can be played. They can in fact be both done at the same time.
2024-04-27 13:43:50 +02:00
Ovahlord b5ce4a66df Core/Creature: implement overriding creature static flags based on spawnId and difficultyId (#29940) 2024-04-26 22:32:17 +02:00
Ovahlord 5a169f6eae Core/Player: moved indoors/outdoors aura interrupting mechanic into heartbeat and movement handling 2024-04-26 14:21:09 +02:00
Ovahlord c2fedbb6cc Core/Units: moved cyclic spline synchronization mechanic heartbeat handling 2024-04-26 14:21:09 +02:00
Ovahlord 80d72a2c91 Core/Player: moved the periodic group update mechanic into heartbeat handling 2024-04-26 14:21:09 +02:00
OvahlordandMykhailo Redko bf9cd88ceb Core/Objects: implement internal heartbeat timer for WorldObjects (#29941)
This is the first step of porting the functionality of #25822 by cutting each change into a nicely self-contained commit

---------

Co-authored-by: Mykhailo Redko <[email protected]>
2024-04-26 01:14:48 +02:00
Ovahlord 47c14bedef Core/Items: allow all soulbound common and poor items to unlock their appearance to reflect patch 10.0.5 changes 2024-03-01 01:39:41 +01:00
Ovahlord 70121171be DB/Creatures: added some movement static flags and wander distance data for some Kelp'thar Forest creatures 2024-03-01 00:17:00 +01:00
Ovahlord 4e8e3d8fb8 Core/Creature: corrected swimming toggle behavior for amphibious creatures 2024-03-01 00:15:14 +01:00
Ovahlord 465c1d682a DB: fixed query added in b04ab91edd 2024-02-29 20:41:45 +01:00
Ovahlord b04ab91edd DB/Creatures: fixed assignment of CREATURE_STATIC_FLAG_SESSILE, CREATURE_STATIC_FLAG_CAN_SWIM and CREATURE_STATIC_FLAG_3_CANNOT_SWIM static flags 2024-02-29 20:38:58 +01:00
Ovahlord fb3e6737da Core/Movement: require a minimum wander_distance value of 0.1 and check the path length of generated random movement (#29766)
this serves as a means to reduce the console spam caused by failed spline validation
2024-02-29 15:52:25 +01:00
Ovahlord c541eda54d Core/Creatures: implemented most movement related static flags and migrated existing movement data into static flags (#29541)
* implemented CREATURE_STATIC_FLAG_AQUATIC - creatures cannot leave liquids
* implemented CREATURE_STATIC_FLAG_AMPHIBIOUS - creatures can enter and leave liquids but remain on the ocean floor when swimming is not enabled until engaged
* implemented CREATURE_STATIC_FLAG_FLOATING - creatures have their gravity on spawn / reset disabled
* implemented CREATURE_STATIC_FLAG_SESSILE - creatures are rooted in place
* implemented CREATURE_STATIC_FLAG_CAN_SWIM - creature can swim in liquids
* implemented CREATURE_STATIC_FLAG_3_CANNOT_SWIM - Amphibious creatures cannot toggle on swimming
* implemented CREATURE_STATIC_FLAG_3_CANNOT_TURN - Creatures cannot turn at all
* implemented CREATURE_STATIC_FLAG_4_PREVENT_SWIM - Amphibious creatures won't toggle on swimming until their victim starts leaving the ocean floor
* partially implemented CREATURE_STATIC_FLAG_3_CANNOT_PENETRATE_WATER
* deprecated CREATURE_FLAG_EXTRA_NO_MOVE_FLAGS_UPDATE as this flag was a hackfix to a wrong implementation that is now gone
2024-02-29 14:43:37 +01:00
Ovahlord 6c15fb00e5 Core/Units: Update facing spline movement immediately after launching (#29494) 2024-02-25 15:12:46 +01:00
Ovahlord 7199ccf156 CMake: added MySQL 8.3 to FindMySQL cmake macro 2024-02-07 09:16:12 +01:00
Ovahlord 924efc89b2 Core/Players: fixed a possible crash in SendInitialPacketsBeforeAddToMap when uninstanced maps don't have a valid MapDifficulty entry 2024-01-29 16:44:23 +01:00
Ovahlord c4a03b9931 Scripts/Baradin Hold: cleaned up some leftovers from Argaloth's rework and applied some missing coding standards 2024-01-23 10:33:00 +01:00
Ovahlord ccc083593a Core/Loot: implemented a custom server config setting to enable or disable AE loot (#29602)
This config primarily serves as a means to reduce potential code differences between the master and classic branches as now we no longer have to meddle with code
2024-01-23 00:55:57 +01:00
Ovahlord b3ccf7b710 Scripts/Baradin Hold: rewrite Argaloth encounter (#29604)
* handle all missing mechanics and visuals
* modernized instance script
2024-01-22 12:33:11 +01:00
Ovahlord b81fa2e8a3 Core/Object: use the final keyword for several (World)Object classes that should not get derived from (#29585) 2024-01-22 08:57:06 +01:00
Ovahlord ba627c1d1c Core/Creatures: fixed a logic mistake in personal skinning loot that was causing creatures without loot to despawn instantly (#29586) 2024-01-16 23:49:03 +01:00
Ovahlord 2f6ed2c203 Core/Units: moved health and power ordering predicates from Unit header into CommonPredicates (#29584) 2024-01-16 20:18:25 +01:00
Ovahlord ea093fef27 Core/Units: moved CharmInfo class and its definitions into a own file (#29583) 2024-01-16 18:43:32 +01:00
Ovahlord 97af0c31af Core/Maps: implement LIQUID_MAP_OCEAN_FLOOR to identify units that are on the bottom of a liquid (#29545) 2024-01-02 19:46:44 +01:00
Ovahlord bfb9fd8a2c Core/Maps: restored a hack in gridmap liquid status code to solve precision issues (#29544)
Closes #29543
Closes #22020
2024-01-02 19:40:34 +01:00
Ovahlord 4a61675191 Scripts/Halls of Origination: modernized creature accessing via data type 2023-12-25 18:06:44 +01:00
Ovahlord 01b1216058 Scripts/Halls of Origination: implemented Lift of the Maker's console to allow players to control the elevator to reach the 2nd floor after defeating Anraphet or Earthrager Ptah 2023-12-25 17:52:05 +01:00
Ovahlord 5c6040feba Scripts/Halls of Origination: modernized scripting models to current standard
* dropped a deprecated hack spellscript from Anraphet
2023-12-25 17:16:03 +01:00
Ovahlord 75300c90b6 Scripts/Halls of Origination: updated boss state and npc enums to current standard 2023-12-25 17:02:56 +01:00
Ovahlord db9a460015 DB/RBAC: restored the RBAC permission entries for the .instance set/getbossstate commands 2023-12-24 06:30:33 +01:00
Ovahlord 0db162790c Core/Common: fixed nopch build for msvc compilers (#29516) 2023-12-24 06:01:47 +01:00
Ovahlord 8187625b27 DB: corrected file name of the sql file that has been added in 32df6ee550 2023-12-24 05:44:13 +01:00
Ovahlord 44921878f1 Scripts/Vortex Pinnacle: implemented Slipstreams and shortcuts 2023-12-24 05:41:44 +01:00
Ovahlord b6a35c7920 CMake: added MySQL 8.2 to FindMySQL cmake macro 2023-12-22 16:40:43 +01:00
Ovahlord 32df6ee550 Scripts/Vortex Pinnacle: added base instance script and definitions 2023-12-22 14:53:52 +01:00
Ovahlord 6e7a4e733a Scripts/Shadowfang Keep: added definitions for the doors and added a comment regarding their usage 2023-12-22 14:36:55 +01:00
Ovahlord 06917b6c43 Scripts/Shadowfang Keep: dropped deprecated scripts and updated instance script and definitions to Cataclysm 2023-12-22 14:29:48 +01:00
Ovahlord 50a2166fb1 Scripts/Deadmines: dropped deprecated scripts and updated instance script and definitions to Cataclysm 2023-12-22 12:51:05 +01:00
Ovahlord cb5eb983b0 Scripts/Grim Batol: added base instance script and definitions 2023-12-22 12:22:19 +01:00
Ovahlord 12f6ac21d9 Scripts/Well of Eternity: fixed a typo in the instance script class name 2023-12-22 12:09:42 +01:00
Ovahlord e8a9223566 Scripts/Throne of the Tides: added base instance script and definitions 2023-12-22 12:08:25 +01:00
Ovahlord ddcaaa61a5 Scripts/Bastion of Twilight: corrected dungeon encounter data for Sinestra 2023-12-22 11:42:55 +01:00
Ovahlord 9ece48a55c Scripts/Hour of Twilight: assign the correct scriptname to the instance 2023-12-22 11:35:28 +01:00
Ovahlord c336a6b53a Scripts/Misc: added base instance scripts and definitions for all 4.3 Cataclysm dungeons 2023-12-22 11:28:05 +01:00
Ovahlord 575a37a703 Scripts/Dragon Soul: added base instance script and definitions 2023-12-22 10:18:17 +01:00
Ovahlord 16b7c3cca9 Scripts/Misc: added instance scripts and base definitions for all Cataclysm 4.0 raids 2023-12-22 08:40:11 +01:00
Ovahlord 53ac8d3ef5 Core/Units: Allow self inflicted damage to bypass CREATURE_STATIC_FLAG_UNKILLABLE (#29502) 2023-12-19 18:21:45 +01:00
Ovahlord 27019a62a4 Core/Spells: Implement spell queue (#29409) 2023-11-25 00:00:10 +01:00
Ovahlord 30759beac7 Scripts/LCT: implement Lockmaw encounter 2023-11-07 16:17:55 +01:00
Ovahlord b606af8c4a Scripts/LCT: use the correct difficulty check to enable General Husam's heroic mechanics for Timewalking difficulty as well 2023-11-07 16:17:55 +01:00
Ovahlord a6c9e44c55 Scripts/LCT: gave General Husam's enums unique names to reduce linking time 2023-11-07 16:17:55 +01:00
Ovahlord 394940e0c5 Scripts/LCT: fixed spell validation for General Husam's Bad Intentions script effect 2023-11-06 16:53:45 +01:00
Ovahlord a457303f97 DB/SpawnGroup: The Lost City of the Tol'vir 2023-11-06 11:56:26 +01:00
Ovahlord 24dab9326d Scripts/LCT: implement General Husam encounter (#29414) 2023-11-06 11:51:37 +01:00
Ovahlord ecd54c07d8 Scripts/Antorus: prevent the Garothi Worldbreaker from falsely initiating an Apocalypse Drive phase when dealing damage would kill him instantly
* replaced some magic numbers in setting encounter frame indexes
* added a missing casting check to stay in line with current scripting standards
2023-11-04 15:05:47 +01:00
Ovahlord 38440996ee Core/Common: Use the [[unlikely]] keyword in all assert, warning and error macros to allow further compiler optimization (#29124) 2023-07-16 16:11:41 +02:00
Ovahlord ab33f35bb5 Core/Unit: modernize some pointers and arrays in unit class (#29104) 2023-07-15 21:47:31 +02:00
Ovahlord 252da139ad Scripts/Halls of Origination: fixed a deprecation warning 2023-07-11 20:11:44 +02:00
Ovahlord 45333fcc8f Core/Spells: fixed an underflow in SPELL_EFFECT_INEBRIATE when using drinks that sober the character up (such as Starfire Espresso) 2023-07-11 19:06:17 +02:00
Ovahlord ff9a23afab Core/Quests: allow QUEST_SPECIAL_FLAGS_AUTO_PUSH_TO_PARTY to be set in quest_template_addon 2023-07-11 18:54:05 +02:00
Ovahlord d535977c6d Build: moved MSVC warning C5054 from warning level 4 to 3 2023-07-11 18:49:52 +02:00
Ovahlord be81ff7133 Core/Player: Modernize some pointers and arrays in player class (#29098) 2023-06-28 17:39:55 +02:00
Ovahlord 58cd4e58f7 Scripts/DK: Implemented Howling Blast (#28761) 2023-01-26 18:38:10 +01:00
Ovahlord c1598d1ac3 Core/Creatures: improved error logging messages added in 6f835c233f7605d74926a2a3058634c9de478617 for creature_template_addon to avoid confusion
(cherry picked from commit 128339730cafefba04ca8b1b6c72ed4ea9315bd3)
2023-01-12 22:55:19 +01:00
Ovahlord 4119f69b21 Core/Creatures: Split creature_addon and creature_template_addon's byte columns into seperate ones (#28562)
* Instead of dumping raw byte values into these fields, we now only allow setting values which should be accessible to database devs. The remaining byte values should be handled by core internals and spells (pet talents and shapeshifting for example)

(cherry picked from commit 6f835c233f7605d74926a2a3058634c9de478617)
2023-01-12 22:55:19 +01:00
Ovahlord d03a5b802d Core/Units: ensure that we use valid iterators when providing spell Ids in Unit::RemoveAppliedAuras and Unit::RemoveOwnedAuras
(cherry picked from commit 4a1989269643a3a441f91c50da6c3153d95a15fe)
2023-01-12 22:55:18 +01:00
Ovah 298febaaf9 Scripts/Halls of Lightning: reworked General Bjarngrim Encounter (#28457)
* handle missing visuals
* reworked all AI scripts
* handle missing mechanic of Arc Weld
* reworked the whole waypoint and tempoary electrical charge handling
* moved Stormforged Lieutenants to their own spawn group to handle their spawning/despawning via boss
* moved the Tempoary Electrical Charge mechanic from spell_linked_spell to spell script instead
* replaced hacky virtual items for Bjarngrim's stances with sniffed ones

(cherry picked from commit f2fcd6746c72930dc0a951521e2f0fe78ce02690)
2023-01-12 22:55:17 +01:00
Ovahlord 4bd780b464 Scripts/HoO: fixed a crash in Temple Guardian Anhuur's script due to now supporting gameobject casters
(cherry picked from commit 3203f04ac1064d0812e3bcad12d0c25dc2e31593)
2023-01-09 12:06:04 +01:00
Ovahlord 83a8a540aa DB/Stormwind: added night time equipment to stormwind city guards and patrollers and moved waypoint scripts to smartAI
(cherry picked from commit https://github.com/The-Cataclysm-Preservation-Project/TrinityCore/commit/e619492a194bc09feb2fb30c50df4edbbcdc87bf)
2022-11-12 18:19:08 +01:00
Ovah 3be76db592 Scripts/DK: Fixed Rime talent (#28333) 2022-10-07 20:56:46 +02:00