Core/Spells: Prevent rerolling gathering skillups until success when mining or gathering herbs

(cherry picked from commit 92b7c98c018c1b950a45fb639e70871dca739ebd)
2023-08-23 18:46:35 +02:00
parent 0728d194d9
commit dce71612ef
1 changed files with 4 additions and 2 deletions
@@ -1668,9 +1668,11 @@ void Spell::EffectOpenLock()
            if (gameObjTarget)
            {
                // Allow one skill-up until respawned
-                if (!gameObjTarget->IsInSkillupList(player->GetGUID()) &&
-                    player->UpdateGatherSkill(skillId, pureSkillValue, reqSkillValue, 1, gameObjTarget))
+                if (!gameObjTarget->IsInSkillupList(player->GetGUID()))
+                {
+                    player->UpdateGatherSkill(skillId, pureSkillValue, reqSkillValue, 1, gameObjTarget);
                    gameObjTarget->AddToSkillupList(player->GetGUID());
+                }
            }
            else if (itemTarget)
            {