josh/TCPlayerbotCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Scripts/AzjolNerub: Fix potential error in pound spell script

Browse Source 
Cast damage spell in AfterEffectApply instead OnEffectHitTarget. This avoids the scenario where we try to apply an aura to a potential dead target.

Ref #21856

(cherry picked from commit 0dd4b685df53d9b61a53aaf3a577c2a9ed8cdd47)
This commit is contained in:
Carbenium
2022-01-26 14:37:05 +01:00
committed by Shauren
parent fa8ab6eb98
commit c302ace100
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/server/scripts/Northrend/AzjolNerub/AzjolNerub/boss_anubarak.cpp
+6 -6
View File
@@ -600,24 +600,24 @@ struct npc_anubarak_impale_target : public NullCreatureAI
}
};
class spell_anubarak_pound : public SpellScript
class spell_anubarak_pound : public AuraScript
{
PrepareSpellScript(spell_anubarak_pound);
PrepareAuraScript(spell_anubarak_pound);
bool Validate(SpellInfo const* /*spell*/) override
{
return ValidateSpellInfo({ SPELL_POUND_DAMAGE });
}
void HandleDummy(SpellEffIndex /*effIndex*/)
void AfterApply(AuraEffect const* /*aurEff*/, AuraEffectHandleModes /*mode*/)
{
if (Unit* target = GetHitUnit())
if (Unit* target = GetTarget())
GetCaster()->CastSpell(target, SPELL_POUND_DAMAGE, true);
}
void Register() override
{
OnEffectHitTarget += SpellEffectFn(spell_anubarak_pound::HandleDummy, EFFECT_0, SPELL_EFFECT_APPLY_AURA);
AfterEffectApply += AuraEffectApplyFn(spell_anubarak_pound::AfterApply, EFFECT_2, SPELL_AURA_FLY, AURA_EFFECT_HANDLE_REAL);
}
};
@@ -652,6 +652,6 @@ void AddSC_boss_anub_arak()
RegisterCreatureAIWithFactory(npc_anubarak_anub_ar_venomancer, GetAzjolNerubAI);
RegisterCreatureAIWithFactory(npc_anubarak_impale_target, GetAzjolNerubAI);
RegisterSpellScript(spell_anubarak_pound);
RegisterAuraScript(spell_anubarak_pound);
RegisterAuraScript(spell_anubarak_carrion_beetles);
}