Core/Spell: Correctly reordered diminishing groups for sharing diminishing timers between spells.

- Fixes several spells witch were in wrong group.
- Charge and scatter shot now has their own group.
- Moved Noblegarden Bunny costumes to negative effect.

Thanks Shocker for testing. Data comes from Elitist Jerks, Arena Junkies and a few addons tracking diminishing timers.

src/server/game/Miscellaneous/SharedDefines.h

@@ -2781,28 +2781,26 @@ enum DiminishingReturnsType
 // Diminishing Return Groups
 enum DiminishingGroup
 {
-    // Common Groups
-    DIMINISHING_NONE = 0,
-    DIMINISHING_CONTROL_STUN,                               // Player Controlled stuns
-    DIMINISHING_TRIGGER_STUN,                               // By aura proced stuns, usualy chance on hit talents
-    DIMINISHING_CONTROL_ROOT,                               // Immobilizing effects from casted spells
-    DIMINISHING_TRIGGER_ROOT,                               // Immobilizing effects from triggered spells like Frostbite
-    DIMINISHING_CHARM,
-    DIMINISHING_POLYMORPH,              // Also: Gouge, Sap, Repentance, Hungering Cold
-    DIMINISHING_KNOCKOUT,               // Sap, Knockout mechanics
-    DIMINISHING_FEAR_BLIND,             // Intimidating Shout, Howl of Terror, Blind
-    // Warlock Specific
-    DIMINISHING_DEATHCOIL,                                  // Death Coil Diminish only with another Death Coil
-    // Druid Specific
-    DIMINISHING_CYCLONE,                                    // From 2.3.0
-    // Shared Class Specific
-    DIMINISHING_CHEAPSHOT_POUNCE,
-    DIMINISHING_DISARM,                                     // From 2.3.0
-    DIMINISHING_SILENCE,                                    // From 2.3.0
-    DIMINISHING_FREEZE_SLEEP,                               // Hunter's Freezing Trap
-    DIMINISHING_BANISH,
-    DIMINISHING_TAUNT,
-    DIMINISHING_LIMITONLY               // Don't Diminish, but limit duration to 10s
+    DIMINISHING_NONE                = 0,
+    DIMINISHING_BANISH              = 1,
+    DIMINISHING_CHARGE              = 2,
+    DIMINISHING_OPENING_STUN        = 3, // Cheap Shot and Pounce
+    DIMINISHING_CONTROLLED_STUN     = 4,
+    DIMINISHING_CONTROLLED_ROOT     = 5,
+    DIMINISHING_CYCLONE             = 6,
+    DIMINISHING_DISARM              = 7,
+    DIMINISHING_DISORIENT           = 8, // Several spells where name cant be generalized.
+    DIMINISHING_ENTRAPMENT          = 9,
+    DIMINISHING_FEAR                = 10,
+    DIMINISHING_HORROR              = 11,
+    DIMINISHING_MIND_CONTROL        = 12,
+    DIMINISHING_ROOT                = 13,
+    DIMINISHING_STUN                = 14,
+    DIMINISHING_SCATTER_SHOT        = 15,
+    DIMINISHING_SILENCE             = 16,
+    DIMINISHING_SLEEP               = 17,
+    DIMINISHING_TAUNT               = 18,
+    DIMINISHING_LIMITONLY           = 19  // No diminishing return, but duration limited to 10 seconds
 };
 
 enum SummonCategory