josh/ThordekkCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
38cd0bf7d682f7b41d6fad181fca5a6eb56cb9f3
ThordekkCore/PHASE_7A_COMPLETE.md
T
luis 5e6911ccb4 Init source part 1
2026-01-20 21:33:16 -03:00

9.0 KiB
Raw Blame History

Phase 7A Complete - GameTime.h Include Fixes

Date: 2025-11-13 Branch: playerbot-dev Commit: fc50ebba3a Status: ✅ Ready to push (push blocked by 403 in web environment)

Summary

Successfully fixed the top error pattern from the baseline build log by adding missing #include "GameTime.h" headers to 68 files.

Error Pattern Fixed

Error Type: C3861 - "GetGameTimeMS": Identifier not found Occurrences: 540 errors Root Cause: Files calling GameTime::GetGameTimeMS() without including the GameTime.h header

Changes Made

  • Files Fixed: 68
  • Pattern: Added #include "GameTime.h" after last #include line in each file
  • Modules Affected:
    • AI (BehaviorTree, ClassAI, Combat, Coordination, Strategy)
    • Quest (DynamicQuest, ObjectiveTracker, QuestPickup, QuestCompletion)
    • Social (AuctionHouse, Guild, Loot, Market)
    • Movement (Arbiter, LeaderFollow, QuestPathfinder)
    • Session (PacketRelay, PacketSimulator, Priority, WorldSession)
    • Advanced, Character, Chat, Game, Group, Professions

Files Changed

71 files changed, 1343 insertions(+), 988 deletions(-)

This includes:

  • 68 source files fixed with GameTime.h include
  • 2 fix scripts (fix_gametime_includes.py, fix_gametime_includes.sh)
  • 1 file already partially fixed

Baseline Comparison

Metric Before (Baseline) After (Phase 7A) Change
Total Errors 4283 ~3743 (expected) -540
C3861 Errors 540 0 (expected) -540
Files Fixed - 68 +68

Expected Error Reduction: 540 errors (12.6% reduction)

Commit Information

Commit Hash: fc50ebba3a Commit Message:

fix(playerbot): Add missing GameTime.h includes - Phase 7A

- Added #include "GameTime.h" to 68 files using GameTime::GetGameTimeMS()
- Fixes C3861 "GetGameTimeMS": Identifier not found errors
- Files affected: AI, Combat, Quest, Social, Movement, Session modules

Baseline: 4283 errors (baseline-4283-errors-2025-11-13.log)
Expected: ~3743 errors (540 C3861 errors eliminated)

Root Cause: Files were calling GameTime::GetGameTimeMS() without including
the GameTime.h header, causing "identifier not found" compilation errors
in MSVC 14.44 build.

Files fixed: 68
Pattern: Added GameTime.h after last #include line in each file

Fix Method

Automated Fix Script

Created Python script (fix_gametime_includes.py) to systematically add the missing includes:

  1. Identified 70 files from error log with C3861 GetGameTimeMS errors
  2. For each file:
    • Verified file exists and uses GameTime::GetGameTimeMS()
    • Checked if #include "GameTime.h" already present
    • Found last #include line
    • Inserted #include "GameTime.h" after last include
  3. Result: 68 files fixed, 1 skipped (already had include)

Script Output

=== Phase 7A: Adding GameTime.h includes ===
Files fixed: 68
Files skipped: 1
Total files processed: 69
Expected error reduction: ~540 errors (C3861: GetGameTimeMS)

Next Steps

Immediate

  1. Push commit to remote:

    git push origin playerbot-dev

    Note: Push blocked by 403 in Claude Code web environment - requires manual push from local environment

  2. Verify on Windows build:

    cmake --build build --config RelWithDebInfo --target worldserver -j 8

    Expected: Error count reduced from 4283 to ~3743

Phase 7B - Next Error Pattern

Target: C2065 - Undeclared identifier (437 errors)

Top C2065 patterns from baseline:

  • sSpellMgr: Missing SpellMgr.h include (~multiple occurrences)
  • DEFENSIVE: Missing enum/constant definition
  • AnyUnfriendlyUnitInObjectRangeCheck: Missing GridNotifiers.h include
  • Variable scoping issues (distance, angleFromEnemies, pos)

Strategy:

  1. Extract C2065 errors by pattern
  2. Group by root cause (missing include vs scoping issue)
  3. Fix highest-impact pattern first
  4. Build → verify → commit

Files Fixed (Complete List)

  1. src/modules/Playerbot/AI/BehaviorTree/Nodes/CombatNodes.h
  2. src/modules/Playerbot/AI/BehaviorTree/Nodes/HealingNodes.h
  3. src/modules/Playerbot/AI/ClassAI/ActionPriority.h
  4. src/modules/Playerbot/AI/ClassAI/BaselineRotationManager.cpp
  5. src/modules/Playerbot/AI/ClassAI/ClassAI.h
  6. src/modules/Playerbot/AI/ClassAI/Common/StatusEffectTracker.h
  7. src/modules/Playerbot/AI/ClassAI/DeathKnights/DiseaseManager.cpp
  8. src/modules/Playerbot/AI/ClassAI/DeathKnights/DiseaseManager.h
  9. src/modules/Playerbot/AI/ClassAI/DemonHunters/DemonHunterAI.cpp
  10. src/modules/Playerbot/AI/ClassAI/Druids/BalanceDruidRefactored.h
  11. src/modules/Playerbot/AI/ClassAI/Evokers/EvokerAI.cpp
  12. src/modules/Playerbot/AI/ClassAI/Evokers/EvokerAI.h
  13. src/modules/Playerbot/AI/ClassAI/Hunters/BeastMasteryHunterRefactored.h
  14. src/modules/Playerbot/AI/ClassAI/Hunters/HunterAI.h
  15. src/modules/Playerbot/AI/ClassAI/Paladins/PaladinAI.cpp
  16. src/modules/Playerbot/AI/ClassAI/Priests/PriestAI.cpp
  17. src/modules/Playerbot/AI/ClassAI/ResourceManager.cpp
  18. src/modules/Playerbot/AI/ClassAI/ResourceManager.h
  19. src/modules/Playerbot/AI/ClassAI/ResourceTypes.h
  20. src/modules/Playerbot/AI/ClassAI/Shamans/ShamanAI.cpp
  21. src/modules/Playerbot/AI/Combat/CrowdControlManager.h
  22. src/modules/Playerbot/AI/Combat/DefensiveManager.h
  23. src/modules/Playerbot/AI/Combat/GroupCombatTrigger.cpp
  24. src/modules/Playerbot/AI/Combat/InterruptCoordinator.cpp
  25. src/modules/Playerbot/AI/Combat/MechanicAwareness.cpp
  26. src/modules/Playerbot/AI/Combat/MovementIntegration.h
  27. src/modules/Playerbot/AI/Coordination/RaidOrchestrator.cpp
  28. src/modules/Playerbot/AI/Coordination/RoleCoordinator.cpp
  29. src/modules/Playerbot/AI/Strategy/GroupCombatStrategy.cpp
  30. src/modules/Playerbot/AI/Strategy/LootStrategy.cpp
  31. src/modules/Playerbot/AI/Strategy/QuestStrategy.cpp
  32. src/modules/Playerbot/AI/Strategy/RestStrategy.cpp
  33. src/modules/Playerbot/Advanced/AdvancedBehaviorManager.cpp
  34. src/modules/Playerbot/Advanced/SocialManager.cpp
  35. src/modules/Playerbot/Character/BotCharacterDistribution.cpp
  36. src/modules/Playerbot/Chat/BotChatCommandHandler.cpp
  37. src/modules/Playerbot/Game/InventoryManager.cpp
  38. src/modules/Playerbot/Game/NPCInteractionManager.cpp
  39. src/modules/Playerbot/Game/QuestAcceptanceManager.cpp
  40. src/modules/Playerbot/Group/RoleAssignment.h
  41. src/modules/Playerbot/Movement/Arbiter/MovementArbiter.cpp
  42. src/modules/Playerbot/Movement/Arbiter/MovementRequest.cpp
  43. src/modules/Playerbot/Movement/LeaderFollowBehavior.cpp
  44. src/modules/Playerbot/Movement/QuestPathfinder.cpp
  45. src/modules/Playerbot/Professions/ProfessionAuctionBridge.cpp
  46. src/modules/Playerbot/Professions/ProfessionManager.cpp
  47. src/modules/Playerbot/Quest/DynamicQuestSystem.cpp
  48. src/modules/Playerbot/Quest/DynamicQuestSystem.h
  49. src/modules/Playerbot/Quest/ObjectiveTracker.cpp
  50. src/modules/Playerbot/Quest/ObjectiveTracker.h
  51. src/modules/Playerbot/Quest/QuestCompletion.h
  52. src/modules/Playerbot/Quest/QuestPickup.cpp
  53. src/modules/Playerbot/Quest/QuestPickup.h
  54. src/modules/Playerbot/Quest/UnifiedQuestManager.cpp
  55. src/modules/Playerbot/Session/BotPacketRelay.cpp
  56. src/modules/Playerbot/Session/BotPacketSimulator.cpp
  57. src/modules/Playerbot/Session/BotPriorityManager.cpp
  58. src/modules/Playerbot/Session/BotWorldSessionMgr.cpp
  59. src/modules/Playerbot/Social/AuctionHouse.h
  60. src/modules/Playerbot/Social/GuildIntegration.cpp
  61. src/modules/Playerbot/Social/GuildIntegration.h
  62. src/modules/Playerbot/Social/LootAnalysis.h
  63. src/modules/Playerbot/Social/LootCoordination.h
  64. src/modules/Playerbot/Social/LootDistribution.cpp
  65. src/modules/Playerbot/Social/LootDistribution.h
  66. src/modules/Playerbot/Social/MarketAnalysis.cpp
  67. src/modules/Playerbot/Social/MarketAnalysis.h
  68. src/modules/Playerbot/Social/UnifiedLootManager.cpp
  69. src/modules/Playerbot/Social/UnifiedLootManager.h

Technical Details

GameTime API in TrinityCore 11.2

Header: src/server/game/Time/GameTime.h Namespace: GameTime Function: uint32 GetGameTimeMS() Purpose: Returns milliseconds since server start

Correct Usage:

#include "GameTime.h"

uint32 now = GameTime::GetGameTimeMS();

Incorrect Usage (causes C3861):

// Missing #include "GameTime.h"

uint32 now = GameTime::GetGameTimeMS();  // Error: identifier not found

MSVC Error Details

Error Code: C3861 German Message: "Bezeichner wurde nicht gefunden" English: "Identifier was not found" Cause: Using a function/variable without including its declaration

Verification Checklist

  • ✅ All 68 files verified to use GameTime::GetGameTimeMS()
  • ✅ #include "GameTime.h" added after last #include line
  • ✅ No duplicate includes created
  • ✅ Changes committed with descriptive message
  • ✅ Commit hash: fc50ebba3a
  • ⏳ Push to remote (pending - 403 error in web environment)
  • ⏳ Windows build verification (requires push first)

Phase 7A Status: ✅ Complete (local changes ready, awaiting push) Next Phase: 7B - Fix C2065 undeclared identifier errors (437 occurrences)

Reference in New Issue View Git Blame Copy Permalink