josh/ThordekkCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
267 Commits 4 Branches 0 Tags
f5da2170d98bb7b2e541b9999c95c19e9b990941
Commit Graph
63 Commits
Author SHA1 Message Date
Cristian Vintila b8bf2f48b7 Scripts/Spells: Implement druid talent Twin Moonfire (#31526) 
Signed-off-by: luis <[email protected]>
 2026-02-04 21:24:13 -03:00
Cristian Vintila 2474ddfc09 Scripts/Spells Implement druid talent Matted Fur (#31508) 
Signed-off-by: luis <[email protected]>
 2026-02-04 21:23:36 -03:00
Naddley 00d0250049 DB/Stormwind: Added Magister Umbric spawn 
Signed-off-by: luis <[email protected]>
 2026-02-04 21:22:43 -03:00
Naddley 04ad5ba2e1 DB/Stormwind: Added Second Chair Pawdo spawn 
Signed-off-by: luis <[email protected]>
 2026-02-04 21:21:04 -03:00
Shauren b4544efc7d Core/Players: Improve trait config validation 
Signed-off-by: luis <[email protected]>
 2026-02-04 21:16:43 -03:00
Hyacinthrose 55d300c3df DB/ElwynnForest: Added missing credit reward for Quest: "The Fargodeep Mine" (#31644) 
Signed-off-by: luis <[email protected]>
 2026-02-04 21:16:04 -03:00
Aqua Deus 47d0dbdccd DB/Spells: Fix dh proc of Live by the glaive (#31505) 
Signed-off-by: luis <[email protected]>
 2026-02-04 21:13:55 -03:00
agathoandClaude Opus 4.5 2bdad4f24e fix(spawner): P1 - Fix DespawnAllBots iterator race with atomic swap 
**Problem:**
Range-based for loop over TBB concurrent_hash_map in DespawnAllBots() was NOT
atomic. Other threads could modify _activeBots during iteration, causing:
- Iterator invalidation
- Missing bots (removed during iteration)
- Seeing bots twice (if rehash happens)
- Potential crashes from concurrent modification

**Root Cause:**
```cpp
// UNSAFE - NOT atomic, race condition window
for (auto const& [guid, zoneId] : _activeBots) {
    botsToRemove.push_back(guid);
}
```

While iterating, other threads could call SpawnBot/DespawnBot, modifying the
underlying hash table structure.

**Solution:**
Implemented atomic swap pattern:
1. Create empty concurrent_hash_maps
2. Atomically swap with _activeBots and _botsByZone (TBB swap is atomic)
3. Process isolated snapshot with zero race condition risk
4. Directly cleanup sessions (bypass DespawnBot since entries already removed)

**Benefits:**
- Thread-safe: No race conditions possible
- Fast: Single pass, no repeated lookups
- Clean: All session cleanup handled properly
- Stats: Batch updates for performance

**Technical Details:**
- Used tbb::concurrent_hash_map::swap() atomic operation
- Isolated oldBots map guarantees no concurrent access
- Direct session cleanup via RemoveAllPlayerBots()
- Atomic counter updates with memory_order_release
- Batch stat updates (single fetch_add vs N individual calls)

**Testing:**
- Compiled cleanly (RelWithDebInfo)
- No new warnings

**Location:** src/modules/Playerbot/Lifecycle/BotSpawner.cpp:1256-1300
**Priority:** P1 (Race condition in mass despawn operation)
**Task:** SESSION_LIFECYCLE_FIXES Task 2/7

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Signed-off-by: luis <[email protected]>
 2026-02-04 21:03:36 -03:00
agatho eee22358af docs: Add session documentation, workflows, and database fixes 
- Added comprehensive backlog tracking
- MCP configuration recommendations
- ZenFlow workflow definitions
- Database fix for pool account IDs
- Automation batch scripts
- Analysis reports and rollback points

These support files enhance development workflow and documentation.

Signed-off-by: luis <[email protected]>
 2026-02-04 21:00:18 -03:00
luis 8ce4578e85 typo fix and add blizzlike fixes 2026-02-02 00:47:02 -03:00
luis 78c9561f7d init boss merge 2026-02-01 21:11:34 -03:00
Aqua Deus d23e0a29ad Scripts/Spells: Implement dh talent "Shattered Restoration" (#31507) 
Signed-off-by: luis <[email protected]>
 2026-02-01 17:47:00 -03:00
Cristian Vintila 407bbb59a7 Scripts/Spells: Implement Rake stealth stun and multiplier (#31511) 
Signed-off-by: luis <[email protected]>
 2026-02-01 17:46:07 -03:00
Cristian Vintila dff034f0d1 Scripts/Spells: Use form-dependent bleed spells for druid spell Thrash (#31513) 
Signed-off-by: luis <[email protected]>
 2026-02-01 17:45:27 -03:00
Aqua Deus 9f69176cbb Scripts/Spells: Implement dh talent "Wave of Debilitation" (#31510) 
Signed-off-by: luis <[email protected]>
 2026-02-01 17:43:08 -03:00
Cristian Vintila fff848d87f Scrips/Spells: Implement druid talent Thorns of Iron (#31537) 
Signed-off-by: luis <[email protected]>
 2026-02-01 17:41:43 -03:00
ReZaRrandModoX 2db00e5c7c Scripts/WanderingIsle: Implement Singing Pools AreaTriggers (#31629) 
Co-authored-by: ModoX <[email protected]>
Signed-off-by: luis <[email protected]>
 2026-02-01 11:33:53 -03:00
Naddley 287e047763 Scripts/IsleOfDorn: Implement Quest: "Vereesas Tale" (#31615) 
Signed-off-by: luis <[email protected]>
 2026-02-01 11:24:11 -03:00
Golrag 244f675627 Scripts/Arenas: Implement Empyrean Domain (#31427) 
Signed-off-by: luis <[email protected]>
 2026-02-01 11:22:37 -03:00
Aqua Deus 5289073a1e Scripts/EyeOfAzshara: Implement King Deepbeard encounter (#31420) 
Signed-off-by: luis <[email protected]>
 2026-02-01 11:10:10 -03:00
Aqua Deus d6423deebb Scripts/Spells: Implement dh talent "Soul Carver" (#31503) 
Signed-off-by: luis <[email protected]>
 2026-02-01 10:52:39 -03:00
Aqua Deus 243fde3c78 Scripts/NeltharionsLair: Implement Rokmora encounter (#31162) 
Signed-off-by: luis <[email protected]>
 2026-02-01 10:51:39 -03:00
Cristian Vintila 40d77c41d4 Scripts/Spells: Implement Void Volley (#31502) 
Signed-off-by: luis <[email protected]>
 2026-01-31 18:39:22 -03:00
luis 3681010c2e new 12x data 2026-01-31 18:30:40 -03:00
luis c66c3947fe 12x data 2026-01-31 18:20:43 -03:00
luis b4992b2f38 65655 2026-01-31 18:16:56 -03:00
luis 21155f62f7 Mising data 2026-01-29 22:06:45 -03:00
luis 189f4b97d2 Fix all missing data for creature template 2026-01-29 21:14:34 -03:00
luis 3e23cd82ee missing data 2026-01-29 20:53:37 -03:00
luis 67343dc1fd Missing spawns 2026-01-29 20:45:42 -03:00
luis abbfb10ce6 new initial zones fixes data 2026-01-29 20:02:46 -03:00
Shauren d71835475e Core: Updated to 12.0.0 
Signed-off-by: luis <[email protected]>
 2026-01-29 08:40:48 -03:00
luis dcc6515a20 Blizzlike fixes 2026-01-28 16:35:21 -03:00
ModoX 109ffc2fd8 DB/Phases: Added some Legion (Remix) phase names 
Signed-off-by: luis <[email protected]>
 2026-01-25 20:58:20 -03:00
Hyacinthrose 167e1dbed0 DB/Westfall: Fix targettype for Horatio Laine actionlist (#31637) 
Signed-off-by: luis <[email protected]>
 2026-01-25 20:57:11 -03:00
Hyacinthrose 161c2c5131 DB/Westfall: Added paths for Protectors Weaver, Dutfield, and Korelor (#31633) 
Signed-off-by: luis <[email protected]>
 2026-01-25 20:56:01 -03:00
Foldor1 d40204d13c DB/Creatures: Update vendor data for Chapman 
Closes #31442

Signed-off-by: luis <[email protected]>
 2026-01-25 20:54:10 -03:00
luis a7a5dd14f6 db sniff data 2026-01-24 08:29:35 -03:00
luis 7ad38c0c55 db fixes 2026-01-24 01:42:32 -03:00
agathoandClaude Opus 4.5 79b0df716a chore(playerbot): Add SQL fixes to sql/playerbot/fixes location 
Additional SQL fix scripts:
- 01_fix_binding_shot_crash.sql
- 02_fix_class_race_matrix.sql
- add_template_validation_constraints.sql
- fix_corrupt_template_entry.sql

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Signed-off-by: luis <[email protected]>
 2026-01-22 19:57:57 -03:00
Hyacinthrose df2bb8d23c DB/Durotar: Update Thotar gossip (#31628) 
Signed-off-by: luis <[email protected]>
 2026-01-21 02:46:53 -03:00
Aqua Deus 04f14414ae Scripts/Spells: Implement dh talent "Painbringer" (#31501) 
Signed-off-by: luis <[email protected]>
 2026-01-21 02:43:05 -03:00
BestPussyInRussia 3978d0a196 DB/WanderingIsle: Fix Aysa summon on quest 29414 accept (#31619) 
Signed-off-by: luis <[email protected]>
 2026-01-21 02:39:48 -03:00
Naddley 849466c91d DB/Dornogal: Added Silver Hand squire spawn 
- scripted cosmetic clone event

Signed-off-by: luis <[email protected]>
 2026-01-21 02:29:20 -03:00
Cristian Vintila 800c40ae70 Scripts/Spells: Implement priest talent Death's Torment (#31487) 
Signed-off-by: luis <[email protected]>
 2026-01-21 02:28:32 -03:00
luis 38ad5b6b6f Revert "DB/Hotfixes: Updated hotfixes to 11.2.7.65299" 2026-01-21 02:28:07 -03:00
MoltenCrystalandNaddley b9d0ee2dee DB/Stormwind: Implement Quest: "Aspectral Invitation" (#31602) 
Co-authored-by: Naddley <[email protected]>
Signed-off-by: luis <[email protected]>
 2026-01-21 02:27:49 -03:00
Meji 7696c428b1 DB/Hotfixes: Updated hotfixes to 11.2.7.65299 
Signed-off-by: luis <[email protected]>
 2026-01-21 02:27:26 -03:00
Aqua Deus 38e7d549a8 Scripts/Spells: Implement dh talent Soulmonger (#31486) 
Signed-off-by: luis <[email protected]>
 2026-01-21 02:26:12 -03:00
Cristian Vintila dfd9ae3f93 Scripts/Spells: Implement priest talent Insidious Ire (#31485) 
Signed-off-by: luis <[email protected]>
 2026-01-21 02:25:46 -03:00