BotAI doesn't extend PlayerAI/UnitAI, so dynamic_cast<BotAI*>(GetAI())
always returned nullptr. The cached health/mana values were never read,
falling back to stale bot->GetHealthPct() on the worker thread.
RestStrategy already receives BotAI* ai as a parameter — use
ai->GetCachedHealthPct() and ai->GetCachedManaPct() directly instead
of trying to look up BotAI from the Player.
Signed-off-by: luis <[email protected]>
The state cache (health, mana, position, map, combat) was being
populated at the start of UpdateAI on the worker thread, reading the
same stale data it was trying to avoid. Health showed 53% for hours
while actually 100% because GetHealthPct() returns the value from the
last Player::Update() call on the main thread.
Now BotSession::SnapshotBotState() runs on the main thread from
BotWorldSessionMgr::ProcessAllDeferredPackets(), after Player::Update()
has already run. Worker threads read these cached values which are
guaranteed current.
Uses movespline->ComputePosition() for accurate interpolated position
instead of FinalDestination() which only gives the endpoint.
Signed-off-by: luis <[email protected]>
All bot stats read via GetHealthPct(), GetPowerPct(), GetMapId(),
IsInCombat() are only updated on the main thread during Player::Update.
Worker threads reading them directly get stale data — health showing
53% when actually 100%, causing rest strategy to idle bots for hours.
BotAI now caches health, mana, map ID, and combat state at the start
of each UpdateAI tick. RestStrategy uses these cached values instead
of reading from the bot directly.
Signed-off-by: luis <[email protected]>
When SearchForQuestGivers found a quest giver at 0yd distance, it
deferred to the pending system which required another UpdateBehavior
tick. With the 150ms throttle and only ~6 calls per session, the
follow-up never happened.
Now resolves the creature and calls ProcessQuestGiver immediately
when the bot is already within interaction distance, instead of
deferring to the next tick.
Signed-off-by: luis <[email protected]>
- Abandon quests with no ender in DB immediately on first attempt
instead of waiting for 3 failures (fixes quest 55660 blocking)
- Loot strategy only activates on game objects within INTERACTION_DISTANCE
preventing distant spatial grid objects from blocking quest strategy
- Rest threshold lowered to 15-25% for no-consumable resting
(was 30-50%, causing bots at 50% health to idle without food)
- Downgrade 275 TC_LOG_ERROR calls to TC_LOG_DEBUG in QuestStrategy
- Downgrade STRAT-SELECT diagnostic to TRACE
- Downgrade target scanner evaluation log to TRACE
- Downgrade auto-accept check diagnostic to DEBUG
Signed-off-by: luis <[email protected]>
bot->GetPositionX/Y/Z() is only updated on the main thread during
Player::Update(). Worker threads reading it mid-spline get stale data.
BotAI now caches the current position at the start of each UpdateAI():
- If a movespline is active: uses FinalDestination() as effective position
- If idle: uses last known server position
GetCurrentPosition() provides this cached value for any worker thread
code that needs accurate bot location. Quest strategy's pending quest
giver distance check now uses this instead of bot->GetPositionX/Y/Z().
Also re-added navmesh reachability check to spatial grid quest giver
scan to skip unreachable NPCs (towers, cliffs) before selection.
Signed-off-by: luis <[email protected]>
bot->GetPositionX/Y() returns the server-side position which lags behind
the client during active spline movement. The bot visually stands at the
NPC but GetExactDist2d reports 77yd because the position hasn't been
updated by the main thread yet.
Now uses movespline->FinalDestination() as the bot's effective position
when a spline is active. This matches where the client renders the bot.
Also re-added navmesh reachability check to the spatial grid scan to
skip unreachable NPCs (towers, cliffs) before selection.
Signed-off-by: luis <[email protected]>
SafeGridOperations::GetCreatureListSafe accessed the live grid which
returned stale creatures from the old map after teleports (worker thread
data race on m_currMap). The bot searched for quest givers on the wrong
continent.
Now uses DoubleBufferedSpatialGrid which provides lock-free atomic
snapshots updated by the main thread. Worker threads always read current
map data. The scan uses creature snapshot fields (hasQuestGiver, entry,
position, isDead) and quest relation DB lookups (thread-safe static data)
to find quest givers without touching any live creature pointers.
Quest acceptance still uses live creature pointers but only in the
pending quest giver arrival phase, when the bot is physically at the NPC
and the data is guaranteed current.
Signed-off-by: luis <[email protected]>
Worker thread reads stale map/grid data after TeleportTo, causing quest
giver searches to return creatures from the old map. Added 5-second
cooldown after each teleport to let the main thread process the map
change before the quest strategy runs again.
Also added diagnostic logging to ProcessQuestGiver auto-accept phase
to trace why quests aren't being accepted (alreadyHas, blacklisted,
canTake, canAdd checks).
Added navmesh reachability check to quest giver selection and position
diagnostic for pending quest giver distance debugging.
Signed-off-by: luis <[email protected]>
Bots walked to quest givers on unreachable terrain (towers, cliffs)
because SearchForQuestGivers selected by straight-line distance without
checking if the navmesh could path there. The bot stopped at the
closest navmesh point, 77+ yards from the NPC.
Now uses PathGenerator to verify navmesh reachability before selecting
a quest giver. Unreachable NPCs are skipped in favor of reachable ones.
Also allows interaction when the NPC is found via grid scan (within
50yd) even if the stored position distance is larger, handling cases
where navmesh pathing ends at a different point than the stored coords.
Signed-off-by: luis <[email protected]>
CastSpell(8690) failed silently for bots without a hearthstone item in
inventory (gear application failed at creation). Bots stood idle in
wrong zones because the hearthstone cast did nothing.
Use Player::TeleportTo(m_homebind) directly — no item required, no
cooldown, no cast time. This is already used elsewhere in the module
(AdvancedBehaviorManager, PlayerbotCommands, TravelRouteManager).
Signed-off-by: luis <[email protected]>
The 2-minute timeout incorrectly killed routes where the bot was
waiting for a ship, riding a transport, or on later legs. Now only
fires when stuck in WALKING_TO_TRANSPORT state on leg 0 — the specific
case caused by worker thread GetMapId() staleness after teleport.
Signed-off-by: luis <[email protected]>
bot->GetMapId() returns stale data on worker threads after a teleport
because m_mapId is updated on the main thread only. The existing map
comparison check fails — the worker still sees the old map ID.
Added a 2-minute timeout: if the travel route has been active for over
2 minutes without completing the first leg, it's considered stale and
cleared. This handles the case where the bot hearthstoned to a
different map but the worker thread can't detect the map change.
Signed-off-by: luis <[email protected]>
Bots stopped 30+ yards from quest givers because 3D distance included
Z-height difference (stairs, ramps, platforms). The bot was visually
at the NPC but the 3D dist of 31yd > INTERACTION_DISTANCE of 5yd.
Switched all pending quest giver distance checks to 2D, matching how
WoW's gossip interaction works. Also widened grid scan to 50yd for
finding NPCs when ObjectAccessor fails.
Signed-off-by: luis <[email protected]>
IsOnGround() returned false when GroundValidator::GetGroundHeight
returned INVALID_HEIGHT (map data not loaded), causing the state
machine to set MOVEMENTFLAG_FALLING. This permanently blocked
MovePoint from generating splines — bots stood idle despite movement
commands being issued every tick.
Changed INVALID_HEIGHT to assume on-ground (safe default). A bot at
a spawn point is never falling.
Also added INFO diagnostic to HandleOnTransport for travel visibility.
Signed-off-by: luis <[email protected]>
Fixture System:
- Use MeshObject GUIDs (HighGuid 56) for FHousingFixture_C Guid and
AttachParentGUID fields instead of Housing GUIDs. The client's fixture
manager searches the frame tree using AttachParentGUID as key, and frames
are indexed by MeshObject entity GUIDs. This fixes fixture hookpoints
showing "None" despite fixtures being spawned.
- Force-send AT entity CREATE/VALUES to player before ENTER_PLOT packet,
matching the retail pattern where UPDATE_OBJECT and ENTER_PLOT arrive at
the same timestamp.
- Set MAX_VISIBILITY_DISTANCE on HousingMap and HouseInteriorMap so all
entities are visible map-wide, eliminating entity streaming race conditions.
- Add PreloadHousingMaps at server startup with LoadAllCells for
neighborhood maps (validates map type before loading).
Fixture Placement:
- Door (entrance) replacement: placing a new door auto-removes any existing
door at a different hook and despawns/respawns the clickable door GO.
- Hook exclusivity: placing a fixture removes any existing fixture at that
hook first.
- Fix DELETE_FIXTURE handler: pass original hookID to RemoveFixture instead
of resolved parent componentID. Fixtures are keyed by hookID.
- Remove default fixture respawn on delete (was causing flicker loop).
Door GO Management:
- Add RespawnDoorGOAtHook/DespawnDoorGO methods for targeted door GO
updates without full house rebuild.
- Door GO positioned at fixture MeshObject location (exact hookpoint).
- Force-send CREATE to player immediately after spawning door GO.
- Auto-create missing door GO templates from ExteriorComponent DB2 at
startup (EnsureDoorGameObjectTemplates) with retail values:
Lock=4296, autoClose=3000, startOpen=1.
Interior Exit:
- Use ExteriorComponentExitPoint position for interior→exterior teleport,
placing player in front of the door they entered through.
Other:
- Add MeshObject::AddRoomDoor for HousingRoomData Doors array population.
- Rename HousingPackets PlotAreaTriggerGuid to NeighborhoodEntityGuid.
Cross-referenced BattlePetState.db2 via wago.tools/WoWDBDefs and fixed
wrong state IDs: Stat_Accuracy is 41 (was 22=Mechanic_IsStunned),
Mod_HealingDealtPercent is 65 (was 26=Ramping_DamageID),
Mod_HealingTakenPercent is 66 (was 27=Ramping_DamageUses).
Added per-type weather damage bonus using the 3-state mechanism from
DB2: Mod_PetTypeDamageDealtPercent(87) + Mod_PetType_ID(89) restricts
damage bonuses to matching ability types (e.g. Rain = +25% Aquatic
only, not all damage). Also added Add_FlatDamageTaken(71) for
Sandstorm-style damage shields.
Expanded enum to 43 states covering weather markers (53-63, 316),
mechanics, cosmetics, and combat modifiers — all verified against
BattlePetState.db2 LuaName field.
agatho