Core/Hotfix: use real HouseDecor table hash

src/server/game/Handlers/HotfixHandler.cpp

@@ -3,7 +3,8 @@
  *
  * This program is free software; you can redistribute it and/or modify it
  * under the terms of the GNU General Public License as published by the
- * Free Software Foundation; either version 2 of the License, or (at your option) any later version.
+ * Free Software Foundation; either version 2 of the License, or (at your
+ * option) any later version.
  *
  * This program is distributed in the hope that it will be useful, but WITHOUT
  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
@@ -23,15 +24,17 @@
 
 namespace
 {
+constexpr uint32 HouseDecorTableHash = 0x137145D0;
+
 bool IsUnsafeClientHotfixTable(uint32 tableHash)
 {
     // HouseDecor.db2 is intentionally not loaded in DB2Manager::LoadStores for the
-    // current 12.1 branch (the source still marks its layout as pending update).
+    // current 12.1 branch. An unloaded DB2Storage keeps its runtime table hash at 0,
-    // Forwarding DB-supplied HouseDecor blobs while that layout is disabled can make
+    // so using sHouseDecorStore.GetTableHash() here does not identify HouseDecor.
-    // the retail client merge incompatible rows into its local DB2 view and terminate
+    // Use the stable DB2 table hash for HouseDecor (FileDataID 5149691) instead.
-    // with ERROR #134 on a duplicate unique key. Keep only this known-unsafe table
+    // Forwarding DB-supplied HouseDecor blobs can otherwise make the retail client
-    // quarantined; all other hotfix traffic continues normally.
+    // merge duplicate unique keys and terminate with ERROR #134 before character login.
-    return tableHash == sHouseDecorStore.GetTableHash();
+    return tableHash == HouseDecorTableHash;
 }
 }