josh/ThordekkCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(lifecycle): Fix incomplete type error and deprecated APIs in clean build

Browse Source 
- Add BotAI.h include to 9 files that use unique_ptr<BotAI> via BotSession.h
  Files fixed: BotCharacterCreator, BotResourcePool, BotSpawnOrchestrator,
  BotSpawner, GracefulExitHandler, DynamicQuestSystem, ObjectiveTracker,
  LootDistribution

- Fix CorpseCrashMitigation.cpp deprecated TrinityCore APIs:
  * Replace SetDeathState() with setDeathState() (correct casing)
  * Replace SetFlag/RemoveFlag/GetByteValue with internal tracking set
  * Replace deprecated PLAYER_FIELD_BYTES2 with _pendingPrevention set
  * Fix dynamic_cast<BotAI*> by using BotSession->GetAI() pattern
  * Fix OrderedSharedMutex usage (direct lock/unlock instead of std::lock)

- Add _pendingPrevention unordered_set to CorpseCrashMitigation.h

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Signed-off-by: luis <[email protected]>
This commit is contained in:
agatho
2026-02-04 21:08:34 -03:00
committed by luis
co-authored by Claude Opus 4.5
parent ce470d10ce
commit d5d61361ba
10 changed files with 98 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/modules/Playerbot/Lifecycle/BotSpawner.cpp
+1
View File
@@ -42,6 +42,7 @@
#include "CharacterDatabase.h"
#include "BotWorldSessionMgr.h"
#include "Session/BotSession.h"
#include "../AI/BotAI.h" // P1 FIX: Required for unique_ptr<BotAI> in BotSession.h
#include "BotResourcePool.h"
#include "BotAccountMgr.h"
#include "Config/PlayerbotConfig.h"