diff --git a/src/modules/Playerbot/Lifecycle/Retirement/GracefulExitHandler.h b/src/modules/Playerbot/Lifecycle/Retirement/GracefulExitHandler.h index e7f0037f5..716ab86b8 100644 --- a/src/modules/Playerbot/Lifecycle/Retirement/GracefulExitHandler.h +++ b/src/modules/Playerbot/Lifecycle/Retirement/GracefulExitHandler.h @@ -39,7 +39,7 @@ class Player; class Guild; -class Mail; +struct Mail; namespace Playerbot { diff --git a/src/server/game/Craft/Crafting.cpp b/src/server/game/Craft/Crafting.cpp index 2a7e65d15..506584056 100644 --- a/src/server/game/Craft/Crafting.cpp +++ b/src/server/game/Craft/Crafting.cpp @@ -121,7 +121,7 @@ SpellCastResult Crafting::DoCraft(uint32 craftingDataId) if (!craftedItemId) return SpellCastResult::SPELL_FAILED_ERROR; - ItemContext context = _spell->GetSpellInfo()->HasAttribute(SPELL_ATTR0_IS_TRADESKILL) ? ItemContext::Trade_Skill : ItemContext::NONE; + //ItemContext context = _spell->GetSpellInfo()->HasAttribute(SPELL_ATTR0_IS_TRADESKILL) ? ItemContext::Trade_Skill : ItemContext::NONE; std::vector bonusLists; /* for (int32 bonusTreeID : bonusTreeIds) diff --git a/src/server/game/DataStores/DB2Stores.cpp b/src/server/game/DataStores/DB2Stores.cpp index a1a707584..d95f70d2d 100644 --- a/src/server/game/DataStores/DB2Stores.cpp +++ b/src/server/game/DataStores/DB2Stores.cpp @@ -3794,7 +3794,7 @@ CraftingReagentQualityEntry const* DB2Manager::GetCraftingReagentQualityByItem(u return _CraftingReagentQualityByItem[itemID]; } -uint32 DB2Manager::GetCraftingQualityTierByDifficultyPercent(int32 craftingDifficultyID, uint32 difficultyPercent) +uint32 DB2Manager::GetCraftingQualityTierByDifficultyPercent([[maybe_unused]] int32 craftingDifficultyID, [[maybe_unused]] uint32 difficultyPercent) { /* CraftingDifficultyQualityEntry const* matchedDifficultyQuality = nullptr; diff --git a/src/server/game/Entities/Player/Player.cpp b/src/server/game/Entities/Player/Player.cpp index b200c691e..bfd0a6387 100644 --- a/src/server/game/Entities/Player/Player.cpp +++ b/src/server/game/Entities/Player/Player.cpp @@ -33291,7 +33291,7 @@ bool Player::HasQuest(uint32 questID) const return false; } -void Player::UpdateWorldQuestPosition(float x, float y) +void Player::UpdateWorldQuestPosition([[maybe_unused]] float x, [[maybe_unused]] float y) { // Throttle updates to avoid excessive processing if (time(nullptr) < m_areaQuestTimer) @@ -33414,12 +33414,12 @@ void Player::UpdateDynamicFlight(bool apply) { if (apply) { - if (!HasAuraType(SPELL_AURA_ADV_FLYING)); + if (!HasAuraType(SPELL_AURA_ADV_FLYING)) AddAura(SPELL_DYNAMIC_FLIGHT, this); } else { - if (HasAuraType(SPELL_AURA_ADV_FLYING)); + if (HasAuraType(SPELL_AURA_ADV_FLYING)) RemoveAura(SPELL_DYNAMIC_FLIGHT); } } @@ -33606,7 +33606,7 @@ void Player::AddPerksPurchase(int32 vendorItemID, uint32 purchaseTime) CharacterDatabase.Execute(stmt); } -void Player::SetPerksFrozenVendorItem(int32 vendorItemID, WorldPackets::PerksProgram::PerksVendorItem const* itemData) +void Player::SetPerksFrozenVendorItem(int32 vendorItemID, [[maybe_unused]] WorldPackets::PerksProgram::PerksVendorItem const* itemData) { _perksFrozenVendorItemID = vendorItemID; _perksFrozenDirty = true; diff --git a/src/server/game/Quests/WorldQuestMgr.cpp b/src/server/game/Quests/WorldQuestMgr.cpp index 4c70f55e6..90d8bb973 100644 --- a/src/server/game/Quests/WorldQuestMgr.cpp +++ b/src/server/game/Quests/WorldQuestMgr.cpp @@ -337,7 +337,7 @@ void WorldQuestMgr::AddEmissaryQuestsOnPlayerIfNeeded(Player* player) } } -std::vector WorldQuestMgr::GetCriteriasForQuest(uint32 quest_id) +std::vector WorldQuestMgr::GetCriteriasForQuest([[maybe_unused]] uint32 quest_id) { std::vector criterias; diff --git a/src/server/game/Quests/WorldQuestMgr.h b/src/server/game/Quests/WorldQuestMgr.h index 018c64b31..8d1de16f0 100644 --- a/src/server/game/Quests/WorldQuestMgr.h +++ b/src/server/game/Quests/WorldQuestMgr.h @@ -92,8 +92,8 @@ struct WorldQuestTemplate struct ActiveWorldQuest { ActiveWorldQuest(uint32 questId, uint32 rewardId, uint32 startTime, uint32 timer) - : QuestId(questId), RewardId(rewardId), StartTime(startTime), IsCompleted(false), - EndTime(startTime + timer) + : QuestId(questId), RewardId(rewardId), StartTime(startTime), EndTime(startTime + timer), + IsCompleted(false) { } diff --git a/src/server/game/Server/Packets/HousingPackets.cpp b/src/server/game/Server/Packets/HousingPackets.cpp index e7b148267..fcd8cd560 100644 --- a/src/server/game/Server/Packets/HousingPackets.cpp +++ b/src/server/game/Server/Packets/HousingPackets.cpp @@ -1510,7 +1510,7 @@ namespace WorldPackets::Housing WorldPacket const* HousingSvcsUpdateHousesLevelFavor::Write() { - // IDA case 5505041: uint8 + uint32 + uint32 + uint32(count) + Entry[count]{3×GUID + uint32 + uint32 + uint8 + uint8(bit7)} + // IDA case 5505041: uint8 + uint32 + uint32 + uint32(count) + Entry[count]{3XGUID + uint32 + uint32 + uint8 + uint8(bit7)} _worldPacket << uint8(Type); _worldPacket << uint32(Field1); _worldPacket << uint32(Field2); @@ -1610,10 +1610,10 @@ namespace WorldPackets::Housing { // IDA case 5505049: bit-packed blob via ai_Decode_ClientOpcodeData // Client reads first byte: top 6 bits = blobSize, bottom 2 bits cached - // Then reads blobSize raw bytes into a 49-byte struct (3×16-byte raw GUIDs + 1 byte) + // Then reads blobSize raw bytes into a 49-byte struct (3X16-byte raw GUIDs + 1 byte) if (Result == 0) { - uint8 blobSize = 49; // 3×16-byte raw ObjectGuids + 1 byte + uint8 blobSize = 49; // 3X16-byte raw ObjectGuids + 1 byte _worldPacket << uint8((blobSize << 2) | (Result & 0x03)); _worldPacket.append(OwnerGUID.GetRawValue().data(), 16); _worldPacket.append(HouseGUID.GetRawValue().data(), 16); @@ -1776,7 +1776,7 @@ namespace WorldPackets::Housing WorldPacket const* HousingHouseStatusResponse::Write() { - // IDA 0x550000: PackedGUID×4 + uint8(Status) + uint8(FlagByte: bit7/bit6/bit5) + // IDA 0x550000: PackedGUIDX4 + uint8(Status) + uint8(FlagByte: bit7/bit6/bit5) _worldPacket << HouseGuid; _worldPacket << AccountGuid; _worldPacket << OwnerPlayerGuid; @@ -1870,7 +1870,7 @@ namespace WorldPackets::Housing WorldPacket const* HousingUpdateHouseInfo::Write() { - // IDA 0x550004: 3×24bit-BE(strLen) + 3×uint32 + uint8 + 3×string(strLen) + // IDA 0x550004: 3X24bit-BE(strLen) + 3Xuint32 + uint8 + 3Xstring(strLen) auto writeBE24 = [&](uint32 len) { _worldPacket << uint8((len >> 16) & 0xFF); _worldPacket << uint8((len >> 8) & 0xFF); diff --git a/src/server/game/Server/Packets/HousingPackets.h b/src/server/game/Server/Packets/HousingPackets.h index 5a7aa5658..5fef5783b 100644 --- a/src/server/game/Server/Packets/HousingPackets.h +++ b/src/server/game/Server/Packets/HousingPackets.h @@ -1690,7 +1690,7 @@ namespace WorldPackets::Housing WorldPacket const* Write() override; // IDA case 5505041 (sub_7FF724C7D8D0): - // uint8 + uint32 + uint32 + uint32(count) + Entry[count]{3×PackedGUID + uint32 + uint32 + uint8 + uint8(bit7)} + // uint8 + uint32 + uint32 + uint32(count) + Entry[count]{3XPackedGUID + uint32 + uint32 + uint8 + uint8(bit7)} uint8 Type = 0; uint32 Field1 = 0; uint32 Field2 = 0; @@ -1779,7 +1779,7 @@ namespace WorldPackets::Housing // IDA case 5505049: bit-packed blob encoding via ai_Decode_ClientOpcodeData // First byte: top 6 bits = blobSize (49 on success, 0 on failure) // bottom 2 bits = result code (0=success, 1-3=error) - // Blob: 3×16-byte raw ObjectGuids + 1 byte = 49 bytes total + // Blob: 3X16-byte raw ObjectGuids + 1 byte = 49 bytes total uint8 Result = 0; ObjectGuid OwnerGUID; ObjectGuid HouseGUID; @@ -1887,7 +1887,7 @@ namespace WorldPackets::Housing HousingHouseStatusResponse() : ServerPacket(SMSG_HOUSING_HOUSE_STATUS_RESPONSE) {} WorldPacket const* Write() override; - // IDA 0x550000: PackedGUID×4 + uint8(Status) + uint8(FlagByte: bit7/bit6/bit5) + // IDA 0x550000: PackedGUIDX4 + uint8(Status) + uint8(FlagByte: bit7/bit6/bit5) // Position 2 is BNetAccount GUID per sniff byte analysis (hi byte7=0x78) ObjectGuid HouseGuid; ObjectGuid AccountGuid; // BNetAccount GUID (sniff-verified at position 2) @@ -1979,7 +1979,7 @@ namespace WorldPackets::Housing HousingUpdateHouseInfo() : ServerPacket(SMSG_HOUSING_UPDATE_HOUSE_INFO) {} WorldPacket const* Write() override; - // IDA 0x550004: 3×24bit-BE(strLen) + 3×uint32 + uint8 + 3×string(strLen) + // IDA 0x550004: 3X24bit-BE(strLen) + 3Xuint32 + uint8 + 3Xstring(strLen) std::string HouseName; std::string HouseDescription; std::string HouseExtra; // third string (purpose TBD) diff --git a/src/server/game/Spells/SpellEffects.cpp b/src/server/game/Spells/SpellEffects.cpp index bb357f67e..946d56715 100644 --- a/src/server/game/Spells/SpellEffects.cpp +++ b/src/server/game/Spells/SpellEffects.cpp @@ -7062,9 +7062,7 @@ void Spell::EffectCompleteAndRewardWorldQuest() Player* playerCaster = GetCaster()->ToPlayer(); uint32 questId = effectInfo->MiscValue; - - Quest const* quest = sObjectMgr->GetQuestTemplate(questId); - + //Quest const* quest = sObjectMgr->GetQuestTemplate(questId); WorldQuestTemplate* worldQuest = sWorldQuestMgr->GetWorldQuestTemplate(questId); if (!worldQuest)