josh/ThordekkCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ci): Resolve Windows Boost path and Linux linker issues

Browse Source 
- Skip FindSystemBoost.cmake on CI (GITHUB_ACTIONS env) to use standard
  Boost finding with MarkusJx/install-boost action
- Change Linux build from SCRIPTS=dynamic to SCRIPTS=static to fix
  linker error with static Boost libraries

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Signed-off-by: luis <[email protected]>
This commit is contained in:
agatho
2026-01-22 21:24:24 -03:00
committed by luis
co-authored by Claude Opus 4.5
parent 5b964c8d50
commit 230cc39a5d
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/linux-build.yml
+1 -1
View File
@@ -56,7 +56,7 @@ jobs:
CXX: /usr/bin/${{ matrix.cxx }}
run: >
cmake -GNinja -S ${{ github.workspace }} -B ${{ steps.strings.outputs.build-output-dir }}
-DWITH_WARNINGS=1 -DWITH_WARNINGS_AS_ERRORS=1 -DWITH_COREDEBUG=0 -DUSE_COREPCH=${{ matrix.pch }} -DUSE_SCRIPTPCH=${{ matrix.pch }} -DTOOLS=1 -DSCRIPTS=dynamic -DSERVERS=1 -DNOJEM=0 -DBUILD_PLAYERBOT=ON
-DWITH_WARNINGS=1 -DWITH_WARNINGS_AS_ERRORS=1 -DWITH_COREDEBUG=0 -DUSE_COREPCH=${{ matrix.pch }} -DUSE_SCRIPTPCH=${{ matrix.pch }} -DTOOLS=1 -DSCRIPTS=static -DSERVERS=1 -DNOJEM=0 -DBUILD_PLAYERBOT=ON
-DCMAKE_C_FLAGS_DEBUG="-DNDEBUG -g0" -DCMAKE_CXX_FLAGS_DEBUG="-DNDEBUG -g0"
-DCMAKE_INSTALL_PREFIX=check_install -DBUILD_TESTING=1
- name: Build
dep/boost/CMakeLists.txt
+2 -1
View File
@@ -9,7 +9,8 @@
# implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
# Use system Boost 1.89 when building with playerbot to avoid vcpkg conflicts
if(BUILD_PLAYERBOT)
# Skip custom FindSystemBoost on CI (GITHUB_ACTIONS env var) - use standard finding
if(BUILD_PLAYERBOT AND NOT DEFINED ENV{GITHUB_ACTIONS})
message(STATUS "Using system Boost 1.89 for Playerbot compatibility")
include(${CMAKE_SOURCE_DIR}/cmake/FindSystemBoost.cmake)