Commit Graph
15927 Commits
Author SHA1 Message Date
joschiwald f5c2dca1d5 Scripts: fix crash in spell_jokkum_scriptcast
Closes #11313
2013-12-14 19:43:29 +01:00
Discover- ec8e94c6ac Core/AI: Fix an issue where the OnQuestAccept hooks were not called for auto-completed quests.
Fixes #11304
2013-12-14 19:39:47 +01:00
jackpoz ca6b9df261 Core/Misc: Fix some static analysis issues
Fix some static analysis issues about uninitialized values.
2013-12-14 19:36:43 +01:00
jackpoz 1c0903e286 Core/Misc: Fix some static analysis issues
Fix some static analysis issues about uninitialized values. Most of them are false positives, always initialized before being accessed, while some of them are real issues spotted by valgrind too.
2013-12-14 18:41:26 +01:00
Malcrom dd546f073a Core/Player: Add another exception to questgiver spell casting. 2013-12-14 14:05:24 -03:30
jackpoz e28cc4660b Core/Movement: Fix invalid memory access
Fix the stack implementation used in MotionMaster and added few sanity checks to ensure no underflows will be made.

Valgrind log:
 Invalid read of size 8
  at : MotionMaster::top() const (MotionMaster.h:115)
  by : MotionMaster::pop() (MotionMaster.h:91)
  by : MotionMaster::~MotionMaster() (MotionMaster.cpp:74)
  by : Unit::~Unit() (Unit.cpp:296)
  by : Player::~Player() (Player.cpp:880)
  by : WorldSession::HandleCharCreateCallback(Trinity::AutoPtr<PreparedResultSet, ACE_Thread_Mutex>, CharacterCreateInfo*) (CharacterHandler.cpp:665)
  by : WorldSession::HandleCharCreateCallback(Trinity::AutoPtr<PreparedResultSet, ACE_Thread_Mutex>, CharacterCreateInfo*) (CharacterHandler.cpp:516)
2013-12-14 16:51:47 +01:00
Discover- 4ca63412c8 Core/SmartAI: SMART_ACTION_UPDATE_TEMPLATE will no longer ignore the target type and force the source creature (creature only) to be updated; from now on it updates the given targets to the given entry (actionparam1) 2013-12-13 09:45:58 +01:00
Malcrom c045d4c7f4 Core/SmartAI: Reset Actions will not be processed until creature reaches home. 2013-12-12 21:23:14 -03:30
Malcrom 9f741432a3 Core/AI: Some code cleanup 2013-12-12 18:09:07 -03:30
Malcrom 9d95351118 Core/SmartAI: Fixed issue where ranged caster would switch to combat ready state between cast. 2013-12-12 16:39:30 -03:30
Shauren 54fd53f7e3 Core/Movement: Fixed possible invalid memory access 2013-12-12 09:50:52 +01:00
Vincent_Michael fb26e18523 Core: Fix warnings 2013-12-11 20:30:15 +01:00
joschiwald a40e814240 Core/SmartScripts: speedup loading/validating sai scripts from db
Before:
>> Loaded 6953 SmartAI scripts in 3543 ms

After:
>> Loaded SmartAIMgr Helpers in 4 ms
>> Loaded 6953 SmartAI scripts in 95 ms
2013-12-11 18:53:05 +01:00
Shauren 488841dd2c Merge pull request #11306 from trickerer/fixaggro
Don't allow units to enter combat upon death
2013-12-11 00:40:46 -08:00
Malcrom fc7e335d3b Scripting/Obsidian Sanctum: Updated scripts to use Events. 2013-12-11 01:13:23 -03:30
trickerer 91ebea4a77 Don't allow units to enter combat upon death 2013-12-11 09:38:24 +07:00
joschiwald eddf1b5a64 Scripts: replace some SetOrientation() calls with spline packets and some random changes 2013-12-10 18:46:11 +01:00
joschiwald bb45db65a0 Merge pull request #11275 from Carbenium/UtgardePinnacle
Scripts/UtgardePinnacle: Convert Svala Sorrowgrave to event system
2013-12-10 07:29:00 -08:00
Carbenium 000bfbb732 Convert Svala Sorrowgrave to event system 2013-12-10 16:05:02 +01:00
Malcrom 74facef60d Scripting/Storm Peaks: Renamed npc_brann_bronzebeard script because name has already been used. 2013-12-10 00:11:33 -03:30
Kinzcool ceaa6c332e Core/Enums: Few inns/zones use the zone itself for the resting state instead of an areatrigger. 2013-12-09 20:40:22 -05:00
jackpoz 822755ca87 Core/Misc: Fix some static analysis issues
Fix some static analysis issues about uninitialized values.
2013-12-09 21:10:42 +01:00
Malcrom 755283ac8d Scripting/Storm Peaks: Quest 13285 "Forging the Keystone" now scripted.
Closes #6921
2013-12-09 03:28:40 -03:30
Malcrom dd4aee2c10 Scripting/Howling Fjord: Fix Quest 11310 Warning: Some Assembly Required
Quest is doable and completeable with the following Issues:
Aura not being removed from player after Abomination explodes.
Camera angle should not changes after Abomination explodes.
Can't check if Abomination leaves Halgrind. GetAreaId returns players area id.
2013-12-08 18:46:06 -03:30
jackpoz f418f4cf94 Core/Misc: Fix some static analysis issues
Fix some static analysis issues about uninitialized values in scripts.
Add spell id validation in Unit::SpellNonMeleeDamageLog() .
2013-12-08 22:04:30 +01:00
Vincent_Michael b76d141ce0 Core: Fix warning 2013-12-08 20:53:06 +01:00
Malcrom ae597c3594 Scripting/Razorfen Downs: Discovered some missing text for boss Glutton. 2013-12-08 15:07:49 -03:30
Malcrom 5c15e88da9 Core/Unit: Add switch to prevent COMMAND_ATTACK being added to action bar for supplied creature entries. 2013-12-08 11:55:28 -03:30
Warpten 98d2dbbd3f Core/Spells: Fixed rare issues where spell modifiers would not be correctly restored.
Happens in case of a spell having more than one modifier granted by an aura.
2013-12-08 15:06:10 +01:00
Vincent_Michael 2ed05e487d Core: Fix non pch build 2013-12-08 02:06:55 +01:00
Malcrom 89de7e7419 Scripting/Razorfen Downs: Additions and fixes for instance.
Moved bosses Glutton, Mordresh Fire Eye, Tuten Kash to cpp.
Cleaned up code for boss Amnennar The Coldbringer.
Fixed up gong event for gong to have sound and proper spawning.
Scripted quest 3525 "Extinguishing the Idol" so you can now fight Plagmaw the Rotting.
2013-12-07 21:19:46 -03:30
Malcrom e667c96cfc Scripting/Grizzly Hills: Add missing include "SpellScript.h" 2013-12-05 13:24:34 -03:30
Malcrom af5d3daeab Core/Vehicle: Add an extra check for required energy before setting power. 2013-12-05 13:07:15 -03:30
Malcrom 621ba87917 Grizzly Hills/Scripting: Fix Quest 12244 "Shredder Repair" and 12270 "Shred the Alliance"
Closes #1942 #3754
2013-12-05 13:04:11 -03:30
w1sht0l1v3 dc1d1a684a Scripts/HoR: Some fixups. 2013-12-05 16:05:15 +02:00
joschiwald dd16bfb881 Scripts/Oculus: fix drake spells
Closes #6681
Closes #6680
Closes #6673
2013-12-05 00:00:07 +01:00
Vincent_Michael c2984e3dbc Core/RBAC: Fix typo 2013-12-04 22:35:44 +01:00
jackpoz 8669633921 Core/Commands: Fix NULL dereference crash in .npc set link
Fix NULL dereference crash in .npc set link happening when passing a not-existent Creature guid as parameter, es. ".npc set link -1" .
Issue spotted by static analysis, added in c05ed659cb
2013-12-04 20:42:51 +01:00
Malcrom fb1daeb44c Core/SpellMgr: Remove unneeded check for max targets 2013-12-04 16:08:57 -03:30
Malcrom 5da508c0a0 Scripting/Blade's Edge: Quest 10594 "Gauging the Resonant Frequency"
Closes #6214
2013-12-04 14:43:35 -03:30
Malcrom c084b3d16e Core/SmartAI: Remove unneeded code added in error 2013-12-04 01:05:56 -03:30
Malcrom e60fe4c303 Core/SmartAI: Fixed waypoint pathing not resuming after evade. 2013-12-03 23:41:11 -03:30
Malcrom 81c73c2d53 Scripting/Sholazar Basin: Fix warning 2013-12-03 21:05:54 -03:30
Malcrom b407e72339 Core/SmartScript: Allow flag to be added to spell to determine combat movement.
Greatly simplifies SAI combat scripting.
2013-12-03 20:53:33 -03:30
Malcrom 48d8af0962 Core/SmartAI: Fix SMART_ACTION_ALLOW_COMBAT_MOVEMENT 2013-12-03 20:19:17 -03:30
jackpoz 7806b7c493 Core/Chat: Fix ChatFlood.MessageCount not being handled correctly
Fix Anti-flood chat system to always allow 1 more message than the count specified in the ChatFlood.MessageCount config parameter.
2013-12-03 21:47:52 +01:00
jackpoz 5bbded18b5 Core/Misc: Fix some static analysis issues
Fix some static analysis issues about missing NULL checks.
Pass safe Creature pointer instead of summoning a Creature, passing the GUID and retrieve the same Creature from GUID.
2013-12-03 21:46:00 +01:00
w1sht0l1v3 8920994045 Scipts/HallsOfReflection: Fix reset during mob waves.
closes #10995
2013-12-02 20:56:22 +02:00
Malcrom 3485656aee Core/Player: GetRewSpellCast & GetRewSpell should not be cast by questgiver if effect type SPELL_EFFECT_LEARN_SPELL 2013-12-01 22:00:10 -03:30
Malcrom 422fd5fc48 Scripting/Sholazar Basin: Fix spell_shango_tracks script. 2013-12-01 13:38:28 -03:30