Commit Graph
22031 Commits
Author SHA1 Message Date
Shauren 8396dabdad Core/Misc: Fixed coverity issues
Uninitialized fields: CID 1354593, 1354595, 1354738
Unchecked return value: CID 1354558
Out of bounds access: CID 1352989, 1352993
Null pointer dereference: CID 1296286
2016-06-06 09:16:59 +02:00
Shauren d59bba3c5d Core/Misc: Fixed uninitialized field
Coverity CID 1354596
2016-06-06 08:51:42 +02:00
Shauren d8e0ce4d40 Core/Misc: Fixed uninitialized fields in black market packets
Coverity CID 1354736 and 1354737
2016-06-06 08:49:10 +02:00
Shauren b920d6a35c Core/Spells: Fixed possible null pointer dereference
Coverity CID 1355243
2016-06-06 08:45:09 +02:00
Shauren 1c139214b5 Core/Spells: Silence coverity false positive - CID 1356246 2016-06-06 08:38:39 +02:00
Vincent-Michael 9d7a17d9f5 Core/Commands: Added ".npc set phase" command error message for invalid phaseid
Closes #14927
2016-06-05 16:43:41 +02:00
Shauren 6ce84d9401 Core/PacketIO: Fixed sending SMSG_SPELL_EXECUTE_LOG 2016-06-05 01:19:25 +02:00
Shauren dd1533b315 Core/Utils: Added additional argument to Tokenizer class to make it behave like strtok - not returning empty tokens in case of multiple consecutive separators in input string 2016-06-04 16:40:57 +02:00
Aokromes 1379505bf2 Update worldserver.conf.dist 2016-06-04 12:49:07 +02:00
DDuarte 8b26aea95a Implement real time statistic visualization (#16956)
Docs at https://trinitycore.atlassian.net/wiki/display/tc/Monitoring+a+TrinityCore+server

* Common/Graphs: Initial proof of concept

* Move influx db code to its own class

* Reuse the same socket

* Allow to log values of different categories

* Allow to log events

* Pass the timestamp to influxdb

* Send events in batches

* Send data async

* Log server shutdown.
Fix memory leak.

* Allow to enable/disable Stats in the settings and at runtime

* Read interval between each batch send from config

* Add InfluxDB connection info to configs

* Move each event category to its own table

* Log pathfinding queries

* Move categories table initialization to constructor using enum as key to avoid assigning the table name to the wrong enum value

* Log player login/logout events.
Pass the hostname correctly in the HTTP request.

* Fix linux build

* Handle "Connection: close" HTTP header, reconnecting on next scheduled send.
Disable StatsLogger if connection fails, logging the error.

* Add an enum for categories of logged values, it's still possible to pass a string instead of the enum.

* Don't log the whole batchedData when InfluxDB returns an error, it's too long and unreadable on console.

* Allow to call a function at a specified interval in thread-safe World::Update() context to log data like player count.

* Log map tile load/unload

* Core/StatsLogger: Allow logging more value types other than ints

https://docs.influxdata.com/influxdb/v0.10/write_protocols/write_syntax/

* Fix a typo in string escape of StatsLogger

* Yet more fixes to the escaping in FormatInfluxDBValue

* DB/Gameobject: Fix respawn time of few Quest GameObjects

By Tauriella, closes #16701

* DB/Misc: Fix some engrish

By tkrokli closes #16648

* Tools/MMaps: Add format library linking to mmaps_generator

(Very) partial cherry pick of ed75b0649a

* Core/StatsLogger: Simplify code

Convert values and categories arrays to maps initialized in-place
Remove constructor and destructor

* Core/StatsLogger: Add realm name to the event and value tags

* Log amount of processed packet of each session

* Apply recent singleton changes to sStatsLogger too

* Fix influxdb data format if no realm name is present

* Remove unneeded newlines from request body, fixes response 400 from InfluxDB 0.10

* Rename Reporting folder to Metric

* Rename StatsLogger to Metric

* Rename InfluxDB configs to Metric

* Add Grafana dashboards

* Add a random annoying macro

* Move string formatting to Metric::SendBatch(), reducing performance footprint of Metric::LogEvent() and Metric::LogValue()

* Update grafana graphs refresing tags on load and showing now-15m data, refreshing every minute. These settings can be modified in grafana.

* Rename MetricData fields

* Contrib/Grafana: Rename dashboard files

* Contrib/Grafana: Replace hardcoded Windows/Ubuntu realm names by the default, Trinity

* Config/Worldserver: Add missing section to the index

* Contrib/Grafana: Add singlestat panels with current online players, update diff averages (1 min, 5 mins and 15 mins)

http://i.imgur.com/Zi8lfvS.png

* Core/Metric: Replace the enums MetricEventCategory and MetricValueCategory by strings

For the sake of simplicity and less recompile time when adding new metrics, similar to how TC_LOG_* works

* Contrib/Grafana: Display the current number of online players and not its average

Closes #15075
(cherry picked from commit 3ae10160820782d039c3449107960108fb3a63b9)

# Conflicts:
#	src/server/game/Server/WorldSession.cpp
#	src/server/game/World/World.cpp
#	src/server/worldserver/Main.cpp
2016-06-04 11:26:57 +01:00
Shauren 2c2bb4a237 Core/Auras: Named currency gain modifying aura types 2016-06-03 23:27:07 +02:00
Sean Rhone 9db75766e7 Update worldserver.conf.dist (#17270)
- Very minor typo
2016-06-03 00:35:24 +01:00
Shocker 63f8f54e5c Core/Spells: Define SPELL_EFFECT_ALTER_ITEM 2016-06-02 17:07:07 +03:00
Shauren 3ccb1e665f Core/Auras: Send aura update to client when aura amount changes and aura has SPELL_ATTR8_AURA_SEND_AMOUNT 2016-06-01 23:08:30 +02:00
Shauren 2cead228d2 Core/PacketIO: Fixed setting player declined names
Closes #16669
2016-05-31 17:03:05 +02:00
Shauren e78abe9911 Core/Auras: Fix copypaste mistake from fde9e8985f 2016-05-31 17:02:22 +02:00
Shauren fde9e8985f Core/Spells: Implemented auras 394 and 469 SPELL_AURA_SHOW_CONFIRMATION_PROMPT (WITH_DIFFICULTY) 2016-05-30 18:31:30 +02:00
Shauren 529e072fa3 Core/Spells: Defined new spell attribute (SPELL_ATTR12_IS_GARRISON_BUFF) 2016-05-29 19:05:45 +02:00
Trond B Krokli 186375d997 Core/DB/Updater: English grammar corrections (#17207)
Improve English text in strings and comments in UpdateFetcher.cpp
- replace incorrect text with the intended words in some output strings
- corrections in the comments to point out the intention of the code
2016-05-29 15:06:07 +01:00
Shauren cd51e27e19 Core/Auras: Implemented aura 475 - SPELL_AURA_ALLOW_USING_GAMEOBJECTS_WHILE_MOUNTED 2016-05-28 11:33:06 +02:00
Golrag d60fe0e5d5 Core/Battleground: Areatriggers will now check if player leaves the start area before the battleground begins in the following battlegrounds: (#15935) 2016-05-27 15:17:51 +02:00
Shauren 5776a256b8 Core/Pets: Fixed wrong prepared statement in bc1a81747a
Thanks Lordron for pointing it out
2016-05-26 23:13:31 +02:00
myran2 bc1a81747a Core/Pets: Implemented pet specializations (#17058)
* Use prepared statements in Pet::SavePetToDB
* Add support for resetting all of a player's pet specializations
* Send one big spell unlearn/learn packet instead of lots of small ones
* Implemented Adaptation talent
2016-05-26 17:20:01 +02:00
Shauren 6c71c8694f Core/Auras: Implemented SPELL_AURA_MOD_SPELL_COOLDOWN_BY_HASTE, SPELL_AURA_MOD_GLOBAL_COOLDOWN_BY_HASTE, SPELL_AURA_MOD_COOLDOWN_BY_HASTE_REGEN and SPELL_AURA_MOD_GLOBAL_COOLDOWN_BY_HASTE_REGEN 2016-05-26 14:47:36 +02:00
Shocker b539ac6afa Core/GameObjects: Add isUse parameter to GossipHello for distinction between CMSG_GAMEOBJECT_USE and CMSG_GAMEOBJECT_REPORT_USE 2016-05-26 13:09:56 +03:00
Shauren 6b30b88910 Core/Bnet: Order account list by id when the bnet account has more than 1 game account attached 2016-05-25 20:55:28 +02:00
Shauren a6205e4035 Core/Containers: Warning fixes and RandomResizeList with predicate optimization
(cherry picked from commit 0fbfa8ead04a59f3eef70f4f2e454e318d895bd9)
2016-05-24 18:52:34 +02:00
Shauren 40b38658c4 Core/DataStores: Fixed loading non-localized db2 strings 2016-05-23 21:18:54 +02:00
Shauren 18d28e8dc6 Core/PacketIO: Fixed sending OnHold pet cooldowns 2016-05-22 23:15:11 +02:00
Shauren b426262d1b Core/PacketIO: Fixed LFGuildApplications structure 2016-05-21 11:25:58 +02:00
Shauren 9a6c08efa2 Core/Spells: Fixed Fulmination and Shaman T18 bonuses related to it 2016-05-20 21:11:43 +02:00
Shauren 7cf22eab81 Core/Auras: Implemented SPELL_AURA_MOD_XP_FROM_CREATURE_TYPE 2016-05-18 23:28:40 +02:00
MitchesD f636141345 Core/Phase: phase_area table now support even parent area (known as zone)
Closes https://github.com/TrinityCore/TrinityCore/issues/17025
2016-05-18 20:06:47 +02:00
MitchesD 192c428865 Core/ConditionMgr: condition CONDITION_SOURCE_TYPE_PHASE should not break on first phaseID which is equal to condition phase Id, it should iterate over all and check if more areas are trying to apply the same phase
* it's required for example for Wandering Isle quests

Closes https://github.com/TrinityCore/TrinityCore/issues/17054
2016-05-17 21:35:54 +02:00
joschiwald c194daf0b5 Scripts/Freya: removed obsolete code
(cherry picked from commit d812505fc29daa51d549439eaa2c72221dbefe07)

Makes travis happy
(cherry picked from commit ab2466ac011dde5d728d2a75983c292eaebff4cd)
2016-05-17 21:22:06 +02:00
Shauren 22dc8b6871 Core/Spells: Fixed spell mod application order
Closes #10250
2016-05-17 17:23:40 +02:00
Shauren 17118f4832 Core/Auras: Implemented auras SPELL_AURA_PREVENT_DURABILITY_LOSS and SPELL_AURA_PREVENT_DURABILITY_LOSS_FROM_COMBAT 2016-05-17 00:02:55 +02:00
Shauren 316afd97e0 And nopch fix too 2016-05-16 16:35:15 +02:00
Shauren 0be1e269f6 Build fix for VS2013 - pls stop using it, upgrade to 2015. 2016-05-16 16:32:39 +02:00
Shauren 9ed0b20461 Core/PacketIO: Updated charm/vehicle spell sending 2016-05-16 15:59:49 +02:00
Shauren 7a806595ee Core/DataStores: Defined ChrSpecialization flag values 2016-05-15 00:04:06 +02:00
Vincent-Michael 0139d83e28 Core/Spells: Fixed non pch build 2016-05-14 21:27:22 +02:00
Gacko 5cb2ca5c81 Spell/Shaman: Fix non PCH linking.
Thanks @Shauren.
2016-05-14 16:09:51 +02:00
Aokromes 1a7df22122 Update worldserver.conf.dist 2016-05-14 06:43:04 +02:00
Shauren 698a197cf0 Core/Units: Updated rage generation formula 2016-05-14 00:06:23 +02:00
Shauren 00640dee97 Core/Auras: Implemented aura 481 - SPELL_AURA_CONVERT_CONSUMED_RUNE
Used by: Blood Rites, Reaping and Glyph of the Ice Reaper
2016-05-13 21:46:32 +02:00
Shauren 791e0f0513 Core/Spells: Fixed Lightning Shield dropping charges when attacked 2016-05-12 16:47:45 +02:00
Shauren c9ba5ce591 Core/Misc: Warning fixes (/W4) 2016-05-11 16:52:39 +02:00
Vincent-Michael cccdbf4755 Core/Spells: Fixed warning 2016-05-10 19:57:20 +02:00
Naios a0dacd90cb Core/Game: Remove some unnecessary export macros
(cherry picked from commit f50c4b71a137b90c2c5848c2ddef0139b05fa4a1)
2016-05-10 19:24:30 +02:00