Commit Graph
2286 Commits
Author SHA1 Message Date
Shauren de592386dc Core/Spells: Autorepeat casting fixes
* Fixed cast bars of ranged spells not disappearing when canceled while autoshooting
* Replaced hacky 500ms delay on non auto shot autorepeat spells with native spell cast time (wands have 500ms cast time)
* Update cooldowns before attempting to cast autorepeat spells (for cases when cooldown ends on the same server tick as cast attempt)
2022-05-08 15:54:15 +02:00
Shauren 538fa8e97f Core/Spells: Cleanup movement checks in spells - use correct interrupt flags 2022-05-07 23:31:55 +02:00
Shauren 0620b829b2 Core/Spells: Implemented SPELL_ATTR6_DELAY_COMBAT_TIMER_DURING_CAST 2022-05-07 20:09:25 +02:00
Shauren 50eff8c238 Core/Spells: Implemented SPELL_ATTR6_NO_PUSHBACK 2022-05-07 00:18:01 +02:00
Shauren 076c63c766 Core/Spells: Implemented SPELL_ATTR5_NOT_AVAILABLE_WHILE_CHARMED 2022-05-02 19:29:51 +02:00
Shauren 8a219b7e39 Core/Spells: Corrected implementation of SPELL_ATTR5_ALLOW_ACTIONS_DURING_CHANNEL - it allows casting other spells while channeling, not allows movement while channeling 2022-05-02 16:15:28 +02:00
Shauren d818add0e2 Core/Auras: Added support for SPELL_ATTR5_LIMIT_N limit to other number than just 1 2022-05-02 16:14:41 +02:00
Shauren 8d16a79dea Core/Spells: Rename SpellAttr4 to use official attribute names
* Corrected implementation of SPELL_ATTR4_CLASS_TRIGGER_ONLY_ON_TARGET
* Implemented SPELL_ATTR4_NO_HELPFUL_THREAT
* Implemented SPELL_ATTR4_NO_PARTIAL_IMMUNITY
* Implemented SPELL_ATTR4_ALLOW_PROC_WHILE_SITTING
* Implemented SPELL_ATTR4_USE_FACING_FROM_SPELL
* Implemented SPELL_ATTR4_BOUNCY_CHAIN_MISSILES
* Implemented SPELL_ATTR4_AURA_NEVER_BOUNCES
* Implemented SPELL_ATTR4_AURA_BOUNCE_FAILS_SPELL
* Implemented SPELL_ATTR4_AURA_IS_BUFF
* Implemented SPELL_ATTR5_MELEE_CHAIN_TARGETING

* Implemented SpellEffectAttributes::ChainFromInitialTarget
2022-05-01 20:01:13 +02:00
Shauren 88d7b58a3d Core/Spells: Rename SpellAttr3 to use official attribute names
* Implemented SPELL_ATTR3_NO_AVOIDANCE
* Implemented SPELL_ATTR3_ONLY_PROC_OUTDOORS
* Implemented SPELL_ATTR3_ONLY_PROC_ON_CASTER
* Implemented SPELL_ATTR3_PVP_ENABLING
* Implemented SPELL_ATTR3_SUPPRESS_CASTER_PROCS
* Implemented SPELL_ATTR3_SUPPRESS_TARGET_PROCS
2022-04-30 16:57:32 +02:00
Shauren dda375b986 Core/Spells: Rename SpellAttr2 to use official attribute names
* Corrected implementation of SPELL_ATTR1_ALLOW_WHILE_STEALTHED
* Implemented SPELL_ATTR2_RETAIN_ITEM_CAST
* Implemented SPELL_ATTR2_ALLOW_WHILE_INVISIBLE
* Implemented SPELL_ATTR0_PROC_FAILURE_BURNS_CHARGE
* Implemented SPELL_ATTR2_PROC_COOLDOWN_ON_FAILURE
* Implemented SPELL_ATTR2_NO_TARGET_PER_SECOND_COSTS
* Implemented SPELL_ATTR2_DO_NOT_REPORT_SPELL_FAILURE
* Implemented SPELL_ATTR1_REQUIRE_ALL_TARGETS
* Implemented SPELL_ATTR2_CHAIN_FROM_CASTER
* Implemented SPELL_ATTR2_NO_ACTIVE_PETS
* Implemented SPELL_ATTR2_ENCHANT_OWN_ITEM_ONLY
2022-04-28 18:31:26 +02:00
Shauren c88b602a2c Core/Spells: Rename SpellAttr1 to use official attribute names
* Implemented SPELL_ATTR1_NO_SKILL_INCREASE, SPELL_ATTR1_AURA_STAYS_AFTER_COMBAT, SPELL_ATTR1_DISPEL_ALL_STACKS
2022-04-25 22:16:56 +02:00
Shauren a31e681944 Core/Spells: Rename SpellAttr0 to use official attribute names 2022-04-24 18:40:10 +02:00
Shauren 52fb467031 Core/Units: Include SPELL_AURA_MOD_FACTION auras when restoring faction (either on aura removal or .gm off) 2022-04-16 12:15:37 +02:00
Shauren 5558769405 Core/Battlegrounds: Replaced overriding m_team with more fine grained approach 2022-04-16 12:15:37 +02:00
Shauren b47185cabf Core/Misc: Rename AddXXXFlag updatefield functions to SetXXXFlag 2022-03-27 18:14:47 +02:00
Shauren 4eba978670 Core/Misc: Rename SetXXXFlags updatefield functions to ReplaceAllXXXFlags 2022-03-26 18:59:44 +01:00
offl 050f55b62f Core/AI: OnSpellCast, OnSpellFailed, OnSpellStart hooks (#27704)
(cherry picked from commit 3dca705acc953d20e4a43d4c2b3c97a84e5ab346)
2022-03-26 15:15:46 +01:00
Giacomo Pozzoni 8c25abca72 Core/AI: Fix crashes caused by charmed Creatures having null AI for 1 map update tick (#27434)
Implement using ScheduledChangeAI instead of nullptr to signal a required AI change

(cherry picked from commit 19e99db821ba5975e88ec160df3f4ff78ed562b0)
2022-03-24 22:35:05 +01:00
Shauren 56dd1243fd Core/Units: Rename AnimationTier to AnimTier for consistency between branches 2022-03-24 20:44:26 +01:00
Shauren 57d9d16442 Core/Auras: Properly clean up partial charm applications
Ref #24876

(cherry picked from commit 9174281b9253712982273b9b703d9fbac5cef9cd)
2022-03-23 00:06:51 +01:00
Lucas Nascimento 4ed918fcb3 Core/Combat: Fixed combat after remove charm (#27248)
https://github.com/TrinityCore/TrinityCore/pull/27038#issuecomment-958784361
(cherry picked from commit 0cc0b3f926a55fd70a51a90631dde99fbb8c6b8b)
2022-03-21 22:02:34 +01:00
Keader 381c543c60 Core/Unit: Fixed wrong combat stop when set charm
(cherry picked from commit 9b354c6bebdf9fe9c9842330447162edc63cc751)
2022-03-20 23:50:55 +01:00
offl 7a0268d4f1 Core/Scripting: Get rid of ModifyVehiclePassengerExitPos (#27126)
(cherry picked from commit d7adc50daa5a20142e0f39a9f65d39869525fd0e)
2022-03-20 16:27:10 +01:00
Lucas Nascimento 7de20bcc1c Entities/Unit: Fixed wrong combat stop when remove charm (#27038)
(cherry picked from commit fa3a62ae4e890dc526f2f0474e3469ccddb15edf)
2022-03-20 16:03:44 +01:00
Lucas Nascimento 4c632bb690 Core/Unit: Fixed Deterrence stopping working for no reason (#26996)
(cherry picked from commit 63c6f7bc26b73f59165179935d2556aea1636f12)
2022-03-20 00:05:21 +01:00
trickerer 6c9bde098b Core/Combat Improve extra attacks handling (#26859)
* Core/Combat Improve extra attacks handling

* Remove unnecessary _lastDamagedTargetGuid check

* Add missing initialization of _lastExtraAttackSpell. Do not use hardcoded spell ids.

* Partially revert 9f90b835019b

(cherry picked from commit 084f8f3ded45150a57eabd3ad117f1152d4d046d)
2022-03-19 22:37:41 +01:00
offl ad0ebedd9b Core/Misc: Rename UNIT_FLAG_SWIMMING to UNIT_FLAG_CAN_SWIM
Ref #26912

(cherry picked from commit e4a82ee97ad99f751216af47c88f29ff118d771b)
2022-03-15 23:47:31 +01:00
offl c4906ce60b Core/Misc: Rename UNIT_FLAG_NOT_SELECTABLE to UNIT_FLAG_UNINTERACTIBLE (#26913)
(cherry picked from commit c4741a131a0a28b69c228d3637beab7090e5f1e3)
2022-03-15 23:03:26 +01:00
Gildor 9b7c55921f Core/Unit: improve SPELL_AURA_MOD_IMMUNE_AURA_APPLY_SCHOOL immunities (#26849)
(cherry picked from commit 0fad28e4ab4d7143d629a8f28883a46823680fde)
2022-03-13 23:36:57 +01:00
Giacomo Pozzoni 71c2f0af46 Core/AI: Add DamageEffectType and SpellInfo parameters to UnitAI::DamageTaken (#26787)
* Core/AI: Add DamageEffectType and SpellInfo parameters to UnitAI::DamageTaken

* Update scripts

(cherry picked from commit 0800ab20a8039620fd271a43c173c008af68c22a)
2022-03-12 14:45:04 +01:00
offl 53d19b09f4 Core/Creature: rename CREATURE_FLAG_EXTRA_IGNORE_COMBAT into CREATURE_FLAG_EXTRA_CANNOT_ENTER_COMBAT (#26762)
Co-authored-by: offl <[email protected]>
(cherry picked from commit 06b554c36e8f196667e0a72820b37b9dc25bdde0)
2022-03-11 21:20:04 +01:00
jackpoz 98e4bc2d3d Core/Unit: Add more logs for #26325
Add more logs to try spotting the cause of #26325 . It might be that a minion is added to a owner that is not in world.
Report any issue with minions/pets that contain the log.

(cherry picked from commit 3f08c16749984252e657d46cfaa1ef50cd3f5a15)
2022-03-11 19:09:40 +01:00
jackpoz 779053ab90 Core/Unit: Include m_Controlled in crashlogs
(cherry picked from commit 40f4b141bd602d6285c3d2d21315a29b2ab3cce1)
2022-03-11 15:23:48 +01:00
Giacomo Pozzoni 8111f50d03 Core/Movement: Add new flag MOVEMENTGENERATOR_FLAG_PERSIST_ON_DEATH (#26549)
* Core/Movement: Add new flag MOVEMENTGENERATOR_FLAG_PERSIST_ON_DEATH

Add new flag MOVEMENTGENERATOR_FLAG_PERSIST_ON_DEATH to keep movement generators even after death.

Fixes #23095
Could replace ff26027453179448bb972d88a51e565d71e95f3f

* Core/Movement: reorder new method MotionMaster::StopOnDeath

* Core/Movement: reorder new method MotionMaster::StopOnDeath

* Keep MoveJump movement generator after death

Co-authored-by: ccrs <[email protected]>
(cherry picked from commit 9fe9dc087b4dc52af7897942a83c1f880d3a4ef8)
2022-03-10 23:57:14 +01:00
jackpoz 89ea13ed46 Core/Player: Log more information when Player::StopCastingCharm() fails
(cherry picked from commit af815e991d3dc407846fcd05000b4e356d7336ed)
2022-03-10 23:57:13 +01:00
offl e72264cfbd Core/Misc: Define / rename attributes and flags (#26315)
Co-authored-by: Trond B. Krokli <[email protected]>
(cherry picked from commit e6d9d9ead99aba4bfbd0b6389cb7a88827fe40d7)
2022-03-07 23:35:21 +01:00
jackpoz c93d6856c7 Core/Unit: Fix crash when exiting a vehicle
Ref #25649

(cherry picked from commit b84b92506354fc37017cb687aac263218265cf06)
2022-03-06 20:01:38 +01:00
jackpoz 730a8da9e9 Core/Unit: Set stand state on damage only to players
(cherry picked from commit 4cc1f850670b868a1d16833a2cf5c60715f749ef)
2022-03-06 20:01:25 +01:00
Giacomo Pozzoni 6b242eee13 Core/Unit: Fix movement hiccups in water (#24020)
* Core/Unit: Allow to define Units which can enter water but cannot swim

Allow to define Units which can enter water but cannot swim, i.e. crabs walking at the bottom of a sea.

* Add UNIT_FLAG_SWIMMING to creatures when entering combat

* Fix charmed creatures not entering water

* Always allow Creatures controlled by players to enter water

* Add swimming flag when possessing a unit and remove it properly at the end, even if the creature engaged combat before and after.
When adding/removing UNIT_FLAG_SWIMMING manually calling Creature::RefreshSwimmingFlag(true) might be required.

(cherry picked from commit fc1a0d936888395f114028af3337e7d674e0a43c)
2022-03-05 23:04:24 +01:00
Kargatum 373ed8f46b Core: whitespace cleanup, reduce double blank line to single (#25795)
* Core/Misc: fix double empty line

* worldserver.conf

(cherry picked from commit a32b6b8ac4c81128a56b282f20837fb085bdd9e7)
2022-03-05 20:07:57 +01:00
Aurelio Arcabascio 05a9b2d2cb Core/Player: auto-attacked player stands up from sit or sleep state (#25684)
* Fixed Auto Attack bug on sitting player

* Victim now stands during sleep and stand emotes

(cherry picked from commit 4ea64b515aa952662dce11fd1012c566ae0d2449)
2022-03-05 19:41:18 +01:00
Ovah d1594c7295 Core/Spells: unify OnSpellCastInterrupt and OnSuccessfulSpellCast hooks into OnSpellCastFinished (#25522)
* added support for calling the hook when completing a channeled spell as well

(cherry picked from commit 77aa058504e1ee99b560176d70bcf452c7e3d4f7)
2022-02-28 14:21:08 +01:00
Ovah ac6e242bff Core/Movement: fix units falling through the ground when hover mode is disengaged (PR #25518)
(cherry picked from commit e811b9cdc2582cb1504e85b43d80696031fe2634)
2022-02-28 14:08:36 +01:00
Shauren ee835671b4 Core/Objects: Added helper structures to allow using customized updatefield sending packet functions with Trinity::MessageDistDeliverer 2022-02-26 15:58:23 +01:00
Shauren d945a118db Core/Auras: Implemented SPELL_AURA_DISABLE_INERTIA (506) 2022-02-25 12:37:04 +01:00
Shauren 9f30afe352 Core/PacketIO: Updated packet structures to 9.2.0 2022-02-24 23:16:55 +01:00
Aqua Deus 1a0341ccbd Core/Auras: Implement SPELL_AURA_IGNORE_DUAL_WIELD_HIT_PENALTY (#27786) 2022-02-17 18:14:42 +01:00
Aqua DeusandShauren 64e8e11377 Core/Auras: Fix SPELL_AURA_MOD_DAMAGE_DONE_FOR_MECHANIC for effects mechanics (#27783)
Co-authored-by: Shauren <[email protected]>
2022-02-16 21:56:49 +01:00
Aqua DeusandShauren f205a89c86 Core/Spells: Implement spell attribute SPELL_ATTR3_NO_DURABILITY_LOSS (#27750)
Co-authored-by: Shauren <[email protected]>
2022-02-15 23:36:18 +01:00
Shauren ad4f4bfab7 Core/Misc: Minor game include cleanup 2022-02-13 00:49:10 +01:00