Commit Graph
5709 Commits
Author SHA1 Message Date
Rat dd24d80312 stick with 1x rates, thankya
--HG--
branch : trunk
2010-06-02 20:41:31 +02:00
Liberate 5981aa5495 *Fix: Only don't apply aura's with 0 sec duration (because of diminishing return for example) if the aura is not positive.
--HG--
branch : trunk
2010-06-02 20:26:46 +02:00
Trazom62 b7471f800c Fix crash in Unit::HandleProcTriggerSpell (Actually in Object::GetUInt32Value when pVictim is null).
Fixes issue #2458.

--HG--
branch : trunk
2010-06-02 19:36:59 +02:00
Machiavelli b1bf3b5e13 Merge
--HG--
branch : trunk
2010-06-02 18:45:19 +02:00
Machiavelli fb8399c413 Few changes to *_scripts handling in core.
- Use pointers of most abstract classes possible where applicable.
- Don´t use dynamic_cast when casting possibility is already explicitly checked per typeid.
- Where applicable use the ToCreature() and ToPlayer() functions for typecasting.
- Fix functioning of SCRIPT_COMMAND_CAST_SPELL
- Fix possible crash in SCRIPT_COMMAND_KILL
- Always include script id in error messages.
- Added a few TODO comments.

These changesets were merged in from MaNGOS:
- [9576] Implement SCRIPT_COMMAND_CREATE_ITEM by NoFantasy
- [9577] Implement SCRIPT_COMMAND_DESPAWN_SELF by NoFantasy
- [9869] Extend SCRIPT_COMMAND_QUEST_EXPLORED to allow player<->player as
source/target by NoFantasy

--HG--
branch : trunk
2010-06-02 18:43:11 +02:00
Rat d9728b2b80 fixed sota round two ships
--HG--
branch : trunk
2010-06-02 18:16:57 +02:00
Spp 60fd4a2f60 Dungeon Finder: Fix a crash when join queue had any restriction.
Fixes issue 2500

--HG--
branch : trunk
2010-06-02 17:03:48 +02:00
Rat ad753b3f67 SOTA update
-proper warning text (under attack, destroyed, capture..)
-proper icons on map for gate states
-fixed second round starting

--HG--
branch : trunk
2010-06-01 23:55:09 +02:00
Spp d53f91ff32 Dungeon finder: Fix typos
- Add missing credits from previous Dungeon Finder commit (6f13a4afc4)
* Thanks to Zor for packet structure
* Thanks to Taliesin for initial Queue design

--HG--
branch : trunk
2010-06-01 09:38:05 +02:00
Brian ed636d96d8 * Fix target count for Blazing Harpoon (spell 61588)
* Credits to click and Xanadu who had to show some love to Malcrom

--HG--
branch : trunk
2010-05-31 18:55:02 -06:00
Brian 76f4259091 * Fix Linux compile.
--HG--
branch : trunk
2010-05-31 18:10:29 -06:00
Machiavelli 97ea58fe0c Revert unintended change in 39d9d11c09 - special thanks to HG for being so cooperative.
(Essence of 39d9d11c09 is still intact)

--HG--
branch : trunk
2010-05-31 23:03:14 +02:00
Liberate b02bde6d2a *Fix: Strand of the Ancients.
- Massive Seaforium Charge (needs DB support for the spawns)
 - Demolishers are not attackable at the start
 - Demolishers spawn at the workshop if the graveyard is taken
   (The spawn locations aren't official yet)
 - Demolishers spawn immediately after being destroyed
 To make SotA perfect, it needs a lot of DB support.
 - Seaforium Bomb spawn locations
 - Set speed_run to 0 of the Cannons.

--HG--
branch : trunk
2010-05-31 23:01:47 +02:00
Machiavelli a623ccd5fa Fix possible client crash in SMSG_ATTACKERSTATEUPDATE caused by outdated packet structure.
--HG--
branch : trunk
2010-05-31 22:09:58 +02:00
Spp 08a20ef8a2 Random BG: never select a disabled bg
--HG--
branch : trunk
2010-05-31 20:53:43 +02:00
Spp 824b1303ce Dungeon Finder:
- Add Rolechecks
- Can Join and Leave queue

* No Find group implementation, it just adds u to the queue.
* Still missing some join queue restrictions.

--HG--
branch : trunk
2010-05-31 20:25:21 +02:00
Trazom62 248782448c Fix hidden CD for HandleDummyAuraProc for random proc spell (put the hidden CD on one of the random spell to avoid multiple proc of different random spell).
Take trigger_spell from dbc in case there is one and not yet handled by custom case.

--HG--
branch : trunk
2010-05-31 20:14:21 +02:00
Trazom62 427e8be656 Fix Spell::m_selfContainer not reset in destructor. This should fix crash in Unit::FindCurrentSpellBySpellId.
Fixes issue #2263.

--HG--
branch : trunk
2010-05-31 19:19:30 +02:00
Trazom62 15847b2f2f Fix exploit with swaping already looted items.
Patch by Vladimir from idea of Zhenya.
Fixes issue #702.

--HG--
branch : trunk
2010-05-31 19:10:26 +02:00
Shauren 042b503665 ITEM_FLAGS_EXTRA_NEED_ROLL_DISABLED should only affect Need before Greed loot method
--HG--
branch : trunk
2010-05-31 14:07:29 +02:00
Xanadu 7fbeef3d09 Cleaned up and unified various sort predicates and moved them to Trinity namespace, replaced priority queues with sorts and purged some unused code.
--HG--
branch : trunk
2010-05-30 04:23:27 +02:00
Shauren cf34b23692 Fixed Twisted Faith not increasing damage of Mind Flay while Shadow Word: Pain was present on target, thx maxdestroyer for pointing that EffectSpellClassMask doesn't match
Fixes issue #1085.

--HG--
branch : trunk
2010-05-29 21:00:30 +02:00
_manuel_ 78cb29a30d Implemented areaflag hacks for areas Sunreaver Pavilion and Silver Covenant Pavilion.
--HG--
branch : trunk
2010-05-29 14:13:56 -03:00
click 1758940ce2 Fix: use stored randombg resettime for calculating when to do the next daily reset of random battlegrounds
Thanks to HP for pointing this out.

--HG--
branch : trunk
2010-05-29 18:42:19 +02:00
Shauren a083bc5981 RequiredReputationFaction == 0 && RequiredReputationRank != 0 means its some leftover data, not a sign we should check standing with vendor's faction
This fixes players "randomly" being unable to purchase an item due to missing reputation

Fixes issue #2193.

--HG--
branch : trunk
2010-05-29 16:17:28 +02:00
Shauren 0d64afc166 Fixed quests 11505 and 11506 - Spirits of Auchindoun
Fixes issue #126.

--HG--
branch : trunk
2010-05-29 13:42:57 +02:00
Liberate 3b8be6d108 Fixes the cooldown of the heroic version of the Deathbringer's Will Trinket.
Thanks nightseas for testing and finding this bug.

--HG--
branch : trunk
2010-05-29 10:11:39 +02:00
Xanadu d104f19469 *Properly initialize members to prevent DB logging before the DB is started. Fixes a rarely seen startup crash.
*Code cleanup.

--HG--
branch : trunk
2010-05-29 03:16:39 +02:00
Anubisss de97bd4f00 Remove a duplicate check from map/vmap files existance of all races' startup areas. Dear God, my english rocks (:.
--HG--
branch : trunk
2010-05-29 00:16:06 +02:00
Spp f14ab71fad Fix SMSG_LOGOUT_RESPONSE
- Use correct structure format
- Send opcode when instant logout

--HG--
branch : trunk
2010-05-28 02:07:47 +02:00
Trazom62 7ac8e6571d Fix compile on linux for previous commit. Thanks click for testing.
--HG--
branch : trunk
2010-05-27 22:40:47 +02:00
Trazom62 452675e500 Fix Vigilance.
Implements Glyph of Vigilance.
Fixes issue #1134. Thanks Bodompelle for the idea, even thought the fix is rather different.

--HG--
branch : trunk
2010-05-27 21:11:38 +02:00
click ac2ac3dbcf Change auctionhousesearches with extended itemnames (of the hawk etc) to use the DBC-locale, not the DB-locale
Major thanks to D_Skywalk for figuring out the bug

--HG--
branch : trunk
2010-05-27 14:13:22 +02:00
click ca5f51d48f Don't parse "== START DUMP" or "== END DUMP" lines when attempting to load dumpfiles (another PEBKAC-check)
--HG--
branch : trunk
2010-05-27 04:41:02 +02:00
Liberate c3b480ce81 Fixes the Deathbringer's Will Trinket.
This needs DB support so you don't change into a pig instead of a vrykul/taunka.
Based on c.j.b's patch.
Fixes issue 1933
Fixes issue 1843

--HG--
branch : trunk
2010-05-26 22:47:47 +02:00
click 249a5f7722 Remove some guardAI gossip (handled DB-side), remove some NPC gossip (handled DB-side)
--HG--
branch : trunk
2010-05-26 20:03:40 +02:00
John Holiver ff7308f754 Re-re-fix for Life Tap (3.3.3).
I hope that this one is the last.
Each rank now use diferent spell power gains (0, 0.2, 0.5).

--HG--
branch : trunk
2010-05-26 14:54:56 -03:00
Liberate 3cd4626dac Fix a typo in my previous commit. thanks dr.tenma for pointing this out.
--HG--
branch : trunk
2010-05-26 16:18:45 +02:00
Liberate aa5100e7d9 *Fix: Don't apply an aura when it's duration is 0. (for example because of diminishing returns)
This should fix interrupts when casting fear, stun, etc, while the duration is 0.
Fix based on havenard's patch.
Fixes issue 1621
Fixes issue 2271

--HG--
branch : trunk
2010-05-26 15:38:31 +02:00
click 3718dfa94f Fix statistics for random battlegrounds (by footman) + add missing configoption for when to reset random BGs
--HG--
branch : trunk
2010-05-26 13:15:35 +02:00
click 28b9e104a8 Remove two lingering (unused) files from previous commit
(damn mercurial and it's inability to not detect removed files)

--HG--
branch : trunk
2010-05-26 11:59:30 +02:00
click 7a13839178 Add support for random battlegrounds - port by n0n4me, original code by Vladimir and Griffonheart (Big thanks to all of you!)
--HG--
branch : trunk
2010-05-26 11:34:37 +02:00
Shauren e4c03aa55a Fixed achievements rewarding titles to wrong faction (alliance title for horde char)
--HG--
branch : trunk
2010-05-26 11:03:45 +02:00
_manuel_ 4658b3be97 Modified SCRIPT_COMMAND_TELEPORT_TO now it can be used for Creatures. For players datalong2 must be 0 for creatures 1.
--HG--
branch : trunk
2010-05-25 22:11:36 -03:00
click bd13582bd2 Minot codestyle cleanup (tabs to spaces)
--HG--
branch : trunk
2010-05-26 02:03:45 +02:00
John Holiver dd1a750921 Re-Fix Life Tap Formula (3.3.3).
More blizzlike formula.
The formula used now IS NOT perfect(!), but it's a extremely good aproximation of the current Blizz calc.
This formula was based on curve fitting from data collected from retail.
Also, fix the usage of BaseSpellPower, now it also employ 'green' bonus.

Tnx to the reviewers.

--HG--
branch : trunk
2010-05-25 20:25:56 -03:00
click 2b9eef87e4 Slap auctioneers in the face telling them to search for items with partial names or suffixes - patch by MrSmite
Will require more testing, but base functionality is there. Fixes issue #1510. Closes issue #1534.
+ Skip some excess (unused) packetdata sent from client during AH-usage (click)

--HG--
branch : trunk
2010-05-25 16:15:22 +02:00
click aaf6b425fc Allow accounts to create characters in both horde and alliance factions by default (now blizzlike)
--HG--
branch : trunk
2010-05-25 10:50:11 +02:00
click b4e19528ef Make spellsteal respect dispel-resistances - patch by dr.tenma (thank you!)
This changes the way SPELL_AURA_MOD_DISPEL_RESIST works and fixes mages root diminishing returns
Closes issue #1045.

--HG--
branch : trunk
2010-05-25 10:36:33 +02:00
click 8f908f9df7 Add support for sending accountbound items between characters on the same account - Fix by Francesco
Closes issue #2332

--HG--
branch : trunk
2010-05-25 08:43:56 +02:00