josh/TCPlayerbotCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
10,846 Commits 1 Branch 0 Tags
d951407822ac009f75b73df840cea8977972aa91
Commit Graph
1526 Commits
Author SHA1 Message Date
leak 04e4561134 Prevent completing quests by packet manipulation 
--HG--
branch : trunk
 2010-12-18 15:29:11 +01:00
Machiavelli 57132e35b8 Core/Spells: Fix spells 59915 and 59906 / Discerning Eye of the Beast and Swift Hand of Justice (Heirloom trinkets) 
Fixes issue #2435
Fixes issue #2529

--HG--
branch : trunk
 2010-12-18 12:27:40 +01:00
Machiavelli 32d94ed52a Core/Units: Aura´s of type SPELL_AURA_MOD_RESISTANCE_EXCLUSIVE (143) should stack with eachother in the way that only the strongest aura of each magical school applies. 
Author: Iskander
Fixes issue #3897

--HG--
branch : trunk
 2010-12-17 20:31:46 +01:00
click 97f912fe93 Core/Pets: Use the safer pet level check-method in SynchronizeLevelWithOwner() too (forgotten in previous commit) 
--HG--
branch : trunk
 2010-12-17 20:27:36 +01:00
click 0785ad465b Core/Pets: Clean up logic/codedesign slightly for XP/levelup-handling, and also fix a possible overflow in the pet level-tests 
(Thanks to Vladimir for the discussion regarding the possible overflow!)

--HG--
branch : trunk
 2010-12-17 20:08:27 +01:00
Machiavelli e867481ccb Fix a typo in 52d8bc05c3 
--HG--
branch : trunk
 2010-12-17 19:27:09 +01:00
Shauren 3df2310417 Core/Auras: Fixed Festive Holiday Mount transformation (3.0.8 update) 
--HG--
branch : trunk
 2010-12-17 19:03:12 +01:00
Shauren 21f6248726 Core/Spells: Fixed diminishing returns for positive/event spells, patch by DrTenma 
--HG--
branch : trunk
 2010-12-17 18:21:37 +01:00
Shauren b11e5bbf81 Core/Achievements: Prevent ACHIEVEMENT_CRITERIA_TYPE_SPECIAL_PVP_KILL updates at login 
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_HONORABLE_KILL
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_HONORABLE_KILL_AT_AREA
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_HIGHEST_TEAM_RATING
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_REACH_TEAM_RATING
Core/Achievements: Implemented map id requirement for achievement criterias

Closes issue #4479.
Closes issue #4478.
Closes issue #4473.
Closes issue #4472.
Closes issue #4471.
Closes issue #4480.
Closes issue #2284.
Closes issue #4481.

--HG--
branch : trunk
 2010-12-17 18:12:46 +01:00
Machiavelli 1cdeb4d057 Core/Player: Change equipmentset saving to use prepared statements. 
Update issue #4550
Please try to re-reproduce

--HG--
branch : trunk
 2010-12-17 17:29:16 +01:00
Machiavelli 0a8c99e02c Core/Social: Fix SMSG_WHO. Packet should contain number of players matching given criteria + number of players displayed, instead of total number of players online + number of players displayed. 
Fixes issue #4886

--HG--
branch : trunk
 2010-12-17 16:36:01 +01:00
Spp fa6f2ee9d9 Core/Dungeon Finder: Fix typo, debug msg was supposed to be logged to debug (not error) 
--HG--
branch : trunk
 2010-12-17 13:45:41 +01:00
Shauren 82f45966fc Core/Unit: Renamed addUnitState/hasUnitState/clearUnitState to AddUnitState/HasUnitState/ClearUnitState 
Core/Vehicles: Allow the vehicle to always damage the passenger (removed unneded dbc hacks from scripts)

--HG--
branch : trunk
 2010-12-17 13:43:24 +01:00
Spp ee3fd3ebeb Core/Vehicles: Fix facing adjustment. Patch by beberlescaraber 
closes issue #1810
updates issue #4714

--HG--
branch : trunk
 2010-12-17 13:22:17 +01:00
Spp a47150abb3 Core: Fix non-PCH build 
--HG--
branch : trunk
 2010-12-17 08:54:15 +01:00
click 0c6750dd52 Core: Fix a memoryleak in LoadCreatureFormations() - thanks to ge0rg (again) 
--HG--
branch : trunk
 2010-12-17 05:05:17 +01:00
click a6df53bbe2 Core/Spells: Fix erraneous behaviour on hunter spell Lock and Load (disable charge-drop) - thanks to Dr. Tenma 
Closes issue 3307

--HG--
branch : trunk
 2010-12-17 04:52:17 +01:00
Machiavelli 5d887159c6 Core/Spells: Fix Power Word: Shield absorb amount after r5badab6d42. 
(casting TotalAuraMultiplier to int32 effectively meant setting amount to 0)

--HG--
branch : trunk
 2010-12-16 23:16:14 +01:00
Anubisss 942dadc6a9 Correctly fix my change (r10666 / 672c38da05). 
Kudos go to QAston.

--HG--
branch : trunk
 2010-12-16 19:23:58 +01:00
Anubisss 6d9029c12e Make some cleanup. 
My thank goes to Az@zel for the code analysis.

--HG--
branch : trunk
 2010-12-16 18:08:23 +01:00
Spp 4671500172 Core/Dungeon Finder: Move all LFG data from Player and Group classes to internal LFG data classes. 
--HG--
branch : trunk
 2010-12-16 10:53:21 +01:00
Spp 451a6f40d4 Core/Dungeon Finder: Use full guid of players instead of lowguid 
Note: This change is done in preparation of other changes that will come later.

--HG--
branch : trunk
 2010-12-16 04:20:22 +01:00
Machiavelli ad13cd89b5 Core/Items: Fix item duration saving (and loading at a later stage). 
--HG--
branch : trunk
 2010-12-15 15:00:52 +01:00
Spp 382fef1958 Core: Some warning fixes 
--HG--
branch : trunk
 2010-12-15 10:44:06 +01:00
azazel ddf06c086e Core/Social: properly remove deleted character from social list of online players (by Emtec) 
--HG--
branch : trunk
 2010-12-15 14:44:41 +06:00
azazel 0fdea34a8a Core/Items: fix error in saving item's enchantments introduced in rev 022f3858fc (thanks Shauren for spotting the problem) 
--HG--
branch : trunk
 2010-12-15 14:44:02 +06:00
azazel 23e3909221 Core/Arena: avoid arena match loss when leaving queue before actual invitation to match (by VladimirMangos) 
--HG--
branch : trunk
 2010-12-15 14:25:10 +06:00
azazel b39b8fdd0d DB Schema/Characters: removed columns auctionhouse.item_template, character_inventory.item_template, guild_bank_item.item_entry and mail_items.item_template and created item_instance.itemEntry column instead of them. 
As a side effect moved related queries to prepared statements.
As one more side effect fixed not shown and lost mail items in returned expired mail (patch by Quriq14).

--HG--
branch : trunk
 2010-12-15 14:08:12 +06:00
Shauren 58a9b15443 Core: Fixes some warnings 
Core/SmartAI: Fixed DamageTaken and DamageDealt hooks

--HG--
branch : trunk
extra : rebase_source : 062f1c68cd1d318d192b294a493db17a1943bee2
 2010-12-14 22:45:23 +01:00
Machiavelli 3b0297f912 Core/CharacterHandler: Fix ¨[ERROR] GetUInt32() on non-numeric field¨ on a certain query. 
Author: toshik.777
Closes issue #5068

--HG--
branch : trunk
 2010-12-14 19:14:54 +01:00
Shauren 314376e32c Scripts: Fixed uninitialized variables, unreferenced parameters and virtual overrides 
--HG--
branch : trunk
 2010-12-14 16:24:59 +01:00
Shauren f4581f67b8 Core: Fixed uninitialized variable warnings 
--HG--
branch : trunk
 2010-12-14 15:58:45 +01:00
Shauren 0c04b178db Scripts/Icecrown Citadel: Minor adjustments and compile warning fixes 
--HG--
branch : trunk
 2010-12-14 15:46:54 +01:00
Liberate 6be8446053 Core/Gameobjects: Fix fishing and looting specific chests which were bugged because of revision 044e466d75. 
Fixes issue #5116.

--HG--
branch : trunk
 2010-12-14 15:02:42 +01:00
click 48b234022f Core: Change HandleEjectPasenger to HandleEjectPassenger (English thank you) 
--HG--
branch : trunk
 2010-12-14 14:09:14 +01:00
Liberate 09f4eb9e1c Core/Gameobjects: Make a chest not lootable when it still has a respawn time, to avoid cheating using third-party software. 
--HG--
branch : trunk
 2010-12-14 03:58:59 +01:00
click 2d8e73fab5 Core: Fix up opcode-mess from previous commit, and move CMSG_DECLINE_CHANNEL_INVITE handling to its correct opcode (0x0410) 
(Please report back any findings of erranous behaviour to the tracker, or into this commit)

--HG--
branch : trunk
 2010-12-14 02:23:28 +01:00
click 2642894342 Core: Add new system for parallelizing client packet processing. Handle WorldSession updates in Map::Update() where we are safe to proceed. Patch by Ambal. 
(And clean up tabs and whitespace while rummaging around in there)
Closes issue 5084.

--HG--
branch : trunk
 2010-12-13 22:37:56 +01:00
Spp 89a33bbf61 Core/Dungeon Finder: Fix a crash in Join when there are no dungeons available for that group (And probably other random crashes that appear when having DF enabled) 
Core/Dungeon Finder: Tab2spaces + remove trailing spaces in LFG* files.

Notes to self:
- assign NULL to a pointer parameter will not change the pointer value outside the scope of the function
- deleting a const_iterator can lead to mem corruption

--HG--
branch : trunk
 2010-12-13 21:31:55 +01:00
Spp 865f35a637 Core/Dungeon Finder: Minor optimization in handler code 
Note: LfgDungeonSet and LfgLockStatusMap were being used without using the existing typedef (to avoid including LFGMgr.h).
Now those functions use a struct as param that is forward declared so still LFGMgr.h is not needed and redefinition of LfgDungeonSet/LfgLockStatusMap is removed.

--HG--
branch : trunk
 2010-12-13 21:28:36 +01:00
Spp 9815847511 Core/Dungeon Finder: Return a copy of cached dungeons set (to avoid being cleared later in code) 
--HG--
branch : trunk
 2010-12-13 21:28:33 +01:00
click 620cde80cd Core: Fix non-PCH build 
--HG--
branch : trunk
 2010-12-13 17:44:20 +01:00
Machiavelli d75eaf8e83 Core/Guild: More signed/unsigned comparison fixes. Should fix guild log loading. 
--HG--
branch : trunk
 2010-12-13 16:58:59 +01:00
Machiavelli 1a4fe4baca Core/Guilds: Fix logic in bank withdrawal method (unsigned comparison with signed value). Should fix certain guild bank related bugs. 
--HG--
branch : trunk
 2010-12-13 16:42:09 +01:00
Machiavelli 976225a9dd Core/DBLayer: Implement global ExecuteOrAppend methods to DatabaseWorkerPool for executing queries in a diverse context (transaction or non transaction) - instead of local to Guild.cpp 
--HG--
branch : trunk
 2010-12-13 16:27:14 +01:00
Shocker 4b0ffeb0bd Core/ChatHandler: Cleanup in HandleMessagechatOpcode. Now commands are parsed and security checks are made in all channels 
--HG--
branch : trunk
 2010-12-11 17:47:43 +02:00
azazel d2d62eab50 Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings). 
NOTE: Initially I just wanted to fix some warnings, but noticed that there is no common method for percentage calculation and various formulas are used many time in the code making it difficult to read and understand what the code actually does. So, I introduced several template methods for calculating percent values and adding those values to the original base. I replaced all the raw calculations throughout the code where found, but I could have missed something or could have made a mistake. So, please report any strange behaviour after this commit.
If you ask me why I did it: for the sake of consistency and exact understanding what code means. If you see CalculatePct method, you clearly understand, that it find the value of x percent of y. And you can easily express, for example, spell behviour "reduces smth by x%" by the means of a method instead of recalling school maths.

--HG--
branch : trunk
 2010-12-11 20:37:38 +06:00
click 81db111ffd Core/Spells: Fix mage talent Frost Warding (and a little cleanup on CalcAbsorbResist) - patch by DrTenma 
Fixes issue 2715.
Closes issue 3770.

--HG--
branch : trunk
 2010-12-11 12:00:57 +01:00
click 0e33e73d39 Core/ChatHandler: Allow GM/server-commands to be executed through whisper-channels - patch by Ramus 
Closes issue 5006.

--HG--
branch : trunk
 2010-12-11 03:25:31 +01:00
Spp a791df6415 Core/Dungeon Finder: Fix crash in Join 
(trying to delete a const iterator)

Closes issue 5083

--HG--
branch : trunk
 2010-12-10 14:58:45 +01:00