Commit Graph
21296 Commits
Author SHA1 Message Date
joschiwald c4f64c6d9c Scripts/BWL: cleanup instancescript
(cherry picked from commit 05429b35937b02ef1f191a39d2654a68ab5c4241)

# Conflicts:
#	src/server/scripts/EasternKingdoms/BlackrockMountain/BlackwingLair/instance_blackwing_lair.cpp
2015-11-06 11:48:53 +01:00
MitchesD 81ce5acb34 Core/Scripts: fix build after recent cherry picks 2015-11-06 11:28:35 +01:00
sirikfoll d4b3b1d1d2 DB/CORE Minor change in quest Kick, What Kick? and some codestyle
Remove the line that despawns the 'Apple' npc, this despawn is non-blizzlike and breaks the quest.
Thx Killyana for sql and valuable information

Closes #15480

(cherry picked from commit 22f1d269865a5980dabadab1f469e60a701e9de1)
2015-11-06 11:11:16 +01:00
treeston 6d14c4871f Scripts/Naxxramas: Anub'rekhan encounter cleanup.
- Cleaned up events behavior to use phases instead of weird checks for auras.
- Cleaned up Crypt Guard despawn behavior, they should no longer despawn instantly upon death.
- Moved initial greeting from MoveInLineOfSight hack to proper areatrigger script.
- Fixed Crypt Guard respawn behaviour to prevent pulling them before Anub'rekhan has fully reset.
- Fixed Crypt Guard aggro behaviour to call for help on aggro. This prevents pulling the initial pair of Crypt Guards without engaging the boss.
- Added missing boss emotes.
- Code style cleanup.

(cherry picked from commit 91de0322bba3ef071338ce5a71f512369486eb1f)

# Conflicts:
#	src/server/scripts/Northrend/Naxxramas/boss_anubrekhan.cpp
2015-11-06 11:07:31 +01:00
treeston b6ac8c577c Scripts/Naxxramas: Faerlina cleanup:
- Move greeting to areatrigger instead of MoveInLineOfSight hack
- Clean up add spawn handling to prevent various glitching with combinations of evade state and add aggro
- Ensure all adds are always pulled alongside the boss and vice versa
- Add missing texts.
- Fix a bug in the core that prevents castable-while-dead spells (such as Widow's Embrace) from appearing on possess bars.

(cherry picked from commit 577fcf356e9cd54fb0490069d7aa26894e9b5db3)

# Conflicts:
#	src/server/scripts/Northrend/Naxxramas/boss_faerlina.cpp
2015-11-06 10:59:34 +01:00
jackpoz 5f5ac9630c Scripts/Naxxramax: Fix clang warning
(cherry picked from commit da0671f4fee1ee00a45dc15e4ddd94d3f9c82a18)
2015-11-06 10:56:27 +01:00
Rushor 9483bd9180 Scripts/IcecrownCitadel: Quest 'Blood Quickening' - Add Killcredit in 25ManRaid
closes #15733

(cherry picked from commit c5641a9a58e385015dbbcefd9dd747ee52f21f97)
2015-11-06 10:35:29 +01:00
treeston a37e6e20c8 Scripts/Naxxramas: Loatheb follow-up:
- Fix Deathbloom (for real this time)

(cherry picked from commit 17fdb1e091796933a2028778e4ea5f3b53186b4f)
2015-11-06 09:54:40 +01:00
Shauren 49543a5174 Core/Accounts: Unified game account ban checks with 3.3.5 branch 2015-11-05 21:24:42 +01:00
Naios 30c421bf57 Core/ScriptMgr: Improve commit 155a289f05 2015-11-04 21:46:26 +01:00
Naios 155a289f05 Core/ScriptMgr: Fix "conditional expression is constant" warning.
* introduced in commit 12d1993994
2015-11-04 21:16:39 +01:00
Naios b7b49fe35f Core/Globals: Use std::string rather than char* to pass script names around. 2015-11-04 20:52:13 +01:00
Naios 12d1993994 Core/ScriptMgr: Replace IsDatabaseBound() methods through traits. 2015-11-04 20:51:56 +01:00
Shauren 5695969725 Core/Commands: Added assertion checking if command name is not null 2015-11-03 20:02:47 +01:00
Shauren c463c84325 Core/Auth: Added missing lock country check to AuthSession handler 2015-11-02 20:23:39 +01:00
Naios 6fa4588191 Core/AI: Cleanup in CreatureAISelector 2015-11-01 14:33:37 +01:00
Naios 0b6f784591 Core/AI: Convert the hardcoded variadic RAND functions into one C++11 variadic template version. 2015-11-01 14:33:31 +01:00
joschiwald 92b08fc74b Scripts/VioletHold: rewrote the whole instance
thanks @MitchesD for help

(cherry picked from commit df21162fe44d2ff29c201a9004586f560789c38b)
(cherry picked from commit 3a4f54197c05ce4209c7e659acfd382896607265)
(cherry picked from commit f50df728201849ee7185d33c5a061c91e781c8de)
(cherry picked from commit 95bae7143f0f4bb7d5975f8a61daa3c533f48225)
(cherry picked from commit 5406f82044e7bd6ceb024a67f33c1674400cdc1f)
2015-11-01 13:09:30 +01:00
jackpoz 7b684e8813 Script/Commands: Add new "debug loadcells" command
Closes #15292

(cherry picked from commit 5e1722c2f497ac7df8fed5ebe01e352965884584)
2015-11-01 12:30:45 +01:00
jackpoz ee5eb215e9 Scripts/Commands: Change few commands to target current Player by default
(cherry picked from commit d1efb90ae88bfb30ad13c48eef5d6c19ce5739e2)
2015-11-01 12:00:48 +01:00
jackpoz e0ccbede07 Core/NetworkIO: Adjust more packet throttling values
Adjust more packet throttling values by increasing some limits, this might fix some random kicks.
Close #14659

(cherry picked from commit 5bd7c295c0b0f2cb78345ed02dd37531a67348f5)
2015-11-01 10:52:17 +01:00
Vincent-Michael 23bb45bfe9 Core/Misc: Fix issues reported by static analysis
Coverity defect IDs: 1296295, 1296294

(cherry picked from commit 5745c880fdbaa69de619263884c8f690c2bd044b)
2015-11-01 10:44:39 +01:00
Shauren 5da3079471 Build fix 2015-11-01 00:43:56 +01:00
Kittnz 2cd545849c Scripts/Uldaman: Fix build & fix some movement suggested by josch
(cherry picked from commit cf286ea9cdba3e9019eb6bc4816034070f6480be)
2015-11-01 00:31:18 +01:00
Kittnz c094e49e74 Scripts/Uldaman: Instance update
- Fixup Boss Ironaya
- Add the freeze animation for minions and archaedas
- Fix attack target for minions who wake up

(cherry picked from commit 9cb4cb52d842d3611e3053c9bd46e1925283d14e)
2015-11-01 00:31:00 +01:00
w1sht0l1v3 ec567f1c41 Core/LFG: Move code to a better place.
(the case where the last player left inside a dungeon would not be removed from lfg&group when he ports outside)

(cherry picked from commit 837a0a75246b177858825caf1861dd61a6b87868)
2015-11-01 00:30:42 +01:00
w1sht0l1v3 43cf01d510 Core/LFG: Fix crash in ".lfg group <playername>" in case of offline player and
extend the output to display the offline members of the group also.Atm if members are offline no info is displayed.

Note: all the new code is mostly copy/paste from ".group list <playername>" command.
(cherry picked from commit 4e0dec7fd26452e60055eb2fa9461d39ec49d45b)
2015-11-01 00:29:31 +01:00
Kittnz e4d0652e7f Core/Script: Make 2 remaining bridge parts active in Serpent Shrine
(cherry picked from commit 6e1113a81034a4a07b588439f6c5f737e5fa426c)
2015-10-31 18:12:59 +01:00
Shauren d8391f23b1 Build fix after cherry-picks 2015-10-31 00:05:09 +01:00
Shauren 7f09392ccc Warning fix 2015-10-30 20:18:09 +01:00
Shauren d72293bdf7 Core/Corpses: Fixed a crash happening when a corpse is added to a grid that was not yet fully loaded
Closes #15684

(cherry picked from commit 8c9ea7782a4eb251933f43d57bf8271c11a0e6a6)
2015-10-30 18:05:35 +01:00
Shauren b96bb15042 Core/Corpses: Prevent deleting corpses by ObjectGridUnloader, fixes accessing freed memory in multiple places due to the corpse still being registered in Map containers
Closes #15775
Closes #15781

(cherry picked from commit a94bdd00a9f31dcd9e4134987531937ca57975d6)
2015-10-30 18:05:26 +01:00
Shauren 60370d0c03 Core/Corpses: Fixed map crash happening during map unload when there are corpses inside
(cherry picked from commit 1d17475791cae66beafda1e2c3198a66d355086f)
2015-10-30 18:04:58 +01:00
MitchesD 26d362febc Revert "DB/NPC: Stable Masters" Please in the future mark 335 only commits with *_335 in the end of SQL file, if it has any.
This reverts commit 18f511431a.
2015-10-30 14:46:14 +01:00
Killyana 18f511431a DB/NPC: Stable Masters
Closes #15505

(cherry picked from commit a513abc02c65a45833ca4006ff346ab690232b0c)

# Conflicts:
#	src/server/scripts/World/npcs_special.cpp
2015-10-30 14:34:46 +01:00
joschiwald b459b10b0f Core/Scripts: fixed startup errors
Closes #14730

(cherry picked from commit 497aa4425bd8a84acb7f5ebcf03692ef96a64c06)

# Conflicts:
#	src/server/scripts/Northrend/Ulduar/Ulduar/boss_flame_leviathan.cpp
2015-10-30 14:01:26 +01:00
treeston 7886fafbdc Heigan cleanup:
- NearTeleportTo hack -> proper spell with DB coordinates
- Add boss emotes
- Some code streamlining using event phases and IN_MILLISECONDS instead of large constants
- Improvement to eruption hitbox and delimiters to match retail layout more closely
- Spell timers adjusted from sniffs

(cherry picked from commit 3e2014a958c2295c175b359dbeed48f36befce98)
2015-10-30 12:24:26 +01:00
treeston f3b5bdc0b3 Scripts/Naxxramas: Bugfixes to the Noth encounter.
- Added missing raid boss emotes
- Fixed an issue where Noth would stand idly after blinking if his current target stood still
- Fixed some reset edge cases
- Prevent Noth from dying during Balcony phase
- Fix targeting of 25-man Curse of the Plaguebringer (now has 8 targets, down from 10)
- Fix balcony/ground phase durations to be blizzlike
- Fix an issue where summoned mobs would sometimes not be aggroed automatically
- Get rid of ugly millisecond values in favor of seconds times constant
- Moved the chance to yell on kill to the database
- Prevent AoE abilities from hitting Noth during the balcony phase
- General cleanup of events handling
- Generally make @Nayd happy

(cherry picked from commit 3fc1bb1abf0d4ae7b37507c62a3b57175477ce2f)

# Conflicts:
#	src/server/scripts/Northrend/Naxxramas/boss_noth.cpp
2015-10-30 11:46:37 +01:00
treeston dba753b0ef Scripts/Naxxramas: Adjustments to the Loatheb encounter
- Adjusted doom cast timings as per boss mod timers.
- Add Deathbloom's final tick using spellscript
- Move Spores' Fungal Creep cast handling to Loatheb's cpp instead of handling it in SmartAI
- Fungal Creep should also be cast if the spore expires (important for Spore Loser achievement)
- Remove Fungal Creep from players on reset to avoid cheesy strats

(cherry picked from commit ea1c783b84d4fa489436531667f3c121631b25d4)
2015-10-30 11:42:19 +01:00
tkrokli 3d9b2d8de2 Core/Scripts: The Endless Hunger & Death's Challenge, creature text
This PR solves the following say text issues:
In quest ID 12733, Death's Challenge, the creature script npc_death_knight_initiate is supposed to target the player and refer to the player character's name in the following 2 lines from `creature_text`.`entry` 28406:

- "You don't stand a chance, $n." (`BroadcastTextId` 29267)
- "Remember this day, $n, for it is the day that you will be thoroughly owned." (`BroadcastTextId` 29270)

In quest ID 12848, The Endless Hunger, the creature script npc_unworthy_initiate is supposed to target the player and refer to the player character's race in the following 2 lines from `creature_text`.`entry` 29519, 29520, 29565, 29566 and 29567:

- "You are hopelessly outmatched, $r."  (`BroadcastTextId` 30212)
- "Sate your hunger on cold steel, $r!" (`BroadcastTextId` 30214)

The untargeted variables $r and $n appear in the say lines because the existing script assigns the text to the player character instead of the creatures. This does not produce any race or name information in /say or chat.

This Pull Request closes issue #14700 and replaces PR  #15678.

(cherry picked from commit 89107c3a8e61447fb6d34fd77fd454074ae5e064)
2015-10-30 11:33:40 +01:00
Zedron bd04a46011 Core/Spells: Fixed a mistake in SpellInfo::CalcPowerCost
Fixed a mistake which caused some SPELLMOD_COST modifiers to give (lots) of power instead of taking power in Spell::TakePower
2015-10-28 16:57:52 -05:00
Shauren bd16520ecc Core/Corpses: Fixed leaking bones
Ref #15765
2015-10-28 21:43:44 +01:00
MitchesD 9617da7249 Core/Player: remove unused method prototypes 2015-10-28 19:18:16 +01:00
Shauren 3fd15ed22a Core/Misc: Removed manually defined ObjectGuid copy/move constructors. This will cause the compiler to automatically generate trivial constructors allowing them to be treated as simple integers 2015-10-27 22:55:57 +01:00
Shauren f7dba226fe Core/PacketIO: Started work on updating last bunch of packets still using old ObjectGuid::operator[] to remove it entirely 2015-10-26 17:06:30 +01:00
Shauren db0c48c17f Core/Conditions: Optimizations part 3 changed ConditionStore to a simple array 2015-10-25 13:35:45 +01:00
Shauren b09e63e9de Core/Conditions: Optimizations part 3 removed copying condition containers all over the place 2015-10-25 13:20:28 +01:00
Shauren 2cce998e90 Core/Conditions: Add const to methods not modifying ConditionMgr 2015-10-25 12:22:53 +01:00
Shauren e5c1e7d71c Core/Conditions: Optimizations part 2 removed unneeded code 2015-10-25 12:22:04 +01:00
Shauren 9fa938f3e0 Core/Conditions: Optimizations part 1 - use containers more suited for their role 2015-10-25 12:00:05 +01:00