josh/TCPlayerbotCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
11,049 Commits 1 Branch 0 Tags
c59ea4726e078a844f465407e5d893a1afee06fb
Commit Graph
1646 Commits
Author SHA1 Message Date
leak c59ea4726e SQL: Characters db storage type cleanup No. 6 2011-01-20 01:02:24 +01:00
leak a486eb0c2f SQL: Characters db storage type cleanup No. 5 2011-01-20 00:08:45 +01:00
leak a7df9ddff1 SQL: Characters db storage type cleanup No. 4 2011-01-19 22:46:21 +01:00
leak 471b6f138d SQL: Characters db storage type cleanup No. 3 - Note: 
There is a chance that you will be getting importing errors / data truncation warnings because of ancient invalid pet names.
SELECT * FROM character_pet WHERE CHAR_LENGTH(`name`) > 21;
 2011-01-19 18:51:00 +01:00
leak c306acf298 SQL: Characters db storage type cleanup No. 2 2011-01-19 14:04:33 +01:00
leak b8210f4396 SQL: Characters db storage type cleanup #1 - Note: 
- MySQL numeric types can NOT be altered in value range or or storage size at all, so things like INT(32) are entirely pointless. As TC currently doesn't use the display width of numeric types, use the default width to avoid confusion. (see MySQL numeric types docs)

- Timestamps can be stored as INT(10) UNSIGNED. As the max value of this type is 4294967295 which translates into year 2106 using it as timestamp we are NOT affected by the year 2038 bug. If the timestamp needs to be negative in some cases, i.e. for displaying infinity using -1, use BIGINT(20) instead.

- Do NOT set ROW_FORMAT for InnoDB tables unless you specifically want COMPRESSED tables (which we don't for performance reasons). MySQL will chose the appropriate ROW_FORMAT by itself depending on the innodb_file_format setting of the server. (FIXED is only available for MyISAM)

- Even though VARCHAR does require less storage space than CHAR for values with variable length, the length still needs to be chosen wisely as this doesn't apply to memory consumption.
 2011-01-19 02:53:44 +01:00
leak 40af92dd66 Core/Spells: Stop exploit that allowed looting despawned gameobjects by packet manipulation. 2011-01-18 20:02:28 +01:00
Spp e05ab4b25a Core/Dungeon Finder: Fix exploit that allowed players to get random reward after finish a dungeon they did not queue for. Note: lfg_dungeon_encounters MUST contain the correct dungeonId, no the random ones. 2011-01-17 12:27:44 -03:00
Shauren b28881f648 Core/Spells: Fixed Ignite talent getting removed by Ice Block 
Closes #138
 2011-01-16 19:26:01 +01:00
Machiavelli deed0d0781 Core/General: Fix some comment style. //* to // *. Fixes certain code display errors on nano. Thanks to Aokromes for pointing out. 2011-01-16 12:23:17 +01:00
Machiavelli 09f2a48227 Core/Spells: Add unittarget check for spell 54798 2011-01-16 00:50:57 +01:00
Machiavelli 52cd2cbd7e Core/Maps: Unload transports in MapManager::UnloadAll instead of singleton destructor. 
Core/Transports: Properly delink units from transports on transport desutruction. - Thanks to Shauren for help.
Core/ObjectAccessor: Unload corpse 'storage' in added UnloadAll method called in WorldRunnable postservice hook.
Core/Master: Change some postservice queries to syncrhonous (direct) execution to ensure execution on shutdown
Core/Master: Remove redundant calls to ACE::init and ACE::fini

These changes were made to fix crash/freeze issues on shutdown.
 2011-01-16 00:08:52 +01:00
Machiavelli 38816cb1df Core/Spells: Implement SPELL_ATTR6_IGNORE_CROWD_CONTROL_TARGETS (0x00000100). Spells with this attribute flag (Avenger's Shield, Hammer of Righteousness, Shield of Righteousness, Felguard Cleave, Fel Iron Bomb) will ignore secondary targets that are under the effect of crowd control aura's. 
Thanks to Shauren for advices.
 2011-01-15 19:40:06 +01:00
Shauren 9584f58130 Core/Battleground: Combine bg score type enum values with the same name 
Signed-off-by: Shauren <[email protected]>
 2011-01-14 23:02:15 +01:00
Lightguard 4aae3cd45e Add missing opcodes to OpcodeHandlerTable. 
Signed-off-by: Anubisss <[email protected]>
 2011-01-14 22:40:41 +01:00
VladimirMangos 8c48704b23 Core/Loot: Fixed looting of individual, owner only items (item loot/skinning) 
Signed-off-by: Shauren <[email protected]>
 2011-01-14 21:24:11 +01:00
JohnHoliver db72c4f561 Core - Modifies a few security checks to take realm id into consideration. It will enable add friends which have moderators (or more) status in other realms and cease undue AH activity logging from those same accounts. 
Signed-off-by: click <[email protected]>
 2011-01-14 21:05:02 +01:00
Shauren 458c7c642f Core/Spells: Fixed Glyph of Pain Suppression 
Signed-off-by: Shauren <[email protected]>
 2011-01-14 20:24:39 +01:00
Manuel 3ab85db411 Core/Player: Pets are unsummoned after spec switch. Fixes #180 2011-01-14 13:38:56 -03:00
Machiavelli d399daab59 Core/Quests: Resolve ambiguity between QUEST_STATUS_COMPLETED and rewarded state by implementing QUEST_STATUS_REWARDED. The latter is not used in the database explicitly, only in the core. This is to prevent overhead by iterating over the rewarded quests storage multiple times. 
All relevant upper level code has been updated accordingly to the best of my ability.
 2011-01-13 23:06:59 +01:00
Machiavelli 57ee357c02 Core/Maps: Fix a possible crash in ObjectGridStoper:Visit 
Dump found here: http://pastebin.com/2GZ3t5v4
 2011-01-13 21:33:56 +01:00
Shauren 8d59953f93 Scripts/Icecrown Citadel 
* Call EnterEvadeMode before teleporting players to entrance - prevents players being stuck in combat
* Fixed Gaseous Blight stacking damage
* Properly initialize phase for Professor Putricide when entering combat
* Fixed Blood Nova and Boiling Blood abilities of Deathbringer Saurfang
 2011-01-12 22:50:51 +01:00
Machiavelli 52499b03ea Core/Guilds: Don't allow more than 25 and 100 log events to be sent to the client for bank eventlog and regular eventlog respectively. Higher values will result in client crashes. 2011-01-12 19:38:47 +01:00
Anubisss 806794d4ce Fix a crash in Spell::CheckCast(). 
This crash happens when effect is SPELL_EFFECT_TALENT_SPEC_SELECT and the caster is not a player.
You should always check object's type (or sure that object is 101% a player) before you use ToPlayer() casting function.

Signed-off-by: Anubisss <[email protected]>
 2011-01-12 02:06:06 +01:00
Spp bd2728eb74 Core: Fix some warnings 2011-01-11 11:18:00 +01:00
Shocker f03040b5b3 Core/Spells: Glyph of Polymorph should remove leech auras too, fixes #171 2011-01-11 00:57:20 +02:00
Taser 1a5554ccb5 Core/Battlegrounds: Fix Fel Reaver Ruins capturepoint in Eye of the Storm 
Signed-off-by: Machiavelli <[email protected]>
 2011-01-10 22:31:57 +01:00
Shauren 870add0a3d Core/Spells: Fixed Spirit Walk ability of shaman's Feral Spirit summons 
Closes #115

Signed-off-by: Shauren <[email protected]>
 2011-01-10 22:01:19 +01:00
Machiavelli fa8e5047a6 Core/Guilds: Fix a possible client crash in MSG_GUILD_BANK_LOG_QUERY 2011-01-10 20:57:58 +01:00
Manuel 014714fb17 Core: Killing magic numbers. 2011-01-09 20:44:33 -03:00
Machiavelli 01d4080b4d Core/Units: Send proper orientation in SMSG_MONSTER_MOVE_TRANSPORT 
Also get rid of the 100 constant in moveticks segment and use getMSTime() for consistency sake
 2011-01-09 16:22:04 +01:00
Shauren 1aa294d3e9 Core/Players: Fixed typo in updating soulbound trade times (check every second, not every 1000 seconds) 2011-01-09 15:14:44 +01:00
Derex 45459bed23 Core/Netcode: Fix file descriptor leak under linux platforms with ACE dev poll reactor. 
close #15

Signed-off-by: Machiavelli <[email protected]>
 2011-01-09 13:53:25 +01:00
Manuel 5cf76896eb Core/Battleground: Implemented blizzlike script for Isle of Conquest, written by gyullo and me, based on Socolin's and Josh's patch -BIG THANKS TO THEM- 
Anyway the map is not yet playable, there are issues not related with the script.

I also want to thanks to QAston, linencloth, Shauren and Machiavelli to be so patient with my questions.
 2011-01-09 00:00:08 -03:00
Machiavelli 58f795d171 Core/Vehicles: Logic fix for AddPassenger seat validity check, thanks to Tassader 2011-01-08 21:13:18 +01:00
McBitter 63333dc6ff Core/Spells: Fixed targeting for spell 49305 (missing unit target) 
Signed-off-by: Shauren <[email protected]>
 2011-01-08 17:40:10 +01:00
Shauren 39247d912b Core/Quests: Fixed quest chain issues introduced by daily quest fix 
Closes #127

Signed-off-by: Shauren <[email protected]>
 2011-01-08 13:57:59 +01:00
Shauren 051cceb7ac Core/Quests: Fix daily quests not showing up in list of available quests after having completed them once before. (Bug usually used to surface when in ExclusiveGroup) 
Signed-off-by: Machiavelli <[email protected]>
 2011-01-08 00:27:50 +01:00
Machiavelli dc3d6a2f23 Remove redundant code from 1487ebedaa 2011-01-07 19:13:19 +01:00
Christyan bc048ad216 Fix a typo in LFG. 
Use the proper DungeonID for SMSG_LFG_PROPOSAL_UPDATE if player selected multiple dungeons.

Signed-off-by: Anubisss <[email protected]>
 2011-01-07 01:30:39 +01:00
Machiavelli efe0ed3194 Core/Entities: Fix a silly typo in Object::AddExtraMovementFlag 2011-01-06 22:54:33 +01:00
Machiavelli c65e3822a2 Fix build from 06314c9387 
closes #99
 2011-01-06 22:45:07 +01:00
Sarjuuk 06314c9387 Core/Spells: Implemented Pygmy oil use effect 
Signed-off-by: Machiavelli <[email protected]>
 2011-01-06 21:40:32 +01:00
Sarjuuk 8859aa689c Core/Spells: Implemented Improved Faerie Fire crit chance increase effect 
Signed-off-by: Machiavelli <[email protected]>
 2011-01-06 21:37:16 +01:00
sarjuuk dfc848b88e Core/Spells: Periodic Dummy for spell 54798. Fixes quest 12851 
Signed-off-by: Machiavelli <[email protected]>
 2011-01-06 20:25:51 +01:00
Ottowayne 7aa85728fc Core/Spells: Dummy for spell 51961; support for Quest 12532 & 12702 
Signed-off-by: Machiavelli <[email protected]>
 2011-01-06 20:22:39 +01:00
Ottowayne 1487ebedaa Core/Spells: Dummy for spell 47703 (Unholy Union) for quest 12126 
Signed-off-by: Machiavelli <[email protected]>
 2011-01-06 20:14:13 +01:00
sarjuuk 0cf89f635f Core/Spells: Starfall skips targets in stealth, invisibility or not in LoS 
Signed-off-by: Machiavelli <[email protected]>

Also minor codestyle fixes from previous commits
 2011-01-06 19:57:36 +01:00
sarjuuk 20b49bccb0 Core/Spells: Set energy in cat form to zero on shapeshift before calculating energy gain from furor talent. 
Signed-off-by: Machiavelli <[email protected]>
 2011-01-06 19:43:36 +01:00
Ottowayne b0c559e704 Core/Spells: Fix Spell 54577 - Support for Quest 12828 
Signed-off-by: Machiavelli <[email protected]>
 2011-01-06 19:33:22 +01:00