Quest 12288: Overwhelmed!
- Upon casting the healing quest spell, Wounded Skirmisher (npc_wounded_skirmisher)
shows $r and $c in their reply talk text because of the missing target argument,
hence not targeting the player on the quest (or the specific caster, in this case).
Text used by the NPC Wounded Skirmisher:
0 Ahh.... better.
1 Whoa - I nearly died there. Thank you, $r!
2 Thank you, $c.
Solution: add the missing target name, caster, to the Talk() script line.
(cherry picked from commit 95398fadf958d40ba6755a6c2f7b374f0a36b7c7)
I'm referencing line 97 from ChaseMovementGenerator.
That commit introduced a modification in this use case:
- Chasing target is not my current victim, I should stop moving till it is my victim again
Changed To:
- Chasing target is not my current vicitm, I should stop chasing
My correction:
- I dont care about the relation of my current victim and my chasing target, I'm commanded to chase, something will tell me to stop chasing
--> Most likely: evade, new attackstart, etc.
the rest are just minor changes
(cherry picked from commit 9080e7863c28df7dc1c2af321964776e7b59e41a)
* Add duration override argument to StartCooldown (for cooldowns sent to client)
* Research new SMSG_SPELL_COOLDOWN flags
* Send interrupt school lockouts with newly defined SPELL_COOLDOWN_FLAG_LOSS_OF_CONTROL_UI
* Fixed packet structure of SMSG_MODIFY_COOLDOWN
* std::chorno-ification
Fix issues reported by Address Sanitizer about LoadMinionData() calls on arrays that don't end with a {0, 0} pair.
(cherry picked from commit 08dcee0cf9a56944027d3f65b7fd5c4a4959761c)
Closes#22754#21887#17882
Ty sirikfoll for all help
Bonus fixes: Abomination letting worms when fight end, visual missing, archmages stop respawn if corpse despawn
(cherry picked from commit dd81978f432f9c1ecb72ebcadcb5a50042e005ad)
* Scripts/Commands: Fix crash caused by .set npc model
Fix crash caused by .set npc model with invalid model id
(cherry picked from commit 20ea24bf5ccf165ce19139d1f7ec7c650719eb68)
Fix crash added in PR #22806 happening in quest "Ruthless Cunning and Returning the Favor"
(cherry picked from commit cb136387218bc7a5473cf1ca6707ec1ba3b8c1c0)
* Ruthless Cunning and Returning the Favor
* no more magic numbers
* now with scripted ai and condition
* travis
* more travis
* jackpoz
* now with no banner spellscripts
* typo
* Rename 9999_99_99_99_world.sql to 2018_12_03_00_word.sql
(cherry picked from commit 9d93504f34b112eb2403381e61deff1559771cd3)
* Core/GameEvent: weekend xp rate
by kline
* Update to recent code
* compile fix try
things of copy and paste 4 years old code xd
* more code update
* forgot to change this
* Update worldserver.conf.dist
* Added function to calculate weekend event xp rates
By greenbagels
* Cleaning using scripts
* Implement daymask and rename variables etc.
* Rename script file weekend -> boosted
* Update src/server/game/World/World.cpp
Co-Authored-By: Aokromes <[email protected]>
* Fix xp multiplier not applying to quest rewards
* Disable xp boost script when no boosted days selected
(cherry picked from commit 538c5b86873a4c57e1eb37f0c81c2a7b4552ebc1)
Closes#21264
ScheduleEvents need happens after remove ImmuneToPc, or it will cause evade.
(cherry picked from commit f1a1acdc89a6521fddca98cc8ef8d6e7ed0b9495)
* Add rotation to .gob info
- Add rotation (yaw, pitch, roll) to .gob info command
- Replace LANG_SPAWNINFO_DISTANCEFROMPLAYER with LANG_SPAWNINFO_ROTATION
- Fix description of .distance to describe the command arguments (the more you know..)
- Fix .gob info guid targetting nearest gameobject instead of finding with given guid
- Reorder the info data slightly
- Print location and rotation data regardless of object found in world
- Add error messages for when object is not found by guid or entry
(cherry picked from commit 257ae44a20ed40469dd821845de8e27c0af838c7)
- Added SmartEnum.h for enum iteration, stringification, and more, courtesy of krabicezpapundeklu/smart_enum
- Moved a bunch of enums in SharedDefines.h to the new system
- Miscellaneous utility methods ported
Core/Util: Redesign SmartEnum to properly work for large
enums (>64 entries) and play nice with IDEs (PR #22768)
(cherry picked from commit 338e8ba0fea8b4b15120c96fff15a6c4b1a52593)
(cherry picked from commit f7ca0877a3736000a6e3b4ed09ac5f08b4d8e3f0)
(cherry picked from commit 207093475a177e9fd29696e80fdd06a11324782d)
(cherry picked from commit ee68cf33921944fd3f8c188044906998cf10ff2a)
(cherry picked from commit c16d461e16f0704bb11040faff30953d33ba2188)
(cherry picked from commit f6b0d99e2c0bc22b44d6f3cfdae50cbba7d51de8)
(cherry picked from commit bc1f456125c1b6c90617a514152d69c40ce64886)
High Justice Grimstone's movement script timers improvement in Ring of the Law.
case 6 & case 7 modifications:
- Event_Timer = 5000; // originally 0
Closes#20499 (High Justice Grimstone issue)
(cherry picked from commit 48eba61e90e3958613ceca05bb6a550fce8816ad)
* Atal'Alarion will now despawn as a regular Elite mob
(5 minutes unlooted or 2.5 minutes when fully looted)
instead of 7200 (ms) (7.2 seconds) before this change.
Closes#22531
(cherry picked from commit d24b46139600c74f5e200d9ab1592d7128245113)
Fix infinite loop in Gyth fight and double event caused by Rend Blackhand being respawned.
Please note this event is completely bugged and unfinished and contains for sure more bugs.
(cherry picked from commit af3449e06463b3425df2ce67195fa55492af4151)
- The previous (wrong) spell ID used mana, so it was never cast because Firesworns aren't mana users
(cherry picked from commit 001dd32b5cf6939886b895cb7186df82433dae48)
* Scripts/TempleOfAhnQiraj: Implement Battleguard Sartura's skip-prevention area trigger
* Sartura engages players if they try to skip her by walking past down the tunnel
* Clean up the instance script a bit
(cherry picked from commit c8f830ff2b735fb45bf16f4421396709661939f6)
Trond B. Krokli