Commit Graph
3075 Commits
Author SHA1 Message Date
Shauren 062e645637 Scripts/Spells: Bloodlust/Heroism handling changed, it is now possible to use these spells even if caster is under Sated/Exhaustion debuff 2011-09-25 15:08:48 +02:00
QAston e949ad3adb Core/Spells: spell effect handling improvements
* Call spell effect handlers in 4 modes:
   - SPELL_EFFECT_HANDLE_LAUNCH - called when spell is launched (cast just finished)
   - SPELL_EFFECT_HANDLE_LAUNCH_TARGET - called when spell is launched for each target in spell target map
   - SPELL_EFFECT_HANDLE_HIT - called when spell hits its destination
   - SPELL_EFFECT_HANDLE_HIT_TARGET - called when spell hits it's target from spell target map
*Correctly implement SPELL_EFFECT_TRIGGER_SPELL, SPELL_EFFECT_TRIGGER_SPELL_WITH_VALUE, SPELL_EFFECT_TRIGGER_MISSILE_SPELL_WITH_VALUE, SPELL_EFFECT_TRIGGER_MISSILE_SPELL
*Remove spell system hacks which became obsolete with this commit
Core/SpellScripts:
add OnEffectLaunch, OnEffectLaunchTarget, OnEffectHit, OnEffectHitTarget hooks for new effect handle modes and remove OnEffect hook.
A generic rule of thumb how to update your scripts (will work for nearly all cases) for spell system noobs:
if your spell script used GetHitXXXX function, you need to use OnEffectHitTarget, otherwise use
OnEffectHit
2011-09-25 13:29:50 +02:00
Chaplain 877579d386 Revert "Core/Spells: Fix talent Sword Specialization for melee abilities"
This reverts commit cdd4160157.
2011-09-25 14:20:41 +03:00
Shauren b07cc3751f Core/Scripts: Added NULL checks to new target selectors, threat references aren't guaranteed to be valid always, also added (default true) player typeid check to NonTankTargetSelector 2011-09-24 23:30:11 +02:00
Shauren da0229da8f Core/Scripts: Implemented 2 new target selectors, one specialized for spells, checking auras, range and attributes; and the other is a very simple non-tank selection what is sufficient for most cases 2011-09-24 19:40:57 +02:00
QAston cd7060c65a Core/Spells: Add more generic overload for Unit::CastSpell function and make all cast functions use it as a base. 2011-09-24 16:41:50 +02:00
QAston d01a761f53 Core/Spells: Drop EFFECT_IMPLICIT_TARGET_PET and use EFFECT_IMPLICIT_TARGET_EXPLICIT instead. 2011-09-24 02:02:39 +02:00
QAston 71bbbaa21b Merge pull request #3146 from Havenard/fix0001
Reimplement WorldObject::IsInBetween() to work as intented.
2011-09-23 06:04:17 -07:00
QAston 413b542cd9 Add a tempfix for trigger missile spell effects after rev 13a1d90130. 2011-09-23 13:09:31 +02:00
QAston 13a1d90130 Core/Spells: Improvements in selecting default targets based on effect type. 2011-09-23 11:58:40 +02:00
Spp ab023e847a Core/Misc: Add <GM> tag to GMs in Who list 2011-09-23 11:23:22 +02:00
Souler 99c63e86ae Scripts/Ulduar: Make XT-002 and Ignis enter evade mode if pulled out from their fight areas.
Also implement a default case for EnterEvadeIfOutOfCombatArea.
2011-09-22 22:14:52 +02:00
Machiavelli 9ea40a4746 Scripts/Ulduar/Kologarn:
- Fix arm respawn and reinstall events
- Fix possible erratic event timers
- Fix Focused Eyebeams after recent spell system changes
- Fix looting the chest after the encounter
2011-09-22 21:19:26 +02:00
Shauren 154c7ce79c Core/Spells: Fixed Brewfest - Attack Keg spell damage 2011-09-22 20:16:47 +02:00
QAston 29fef71137 Merge pull request #2915 from idostyle/armorPen
Core/Mechanics: Cap armorPen to maxArmorPen - prevents having armor penetration rating greater than 100%.
2011-09-22 02:03:14 -07:00
megamage 738f94eed3 Fix incorrect logic in PetAI. Solve #3155. 2011-09-21 12:53:29 -04:00
Rochet2 a0a22ecbc8 Scripts/Commands: Added .dev command to show <Dev> tag in nickname 2011-09-21 11:35:29 -03:00
QAston e2e784e7ea Merge pull request #3086 from LihO/master
Core/Groups: Refactored sending of update packets.
Closes #1042.
2011-09-21 01:05:53 -07:00
QAston d628145d95 Merge pull request #3143 from megamage/master
Threat manager. Fix crashes #2396 and #2992.
2011-09-21 01:03:53 -07:00
QAston 82bc917265 Merge pull request #2908 from Drethek/TwinsValk
Scripts:
Twins Valk - Cleanup / Remove Hardcoded Bullet Spawn (Need DB Support - Stalkers Spawns)
Acidmaw - Use Correct Submerge Spell
Trial Of Crusader - Correct Coordinate Spawn
Trial Of Crusader - Correct Open/Close Main Door Timer
Trial Of Crusader - Open/Close On Boss EnterEvadeMode
2011-09-21 00:27:20 -07:00
Havenard c298d09417 Reimplement WorldObject::IsInBetween() to work as intented.
Closes #2163 and #1329
2011-09-20 17:48:13 -03:00
Rat 0ab9dd3f9f Core/SmartAI: Re-apply accidentally removed crash fix, whoops 2011-09-20 17:56:47 +02:00
Rat 41ad855bdf Core/SmartAI: fixed SMART_ACTION_SOUND, note: target(s) must be player(s)
Signed-off-by: Rat <[email protected]>
2011-09-20 17:46:40 +02:00
megamage 4ccb22e1a6 Fix the incorrect logic of threat online status check. Also add targets in other map or phase to offline container. 2011-09-20 10:26:34 -04:00
megamage 8aead2a1ee Do not add spell-caused threat to creatures in other map or phase. Fix crashes #2396 and #2992.
Note: Threat system is still thread-unsafe. This patch only reduces the chance of crash.
2011-09-20 10:24:44 -04:00
Shauren 3d4f9a0d1c Core/World: Shutdown messages are now sent in blizzlike intervals (every 15 seconds under 5 minutes and every minute under 15 minutes) 2011-09-20 11:40:08 +02:00
Shauren 80800def40 Core/Scripts: Reverted part of 7afb179185, fixes selecting random target starting at given position
Closes #3127
2011-09-20 09:03:12 +02:00
megamage e81b3c6fde Move thread-unsafe events from Player to BattlegroundQueue. Fix crash #2960. 2011-09-19 17:22:27 -04:00
megamage c9a4efdf8f Fix crash caused by invalid talker in SmartScript. Solve #3082. 2011-09-19 09:24:59 -04:00
Shauren a11bee31c3 Core/SmartAI: Corrected validation check for SAI action summon, type parameter 2011-09-19 14:41:21 +02:00
click 872c2d4d63 Core/Build: Fix non-PCH builds 2011-09-18 16:30:18 +02:00
Aokromes 055b9c7574 Remove 2 useless logs 2011-09-18 09:29:09 +03:00
LihO 069162b9d4 Core/Entities: Restore group of player after teleport from BG. 2011-09-17 20:20:10 +02:00
LihO db8b02690b Core/Groups: Refactored sending of update packets.
Now it is possible to send update packet to single player.
2011-09-17 20:17:41 +02:00
QAston 8c2e58d036 Core/Entities: Allow 2 side parties to work. 2011-09-17 13:45:07 +02:00
Shauren a644e0d951 Core/Entities: GameObject's m_unique_users will now store full guids to get rid of silly casts 2011-09-17 13:20:21 +02:00
Shauren 63b62d4ad0 Core/Grids: Added GameObjectWorker 2011-09-17 13:18:42 +02:00
Shauren 94e5ff6549 Core/Commands: Removed setting orientation from cast commands 2011-09-17 12:16:33 +02:00
QAston a2d9aabbb3 Core/Entities: Allow creatures to attack players while in sanctuary. 2011-09-17 01:50:53 +02:00
QAston fe25ce4fa3 Core/AI: Replace many Unit::IsHostileTo with Unit::IsValidAttackTarget or Creature::canCreatureAttack. 2011-09-17 00:56:59 +02:00
QAston 580264b5a5 Core/Entities: Remove obsolete function Unit::canAttack. 2011-09-16 23:51:01 +02:00
QAston c0b1823524 Core/Entities: Replace Unit::canAttack usage with more accurate Unit::IsValidAttackTarget 2011-09-16 23:49:31 +02:00
QAston 3a3f2d927f Core/Misc: Whitespace and a minor typo fix (thanks Kapoeira) 2011-09-16 22:37:49 +02:00
QAston 9bbb4ef583 Core/Spells: Use Unit::IsValidAttack/AssistTarget functions to validate spell explicit targets. 2011-09-16 22:17:49 +02:00
QAston 31e755c291 Core/Entities: Add Unit::IsValidAssistTarget and Unit::IsValidAttackTarget functions for proper serverside checks of related entity flags. 2011-09-16 22:17:48 +02:00
Spp bf38cd8f3e Tab2spaces previous commit :S 2011-09-16 21:56:29 +02:00
Spp d0f9406a10 Core/Instances: Resurrect a dead player (with corpse) before enter to instance. Original patch by Den 2011-09-16 21:54:45 +02:00
Spp 2f83db28f2 Core/Instances: Fix client freeze when trying to enter an instance which have players inside and you have save but not in same group that people inside and your homebind is in the same continent that the instance 2011-09-16 21:52:49 +02:00
Shauren f356f65fa6 Core/Spell: Remove obsolete check, its already handled in a better way using SpellScript 2011-09-16 12:32:09 +02:00
Shauren 113080dace Core/Spells: Temporarily commented out SPELL_ATTR6_CAN_TARGET_UNTARGETABLE check, needs more research 2011-09-16 12:27:00 +02:00