Commit Graph
24566 Commits
Author SHA1 Message Date
Shauren beceafc39f Core/DataStores: Skip loading hotfixes for locales that are not loaded from files first 2020-07-04 20:18:57 +02:00
funjoker 590f541019 Core/Hotfixes: Add locales to hotfix_blob (#24913) 2020-07-04 19:09:36 +02:00
Shauren 6cbd6476f0 Nopch fix 2020-07-02 00:37:50 +02:00
Shauren 661470c658 Core/PacketIO: Convert all leftover packets to use packet classes 2020-07-02 00:07:38 +02:00
Shauren 4499f203a3 Core/DataStores: Fixed sending localized hotfixes and improved db2 loading error messages 2020-07-01 00:34:51 +02:00
Shauren 79cd94d26d Core/Misc: Changed GetLocaleByName to return invalid value on invalid input instead of LOCALE_enUS
* Also added IsValidLocale helper function
2020-06-30 00:22:25 +02:00
Shauren 40c71ea9fc Core/Misc: Remove unused variables 2020-06-29 09:23:38 +02:00
Shauren 2fcb79e2de Core/DataStores: Fixed loading db2 strings
Closes #24916
2020-06-29 00:10:37 +02:00
Shauren 6040f8eb31 Core/Collision: Port new parts for retrieving area/liquid data from gameobjects added when porting 42f9deb21e to 3.3.5 2020-06-28 12:26:39 +02:00
Shauren deca201f77 Core/DataStores: Simplified string memory allocation in db2 files, dropped unneccessary level of indirection 2020-06-27 13:33:17 +02:00
Shauren 176c75e8db Core/Spells: Include more than first 2 spell effects when determining if a spell is negative 2020-06-26 00:23:46 +02:00
Shauren bbdabd7d77 Core/Players: Remove deprecated skill related config AlwaysMaxWeaponSkill and command .maxskill 2020-06-25 14:45:28 +02:00
Carbenium 9969d6e194 Fix non-PCH build
(cherry picked from commit 05025d79f3cb34fa135cb820badeef32883f7eb4)
2020-06-24 14:35:10 +02:00
Peter Keresztes Schmidt bab5fd87a3 Core/Misc: Replace Trinity::make_unique with std (#24869) 2020-06-23 08:54:12 +02:00
Shauren c3dcbe04dc Core/Spells: Assign spell effect handles for new apply aura effects 2020-06-22 11:04:57 +02:00
ForesterDev 01d098830a DB/Account: update account_access table (#24788)
* DB/Account: update account_access table:

- rename fields id -> AccountID, gmlevel -> SecurityLevel
- add Comment field
- rename command .acc set gmlevel to .acc set seclevel

* Update auth database

* Fix primary key

* Temporary restore old command account set gmlevel with same handler as account set seclevel

Use Optional  for realmID - if not set, use -1 (for all realms)

* Rename 2020_XX_XX_00_auth.sql to 2020_06_20_00_auth.sql

* Update auth_database.sql

* Rename 2020_XX_XX_00_world.sql to 2020_06_20_06_world.sql

Co-authored-by: Giacomo Pozzoni <[email protected]>
(cherry picked from commit 8e0365d8a6ca5628ad17e6684743d9ab2138c068)
2020-06-22 11:03:31 +02:00
Shauren fce9fca900 Core/Spells: Implemented new target types
* TARGET_UNIT_TARGET_ALLY_OR_RAID
* TARGET_UNIT_CASTER_AND_SUMMONS
* TARGET_UNIT_AREA_THREAT_LIST
* TARGET_UNIT_AREA_TAP_LIST
* TARGET_DEST_CASTER_GROUND
* TARGET_DEST_SUMMONER
* TARGET_DEST_TARGET_ALLY

Closes #18558
Closes #18867
Closes #24295
2020-06-21 15:59:43 +02:00
Shauren 7d9880252c Tools/mmaps_generator: Print readme with --help 2020-06-19 17:49:56 +02:00
Shauren 22a3cb4432 Core/Auction House: Fixed sorting in non-equipment categories 2020-06-18 10:57:26 +02:00
Shauren c715e635cf Merge pull request #24554 from funjoker/cherry-picks 2020-06-15 00:26:08 +02:00
Carbenium abff505a6e common: Add a missing include guard 2020-06-15 00:22:12 +02:00
ariel- 7c2e83604c Core/Scripts: moved Wild Growth calculation to script and fixed formula
Thanks ccrs for the formula

(cherry picked from commit 96ee23487fe2a5fc2cf79e5d2ec4ec38b965e70d)
2020-06-14 23:49:05 +02:00
ariel- 8e44a6a381 Core/AI: restore old check forcing PetAI on Pets using SmartAI
includes more template love

Closes #19837

(cherry picked from commit 9c24ec5c966da1a78ddd3df6023c6cab43111ebc)
2020-06-14 23:49:05 +02:00
ForesterDev 15609a197e Scripts/Gossip: fix go_ahune_ice_stone (#19835)
(cherry picked from commit f9a01c4b691c5d179acd55bfe8db36f21a327dfb)
2020-06-14 23:49:05 +02:00
ariel- 3cf5db1831 Core/Globals: add more AIName and MovementType checks to ObjectMgr
- Ninja fix AI factories (restores prev behaviour of not selecting stuff with PERMIT_BASE_NO)

Closes #19831

(cherry picked from commit d56a28afee19741c582ed8e16dbf8e30311f68ea)
2020-06-14 23:49:05 +02:00
Keader e50a95839c Core/Scripts: Fixed some events that not should triggered by non-players on Illidan encounter
(cherry picked from commit 0c6829f7f22f32e602ea6ed440d50f2f596ba998)
2020-06-14 23:49:05 +02:00
Shauren 1fd59700d7 Core/Groups: Fixed calculating canReset attribute
Broken in d6df19cd99.

(cherry picked from commit 0222d9fc1a5ff4267a907c6b0cc4a1977f519baf)
2020-06-14 23:49:05 +02:00
Shauren 042418cf26 Revert "Core/Groups: fix wrong query for loading group instance data. canReset attribute was calculated in the wrong way"
This reverts commit 0c1dd398bd.

Closes #19745

(cherry picked from commit 023d25215574df5463dfe7f11bc996941a5acc2d)
2020-06-14 23:49:05 +02:00
Keader c9c178db19 Core/Spells: Removed duplicated check again followup 3a0417f7128292995a4085a0114ed59fbfa64325
to send some info to client

(cherry picked from commit ed43883160f2bb33f7be64362f32e52ea05e3dd6)
2020-06-14 23:49:05 +02:00
Keader 19602c2e83 Core/Spells: Removed duplicated check
unitTarget was checked twice in Spell::EffectTaunt

(cherry picked from commit 3a0417f7128292995a4085a0114ed59fbfa64325)
2020-06-14 23:49:05 +02:00
ariel- 1881088744 Core/AI: Factory functions cleanup
- Get rid of fugly void pointers
- Streamlined AI selection code, using Permissible as it should've been instead of harcoded checks on the selector code
- Moved IdleMovementGenerator singleton to factory code

(cherry picked from commit ce3787f190d28c1e981598eef2cd24c622a2cbae)
2020-06-14 23:49:05 +02:00
ariel- 43339e6840 Core/Players: fix null dereference crash
(cherry picked from commit c3176a814306db20a6f0ff7cdf1baad6bf9c877c)
2020-06-14 23:49:04 +02:00
treeston 57e3a67c94 Fix an issue where CanSpawn would never get invoked on creatures without per-guid script.
(cherry picked from commit aeaa8ecfabc2885aa24a86ce22034718cb4f62d8)
2020-06-14 23:49:04 +02:00
treeston 803012cc40 Add another helper to ScriptedGossip.h for resolving listId -> action.
(cherry picked from commit 302a039b7c1034ad0be67b1895565caf95853c2b)
2020-06-14 23:49:04 +02:00
sirikfoll c99963b023 Core/Scripts Properly set Freya's BossState do DONE and avoid some loot exploits
Closes #19823

(cherry picked from commit 1cc0458b114490238ff9cfed78b1932df67def29)
2020-06-14 23:49:04 +02:00
Treeston aa811d57b6 Partial revert of 15a207f, which was causing issues (ref #4943 and #19768). Instead, fix the underlying issue from 15a207f one level further down - Unit::getAttackerForHelper() shouldn't return units that we aren't in combat with (victim can be such a unit for players/player pets, which can startattack from a distance without entering combat). (#19814)
Fixes the following issues:
- Player pets would aggro neutral mobs as soon as they start autocasting (Imp's Firebolt) if they're in react range (due to victim != null, autocast counts as autoattack and sets victim)
- Neutral mobs would randomly evade when aggro switched between targets.

Closes #19768, #19485 and #10921.

(from PR #19814)

(cherry picked from commit 69fd6245dc41dca658cadb4e99c1ee6593fe000b)
2020-06-14 23:49:04 +02:00
ForesterDev 7211c6e51d Scripts/Command: implement .debug play music command
Closes #19809

(cherry picked from commit dd4ff1fe5458c89fc1d988fcc6ba5792ee482dcf)
2020-06-14 23:49:04 +02:00
Treeston 496263fccb Fix evade issues when a spell hits the target just before evading. (#19815)
- Creatures should no longer get stuck in evade mode following a target if a spell hits the creature just as it's entering evade mode.
- Fixes and closes #4943. Finally.

(cherry picked from commit 1945874f965a2aef951bc3dfae1144bd42365dcb)
2020-06-14 23:49:04 +02:00
ariel- b1f1cc4514 Core/Spell: in case of immunity, check all effects to choose correct procFlags, as none has technically hit
(cherry picked from commit 63e502a67dfdfb4edb8a84af630244ac13600b24)
2020-06-14 23:49:04 +02:00
treeston 6f73960480 Instances/Ulduar: Fix a super edge case bug where Algalon would evade if his tank successfully tanked a Cosmic Smash and got knocked up. Shadow priests everywhere rejoiced.
(cherry picked from commit b6a4e9f3f9aca8e82e4b8cc1868e4b24dd2bba6f)
2020-06-14 23:49:04 +02:00
ariel- 444754e65a Core/SmartAI: allow SMART_ACTION_SEND_GOSSIP_MENU to override default gossip
Closes #19769

(cherry picked from commit f2b0819e5368b2b8e8865b13555c140e4f9a59a7)
2020-06-14 23:49:04 +02:00
treeston 250aef5186 Quickfix a bug introduced by 2f19d97 which prevented GTAoE from being cast.
(cherry picked from commit 1c528c30f8ca5717c5d9a88dbceb14c31d825036)
2020-06-14 23:49:04 +02:00
ariel- f1eb73001c Core/Spell: fixed some problems with per caster aura states
- Update clients whenever target has more than one application of an aura that applies such aurastate
- Update again when one application gets removed
- Fixed Fire and Brimstone computing damage if any warlock applied the Immolate (should only count for own)

Closes #19790

(cherry picked from commit e27c385b48fce359a168d602dabae8c55fa85563)
2020-06-14 23:49:04 +02:00
ariel- 6fa8b8e1d5 Core/Creature: fix _DespawnAtEvade saving wrong respawn time
Closes #19557

(cherry picked from commit 47d387d6b0d123334e4721c55426c1d236297112)
2020-06-14 23:49:04 +02:00
ariel- 25f47e4680 Core/Spell: abort channeling if no valid targets are found after searching
Closes #17624

(cherry picked from commit 2f19d97d210c70eade4fb87c1d86642d77bbcd69)
2020-06-14 23:49:03 +02:00
ariel- b161447b47 Scripts/VioletHold: fix stack overflow when reflecting 'Splash'
Closes #19514

(cherry picked from commit d9a1c82ab44254c280083e6297b8aec6350ab363)
2020-06-14 23:49:03 +02:00
Aokromes ce1dc8b3de Fix build
(cherry picked from commit 195db7c7bb7137f3ebadefa81fabdcf66672711a)
2020-06-14 23:49:03 +02:00
ariel- 412af93a28 Core/Player: update interaction checks, some info taken from client
(cherry picked from commit d03e97d53f8dcabe006773d3377842bc091359a9)
2020-06-14 23:49:03 +02:00
ForesterDev c34b83a467 Core/Defines: define faction templates and replace magic numbers from scripts
(cherry picked from commit abea8bf4cb3034f56d833982f951a0742dc36fc7)
2020-06-14 23:49:03 +02:00
ccrs 205d8bf591 Scripts/ICC: add missing cases for Dark Martyrdom difficulty entries
how come nobody noticed this?

(cherry picked from commit 7afe0b7fb005999dfb8bfae45b7d22abbec29b93)
2020-06-14 23:49:03 +02:00