Commit Graph
489 Commits
Author SHA1 Message Date
Shauren dda375b986 Core/Spells: Rename SpellAttr2 to use official attribute names
* Corrected implementation of SPELL_ATTR1_ALLOW_WHILE_STEALTHED
* Implemented SPELL_ATTR2_RETAIN_ITEM_CAST
* Implemented SPELL_ATTR2_ALLOW_WHILE_INVISIBLE
* Implemented SPELL_ATTR0_PROC_FAILURE_BURNS_CHARGE
* Implemented SPELL_ATTR2_PROC_COOLDOWN_ON_FAILURE
* Implemented SPELL_ATTR2_NO_TARGET_PER_SECOND_COSTS
* Implemented SPELL_ATTR2_DO_NOT_REPORT_SPELL_FAILURE
* Implemented SPELL_ATTR1_REQUIRE_ALL_TARGETS
* Implemented SPELL_ATTR2_CHAIN_FROM_CASTER
* Implemented SPELL_ATTR2_NO_ACTIVE_PETS
* Implemented SPELL_ATTR2_ENCHANT_OWN_ITEM_ONLY
2022-04-28 18:31:26 +02:00
Shauren c88b602a2c Core/Spells: Rename SpellAttr1 to use official attribute names
* Implemented SPELL_ATTR1_NO_SKILL_INCREASE, SPELL_ATTR1_AURA_STAYS_AFTER_COMBAT, SPELL_ATTR1_DISPEL_ALL_STACKS
2022-04-25 22:16:56 +02:00
Shauren a31e681944 Core/Spells: Rename SpellAttr0 to use official attribute names 2022-04-24 18:40:10 +02:00
offl 2e3f240051 Scripts/Spells: Handle quest tame spells in spell script (#27022)
(cherry picked from commit 4441d42253d64ccd8fc9f78f1b44c851d6408312)
2022-03-19 23:14:52 +01:00
offl c4906ce60b Core/Misc: Rename UNIT_FLAG_NOT_SELECTABLE to UNIT_FLAG_UNINTERACTIBLE (#26913)
(cherry picked from commit c4741a131a0a28b69c228d3637beab7090e5f1e3)
2022-03-15 23:03:26 +01:00
Ovah 60119ba850 Core/Spells: implement SpellInfo helper to filter for relevant mechanic immunities in spell_start packet (#26183)
* Core/Spells: implement SpellInfo helper to filter for relevant mechanic immunities when sending SMSG_SPELL_START packets.

According to sniff analysis Blizzard does not send all mechanic immunities of creatures but instead only the ones that are responsible for actual interrupts which are MECHANIC_INTERRUPT  and MECHANIC_SILENCE. Additionally we no longer send immunities for instant cast spells as sniffs confirm that they are not sent for spells without a cast time.

(cherry picked from commit 6215cb4e0014fbe9df35a8c6b013e7801bd8ffec)
2022-03-08 00:31:02 +01:00
Keader 2e69b64d67 Revert "Core/Spells: Spells with Attribute SPELL_ATTR1_DISPEL_AURAS_ON_IMMUNITY should dispel snare auras. (#20621)"
This reverts commit b507acf1c04ff6e9d0a075f9663e9549d5b238b4.

(cherry picked from commit c6e2b6e88c43b3ef79e4eab25b99b1799af161c3)
2022-03-07 22:05:49 +01:00
xvwyh 2a595d55b2 Core/Spells: Correct swapped TARGET_UNIT_NEARBY_ALLY and TARGET_UNIT_NEARBY_PARTY (#25837)
* Update SharedDefines.h

* Update SpellInfo.cpp

(cherry picked from commit 7c6d92012afa4efe7b075aa6543e2169cda3faed)
2022-03-05 23:51:50 +01:00
Gildor 8585b127f4 Core/Spells: SPELL_AURA_MOD_HEALING_PCT should be negative if TargetType is enemy or BasePoints are negative (#25490)
(cherry picked from commit a770ad0476a32007a356c3539309f7a111893145)
2022-02-27 23:52:55 +01:00
Shauren 7fbdd6473e Core/DataStores: Updated db2 structures to 9.2.0 2022-02-25 11:40:20 +01:00
Shauren f8ad7017dd Core/Misc: Move (or delete) constructors and destructors to .cpp files (avoids compiling them in every file that includes them) 2022-02-12 21:36:46 +01:00
Shauren 3844c79adb Core/Spells: Load entire proc flags array from db2 2022-02-09 23:46:29 +01:00
Shauren 25b84e5e7b Core/Spells: Fixed TARGET_UNIT_TARGET_ALLY_OR_RAID targeting 2022-02-08 12:04:09 +01:00
Aqua Deus 2ae67de4c0 Core/Spells: Implement SPELL_ATTR7_BYPASS_NO_RESURRECT_AURA (#27714) 2022-02-07 20:08:55 +01:00
Treeston c4b287c7bf Core/Misc: DBC std::array refactors, and |Hachievement unit tests
(cherry picked from commit 3fbbe7cfbe1bc51db12bdc1ec7b21c16d1716366)
2022-02-04 23:37:29 +01:00
Peter Keresztes Schmidt 44ea32ace4 Build: Enable -Wimplicit-fallthrough on clang (#25056)
* Misc: Use [[fallthrough]] attribute instead of comment to mark intentional fallthroughs

Related: #25006

* Misc: Add some missing breaks (no-ops) to satisfy clang

Related: #25006
Closes #25055

* Build: Enable -Wimplicit-fallthrough on clang

Closes #25006
2022-01-23 22:16:15 +01:00
Peter Keresztes Schmidt ad340466d0 Misc: Use [[fallthrough]] attribute instead of comment to mark intentional fallthroughs (#25054)
Related: #25006
(cherry picked from commit 85b5b842ca6c05d4e51081e6c3282940a80f3761)
2022-01-23 22:02:03 +01:00
Gildor 81154a7455 Core/Spells: Check a few aura effects for determining if should be negative (#25004)
(cherry picked from commit 5e1571062ac05bc3e68ebf1cf9ed04ab54e713bd)
2022-01-23 15:20:09 +01:00
Gildor a8edacd20b Core/Spells: Check a few aura effects for determining if should be negative (#24930)
* Core/Spells: Check a few aura effects for determining if should be negative

* Rename 9999_99_99_99_world_auras.sql to 2020_07_04_00_world.sql

Co-authored-by: Giacomo Pozzoni <[email protected]>
(cherry picked from commit 26ba4ecd5140fa13953ca7c3e1ab3f269a85ce71)
2022-01-21 18:45:04 +01:00
Gildor a16c804ea0 Core/Spells: SPELL_AURA_MOD_HEALTH_REGEN_PERCENT should be negative if TargetType is enemy and Basepoints are negative (#24902)
(cherry picked from commit af1571ce508379895fb4f8f4fbcaccf7c5dbd156)
2022-01-21 16:12:31 +01:00
Gildor de21d446aa Core/Spells: SPELL_AURA_MELEE_SLOW should be negative if TargetType is enemy or Basepoints are negative (#24901)
(cherry picked from commit 7a81ce2f21d5823cfa872cdef8fc880f2c81f94c)
2022-01-21 16:11:39 +01:00
Gildor cc6e616e61 Core/Spells: SPELL_AURA_MOD_MELEE_RANGED_HASTE should be negative if Basepoints are negative (#24900)
(cherry picked from commit 0759d73777e59d548fa8b8cb7d2707fd9128abba)
2022-01-21 16:11:15 +01:00
Shauren 96137fb30f Core/Misc: Future msvc warning fixes 2022-01-21 13:40:48 +01:00
Shauren bff5ae51fe Core/Spells: Fixed crash in spell visual selection when CasterUnitConditionID is set 2022-01-15 19:16:20 +01:00
Shauren 72286dc5e4 Core/Conditions: Initial support for UnitCondition.db2 2022-01-15 00:52:55 +01:00
Gildor 81a5bc597b Core/Spells: SPELL_AURA_PERIODIC_DUMMY should be negative if TargetType is enemy (#24864)
(cherry picked from commit 9405f78ee4bfee265a744daa92a8d5b155804cc3)
2022-01-07 00:25:52 +01:00
Carbenium 60b48ad046 Core/Misc: Create new enum for AreaIds
Move Wintergrasp BF related values there

(cherry picked from commit 6a8c12587eef47722f6c845f477e0ca66e9ccd1e)
2022-01-06 23:42:15 +01:00
Gildor 71ce61cc95 Core/Spells: SPELL_AURA_MOD_HEALING should be negative if TargetType is negative (#24862)
(cherry picked from commit a555bf1fd786d1f9b65ed9673ce6f8fc8a2b403e)
2022-01-06 23:30:16 +01:00
Gildor fc43a95729 Core/Spells: SPELL_AURA_MOD_ATTACK_POWER_PCT should be negative if TargetType or Basepoints are negative (#24837)
(cherry picked from commit 7d88891983d5c7d2673be760e11bff12df958d41)
2022-01-06 23:13:44 +01:00
NoName 5417438731 Core/Spells: Crystallize should not use DIMINISHING (#24502)
and also correcting spelling in script

by Rushor and wotlk-enthusiast

(cherry picked from commit 45993428f5c7e7e03d0d98529354e23cd8c7cf98)
2022-01-01 21:38:13 +01:00
Shauren 116a3ab694 Core/Spells: Name more targets (without implementation) 2021-12-29 23:38:09 +01:00
Shauren f5631b7134 Core/Spells: Implemented target 124 TARGET_UNIT_TARGET_TAP_LIST 2021-12-29 19:08:36 +01:00
Shauren 195457b682 Core/Spells: Implemented target 121 TARGET_CORPSE_TARGET_ALLY 2021-12-29 18:04:27 +01:00
Shauren b50783ae80 Core/Spells: Implemented target 115 TARGET_UNIT_SRC_AREA_FURTHEST_ENEMY 2021-12-29 17:56:11 +01:00
Shauren 115409f353 Core/Spells: Implemented target 116 TARGET_UNIT_AND_DEST_LAST_ENEMY 2021-12-29 16:03:52 +01:00
Shauren 730fc4665b Core/Spells: Rename targets 110 to TARGET_UNIT_CONE_CASTER_TO_DEST_ENTRY 2021-12-29 15:08:59 +01:00
Shauren 3c11ae4156 Core/Spells: Rename targets 108 and 109 to include CASTER_TO_DEST wording 2021-12-29 14:56:59 +01:00
Shauren 3a26b0b013 Core/Spells: Implemented target 107 TARGET_DEST_NEARBY_ENTRY_2 (the same as target 46) 2021-12-29 14:50:42 +01:00
Shauren 88cf53e54a Core/Spells: Implemented target 62 TARGET_DEST_CASTER_GROUND (the same as target 125) 2021-12-29 13:43:07 +01:00
Shauren 8921d07201 Core/Spells: Rename TARGET_UNIT_CONE_ENEMY_54 to TARGET_UNIT_CONE_180_DEG_ENEMY and add 180 degree fallback for this target type 2021-12-29 11:47:32 +01:00
Shauren bbdb70ed57 Core/Spells: Implemented target 105 TARGET_UNIT_CASTER_AND_PASSENGERS 2021-12-29 01:18:17 +01:00
Shauren 565ef6a2f4 Core/Spells: Implemented target 136 TARGET_UNIT_CONE_CASTER_TO_DEST_ALLY 2021-12-29 00:12:23 +01:00
Shauren 70f1eaac48 Core/Spells: Rename TARGET_UNIT_CONE_ENEMY_104 to TARGET_UNIT_CONE_CASTER_TO_DEST_ENEMY 2021-12-29 00:12:07 +01:00
Shauren f515424217 Core/Spells: Implemented target 137 TARGET_DEST_CASTER_MOVEMENT_DIRECTION 2021-12-28 22:19:31 +01:00
Shauren 8029035b80 Core/Spells: Implemented target 138 TARGET_DEST_DEST_GROUND 2021-12-28 19:24:24 +01:00
Rushor 2c5eb750b3 Spell: Emerald Drake, Dream Funnel
Closes #24219

(cherry picked from commit 5e6f55381a322d2306d814ae42ebeda92c447376)
2021-12-23 00:21:11 +01:00
NoName 37178ff311 Core/Spells: SPELL_AURA_48 implementation (#24054)
by xvwyh

(cherry picked from commit b3b7f0761d5605d57f9d62ca8e22a8cd9a4df24b)
2021-12-20 22:30:41 +01:00
Giacomo Pozzoni fda1630f74 Core/Spells: Fix Spellsteal stealing Silence buff of Arcane Torrent (#23992)
(cherry picked from commit 7920347f439b1c17805182a4f22d3b3b9f521a29)
2021-12-19 15:30:59 +01:00
Keader 47659e219a Core/Spells: Fixed some issues with Drain Soul
Issue 1: Drain soul was always negative, but effect2 need be positive.
Issue 2: Drain soul was interrupted if someone in your group die. Caused by negative effects proccing in creature.
Issue 3: Since effect2 is positive, it was down-ranking in low level targets and should never happens (fixed before by ariel, transforming everything in negative in 2c8a6fb771a42169a1817149ab0a2a19912ebea7 but it's wrong)

(cherry picked from commit 43c08b176115505b76c027667047f9a5bfcc4e11)
2021-12-18 20:43:05 +01:00
ccrs 4e6c59dca7 Core/Unit: rename several getters to follow codestyle
uint8 GetLevel()
        uint8 GetLevelForTarget(WorldObject const* /*target*/)
        void SetLevel(uint8 lvl)
        uint8 GetRace()
        uint32 GetRaceMask()
        uint8 GetClass()
        uint32 GetClassMask()
        uint8 GetGender()

(cherry picked from commit 5c09ff51f7015b775def8d5cc1f678eaef37200f)
2021-12-13 00:42:20 +01:00