Commit Graph
24405 Commits
Author SHA1 Message Date
ariel- f31e380499 Core/Spell: check aura positivity per effect on spell hit
- Fixes applying DR to positive effects, and changing duration of whole aura

Closes #19447

(cherry picked from commit 232e631390a504b51d82a7b678b7cf26d49d182a)
2020-04-27 12:25:52 +02:00
ariel- 296abf3e12 Core/Player: fix use after free crash
(cherry picked from commit d914c55c0585fe31a9a1b9fe4e9d4a9b498e8e8f)
2020-04-27 12:25:52 +02:00
ariel- fc0a037eef Core/Spell: fix SPELL_ATTR3_IGNORE_HIT_RESULT bypassing reflects
Closes #19440

(cherry picked from commit 83177e771a373514913d066e14d5a7f9775407fe)
2020-04-27 12:25:52 +02:00
ariel- 7dcc185a15 Core/Instance: stop updating the instance resettimes based on creature respawns
- Rather update normal instance reset time to 2 hours after last creature kill
- This fixes yet another integer overflow due to the possibility of having time_t max showing up
- Also change respawntime and resettime fields to bigint on respawn/instance related tables
- Start using prepared statements on the InstanceSaveMgr

(cherry picked from commit 4c593f12caa162c1bfb831bdbed934bb39155ddb)
2020-04-27 12:25:52 +02:00
ariel- a2ee35d9a3 Core/Misc: pch fixes pt 2
(cherry picked from commit e32a4f26aaa51fba2647aeb8ef751dd398bc09d8)
2020-04-27 12:25:52 +02:00
ariel- 0d8c1b49b8 Core/Creature: fix integer overflow in Creature::Update leading to endless thrashing of characters database
Closes #19182

(cherry picked from commit 66755eecf117d21504b13a86410aa01cfc44c3ba)
2020-04-27 12:25:52 +02:00
ariel- 7c571c5b0a Core/Misc: fix non-pch build
(cherry picked from commit 5e0485178de0ab794c72d845e331559171301b22)
2020-04-27 12:25:52 +02:00
xinef1 090fd8304a Core/Loot: implement Loot Item Storage (#19018)
* Created Item Loot Storage, no more synchronous DB selects
* Fixed buyback case, where stored loot was not removed from db
* Added Primary key, and changed field types to be unsigned for table item_loot_money

(cherry picked from commit 9dc3de10f0044c35a95e9b72e7b874f4b5b8e867)
2020-04-27 12:25:52 +02:00
ccrs 4e03d2717a Core/Movement: correct no point recalculation on speed change in TargetedMovementGenerator
(cherry picked from commit 4d7e7a97b329dc8ee4354f7be26c5e5efbaeba6b)
2020-04-27 12:25:52 +02:00
ariel- e5e37f0d86 Core/Unit: fix crash on magic school autoattacks
Closes #19436

(cherry picked from commit 0b50ea072e504ac7d5bf87b08d564955785f7197)
2020-04-27 12:25:52 +02:00
ariel- 1960a95425 Core/Unit: cleanup and minor fixes of miss and resist calculations
- Removed Unit::GetUnitMeleeSkill as it was basically a copy of GetMaxSkillValueForLevel
- Removed static from GetEffectiveResistChance, as this was passed anyways, changed name to CalculateAverageResistReduction, which better reflects what it does
- Fix melee miss chances calculated from attacker maxskill instead of victim maxskill
- Do actual checks if spell can be resisted/missed in MagicSpellHitResult (ie chances > 0)
- Fixed SPELLMOD_RESIST_MISS_CHANCE calculation in MeleeSpellMissChance
- Minor codestyle and cleanup of diminishing returns calcs

(cherry picked from commit e565b34f6d24411e210151d0d03e524f94cdff85)
2020-04-27 12:25:52 +02:00
ariel- 16e3796c7f Core/Misc: fix static analysis issues
CID 1373466
CID 1373481
CID 1373482

(cherry picked from commit e478434146fd479fab955aaa80eb925c15e29809)
2020-04-27 12:25:52 +02:00
ariel- 9e945615bc Core/Quest: fix RewardNextQuest being used to condition previous quests in chain
(cherry picked from commit 214b8e53c5598695915c1392702e059d79cfc260)
2020-04-27 12:25:52 +02:00
Keader 304eeea570 Core/Scripts: Baltharus the Warborn preincrement _cloneCount
(cherry picked from commit 2921449a333ea27a62c7b21d003650421c982917)
2020-04-27 12:25:52 +02:00
ccrs 84df2c57a3 Core/Movement: FormationMovementGenerator
Use own movement generator for creatures following on a formation.
First step of implementation, huge room for improvement.

Closes #19422

(cherry picked from commit 46221b6dc1272989e0de85a4563fc49dba8e7851)
2020-04-27 12:25:52 +02:00
jackpoz c31f875cc8 Core/Misc: Fix static analysis issues
(cherry picked from commit 3c4c67160afbe15cc48e5390201157c416cb9a09)
2020-04-27 12:25:52 +02:00
ccrs 14c6a4d823 [3.3.5] Core/Movement: MotionMaster & MovementGenerators cleaning (#19361)
(cherry picked from commit 21b8c4997a260b5e2dc24ab07df17d3daa6b8b5d)
2020-04-27 12:25:52 +02:00
ariel- 7f64eaa3ee Core/Player: fix weapon dependent aura talents not applied on talent learn
Closes #19408

(cherry picked from commit 5cb1555de6db43db03d6202b7edaa9c6835ecfab)
2020-04-27 12:25:52 +02:00
ariel- af3934e8ce Core/Auction: wrap item deletions from AHBot auction on a transaction
This speeds up the query execution time tremendously
Refs #19182

(cherry picked from commit ae9995f463ec9797eaa4a803bdca4fbf5978a9b7)
2020-04-27 12:25:52 +02:00
Keader f623fea923 Core/Scripts: Baltharus the Warborn make clone count more readable
*Also fixed issue that make Baltharus summons alot of clones when he is casting

(cherry picked from commit 58f2e62098f2c78b77b6b3851709c83f33e1cafd)
2020-04-27 12:25:52 +02:00
ariel- f97c28f2f1 Core/AHBot: fix price calc
- priceRatio is already a factor

(cherry picked from commit 4a654be2fbb1857f31180f8d4edca91f7825c34a)
2020-04-27 12:25:52 +02:00
ariel- 847990f030 Core/AHBot: fixed assert check
(cherry picked from commit c36854677c4cef0c83a81afa23b45ba322d354cc)
2020-04-27 12:25:52 +02:00
ariel- d80350da68 Core/Spell: don't set scaleAura for some special spells
Closes #14541

(cherry picked from commit 1ca8434b365687dbd12ca232a615d126234eba5e)
2020-04-27 12:25:52 +02:00
ariel- 8be8b7cff4 Core/AHBot: fix a typo
(cherry picked from commit e594c2d096c101a5b722793612febb6276b3b48e)
2020-04-27 12:25:52 +02:00
ariel- d6e293c718 Core/AHBot: Refactor of AuctionHouseBotSeller:
- Use AuctionHouseBot.Class.* for what they really are, priorities, factor them when calculating item amount per class, changed enums to CONFIG_AHBOT_CLASS_*_PRIORITY to reflect this change
- Don't factor in the priority calc empty item lists:
  * Let's say you had AuctionHouseBot.Class.Glyph set to 10, sum of AuctionHouseBot.Class.* is 20, and AuctionHouseBot.Items.Amount.White is 5000
  * If there were no glyphs on the item list, you automatically lost 50% of the total item amount, meaning only 2500 of original 5000 were alloted to fill
- Fixed AuctionHouseBot.AH.Price.Ratio to be an actual percentage factor

- Separated containers in SellerConfiguration, each one better reflects what kind of data is stored there, now we won't use magic index 0 from _ItemInfo :P
- General cleanup, removal of bad voodoo and magical numbers
- Use unordered_sets for loading item lists, as they were only used to check for item presence

(cherry picked from commit 7f8bfe68d0f660643c8bd4c63d2129d220c2184c)
2020-04-27 12:25:52 +02:00
Keader 14cf4c0692 Core/Scripts: Fixing Carbonion/Travis
(cherry picked from commit 270a6396783ccb2b8dff181fca2760adb47d2110)
2020-04-27 12:25:52 +02:00
Keader 287ed04c8b Core/Scripts: Fixed Baltharus the Warborn clones
*Clones not working after wipe
*Changed Clone Action for a event (to check casting)

(cherry picked from commit 6b8c4fb74feb2210d2fb9ea60ec23ab407ffeb39)
2020-04-27 12:25:52 +02:00
Keader 410585361a Core/Scripts: Typo in last commit
(cherry picked from commit a2a8ffe72328590b43481b430b9a6f281ccdd4be)
2020-04-27 12:25:52 +02:00
Keader fc2872e16c Core/Scripts: Fixed Volatile Ooze/Gas Cloud issues in Professor Putricide
Closes #18925

(cherry picked from commit 8d198cb36050e63811f8f7f81a3daf2a3c961950)
2020-04-27 12:25:52 +02:00
xinef1 e36497aef5 Core/Misc: Always reward all necessary reputations on creature kill (#19106)
(cherry picked from commit fb2aebe46be7439a8f9b99067edb27fd844c1a28)
2020-04-27 12:25:52 +02:00
xinef1 8df577ebfe Corrected points per level calculation for some spells (#19105)
(cherry picked from commit 9142c778dd861eda188ba868433af05038c4e13c)
2020-04-27 12:25:52 +02:00
Xinef 6f7ff9a3ef Core/Achievements: Optimized resetting achievement criteria by condition and changed the functionality to properly reset all possible criteria with given condition
Closes #18905

(cherry picked from commit 7c7b877c3fc0292f33f54f4e8b514be3bf8514a6)
2020-04-26 22:58:51 +02:00
Shauren 0763844fb6 Core/Misc: Improve enum flags with type safe operators 2020-04-26 15:27:48 +02:00
Ujp8LfXBJ6wCPR d994707ba1 Core/Misc: Remove redundant copy constructor for Position and WorldLocation (#24151)
* Default compiler generated ones do the same

(cherry picked from commit b92e4af460e72f8e6180cd5e6aac0250d64800e0)
2020-04-26 11:42:47 +02:00
Shauren 7272508cb4 Core: Fix clang 10 warnings 2020-04-26 01:25:50 +02:00
jackpoz 70c2b4e5ba Scripts/GruulsLair: Fix indentation
(cherry picked from commit 9d77b2be3b72810db1f12b6fde5e39583d521bc9)
2020-04-26 00:51:55 +02:00
Ovah 030d942efe Scripts/Antorus: implement Garothi Worldbreaker encounter for normal and heroic difficulty
* added base script support for the encounter for normal and heroic difficulty
* added instance script for Antorus the Burning Throne
* added sniffed template data for involved gameobjects
* added encounter related spawns to Antorus the Burning Throne
* added instance encounter entry for Garothi Worldbreaker
2020-04-25 19:04:31 +02:00
Shauren af76dc6b88 Core/DataStores: Speedup loading hotfix database and change hotfix database character set to utf8mb4 2020-04-25 17:01:26 +02:00
Shauren 96ec1f16d4 Core/Misc: Fixed wrong db field accessor functions use 2020-04-25 00:30:45 +02:00
Shauren d6d67a9766 Core/DBLayer: Fix build using TRINITY_DEBUG 2020-04-25 00:15:26 +02:00
Shauren ac671cc7ec Core/Items: Updated heart of azeroth level cap and knowledge starting date for 8.3 2020-04-24 22:16:25 +02:00
Giacomo Pozzoni 60b338881d Core/Grid: Code cleanup
Remove unused method that should not be used anyway
2020-04-24 19:40:26 +02:00
Ovah fb0d2ed2b9 Core/Spells: implement SMSG_MOUNT_RESULT and use it for transformed mounting cases (#24404) 2020-04-24 19:00:19 +02:00
Shauren 72ffe65dac Core/Units: Fixed bug in source of cherry-picked commit 2020-04-24 18:44:06 +02:00
ariel- 3d79b5bdea Revert "Core/Battlegrounds: disable health regen for battleground vehicles (#19183)"
This reverts commit 85af0a06305e6f771482da973244737e47bcf34c.

(cherry picked from commit 006e90339ec27b7d487c9a58dc8a212058a8174c)
2020-04-24 17:18:51 +02:00
ariel- 6490095520 Core/Scripts: Fix a logic fail that overriden the script of an entity that changed entry
Closes #19389

(cherry picked from commit dafa7267737ac11b7abb4dcf9943c24ab1e71a8a)
2020-04-24 17:18:51 +02:00
Gustavo 53f79acda9 Core/Battlegrounds: disable health regen for battleground vehicles (#19183)
Updates issue #950

(cherry picked from commit 85af0a06305e6f771482da973244737e47bcf34c)
2020-04-24 17:18:51 +02:00
tkrokli b259614778 Scripts: minimize duplicated enum names in header files (#19377)
* Scripts: Minimize duplicated enum names in header files

This reduces the number of cache resets with the Zapcc compiler

- Standard followed is instance/raid TLA + DataTypes/CreaturesIds/etc
- Partial cherry-pick of master commit 7eb4512eee
- Removed unused defines in sunken_temple.h (the core scripts using these have been moved to SAI)

(cherry picked from commit f6f36be004c3b8c7d09e0f320d5aabb8a9129109)
2020-04-24 17:18:51 +02:00
ariel- cbcc4601ad Core/AI: Build fix
- Stop exposing DoublePosition constructor versions, they're only used for internal representation
- Moved IsInBounds function to public scope

(cherry picked from commit 83162fafa453c1d34fe23ddd86a43c3dff058300)
2020-04-24 17:18:51 +02:00
ariel- 3f79c9f696 Core/AI: AreaBoundary refactor
- Added an auxiliary function IsInBounds to base CreatureAI
- Changed container to vector. Set had no sense because we're storing new pointers, they have different addresses even if the boundary is the same

(cherry picked from commit 2f99fa09c9bacbad376d7a296c3311f94ec8a552)
2020-04-24 17:18:51 +02:00